| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
TBR=satorux
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/555120
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
See bug for more details.
BUG=33120
TEST=Put sleep(15) before post of on_work_done_task, made sure OnAuthDone doesn't get called on shutdown.
Review URL: http://codereview.chromium.org/548147
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=run_webkit_tests doesn't complain about missing tests
R=jorlow@chromium.org
Review URL: http://codereview.chromium.org/553112
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=33195
TBR=darin
Review URL: http://codereview.chromium.org/555117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=9962
Review URL: http://codereview.chromium.org/557008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=31846
TEST=None (automated tests will follow once the event-faking infrastructure is in place on the Mac)
Review URL: http://codereview.chromium.org/555107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Made mac_util.mm and chrome_paths_mac.mm use GetUserDirectory().
Made firefox_importer_utils_mac.mm use PathService.
Added unittests for GetUserDirectory().
BUG=22045
TEST=trybots
Review URL: http://codereview.chromium.org/548123
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
attribute of the button to the correct key.
BUG=33124
TEST=Check that the Certificate Information button is enabled on an https page.
Review URL: http://codereview.chromium.org/552171
Patch from Vernon Tang.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32996
TEST=Mouseover and drag should work correctly in Google Earth and Flash 10.1.
Review URL: http://codereview.chromium.org/551154
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=18063
TEST=Installer an update while Chrome is running. Log out of machine without closing Chrome first and make sure sure Chrome gets updated cleanly whenever it is launched next.
Review URL: http://codereview.chromium.org/553079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This matches Mozilla, which uses ~/.mozilla/plugins.
BUG=22261
TEST=watch an strace, see that it hits the appropriate dir when loading plugins
Review URL: http://codereview.chromium.org/553102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
with PEP-8 in preparation for upstreaming this code to webkit.org.
This change was done by running the pep8_names.py script I wrote (
attached to https://bugs.webkit.org/show_bug.cgi?id=31498) with the following
command-line parameters:
% ./pep8_names.py -i --acronym WebKit --acronym LigHTTPd --acronym WDiff \
--acronym BuildBot *.py */*.py
The code was then reformatted to fit the 79-character line limit.
BUG=23099
TEST=none
R=levin@chromium.org
Review URL: http://codereview.chromium.org/553089
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- This fixes the crash in compact navigation bar without a adjustment.
- I didn't remove the adjustment because ths is necessary to make the compact navigation bar transparent. (currently, the clipping code assumes that the fixed widget and the actual opaque child have the same side, which is not the case for AutocompleteEditView.
BUG=chromium-os:1010
TEST=manual: compact nav bar does not crash.
Review URL: http://codereview.chromium.org/548151
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37198 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ChromeFrame. This was because
the ExternalTabContainer would close the underlying tab contents in its OnDestroy handler without invoking
unload handlers on the page if any. In Chrome the TabStripModel invokes the RunUnloadListenerBeforeClosing
on the delegate which is implemented by the browser. We need to mimic this in the external tab container.
To achieve this we now have a static helper function RunUnloadListenerBeforeClosingHelper in the browser
class which is called by the ExternalTabContainer and the Browser::RunUnloadListenerBeforeClosing function.
The ExternalTabContainer also needs to wait for the unload handlers on the page to return before it returns
control back to the host browser. To achieve this we enter a nested modal loop which is exited when the
underlying tab is closed.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=31853
Bug=31853
Test=Covered by ChromeFrame unit test.
Review URL: http://codereview.chromium.org/543183
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=rsesek
BUG=32719
TEST=none
Review URL: http://codereview.chromium.org/556033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
test does not specify platform option.
This is a temp solution for rebaselining tool. Need to remove the check once we have more reliable Win7 and Vista builtbot.
R=dglazkov
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/552168
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37195 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=darin
Review URL: http://codereview.chromium.org/553101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37194 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
side of patch]
BUG=25831
TEST=none
Review URL: http://codereview.chromium.org/554004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37193 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=zel
BUG=32719
TEST=none
Review URL: http://codereview.chromium.org/548158
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
slightly.
TBR=zel
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/552169
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=zel
BUG=32719
TEST=none
Review URL: http://codereview.chromium.org/552165
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/556026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/552004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This cleans up the interface for BrowserCreateForApp() which now longer takes a final argument of is_popup. The code has changed so that it is no caller is ever passing in true, so the code has been simplified.
BUG=5739
TEST=Ensure steps in bug report still no longer produce the bug.
Review URL: http://codereview.chromium.org/556024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
in incognito mode.
BUG=27945
Review URL: http://codereview.chromium.org/543155
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37162 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
in HungRendererController.
BUG=33160
TEST=None. (No repro case. Hopefully crashes will go away.)
Review URL: http://codereview.chromium.org/556022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=28652
TEST=see bug
Review URL: http://codereview.chromium.org/553103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37160 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
this is potentially temporary
BUG=27635
TEST=search for something that doesn't exist in the page
Review URL: http://codereview.chromium.org/548154
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37159 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/556025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/552161
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the same Extension object and then crash (or are killed by the Task manager). Since the first ExtensionHost RenderViewGone will cause the Extension to be unloaded, the subsequent call will try and unload a dirty pointer. This is prevented by NULLing out the Extension pointer in the host and checking it upon RenderViewGone before sending a notification to have it unloaded (again).
TEST=none
BUG=32613,32653
Review URL: http://codereview.chromium.org/555103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37156 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/548152
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=33162
TEST=manually with sleep()
Review URL: http://codereview.chromium.org/552157
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37154 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32719
TEST=none
Review URL: http://codereview.chromium.org/554045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/543213
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
disable it.
BUG=25977
TEST=manual, verified disabled with --disable-application-cache
Review URL: http://codereview.chromium.org/548122
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
pthread_join on Linux.
BUG=33085
TEST=none
Review URL: http://codereview.chromium.org/552155
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. Make the newly created popup navigate to a url. Without this session
restore won't restore the tab.
. Before exiting manually shutdown the session service. Without this
the windows are closed, which, depending upon timing, is treated as
though the user closed the window so that session restore won't
restore the window.
BUG=32716
TEST=this is only a test fix
Review URL: http://codereview.chromium.org/552134
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/553071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37147 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=darin
Review URL: http://codereview.chromium.org/551152
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
No longer send the creator from the renderer to the browser since this was all it was used for.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/543199
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
XIB changes:
* Add an NSSearchField and adjust window size.
* Add an outlet for the NSOutlineView so we can clear the delegate to avoid
potential crashes during sheet closing.
* Change the control size of the NSOutlineView to small (looks better).
BUG=32328
TEST=Chromium-->Preferences-->Under the Hood-->Show cookies... Enter a domain or domain substring and, without hitting enter, results should be filtered.
Review URL: http://codereview.chromium.org/557002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
changes in chrome/browser/chromeos.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/549139
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32421
TEST=none
Review URL: http://codereview.chromium.org/553051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
browser window.
BUG=1143
TEST=Tested on Linux with two monitors.
Review URL: http://codereview.chromium.org/551094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/555100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37127 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
just renamed a couple of things).
BUG=0
TEST=Just a rename so doesn't change anything.
Review URL: http://codereview.chromium.org/551153
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37124 0039d316-1c4b-4281-b951-d872f2087c98
|