summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Replace all instances of <hash_map> with a "base/hash_tabe.h",erg@google.com2008-09-0836-125/+78
| | | | | | | | | | | which does the right thing based on whatever platform we're compiling for, along with changing the hardcoded "stdext::", which is a MSVC++ism to use base::hash_{map,set}. B=1869 Review URL: http://codereview.chromium.org/1629 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1862 0039d316-1c4b-4281-b951-d872f2087c98
* Normalize leading LWS in line continuations, per Wan-Teh's suggestion.ericroman@google.com2008-09-082-15/+70
| | | | | | Review URL: http://codereview.chromium.org/1802 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1861 0039d316-1c4b-4281-b951-d872f2087c98
* fix build issue on Linux with GCC 4.1.2evanm@google.com2008-09-085-2/+7
| | | | | | | | | | | related to non-virtual destructors in classes having virtual methods BUG=1859 Patch from Paweł Hajdan jr <phajdan.jr@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1860 0039d316-1c4b-4281-b951-d872f2087c98
* Need to close the plugin stream if NPP_Write fails.darin@google.com2008-09-082-9/+17
| | | | | | | | | | This occurs on YouTube when the user moves the slider to advance the video. Flash is doing this to inform the browser that it should cancel the existing stream. Without handling this error, we end up downloading the video multiple times from multiple offsets. After the user moves the slider 6 times, we will end up having saturated the maximum of 6 connections per host, and then YouTube video playback will appear to be wedged. R=joshia Review URL: http://codereview.chromium.org/1622 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1859 0039d316-1c4b-4281-b951-d872f2087c98
* Compile bspatch only on win32 for now.rahulk@google.com2008-09-081-1/+5
| | | | | | Review URL: http://codereview.chromium.org/1820 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1858 0039d316-1c4b-4281-b951-d872f2087c98
* Use FRIEND_TEST() instead of guessing the test class name (!)maruel@google.com2008-09-082-6/+9
| | | | | | Review URL: http://codereview.chromium.org/1626 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1857 0039d316-1c4b-4281-b951-d872f2087c98
* rollbackrahulk@google.com2008-09-081-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1854 0039d316-1c4b-4281-b951-d872f2087c98
* Remove bspatch from linux build targets.rahulk@google.com2008-09-081-1/+0
| | | | | | | | TBR=sgk,evanm Review URL: http://codereview.chromium.org/1817 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1853 0039d316-1c4b-4281-b951-d872f2087c98
* Disable a flakey test.deanm@google.com2008-09-081-2/+2
| | | | | | | BUG=http://code.google.com/p/chromium/issues/detail?id=1880 Review URL: http://codereview.chromium.org/1816 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1852 0039d316-1c4b-4281-b951-d872f2087c98
* Update chrome trunk's v8 dependency from trunk@101 to trunk@138.ericroman@google.com2008-09-083-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | This picks up the "in" operator fix that was made in branches/v8_bleeding@117. $ svn log -r 102:138 http://v8.googlecode.com/svn/trunk ------------------------------------------------------------------------ r138 | ager@chromium.org | 2008-09-04 06:52:27 -0700 (Thu, 04 Sep 2008) | 10 lines Added support for running tests on the ARM simulator. Fixed bug in the 'in' operator where negative indices were not treated correctly. Fixed build issues on gcc-4.3.1. Changed Date.prototype.toLocaleTimeString to not print the timezone part of the time. Renamed debug.h to v8-debug.h to reduce the risk of name conflicts with user code. ------------------------------------------------------------------------ Review URL: http://codereview.chromium.org/1602 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1851 0039d316-1c4b-4281-b951-d872f2087c98
* A couple of quick TODO and other cleanups.beng@google.com2008-09-084-13/+1
| | | | | | | | B=1031854 Review URL: http://codereview.chromium.org/1624 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1850 0039d316-1c4b-4281-b951-d872f2087c98
* Support WM_APPCOMMAND on Window. Make it just pass through to ↵beng@google.com2008-09-085-0/+67
| | | | | | | | | | | | WindowDelegate::ExecuteWindowsCommand. The delegate needs to pre-translate for it. This allows my mouse's back and forward buttons to work on the new frames. B=1031854 Review URL: http://codereview.chromium.org/1620 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1849 0039d316-1c4b-4281-b951-d872f2087c98
* Fix binary patching for localized OS. Not sure how it was working till now.rahulk@google.com2008-09-084-13/+16
| | | | | | | | BUG=1557 Review URL: http://codereview.chromium.org/268 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1848 0039d316-1c4b-4281-b951-d872f2087c98
* Hopefully remove 102 unneeded static initializers. This should require less ↵deanm@google.com2008-09-081-197/+198
| | | | | | | | memory, since now we will share the PrepopulatedEngines across the language locales. Review URL: http://codereview.chromium.org/1619 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1846 0039d316-1c4b-4281-b951-d872f2087c98
* Makes new tab page update properly when its told bookmarks aresky@google.com2008-09-081-5/+10
| | | | | | | | | | | changed. BUG=1861 TEST=see bug Review URL: http://codereview.chromium.org/1618 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1845 0039d316-1c4b-4281-b951-d872f2087c98
* Add LazyInstance (r1837) to the Mac buildmmentovai@google.com2008-09-081-0/+10
| | | | | | Review URL: http://codereview.chromium.org/1814 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1844 0039d316-1c4b-4281-b951-d872f2087c98
* Set svn:ignore for a few things that have been DEPSifiedmmentovai@google.com2008-09-080-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1843 0039d316-1c4b-4281-b951-d872f2087c98
* - Restore pcre target to webkit.xcodeprojmmentovai@google.com2008-09-081-48/+109
| | | | | | | | | - Fix include path used for wtf target: need to put JavaScriptCore/kjs before generated/WebCore in order for the wtf target to pick up the correct config.h (this was the source of the WTF_CHANGES confusion) Review URL: http://codereview.chromium.org/1801 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1842 0039d316-1c4b-4281-b951-d872f2087c98
* Just by implementing a destructor (even if it's not doing anything), MSVC ↵deanm@google.com2008-09-081-2/+4
| | | | | | | | will register a static initializer as to register the empty destructor. Pretty awesome. Verified that the c++ initializer is no longer in the __xc_a array. Review URL: http://codereview.chromium.org/1812 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1841 0039d316-1c4b-4281-b951-d872f2087c98
* Make the sqlite SConscript file platform-independent.sgk@google.com2008-09-081-36/+12
| | | | | | | | Update from gothicx. B=1783 Review URL: http://codereview.chromium.org/1615 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1840 0039d316-1c4b-4281-b951-d872f2087c98
* Add a DISALLOW_COPY_AND_ASSIGN to LazyInstanceHelper.deanm@google.com2008-09-081-0/+3
| | | | | | Review URL: http://codereview.chromium.org/1811 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1839 0039d316-1c4b-4281-b951-d872f2087c98
* This patch is from Andrew Brampton <me@bramp.net>.sky@google.com2008-09-085-8/+17
| | | | | | | | | | | | | | This patches allows menu items in PopUpMenus to be clicked with the right mouse button. menu.cc controls the web content popup menus, and some others chrome_menu{.cc,.h} controls popup menu on the chrome, for example right clicking on a tab. BUG=718 TEST=Bring up any menu (wrench/document) and right click on one of the items. This should select the item. Try the same with any of the bookmark menus. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1838 0039d316-1c4b-4281-b951-d872f2087c98
* Create a LazyInstance abstraction for avoiding static constructors by lazily ↵deanm@google.com2008-09-086-0/+253
| | | | | | | | creating an instance of an object on first access. This is like Singleton, but without the Singleton property of sharing instances. This also preallocates space for the object to avoid the heap to try to help fragmentation and creation performance. Review URL: http://codereview.chromium.org/1608 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1837 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the ifdef platform jungle from hmac.h, abstracting the platform ↵deanm@google.com2008-09-083-78/+59
| | | | | | | | specific data into a platform specific heap-allocated structure. Review URL: http://codereview.chromium.org/1614 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1836 0039d316-1c4b-4281-b951-d872f2087c98
* Add a void* parameter to the AtExitManager callbacks.deanm@google.com2008-09-084-30/+47
| | | | | | Review URL: http://codereview.chromium.org/1805 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1835 0039d316-1c4b-4281-b951-d872f2087c98
* Replace a custom memcpy(wchar_t*) with the new safer lcpy API. Pass ↵deanm@google.com2008-09-081-4/+14
| | | | | | | | MAX_PATH not MAX_PATH+1 to GetSaveFileName, and log failures better. Review URL: http://codereview.chromium.org/1609 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1834 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash (visible sometimes in the single process UI tests inbrettw@google.com2008-09-081-2/+7
| | | | | | | RestoreToDifferentWindow). Review URL: http://codereview.chromium.org/1809 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1833 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the browser is destroyed during DestroyBrowser because EndSession ↵beng@google.com2008-09-081-1/+9
| | | | | | | | | handling needs it to be synchronously deleted, rather than by the Window's destruction. B=1031854 Review URL: http://codereview.chromium.org/452 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1832 0039d316-1c4b-4281-b951-d872f2087c98
* Fix SSL state in the URL bar being incorrect. Going to an EV site like ↵brettw@google.com2008-09-0710-53/+119
| | | | | | | | | | | | | https://www.verisign.com/ would not should the EV name in the URL bar unless you did something like switch tabs away and back because in my cleanup I removed the notification that this was depending on. This patch adds a new NOTIFY_SSL_STATE_CHANGED notification which is broadcast by the various SSL components when they update the flags. The browser now listens for this notification and will update the URL bar. BUG=1359547 TEST=see repro steps in bug Review URL: http://codereview.chromium.org/436 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1831 0039d316-1c4b-4281-b951-d872f2087c98
* Just compile some basic files so we get a libGlue.a.evanm@google.com2008-09-076-18/+44
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1829 0039d316-1c4b-4281-b951-d872f2087c98
* Don't reinvent the wheel - base::wclscpy does this work in one line of code.beng@google.com2008-09-072-12/+3
| | | | | | Review URL: http://codereview.chromium.org/1807 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1828 0039d316-1c4b-4281-b951-d872f2087c98
* Since the compiler line looks like "$CXXFLAGS $CFLAGS", there's no way to ↵evanm@google.com2008-09-072-5/+8
| | | | | | | | | disable a C++-specific warning when -Wall is in CFLAGS. (You disable the warning, then -Wall turns it back on.) Since we only write C++ code and we're only looking for warnings there for now, just put everything in CXXFLAGS. Also disable one more warning (which is the one that bit me here.) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1827 0039d316-1c4b-4281-b951-d872f2087c98
* Fix purify MLK errors resulting from my previous check-in. The TimerManager ↵darin@google.com2008-09-071-0/+7
| | | | | | | | | | previously deleted pending timers. We need to do the same for PostDelayedTask. This CL makes it so. TBR=jar Review URL: http://codereview.chromium.org/1607 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1826 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate the TimerManager by pulling its priority queue into MessageLoop. ↵darin@google.com2008-09-0710-1164/+393
| | | | | | | | | | This CL also eliminates TaskBase by creating a simple PendingTask struct that is allocated inline within a std::queue used to implement the queues in the MessageLoop class. R=jar Review URL: http://codereview.chromium.org/483 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1825 0039d316-1c4b-4281-b951-d872f2087c98
* Normalize all whitespace in this SConscript in anticipation of changes to come.evanm@google.com2008-09-071-129/+129
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1824 0039d316-1c4b-4281-b951-d872f2087c98
* Rebuild chrome.7z archive by default to get new executables.rahulk@google.com2008-09-063-13/+13
| | | | | | | | BUG=936 Review URL: http://codereview.chromium.org/263 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1823 0039d316-1c4b-4281-b951-d872f2087c98
* Adds missing virtual destructors on a couple of interface classes.darin@google.com2008-09-062-0/+4
| | | | | | | | | Patch contributed by knorton@google.com See http://codereview.chromium.org/270 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1822 0039d316-1c4b-4281-b951-d872f2087c98
* Rollback the rollback of r1806. Wasn't the cause of the test failure.ojan@google.com2008-09-062-3/+5
| | | | | | Review URL: http://codereview.chromium.org/272 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1821 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the sandbox when used with the SANDBOX_EXPORTS define.nsylvain@google.com2008-09-062-7/+7
| | | | | | Review URL: http://codereview.chromium.org/266 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1820 0039d316-1c4b-4281-b951-d872f2087c98
* Allow the import lock dialog to be sized by locale.tc@google.com2008-09-0644-12/+105
| | | | | | | | | Also increase the height of the Italian first run bubble. BUG=1334381,1359145 Review URL: http://codereview.chromium.org/482 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1819 0039d316-1c4b-4281-b951-d872f2087c98
* [new http] Normalize line continuations in response headers.ericroman@google.com2008-09-066-34/+356
| | | | | | | | BUG=1272571 Review URL: http://codereview.chromium.org/458 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1818 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a memory leak introduced in the SafeBrowsing prefix cache test.paulg@google.com2008-09-061-1/+5
| | | | | | | BUG=1484 Review URL: http://codereview.chromium.org/481 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1817 0039d316-1c4b-4281-b951-d872f2087c98
* Rollback 1806, requested by Ojan.evanm@google.com2008-09-062-5/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1816 0039d316-1c4b-4281-b951-d872f2087c98
* Fix webkit.xcodeproj. Make it use our new xcconfig and common build directorymmentovai@google.com2008-09-066-5105/+1937
| | | | | | | setup. Turn off headermaps and use explicit #include paths everywhere. Review URL: http://codereview.chromium.org/269 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1815 0039d316-1c4b-4281-b951-d872f2087c98
* The previous fix doesn't work. We should continuewtc@google.com2008-09-051-4/+10
| | | | | | | | | | | decrypting if there is still extra data to decrypt, and read more if there is no data to decrypt. R=darin BUG=b/1329345,b/1329363 Review URL: http://codereview.chromium.org/480 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1814 0039d316-1c4b-4281-b951-d872f2087c98
* This fixes the "passing NULL to non-pointer argument" warning when compiling ↵mmoss@google.com2008-09-051-1/+1
| | | | | | | | with gcc 4.1, and is consistent with the way EXPECT_EQ uses NULL elsewhere in Chrome. Review URL: http://codereview.chromium.org/267 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1813 0039d316-1c4b-4281-b951-d872f2087c98
* Begin Linux port of webkit/default_plugin.mmoss@google.com2008-09-052-18/+28
| | | | | | | This just isolates the Windows build before porting sources. Review URL: http://codereview.chromium.org/475 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1812 0039d316-1c4b-4281-b951-d872f2087c98
* Removing extra copies of the text results from KJS directory.dglazkov@google.com2008-09-052-27/+0
| | | | | | | TBR=ojan Review URL: http://codereview.chromium.org/478 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1811 0039d316-1c4b-4281-b951-d872f2087c98
* Clamp open file name size.beng@google.com2008-09-052-5/+14
| | | | | | | B=1362425 Review URL: http://codereview.chromium.org/476 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1810 0039d316-1c4b-4281-b951-d872f2087c98
* Readding UI test I pulled yesterday; hopefully the bots will like it more ↵finnur@google.com2008-09-0519-9/+160
| | | | | | | | now. I need to wait for the bookmark bar to become visible so I plumbed in similar code as for the Find box instead of using Sleep's. Review URL: http://codereview.chromium.org/473 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1809 0039d316-1c4b-4281-b951-d872f2087c98