summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fix 2 memory leaks in UtilityProcessHostTest.ExtensionUnpacker.tc@google.com2009-06-261-5/+6
| | | | | | | | | | | Valgrind says this test is now clean, let's hope purify agrees. BUG=15456 Review URL: http://codereview.chromium.org/149092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19410 0039d316-1c4b-4281-b951-d872f2087c98
* This test no longer crashes.abarth@chromium.org2009-06-261-2/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19409 0039d316-1c4b-4281-b951-d872f2087c98
* Two fixes:cevans@chromium.org2009-06-263-2/+96
| | | | | | | | | | | | | | | - Apply limit to cursor dimensions. Turns out that the APIs used on Windows and Linux are integer-overflow resistant to width * height issues. Not sure about Mac, though. - Ensure the renderer passed enough data for the dimensions specified, otherwise we read out of bounds. BUG=none TEST=WebCursorTest.CursorSerialization plus http://www.iconutils.com/faq/web-page-cursor.htm and http://www.hypergurl.com/customcursor.html Review URL: http://codereview.chromium.org/147193 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19408 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing include, fix compile on Fedora 11.thestig@chromium.org2009-06-261-2/+3
| | | | | | Review URL: http://codereview.chromium.org/147224 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19407 0039d316-1c4b-4281-b951-d872f2087c98
* Fix div typogman@google.com2009-06-261-1/+1
| | | | | | Review URL: http://codereview.chromium.org/147228 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19406 0039d316-1c4b-4281-b951-d872f2087c98
* s/OS_MAC/OS_MACOSX/willchan@chromium.org2009-06-261-2/+2
| | | | | | Review URL: http://codereview.chromium.org/149087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19405 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring using_proxy_, using_tunnel_, using_socks_proxy_ into a single ↵arindam@chromium.org2009-06-264-23/+145
| | | | | | | | | | | | | | enum ProxyConfig in HttpNetworkTransaction. Fixing http://crbug.com/14982 In case of SOCKS proxies we set the url to append to the group name so that the socks endpoint is at the target server and not the socks proxy server and so can be effectively reused by the socket pool. BUG=14982 TEST=unittests Review URL: http://codereview.chromium.org/146026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19404 0039d316-1c4b-4281-b951-d872f2087c98
* Makes tab overview show the arrow at the right location.sky@chromium.org2009-06-265-10/+11
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/147218 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19403 0039d316-1c4b-4281-b951-d872f2087c98
* GTK bookmark manager: workaround for multi row dragging.estade@chromium.org2009-06-262-14/+78
| | | | | | | | | http://crbug.com/15240 TEST=click around in the bookmark manager a lot, everything works as you'd expect. In particular, if you hold ctrl and select a few rows, then release control, then click on those rows and try to drag them, they will drag. Review URL: http://codereview.chromium.org/147188 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19402 0039d316-1c4b-4281-b951-d872f2087c98
* Fix download shelf z ordering during close.estade@chromium.org2009-06-261-3/+11
| | | | | | | | | | | Pretty much the same as what we do in the find bar. I think the flickering thing in the bug desc. was another result of <http://crbug.com/14786>, as it was only present in 3.0.190.2 and not ToT, and toggling the bookmark bar fixed it. http://crbug.com/15427 TEST=see bug Review URL: http://codereview.chromium.org/149054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19401 0039d316-1c4b-4281-b951-d872f2087c98
* Enable extension protocols on all platforms. This should enable background ↵erikkay@google.com2009-06-261-8/+1
| | | | | | | | | | | pages and tab-hosted pages from extensions. BUG=none TEST=load an extension that has a background page and verify that the process is created (see chrome://extensions) Review URL: http://codereview.chromium.org/149091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19400 0039d316-1c4b-4281-b951-d872f2087c98
* Fix two issues with Drag-N-Drop in gtk tabstrip:jhawkins@chromium.org2009-06-262-2/+37
| | | | | | | | | | | * Handle drag-leave and drag-failed by hiding or destroying the drag arrow respectively. * Hide the drop arrow instead of destroying the drop info when we set the drop index to -1. This compensates for the fact that gtk emits the drag-leave signal before the drag-data-received signal. BUG=none TEST=Drag a URL in and out of the tabstrip. The drop arrow should disappear when the dragged mouse leaves the tabstrip or when the drag fails. Review URL: http://codereview.chromium.org/149093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19399 0039d316-1c4b-4281-b951-d872f2087c98
* Mark flaky test video-src-change.html.jianli@chromium.org2009-06-261-1/+1
| | | | | | Review URL: http://codereview.chromium.org/147229 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19398 0039d316-1c4b-4281-b951-d872f2087c98
* Set images svn:mime-type.maruel@chromium.org2009-06-260-0/+0
| | | | | | | | | | | | png files to image/png, bmp files to image/bmp, gif files to image/gif NO CODE CHANGE. TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19397 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Delete the upstreamed files: V8NPUtils.h V8NPUtils.cpp NPV8Object.h ↵ajwong@chromium.org2009-06-265-4/+718
| | | | | | | | | | NPV8Object.cpp." This reverts commit 1bc6d3dd877193f5eb32216c05738cba1e5cbb0f. Review URL: http://codereview.chromium.org/147227 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19396 0039d316-1c4b-4281-b951-d872f2087c98
* Change BrowserBubble so that clients can say if they expect canvas mirroring ↵cira@chromium.org2009-06-262-7/+3
| | | | | | | | | | | | | to happen or not. ExtensionShelf doesn't need mirroring since View methods already provide most of the RTL functionality. BUG=http://crbug.com/11880 TEST=Run chrome --lang=he and add 1+ extensions, and see if the handle is in proper position. Review URL: http://codereview.chromium.org/149045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19395 0039d316-1c4b-4281-b951-d872f2087c98
* Add DCHECKs to the states that should be entered only when thewtc@chromium.org2009-06-261-0/+7
| | | | | | | | | | | previous state succeeded. R=ibrar,phajdan.jr BUG=http://crbug.com/4965 TEST=none Review URL: http://codereview.chromium.org/149013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19394 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit merge 45203:45247jianli@chromium.org2009-06-2627-178/+7
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/149088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19392 0039d316-1c4b-4281-b951-d872f2087c98
* Delete the upstreamed files: V8NPUtils.h V8NPUtils.cpp NPV8Object.h ↵ajwong@chromium.org2009-06-265-718/+4
| | | | | | | | NPV8Object.cpp. Review URL: http://codereview.chromium.org/141022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19391 0039d316-1c4b-4281-b951-d872f2087c98
* move the ResetToDefault function for prefs to chrome/browser/options_utilmattm@chromium.org2009-06-264-54/+89
| | | | | | | | BUG=11507 Review URL: http://codereview.chromium.org/147190 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19390 0039d316-1c4b-4281-b951-d872f2087c98
* Foundations for gtk advanced options page.mattm@chromium.org2009-06-266-44/+275
| | | | | | | | BUG=11507 Review URL: http://codereview.chromium.org/147187 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19389 0039d316-1c4b-4281-b951-d872f2087c98
* Mark a layout test as flakyhclam@chromium.org2009-06-261-0/+2
| | | | | | | | | | BUG=13907 LayoutTest/media/remove-from-document.html is flaky because it triggers a deadlock. Review URL: http://codereview.chromium.org/149089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19388 0039d316-1c4b-4281-b951-d872f2087c98
* linux plugins: eliminate GtkWidget* from plugin processevan@chromium.org2009-06-2617-87/+181
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | [retry with mac hopefully fixed this time] GtkWidget* (and its wrapper, gfx::NativeView) only work within a single process. Plugins already work with a lower-level type that works across processes -- an X Window id. The parent of a plugin is an HWND on windows, but it's an X Window id on X. So we introduce a new typedef wrapping that and push it through all the places in the code that needs it. Since we no longer have a GtkSocket in the WebPluginDelegateImpl, we need to do a bit more work in the WebViewDelegate (aka the browser process in the multiproc world). We also need the plugin host (the browser) to track the GtkSockets that are hosting the plugin, as well as destroy them when necessary. To do this we require the plugin owner to grab the plug-removed signal rather than putting its handler in GtkPluginContainer; this is the way it worked before I'd refactored into GtkPluginContainer so it shouldn't be so bad. This change still only works in test_shell, but the refactoring should translate to the multiprocess case pretty easily. Review URL: http://codereview.chromium.org/146009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19387 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash 15371finnur@chromium.org2009-06-261-1/+2
| | | | | | | | | | | We need to null check the return from GetActiveEntry. BUG=15371 TEST=Watch the crash data from the field and make sure the crash is gone. Review URL: http://codereview.chromium.org/147214 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19386 0039d316-1c4b-4281-b951-d872f2087c98
* fix windows build break.kuchhal@chromium.org2009-06-261-0/+2
| | | | | | Review URL: http://codereview.chromium.org/147222 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19385 0039d316-1c4b-4281-b951-d872f2087c98
* Given the results of Rohit's investigation, I think that the times that we'remark@chromium.org2009-06-265-34/+49
| | | | | | | | | | | | | getting out of the pageload tests right now are highly suspect because we're not actually getting the bits from each page to the screen. As such, I'm much less inclined to treat the "regression" in these tests as a problem. BUG=15232 TEST=throbber changes between waiting (gray) and loading (blue) at appropriate times; animation still disabled Review URL: http://codereview.chromium.org/147211 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19383 0039d316-1c4b-4281-b951-d872f2087c98
* Gracefully do nothing when run loop sources fire and no delegate is available.mark@chromium.org2009-06-261-0/+26
| | | | | | | | | | | This can happen if foreign code spins the run loop without Run being on the stack. BUG=2708 TEST=none Review URL: http://codereview.chromium.org/149082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19382 0039d316-1c4b-4281-b951-d872f2087c98
* Enable Firefox import on OS X. No UI yet.kuchhal@chromium.org2009-06-2611-201/+352
| | | | | | Review URL: http://codereview.chromium.org/143001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19381 0039d316-1c4b-4281-b951-d872f2087c98
* Sparse IO implementation for memory-only cachehclam@chromium.org2009-06-265-73/+438
| | | | | | | | | | | | | | Implemented the following methods: MemEntryImpl::ReadSparseData MemEntryImpl::WriteSparseData MemEntryImpl::GetAvailableRange TEST=DiskCacheEntryTest.Memory* original CL: http://codereview.chromium.org/140049 Review URL: http://codereview.chromium.org/147217 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19380 0039d316-1c4b-4281-b951-d872f2087c98
* Remove WebFrame::CaptureImage in favor of having consumers call Layoutdarin@chromium.org2009-06-267-74/+40
| | | | | | | | | | | | and Paint manually on the WebView. BUG=10034 TEST=none R=brettw Review URL: http://codereview.chromium.org/147212 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19379 0039d316-1c4b-4281-b951-d872f2087c98
* Enable back the test disabled in r19348,r19345 since dank disabled them fromnirnimesh@chromium.org2009-06-261-3/+0
| | | | | | | | valgrind itself. Review URL: http://codereview.chromium.org/147213 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19378 0039d316-1c4b-4281-b951-d872f2087c98
* Adding chrome start-up parameters to information passed back in breakpad crashcpu@google.com2009-06-261-20/+42
| | | | | | | | | | | | | - we collect the first two params : switch-1 and switch-2 - up to 64 chars, then it truncates BUG=b/1910452 TEST=starting chrome should work as usual, otherwise see the bug Review URL: http://codereview.chromium.org/149034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19376 0039d316-1c4b-4281-b951-d872f2087c98
* Version number bump for releaseericu@google.com2009-06-261-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19374 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug when launching chromecpu@google.com2009-06-262-5/+4
| | | | | | | | | | | | - Toast experiment was missing a space before "--" - Quote the first param (exe path) because it can contain spaces BUG= none TEST=chrome should uninstall as usual (launches chrome to confirm user action) Review URL: http://codereview.chromium.org/149048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19373 0039d316-1c4b-4281-b951-d872f2087c98
* Micro-refactor: added VideoRendererBase::OnStop().scherkus@chromium.org2009-06-266-8/+25
| | | | | | | | | | | | Updated subclasses WtlRenderer and VideoRendererImpl as well. TEST=none BUG=none Review URL: http://codereview.chromium.org/147191 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19372 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline LayoutTests/security/block-test.html for Linux. On Linux,wtc@chromium.org2009-06-263-1/+134
| | | | | | | | | | | | connect() to 255.255.255.255 fails with errno ENETUNREACH (101), which is mapped to net::ERR_ADDRESS_UNREACHABLE (-109). R=eroman BUG=http://crbug.com/10440 TEST=LayoutTests/security/block-test.html should pass on Linux Review URL: http://codereview.chromium.org/147070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19371 0039d316-1c4b-4281-b951-d872f2087c98
* Change ExtensionHost to use notificationserikkay@chromium.org2009-06-269-60/+36
| | | | | | | | | | | rather than direct communication with ExtensionProcessManager. This simplifies ownership and lifetime issues which allows me to also revert the change that made ExtensionProcessManager owned by ExtensionsService. Review URL: http://codereview.chromium.org/147208 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19370 0039d316-1c4b-4281-b951-d872f2087c98
* Remove dependency on NavigationEntry from RenderViewHost. The code forbrettw@chromium.org2009-06-263-66/+47
| | | | | | | | | | converting a NavigationEntry to a Navigate message is now in TabContents and it will send the params rather than the NavigationEntry to the RenderViewHost. I also removed "virtual" fron a bunch of functions that were never overridden. Review URL: http://codereview.chromium.org/147128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19369 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 19361.davemoore@chromium.org2009-06-268-89/+47
| | | | | | | tbr=darin Review URL: http://codereview.chromium.org/149081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19368 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed bug in script.sky@chromium.org2009-06-261-1/+1
| | | | | | | | | | TBR=dave_levin BUG=none TEST=none Review URL: http://codereview.chromium.org/149080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19367 0039d316-1c4b-4281-b951-d872f2087c98
* Always add actual png file to layout test results directoryvictorw@chromium.org2009-06-261-24/+21
| | | | | | | | | | | | | If the expected results for a test is missing, run_webkit_tests outputs the actual txt and checksum but not png file. The actual png should be archived in this case. BUG=15367 TEST=none Review URL: http://codereview.chromium.org/149016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19366 0039d316-1c4b-4281-b951-d872f2087c98
* Disable BookmarkEditorGtkTest.* instead of just one, sincedkegel@google.com2009-06-261-1/+1
| | | | | | | | | | they all run the init code that makes Valgrind unhappy. BUG=http://crbug.com/15445 TEST=none Review URL: http://codereview.chromium.org/149078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19365 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused / obsolete AppCache code from WebFrame.darin@chromium.org2009-06-264-59/+1
| | | | | | | | | | BUG=10044 TEST=none R=dglazkov Review URL: http://codereview.chromium.org/147177 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19364 0039d316-1c4b-4281-b951-d872f2087c98
* Revert cl 19359 due to browser_tests timeout.tim@chromium.org2009-06-2621-207/+157
| | | | | | | TBR=nsylvain Review URL: http://codereview.chromium.org/147206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19363 0039d316-1c4b-4281-b951-d872f2087c98
* Restrict how often javascript can annoy the user with the print dialog. If ↵sverrir@google.com2009-06-264-15/+62
| | | | | | | | | | | | | a page continuously calls print() through javascript and the user cancels the printing no other printer dialog will be shown for 15 seconds. Also removed "Print failed" notification when the user cancels printing (since this should be obvious to the user). BUG=http://crbug.com/7880 TEST=See bug. Review URL: http://codereview.chromium.org/146052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19362 0039d316-1c4b-4281-b951-d872f2087c98
* A recent change broke the load times. It also revealed some deficiencies.davemoore@chromium.org2009-06-268-47/+89
| | | | | | | | | | | | This adds a new time marker for when a load is committed, which is a more interesting value than the start of the load (which we still keep). Also, the first layout time wasn't an interesting time to keep, instead we keep the time of the first paint. The histograms were modified to use the new values when appropriate. Review URL: http://codereview.chromium.org/147123 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19361 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools Profiler: add sanity test.mnaganov@chromium.org2009-06-263-8/+63
| | | | | | | | | | | Add a test that opens a page which executes JS, profiles it, and checks the result displayed. BUG=none TEST=chrome\browser\debugger\devtools_sanity_unittest.cc Review URL: http://codereview.chromium.org/147204 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19360 0039d316-1c4b-4281-b951-d872f2087c98
* Add a 'RegisterMessages' function to DOMMessageHandler to make it easy to ↵tim@chromium.org2009-06-2621-157/+207
| | | | | | | | | | | | | | construct these objects by deferring the DOMUI dependency to the init / "Attach" step. Add GetMessageHandlers to HtmlDialogUIDelegate to allow sending/receiving messages to the page hosted in the dialog as opposed to only on open/close. BUG=none TEST=none Review URL: http://codereview.chromium.org/131094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19359 0039d316-1c4b-4281-b951-d872f2087c98
* revert socks_client_socket.cc from r19005arindam@chromium.org2009-06-261-45/+47
| | | | | | | | | | | TEST=none BUG=none TBR=eroman Review URL: http://codereview.chromium.org/149077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19358 0039d316-1c4b-4281-b951-d872f2087c98
* reverting the change 19354, 19356arindam@chromium.org2009-06-265-387/+96
| | | | | | | | | | | TEST=none BUG=none TBR=eroman Review URL: http://codereview.chromium.org/149076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19357 0039d316-1c4b-4281-b951-d872f2087c98