| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
Valgrind says this test is now clean, let's hope purify agrees.
BUG=15456
Review URL: http://codereview.chromium.org/149092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Apply limit to cursor dimensions. Turns out that the APIs used on Windows
and Linux are integer-overflow resistant to width * height issues. Not sure
about Mac, though.
- Ensure the renderer passed enough data for the dimensions specified, otherwise
we read out of bounds.
BUG=none
TEST=WebCursorTest.CursorSerialization plus http://www.iconutils.com/faq/web-page-cursor.htm and http://www.hypergurl.com/customcursor.html
Review URL: http://codereview.chromium.org/147193
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/147224
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/147228
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/149087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
enum ProxyConfig in HttpNetworkTransaction.
Fixing http://crbug.com/14982
In case of SOCKS proxies we set the url to append to the group name so that the socks endpoint is at the target server and not the socks proxy server and so can be effectively reused by the socket pool.
BUG=14982
TEST=unittests
Review URL: http://codereview.chromium.org/146026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/147218
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/15240
TEST=click around in the bookmark manager a lot, everything works as you'd expect. In particular, if you hold ctrl and select a few rows, then release control, then click on those rows and try to drag them, they will drag.
Review URL: http://codereview.chromium.org/147188
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Pretty much the same as what we do in the find bar. I think the flickering thing in the bug desc. was another result of <http://crbug.com/14786>, as it was only present in 3.0.190.2 and not ToT, and toggling the bookmark bar fixed it.
http://crbug.com/15427
TEST=see bug
Review URL: http://codereview.chromium.org/149054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
pages and tab-hosted pages from extensions.
BUG=none
TEST=load an extension that has a background page and verify that the process is created (see chrome://extensions)
Review URL: http://codereview.chromium.org/149091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
* Handle drag-leave and drag-failed by hiding or destroying the drag arrow respectively.
* Hide the drop arrow instead of destroying the drop info when we set the drop index to -1. This compensates for the fact that gtk emits the drag-leave signal before the drag-data-received signal.
BUG=none
TEST=Drag a URL in and out of the tabstrip. The drop arrow should disappear when the dragged mouse leaves the tabstrip or when the drag fails.
Review URL: http://codereview.chromium.org/149093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/147229
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
png files to image/png, bmp files to image/bmp, gif files to image/gif
NO CODE CHANGE.
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
NPV8Object.cpp."
This reverts commit 1bc6d3dd877193f5eb32216c05738cba1e5cbb0f.
Review URL: http://codereview.chromium.org/147227
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19396 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to happen or not.
ExtensionShelf doesn't need mirroring since View methods already provide most of the RTL functionality.
BUG=http://crbug.com/11880
TEST=Run chrome --lang=he and add 1+ extensions, and see if the handle is in proper position.
Review URL: http://codereview.chromium.org/149045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
previous state succeeded.
R=ibrar,phajdan.jr
BUG=http://crbug.com/4965
TEST=none
Review URL: http://codereview.chromium.org/149013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/149088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
NPV8Object.cpp.
Review URL: http://codereview.chromium.org/141022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=11507
Review URL: http://codereview.chromium.org/147190
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=11507
Review URL: http://codereview.chromium.org/147187
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=13907
LayoutTest/media/remove-from-document.html is flaky
because it triggers a deadlock.
Review URL: http://codereview.chromium.org/149089
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
[retry with mac hopefully fixed this time]
GtkWidget* (and its wrapper, gfx::NativeView) only work within a
single process. Plugins already work with a lower-level type that
works across processes -- an X Window id. The parent of a plugin
is an HWND on windows, but it's an X Window id on X. So we
introduce a new typedef wrapping that and push it through all the
places in the code that needs it.
Since we no longer have a GtkSocket in the WebPluginDelegateImpl,
we need to do a bit more work in the WebViewDelegate (aka the
browser process in the multiproc world).
We also need the plugin host (the browser) to track the
GtkSockets that are hosting the plugin, as well as destroy them
when necessary. To do this we require the plugin owner to
grab the plug-removed signal rather than putting its handler in
GtkPluginContainer; this is the way it worked before I'd refactored
into GtkPluginContainer so it shouldn't be so bad.
This change still only works in test_shell, but the refactoring
should translate to the multiprocess case pretty easily.
Review URL: http://codereview.chromium.org/146009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We need to null check the return from GetActiveEntry.
BUG=15371
TEST=Watch the crash data from the field and make sure the crash is gone.
Review URL: http://codereview.chromium.org/147214
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/147222
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19385 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
getting out of the pageload tests right now are highly suspect because we're
not actually getting the bits from each page to the screen. As such, I'm
much less inclined to treat the "regression" in these tests as a problem.
BUG=15232
TEST=throbber changes between waiting (gray) and loading (blue) at appropriate
times; animation still disabled
Review URL: http://codereview.chromium.org/147211
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This can happen if foreign code spins the run loop without Run being on the
stack.
BUG=2708
TEST=none
Review URL: http://codereview.chromium.org/149082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19382 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/143001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19381 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implemented the following methods:
MemEntryImpl::ReadSparseData
MemEntryImpl::WriteSparseData
MemEntryImpl::GetAvailableRange
TEST=DiskCacheEntryTest.Memory*
original CL: http://codereview.chromium.org/140049
Review URL: http://codereview.chromium.org/147217
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
and Paint manually on the WebView.
BUG=10034
TEST=none
R=brettw
Review URL: http://codereview.chromium.org/147212
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19379 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
valgrind itself.
Review URL: http://codereview.chromium.org/147213
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19378 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- we collect the first two params : switch-1 and switch-2
- up to 64 chars, then it truncates
BUG=b/1910452
TEST=starting chrome should work as usual, otherwise see the bug
Review URL: http://codereview.chromium.org/149034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19374 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Toast experiment was missing a space before "--"
- Quote the first param (exe path) because it can contain spaces
BUG= none
TEST=chrome should uninstall as usual (launches chrome to confirm user action)
Review URL: http://codereview.chromium.org/149048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Updated subclasses WtlRenderer and VideoRendererImpl as well.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/147191
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
connect() to 255.255.255.255 fails with errno ENETUNREACH (101), which
is mapped to net::ERR_ADDRESS_UNREACHABLE (-109).
R=eroman
BUG=http://crbug.com/10440
TEST=LayoutTests/security/block-test.html should pass on Linux
Review URL: http://codereview.chromium.org/147070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
rather than direct communication with ExtensionProcessManager.
This simplifies ownership and lifetime issues which allows me to also
revert the change that made ExtensionProcessManager owned by
ExtensionsService.
Review URL: http://codereview.chromium.org/147208
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
converting a NavigationEntry to a Navigate message is now in TabContents and
it will send the params rather than the NavigationEntry to the RenderViewHost.
I also removed "virtual" fron a bunch of functions that were never overridden.
Review URL: http://codereview.chromium.org/147128
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
tbr=darin
Review URL: http://codereview.chromium.org/149081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19368 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=dave_levin
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/149080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the expected results for a test is missing, run_webkit_tests
outputs the actual txt and checksum but not png file. The actual
png should be archived in this case.
BUG=15367
TEST=none
Review URL: http://codereview.chromium.org/149016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
they all run the init code that makes Valgrind unhappy.
BUG=http://crbug.com/15445
TEST=none
Review URL: http://codereview.chromium.org/149078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=10044
TEST=none
R=dglazkov
Review URL: http://codereview.chromium.org/147177
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19364 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=nsylvain
Review URL: http://codereview.chromium.org/147206
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19363 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a page continuously calls print() through javascript and the user cancels the printing no other printer dialog will be shown for 15 seconds.
Also removed "Print failed" notification when the user cancels printing (since this should be obvious to the user).
BUG=http://crbug.com/7880
TEST=See bug.
Review URL: http://codereview.chromium.org/146052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds a new time marker for when a load is committed, which is
a more interesting value than the start of the load (which we still keep).
Also, the first layout time wasn't an interesting time to keep, instead
we keep the time of the first paint.
The histograms were modified to use the new values when appropriate.
Review URL: http://codereview.chromium.org/147123
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add a test that opens a page which executes JS, profiles it, and checks the result displayed.
BUG=none
TEST=chrome\browser\debugger\devtools_sanity_unittest.cc
Review URL: http://codereview.chromium.org/147204
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
construct these objects by deferring the DOMUI dependency to the init / "Attach" step.
Add GetMessageHandlers to HtmlDialogUIDelegate to allow
sending/receiving messages to the page hosted in the dialog as opposed to only on open/close.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/131094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=eroman
Review URL: http://codereview.chromium.org/149077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=eroman
Review URL: http://codereview.chromium.org/149076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19357 0039d316-1c4b-4281-b951-d872f2087c98
|