| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=brettw
Review URL: http://codereview.chromium.org/150133
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
unimplemented function.
Review URL: http://codereview.chromium.org/152001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/151105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
image can handle the new size.
BUG=None
TEST=Start chromium and the chromium logo should look the same as
before on the new tab page and on the about:version page.
Review URL: http://codereview.chromium.org/150110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The 'product_dir' variable in gyp is only implemented by the
scons generator and only used by plugins, and the
plugin tests don't yet run on Linux (where we use scons).
The npapi_layout_test_plugin is copied into the proper place
for layout tests with a 'copy' rule.
BUG=15695
Review URL: http://codereview.chromium.org/150085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=sgk
Review URL: http://codereview.chromium.org/150129
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It's actually fine, but it'll have a small change because of WebKit's
r45391 tomorrow so I'm marking it as failing now and I'll rebaseline
it and several others tomorrow.
BUG=10293
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Download something, note that the correct item shows up in the shelf.
Review URL: http://codereview.chromium.org/150015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
294 and 370 (if the if clause is false).
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/151050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
browser components.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/150084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Windows uses Ctrl + j, but the Mac equivalent (Cmd + j) is already
in use for Edit -> Find -> Jump to Selection. I've chosen Cmd + Shift + j,
as a replacement, but it's easy enough to change.
TEST=Press the keyboard shortcut (Shift + Cmd + j) to open the download page.
BUG=15653
Review URL: http://codereview.chromium.org/150073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19637 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
JS api to loadtimes in a way that's more easily digestible for them.
Review URL: http://codereview.chromium.org/150083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
StreamOperation threads.
Review URL: http://codereview.chromium.org/151096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
globally, and avoid using the DOM load/unload events.
- moved callback handling into event_bindings.js (ports will use it).
- added chromeHidden, a V8 hidden value, to keep all internal variables that
need to be accessible to native code.
- changed context registration to occur always at extension load, instead of
DOM load.
- added an internal unload event that doesn't disable SuddenTermination.
This is a rework of my earlier CL http://codereview.chromium.org/125280 which was reverted because of a perf regression. I believe the perf problem was caused by the call into javascript I did on page load to handle context registration - this CL avoids that.
Review URL: http://codereview.chromium.org/147033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
In my testing, this speeds it up 2-3x.
Review URL: http://codereview.chromium.org/150032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/150127
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/151091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Part of tree fix. I temporarilly ifdef'ed the code to repair the tree.
This is a better fix.
r=davemoore
Review URL: http://codereview.chromium.org/151086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19627 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=sverrir
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When launching the browser we restore the maximized state. However, the maximize call is asynchronous, so we don't actually observe the change to |state_| until later. So we need to update the shape on that later state-changed signal.
Usually if the user maximizes the window, it will change sizes. To avoid setting the window's shape more often than necessary, cache its current state (custom shape or no custom shape).
BUG=none
TEST=maximize the window, close chrome, re open chrome. It should not have a custom shape.
Review URL: http://codereview.chromium.org/150081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This change is tiny. Yay for cross-platform code.
Review URL: http://codereview.chromium.org/150091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/150105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It is possible for a crazy server to return 206 even
though we are not making a range request. In that
case, we should not allow the stored response to go
through the logic for range support (which right now
is disabled). We've always stored those 206s though.
BUG=15617
TEST=unittest
Review URL: http://codereview.chromium.org/150090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
connections.
BUG=http://crbug.com/13289
TEST=none
Review URL: http://codereview.chromium.org/147252
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=11392
TEST=Right-click on the tabstrip and select 'Task Manager'.
Review URL: http://codereview.chromium.org/150082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/151066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19618 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
manager.
It was previously landed and reverted because it broke the reliability tests.
http://codereview.chromium.org/125148
The breakage was caused by constrained windows not getting a hold of the FocusManager when in unparented tabs.
The fix is to ensure unparented tab still have a way to access their FocusManager for proper closure.
Files changed from the previous patch that need reviewing:
native_tab_contents_container_win.cc
tab_contents_view_win.h
tab_contents_view_win.cc
BUG=None
TEST=Run all tests (unit, ui, interactive). Extensively test the focus in Chrome.
Review URL: http://codereview.chromium.org/146093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19617 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The first complex text support patch just landed, so it's time to
start looking at the layout tests which will now pass.
BUG=10293,10344,10345,9768
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
upstream in V8Proxy.
BUG=15650
Review URL: http://codereview.chromium.org/151087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19614 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/151045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19613 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
but when I look at the code and confer with mal it looks like the offending code can just be removed (and some de-linting applied).
BUG=None
TEST=None (report a bug dialog should work as before).
Review URL: http://codereview.chromium.org/151069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19612 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=No need for one.
Review URL: http://codereview.chromium.org/151056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
since this is used only during testing, if the comment is
correct.
The reason this leaks is due to potential returns before
Broadcast is reached.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/151047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19610 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/151041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
that
accept MessagePortChannels as an optional parameter.
For now, we just ignore passed-in MessagePortChannels (they are automatically
freed)
but we'll add support for them once the Chromium implementation of
cross-process
MessagePorts is in place.
This is the chromium-side change for
https://bugs.webkit.org/show_bug.cgi?id=25435 and should not be landed until
that change lands in the WebKit tree.
BUG=15426
TEST=none (WebKit change contains LayoutTests)
R=levin@chromium.org
Review URL: http://codereview.chromium.org/147189
Review URL: http://codereview.chromium.org/151090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19608 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/15677
TEST=none
Review URL: http://codereview.chromium.org/150115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19606 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
tbr=davemoore
Review URL: http://codereview.chromium.org/151084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19605 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
2009-06-30 Adam Langley <agl@google.com>
Reviewed by Eric Seidel.
Chromium: Add complex text support on Linux.
https://bugs.webkit.org/show_bug.cgi?id=25068
This patch adds complex text support on Linux using Harfbuzz. It's not
the fastest code possible: some caching of font tables will certainly
be required. However, it's probably the simplest code that works.
This will require checking in new baselines in the Chromium tree for
those layout tests which now pass.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45379 268f45cc-cd09-0410-ab3c-d52691b4dbfc
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19604 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/150112
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On Windows, windowed plugins are parented in a two-stage process: initially,
the plugin is parented to the render view, then later it's reparented to
a special per-plugin window.
On Linux, plugin embedding always needs a special per-plugin window before
it can be initialized. So there's no way to do the two-stage initialization
process, and we only want to construct the browser-side plugin container for
windowed plugins after the plugin requests it.
Plumbing this through the WebPlugin interface will also allow us to side-route
this request for window creation out to the browser process in the
multi-process case.
BUG=15421
TEST=plugins still work in test_shell
Review URL: http://codereview.chromium.org/150034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19602 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This time, don't delete images in generated_images_ since we're now going to delete them in image_cache_.
Review URL: http://codereview.chromium.org/151048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19601 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Roll up to the two-sided patch by agl
R=jorlow
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/150111
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
contents area.
Fix a bug where the background color was not updated on theme change.
BUG=14956
Review URL: http://codereview.chromium.org/151063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19599 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Picking up one more V8Proxy un-oopsie.
R=jorlow
BUG=none
TEST=non
Review URL: http://codereview.chromium.org/151081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/15677
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19597 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=13206
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19596 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To do this, I needed to add the feature that ALL FieldTrials that are
established in the browser process are forwarded and established in
the corresponding renderer processes. This then allows both DNS impact,
as well as SDCH inmpact (and any other field tests) to be studied
at the same time in a single binary.
This checkin also establishes a pattern that when we're doing A/B tests
via a histogram such as RequestToFinish, that we produce names for
all groups, rather than leaving one group as the "default" or "empty postfix"
group. This is critical for naming various sub-groups when a multitude
of tests are taking place at the same time.
BUG=15479
r=mbelshe
Review URL: http://codereview.chromium.org/150087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
navigating to another chrome:// url, the destination DOMUI won't be able to retrieve the data it needs (and thus not function)
BUG=14505
R=brettw
Review URL: http://codereview.chromium.org/132009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This renames the command line flags a bit.
--new-tab-page=path/to/file.html
--old-new-tab-page
BUG=13362
TEST=Launch chrome and you should see the new new tab page.
Review URL: http://codereview.chromium.org/151054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19593 0039d316-1c4b-4281-b951-d872f2087c98
|