| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
R=agl,willchan
BUG=43142
TEST=All layout tests should pass on Windows.
Review URL: http://codereview.chromium.org/2012002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=On Chrome OS open app launcher and set focus back to page by mouse click.
Review URL: http://codereview.chromium.org/2003003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46589 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
updates
notifications.
The wrong render was getting told to report preferred size updates.
We now make sure we enable preferred size notifications when the render view host is created.
Also removed a check for the view type in render_view.cc that was preventing us from
polling the preferred size for regular tabs. This check is not needed since the notifications
need to be explictly enabled and they are only enabled by extensions related render views (and
the app launcher).
TEST=Open the app launcher, it should display correctly.
BUG=None
Review URL: http://codereview.chromium.org/1989002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46588 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=bulach
TEST=none
BUG=43441
Review URL: http://codereview.chromium.org/1998005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46587 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=skerner
TEST=none
BUG=43440
Review URL: http://codereview.chromium.org/1988004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46586 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=mbelshe
TEST=none
BUG=42850
Review URL: http://codereview.chromium.org/2000002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46585 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
test timeout.
TBR=sky
TEST=none
BUG=43437
Review URL: http://codereview.chromium.org/2040002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
beachdemo-glsl and its shaders.
Review URL: http://codereview.chromium.org/1894001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46579 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=xiyuan
TEST=none
BUG=43434
Review URL: http://codereview.chromium.org/2035005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
net tests with chrome frame.
See revision 42240 for more details: http://codereview.chromium.org/1107013
TEST=n/a
BUG=none
Review URL: http://codereview.chromium.org/1987001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46577 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
using both and consistency is nice.
Review URL: http://codereview.chromium.org/1924002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46576 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/2003001 broke browser tests for
login / wizard screens. This fixes them.
Review URL: http://codereview.chromium.org/1995005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46575 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
until we figure out the reason for the failure.
BUG=none
TEST=none
TBR=ctguil@chromium.org
Review URL: http://codereview.chromium.org/2004002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46574 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=dpranke@chromium.org
Review URL: http://codereview.chromium.org/2042001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Was failing 268 of 1198
Now failing 266 of 1198
ugh! all those changes only fixed 2 tests :-(
TEST=some unit test and conformance tests.
BUG=none
Review URL: http://codereview.chromium.org/1942004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46572 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46571 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
needed to be redrawn.
BUG=43225
TEST=Drag a bookmark into a bar folder and then a subfolder and verify that the buttons in the path to the open subfolder are all highlighted.
Review URL: http://codereview.chromium.org/2006001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46570 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1954002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
accessibility tree in the browser process.
Adds new RPCs for a browser tab to request accessibility info from
a renderer; the renderer responds with a complete tree of
accessibility metadata for the entire DOM, which is then cached
in the RenderWidgetHostView. This part is cross-platform and will
help with accessibility on both Windows and Mac OS X.
For Windows, MSAA support for web content has been rewritten to
use this new cache. Tested in JAWS and NVDA screen readers.
Using Chrome with a screen reader is now fast and stable,
unlike the previous implementation. However, note that most
advanced functionality is still not supported, and much work remains
to make Chrome work well with a screen reader. This is a necessary
step to improve stability first.
BUG=25564
BUG=13291
TEST=See http://codereview.chromium.org/1806001
Review URL: http://codereview.chromium.org/1637018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46567 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=crosbug.com/2800
TEST=none
Review URL: http://codereview.chromium.org/2003004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46565 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
make it float with top edge.
BUG=crosbug.com/2800
TEST=Should be no visible changes with info bubble, everything should work as before. Bubble is used for example in bookmarking.
Review URL: http://codereview.chromium.org/1820002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2030001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46563 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Added code that detects array out-of-bounds errors. This should help to debug regressions like http://code.google.com/p/chromium-os/issues/detail?id=2878#c11 .
BUG=chromium-os:2878
TEST=see the bug 2878. confirmed that with this change, chrome does not crash.
Review URL: http://codereview.chromium.org/2018002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
lands.
Review URL: http://codereview.chromium.org/2036001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46559 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46557 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
docked inspectors
BUG=40804
Review URL: http://codereview.chromium.org/2009002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46555 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change makes webkit_glue an independent dynamic library again.
BUG=none
TEST=compile DumpRenderTree with shared libraries.
Review URL: http://codereview.chromium.org/2031001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46554 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Also, hooks for to enable/disable a plugin.
Add a test which excercises them.
Review URL: http://codereview.chromium.org/1935003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46553 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original review:
http://codereview.chromium.org/2016001/show
BUG=None
TEST=Valgrind bots should be green.
Review URL: http://codereview.chromium.org/2025001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46552 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On Linux, the WidgetGTK destruction is asynchronous.
The AppLauncher is deleted when the bubble is closing,
but the bubble is deleted when the WidgetGtk is destroyed.
So the bubble (and its DOMUI) is going away after the app launcher.
Since the app launcher is the TabContentsDelegate of the bubble tab,
the deleted app launcher could still be notified.
This CL ensures we NULL the TabContents' delegate when the AppLauncher
is deleted so it is not accessed.
Original review:
http://codereview.chromium.org/1985003/show
BUG=3068
TEST=On ChromeOS, open the app launcher and close it while it is loading.
Try several times, it should not crash.
Review URL: http://codereview.chromium.org/1996005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1980006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
processing order relative to sync messages, in particular flush on
behalf of SwapBuffers, in the GPU process. This fixes a race condition
in WebGL initialization where the back buffer would sometimes not be
resized properly. Thanks to jam for the suggestion for this fix.
Tested manually by reloading the WebGL image-texture-test demo over
100 times and ensuring it displayed properly each time.
BUG=42733
TEST=none
Review URL: http://codereview.chromium.org/1914005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46545 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch adds a new RVH container: BackgroundContents. The idea is that apps can open a live web-page as a "background" page using window.open('<url>', '<name>', 'background');
If 'background' is specified and the opener is within the app's extent, a BackgroundContents will be used. Otherwise, the 'background' feature is ignored and it is treated as a regular popup call.
Note that as of this patch the following are explicitly not-yet addressed:
1) Session storage for BackgroundContents
2) SSL (or other failures) requiring UI
3) Javascript messages (alert, etc...)
4) Session restore
TEST=All tests should pass
BUG=41275
Review URL: http://codereview.chromium.org/1734014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46544 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
moved to common.
BUG=None
TEST=Test Bookmarks Sync
Review URL: http://codereview.chromium.org/1964005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46543 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
number in the About window or about:version.
The existing code assumed that KSChannelID would be set to "stable" on the
stable channel, but this is incorrect. On the stable channel, KSChannelID is
not set at all.
Originally, the code was correct, but it broke in r36375.
BUG=43357
TEST=1. Check the About window in a stable-channel build. It should show the
version number without being adorned by the word "unknown" or any
other text.
2. In the same stable-channel builds, visit about:version. The Google
Chrome line should show something like 5.0.375.29 (Official Build
46008) without the word "unknown" or any other text.
Review URL: http://codereview.chromium.org/1990002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=none
Review URL: http://codereview.chromium.org/2021001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
mechanism similar to buildbot (e.g. give up if no output from a
subprocess within a few minutes).
When SIGTERMed (e.g. by buildbot), make an effort to SIGTERM any
running subprocess. Should make the coverage bots more resiliant
against getting "stuck" (e.g. the "clean" stage won't fail because a
running process prevents a directory from being empty).
Added some unit tests for the coverage script.
BUG=None
TEST=Run the coverage script.
Review URL: http://codereview.chromium.org/1957004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46538 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This also has a small fix to the shrink wrap CSS for the launcher.
BUG=None
TEST=Install an app, the launcher should show up and the icon should bounce.
Review URL: http://codereview.chromium.org/2014001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46536 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
frame page loads fail with:
Net.ErrorCodesForMainFrame
BUG=41811
Review URL: http://codereview.chromium.org/1568024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46535 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the AutoFill dialog.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1988003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46534 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This reverts commit r46528 because it broke the Chrome Frame build.
Chrome Frame: why we can't have nice things.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46533 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=eroman@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46532 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Move the server response handler to FormStructure.
* Update the |autofill_count_| when we receive server data.
TBR=georgey (vacation)
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1965002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46530 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
closes.
BUG=43353
TEST=none
Review URL: http://codereview.chromium.org/1980004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46529 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=compiles on trybots
Review URL: http://codereview.chromium.org/1954005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46528 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We need to set the transition for border-top-left-radius as well
border-top-right-radius. Setting the transition to border-radius is not
sufficient.
BUG=43092
TEST=Hover the thumbnails on the most visited section. There should be no gaps in the upper corners.
Review URL: http://codereview.chromium.org/1994001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46527 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Also output chrome's time to launch on the login screen.
Review URL: http://codereview.chromium.org/2003001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46526 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CreateStreamOnHGlobal may fail if the underlying GlobalAlloc fails. It has
a strange behavaior where if we pass in an HGlobal, it can create more
streams per process. So the fix is to:
1. not register us as a bind status callback if we cannot create a stream
for sniffing data and
2. When initializing the data sniffing stream pre-create a HGlobal
BUG=To be filed
TEST=none
Review URL: http://codereview.chromium.org/1983002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also made NetworkChange{Observer,Notifier}Proxy use it instead of
managing the source message loop and NetworkChangeNotifier themselves.
BUG=42606
TEST=unit tests
Review URL: http://codereview.chromium.org/1973001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46524 0039d316-1c4b-4281-b951-d872f2087c98
|