| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
Also have --generate_suppressions output to normal log file
for now.
Review URL: http://codereview.chromium.org/99356
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15243 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/11327
Review URL: http://codereview.chromium.org/99359
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Comments from Ryan:
Some small changes to get chromium building on ARM. I tested these using the
standard Linux tool chain and crosstools-ng.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/99365
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/102002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15240 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/100149
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
code from HtmlDialogView.
BUG=http://code.google.com/p/chromium/issues/detail?id=9884
Review URL: http://codereview.chromium.org/99305
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
redid them a few months back.
- close button is properly centered horizontally
- animation looks correct - layout no longer dependent on current frame height
http://crbug.com/11389
Review URL: http://codereview.chromium.org/99332
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15237 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Merge latest changes from http://www.netlib.org/fp/dtoa.c into dtoa.cc
This should fix the gcc 4.4. strict aliasing issues. More info here:
http://patrakov.blogspot.com/2009/03/dont-use-old-dtoac.html
Also update gcc_warnings.patch to match.
BUG=9104
Original change by Craig Schlenter via
http://codereview.chromium.org/99315
Review URL: http://codereview.chromium.org/99367
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
after failing to map the index file.
BUG=11414
TEST=none
Review URL: http://codereview.chromium.org/100349
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
also re-enable tests that I disabled in an attempt to green the bot
TBR=tony
Review URL: http://codereview.chromium.org/100351
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This reverts commit r15232.
Review URL: http://codereview.chromium.org/99366
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This should fix the gcc 4.4. strict aliasing issues. More info here:
http://patrakov.blogspot.com/2009/03/dont-use-old-dtoac.html
Also update gcc_warnings.patch to match.
BUG=9104
Original change by Craig Schlenter <craig.schlenter@gmail.com> via
http://codereview.chromium.org/99315
Review URL: http://codereview.chromium.org/99364
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Only shows the text "tree: (open|closed)" initially now. When
you hover over it, it animates open to show the entire bar.
Review URL: http://codereview.chromium.org/100315
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=cpu
Review URL: http://codereview.chromium.org/100348
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This regressed with:
http://codereview.chromium.org/99161
I think more work is needed, such as:
1) Figure out if more combinations need to be added.
2) Figure out if we can consolidate the code into
one function, so that we don't need to keep three
ShouldLookupAccelerators in sync (one in TextField,
one in LocationBarView and potentially one in
AutocompleteEditViewWin as well (OnKeyDownOnlyWritable).
I'm not sure what all those magic keyboard constants like
0xBB do, so I think I'll leave the rest of the work to the
person who created the changelist noted above.
BUG=11326
TEST=Open google.com, press About link, press Ctrl+F,
press e, press BackSpace. Chrome should not navigate
back.
Review URL: http://codereview.chromium.org/100347
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/99358
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/10032
TEST=Open a new tab and browse to www.google.com. Type something
and check that focus is correctly set to the text field.
Review URL: http://codereview.chromium.org/99327
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
- (attempt to) fix find bar z ordering in a simpler way
- get "close without animation" right.
Review URL: http://codereview.chromium.org/100286
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
make timeout global instead of per-file, shorten it.
Review URL: http://codereview.chromium.org/100340
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15224 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gets called from WebFrameLoaderClient::frameLoaderDestroyed().
The Chromium Embedded Framework needs this notification to properly clean up
memory associated with specific WebFrame instances (for example, custom
NPObject types bound to the WebFrame via BindToWindowObject()).
This patch was contributed by Marshall Greenblatt.
R=aa,darin
Review: http://codereview.chromium.org/99283
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/100341
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/100292
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Here's his description:
Mouse hover out of context menu should un-select menu item.
All Context Menu's which are implemented with ChromeMenu is not properly
un-selecting the menu item when out of focus. The areas where this is affected
are: * Tabs * Bookmark bar * Bookmark managerThe others uses winapi for context
menus. Doesn't use ChromeMenu, uses HMENU, that explanes why the others work.
For this fix, I had to make sure that the MenuPart is always NONE when the mouse
is moved outside of the context menu regions, and that is always the case.
Hence, we can assure to remove selection. The same way it has been done for
SetSelection, I have used the same technique for this, but simpler.
BUG=8088
TEST=For the above mentioned affected areas, I brought up the context menu by
right clicking, and hovered over a menu item, then move the mouse horizontally
outside the context menu region, it deselected the item.
Review URL: http://codereview.chromium.org/102025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
considered unless OK is clicked.
Issue=11013
Review URL: http://codereview.chromium.org/99095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/99354
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
- Fake some anti-aliasing so the text entry matches the next/prev images.
- Match padding pixel perfect with Windows.
Review URL: http://codereview.chromium.org/99275
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
actions by posting a task back to the message loop before
notifying the RenderWidgetHost to perform these operations.
Otherwise, the JS code races with the browser to use the
modified window.
BUG=http://crbug.com/6377
BUG=http://crbug.com/6192
Also, because window resizing is asynchronous between the renderer
and browser, added a renderer-side cache of "pending window rect"
to ChromeClientImpl. Before the change, calling setWindowRect() would
schedule a call to the RenderViewHost to do the work, but a subsequent
call to windowRect() would return the current size, as through the
call to setWindowRect() had never happened. We cache a pending size
and then schedule a task on the message loop to clear the cached size.
This allows javascript which writes and reads the WindowRect sizes to
work, and once we come out of JS and return to the message loop, we'll
go back to asking the RenderViewHost for the true values.
This pending_window_size is my only concern about this patch. It does
pass all layout tests, and the ChromeClientImpl code is executed in the
test_shell.exe code path.
BUG=http://crbug.com/835
TEST=LayoutTests have tests which cover all of these actions. The
problem is that we run layout tests using the test_shell, not Chrome.
Review URL: http://codereview.chromium.org/101019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=1660988
Review URL: http://codereview.chromium.org/102024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15212 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Sato (see http://codereview.chromium.org/100198 ), r=me.
BUG=2985
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/99345
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
on different threads safe.
BUG=11323
Review URL: http://codereview.chromium.org/102023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15209 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/99348
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
change.
BUG=11408
Review URL: http://codereview.chromium.org/99347
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/100332
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. The platform paint was allocating at a size bigger than necessary.
. ChromeCanvas::DrawStringInt was not taking into account the matrix on
the canvas, which means the text could be drawn at the wrong
location.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/99279
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/100343
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
removed the code that updates the find in page commands.
Review URL: http://codereview.chromium.org/100331
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This regressed in my favicon/title updating change because the crashed state
is not updated on the codepath, since it comes from the tab.
The other approach would have been to make this call through the "update
everything" codepath for tbe state changing, but that's executed on a timer, and
it's nice to show the tab crash right away since the check is very inexpensive.
BUG=http://crbug.com/10756
Review URL: http://codereview.chromium.org/99341
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/99340
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
host functions.
Review URL: http://codereview.chromium.org/100254
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/100262
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15198 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/99339
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/100329
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15195 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/99177
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15194 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=11354
Review URL: http://codereview.chromium.org/100303
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15192 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15191 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/100325
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15190 0039d316-1c4b-4281-b951-d872f2087c98
|