summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* This updates the DEPS to bring them in line with the versionsgspencer@google.com2009-07-2325-51/+146
| | | | | | | | | | | that Chrome is currently using, and it removes "files" from the NPAPI include paths and file location in third_party so that we can be consistent with other Chrome third party directories. TEST=build using gyp and scons and ran unit tests on each. Review URL: http://codereview.chromium.org/159277 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21415 0039d316-1c4b-4281-b951-d872f2087c98
* Disable worker tests for debug builds.darin@chromium.org2009-07-231-0/+11
| | | | | | | | | | BUG=17572 TEST=none TBR=levin Review URL: http://codereview.chromium.org/160029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21414 0039d316-1c4b-4281-b951-d872f2087c98
* Update valgrind suprression file again.jam@chromium.org2009-07-231-3/+2
| | | | | | Review URL: http://codereview.chromium.org/159279 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21413 0039d316-1c4b-4281-b951-d872f2087c98
* Unrevert 21355 because the revert might be causing thensylvain@chromium.org2009-07-2329-358/+222
| | | | | | | | worker tests failures. Review URL: http://codereview.chromium.org/159276 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21412 0039d316-1c4b-4281-b951-d872f2087c98
* Import WebKit/WebCore/loader/appcache/ManifestParser.{h,cpp}.darin@chromium.org2009-07-232-0/+239
| | | | | | | | | | | | | | | | | This initial patch contains no edits except for the chromium header and a brief comment; it is uploaded as a basis for future diffs. Subsequent patches will contain the edits for this port and tests. Patch by Jennifer Braithwaite R=darin TEST=none BUG=none Review URL: http://codereview.chromium.org/159237 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21411 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Select omnibox text on button release instead of press.agl@chromium.org2009-07-232-26/+62
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We also don't select all of the text if the user dragged to highlight some text before releasing the button. Tested by repeating the scenarios from: http://codereview.chromium.org/151006 http://codereview.chromium.org/159185 plus checking that the following cases behave as expected: 1. Type some text into the omnibox. Click in Webkit to give it the focus. Click once in the omnibox. All of its text should be highlighted, and middle-clicking in another window should show that the primary selection was updated. 2. Click in the omnibox to clear its highlighted text and click in Webkit again. Click in the omnibox again, but this time drag to highlight some text before letting go of the button. The highlighted text should be preserved on button release, and the primary selection should be updated. 3. Repeat step 2. Click a few times in the omnibox and confirm that we don't select all of its text (that should only happen at the end of the initial click that focuses the omnibox). (Patch from Dan Erat) http://codereview.chromium.org/155971 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21410 0039d316-1c4b-4281-b951-d872f2087c98
* Have UtilityProcessHostTest wait until the utility process dies beforempcomplete@chromium.org2009-07-231-2/+37
| | | | | | | | | | | finishing. This is an attempt to fix a memory leak. BUG=17387 TEST=no Review URL: http://codereview.chromium.org/155895 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21409 0039d316-1c4b-4281-b951-d872f2087c98
* Strip embedded "#" in URLs when constructing HTTP cache key.ericroman@google.com2009-07-232-5/+28
| | | | | | | | | BUG=http://crbug.com/17493 TEST=HttpCache.UrlContainingHash Review URL: http://codereview.chromium.org/155972 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21408 0039d316-1c4b-4281-b951-d872f2087c98
* This fixes some float/double warnings and converts everything to floats.gspencer@google.com2009-07-231-11/+11
| | | | | | Review URL: http://codereview.chromium.org/155953 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21407 0039d316-1c4b-4281-b951-d872f2087c98
* Declare exe_name and cmd_line as const pointers and usewtc@chromium.org2009-07-231-7/+9
| | | | | | | | | | | | | | | const_cast only where necessary. Fix a FORWARD_NULL defect reported by Coverity. Pass cmd_line to sandbox::WideToMultiByte only if cmd_line is not NULL. R=rvargas BUG=http://crbug.com/17101 TEST=none Review URL: http://codereview.chromium.org/155969 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21406 0039d316-1c4b-4281-b951-d872f2087c98
* None of these files need to include config.h any longer...so remove it.jorlow@chromium.org2009-07-2314-28/+2
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/155970 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21405 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a FORWARD_NULL defect in ExtractModuleName reported by Coverity.wtc@chromium.org2009-07-232-6/+5
| | | | | | | | | | | | | | | | If 'sep' is still NULL after the for loop, ix must be -1, so ix == 0 cannot be true. Update the comment for ExtractModuleName in the header to match the implementation. I don't see any code that checks whether the path is a full path. R=rvargas BUG=http://crbug.com/17101 TEST=none Review URL: http://codereview.chromium.org/155979 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21404 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Remove suppressions that don't reproduce."erg@google.com2009-07-231-0/+18
| | | | | | | | | | | | | | It turns out while I couldn't reproduce these valgrind errors locally, they reproduce on the buildbot. This reverts commit dd24218ae59e4c9665c6ebf9fa4ebb5784bf3d88 (r21396). http://crbug.com/16089 TBR=dank Review URL: http://codereview.chromium.org/160023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21403 0039d316-1c4b-4281-b951-d872f2087c98
* Build fix: I incorrectly applied r21399 from a patch.agl@chromium.org2009-07-231-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21402 0039d316-1c4b-4281-b951-d872f2087c98
* Update webkit. Mark some tests as expected to fail due todarin@chromium.org2009-07-232-6/+14
| | | | | | | | | | | | | | | out-of-date baselines. I'll cycle back and rebaseline once the bots generate new results. TBR=pkasting TEST=none BUG=none Review URL: http://codereview.chromium.org/160021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21401 0039d316-1c4b-4281-b951-d872f2087c98
* Squash the "Confirm Form Repost" dialog triggered via an external context ↵robertshield@chromium.org2009-07-233-2/+21
| | | | | | | | | | menu reload - the dialog is modal, but there may not be anything for it to be modal to. This is a shorter term fix - a longer term fix will be to change the way the dialog is displayed and allow it to be routed through automation. Review URL: http://codereview.chromium.org/160010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21400 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a couple gyp configuration issues with ipc_tests.agl@chromium.org2009-07-232-3/+2
| | | | | | | | | | | | | | | | | Adds ipc/ipc.gyp:* to the windows-only 'pull_in_all' target in chrome.gyp so that it's built on the windows builders and removes the dependency from unit_tests onto ipc/ipc.gyp:ipc_tests. Renames file_descriptor_set_unittest.cc to file_descriptor_set_posix_unittest.cc to match the .h/.cc files and so that it gets picked up by the exclusion filter properly. (Patch from James Robinson) http://codereview.chromium.org/159272 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21399 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 21355 because it might be causing all the newnsylvain@chromium.org2009-07-2329-222/+358
| | | | | | | | | | | | crashes on reliability. It also seems to be causing valgrind error. Original change: Switch the first thread in a child process to be the main thread, and make theIO thread be the second thread. The change is needed for plugins on mac. Review URL: http://codereview.chromium.org/159274 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21398 0039d316-1c4b-4281-b951-d872f2087c98
* (Identical to 159254 which I had in a messed up client)cevans@chromium.org2009-07-231-1/+1
| | | | | | | | | | | | | | Fix an off-by-one in the zip filename reading code. It's pretty harmless, and caused by a fairly lousy minizip API. It could lead to an out-of-bounds read due to lack of null termination. No way to reliably test. BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/155984 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21397 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the drag over animation.arv@google.com2009-07-232-39/+124
| | | | | | | | | | | | | | | When we drag over a thumbnail we move the drop target 15px towards the location it would be if we dropped the source. BUG=14961 TEST=Drag a thumbnail. When dragging over an item the item should move towards the location of where the source came from. Review URL: http://codereview.chromium.org/155978 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21396 0039d316-1c4b-4281-b951-d872f2087c98
* Remove suppressions that don't reproduce.erg@google.com2009-07-231-18/+0
| | | | | | | | http://crbug.com/16089 Review URL: http://codereview.chromium.org/159207 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21395 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: Use the GTK close button in the download shelf and popup ↵erg@google.com2009-07-237-23/+29
| | | | | | | | notification. Review URL: http://codereview.chromium.org/155939 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21394 0039d316-1c4b-4281-b951-d872f2087c98
* Propagate theme changes to the tabstrip.avi@chromium.org2009-07-234-1/+12
| | | | | | | | | BUG=http://crbug.com/17519 TEST=change themes; tabs should theme too Review URL: http://codereview.chromium.org/159271 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21393 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable some focus UI tests. These failed for unknown reasons with a funnybrettw@chromium.org2009-07-231-4/+2
| | | | | | | | | | error from the notification service. This error seems to be fixed. BUG=15265 Test=This is a test Review URL: http://codereview.chromium.org/155858 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21392 0039d316-1c4b-4281-b951-d872f2087c98
* Add a correct include for the IPC switches.brettw@chromium.org2009-07-231-0/+1
| | | | | | | | TEST=none Review URL: http://codereview.chromium.org/160016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21391 0039d316-1c4b-4281-b951-d872f2087c98
* Fix liner errors due to duplicate symbols in the switches. These switchesbrettw@chromium.org2009-07-239-17/+7
| | | | | | | were moved to IPC, but the source ones in chrome/common were kept. Review URL: http://codereview.chromium.org/160014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21389 0039d316-1c4b-4281-b951-d872f2087c98
* Adding an image that will be used for the omnibox hint infobar.jcampan@chromium.org2009-07-232-0/+1
| | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/159249 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21388 0039d316-1c4b-4281-b951-d872f2087c98
* change smoke test to run true rather than /bin/true to make macosx happydkegel@google.com2009-07-231-1/+1
| | | | | | Review URL: http://codereview.chromium.org/159258 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21387 0039d316-1c4b-4281-b951-d872f2087c98
* Correctly account for windows of different sizes when snapping windows ↵pinkerton@chromium.org2009-07-231-2/+9
| | | | | | | | | | together during a drag. BUG=16386 TEST=dragging together windows of different sizes. Review URL: http://codereview.chromium.org/159270 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21386 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Change js flags apply order: first ours, then from command line.mnaganov@chromium.org2009-07-231-6/+6
| | | | | | | | | | This allows to redefine flags (e.g. 'logfile') for debugging purposes. BUG=none TEST=none Review URL: http://codereview.chromium.org/160003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21385 0039d316-1c4b-4281-b951-d872f2087c98
* Add export_tarball tool.phajdan.jr@chromium.org2009-07-231-0/+90
| | | | | | | | | | It creates a .bz2 tarball with all the sources, but without .svn directories, and has an option to remove files which are not required for build, and take a lot of space. Review URL: http://codereview.chromium.org/155863 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21384 0039d316-1c4b-4281-b951-d872f2087c98
* Update V8 to version 1.2.14.6 to fix bug where a heap number could beager@chromium.org2009-07-231-1/+1
| | | | | | | | interpreted as a string in a keyed load. TBR=kmillikin@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21383 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the multiplication sign is encoded properly.avi@chromium.org2009-07-231-2/+10
| | | | | | | | | BUG=http://crbug.com/17454 TEST=as bug Review URL: http://codereview.chromium.org/159209 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21382 0039d316-1c4b-4281-b951-d872f2087c98
* Increase the close button offset so the text doesn't overlap it.pinkerton@chromium.org2009-07-231-3/+1
| | | | | | | | BUG=13300 TEST=see bug. Review URL: http://codereview.chromium.org/159269 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21381 0039d316-1c4b-4281-b951-d872f2087c98
* Call setlocale(LC_ALL, "") in a renderer process for subsequent calls tojshin@chromium.org2009-07-231-0/+3
| | | | | | | | | | | | | | | SysNativeMBToWide and WideToSysNativeMB (that use mbstowcs and wcstombs) to work correctly. This is a clone of http://codereview.chromium.org/155913 BUG=16860 (http://crbug.com/16860 ) TEST=Run Chrome with LC_ALL=en_US.UTF-8 and try to upload a file whose name contains non-ASCII characters in UTF-8 (e.g. "café.txt" or "一二.txt" ) . The filename field in a form should be populated with the name (rather than empty). Review URL: http://codereview.chromium.org/159221 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21380 0039d316-1c4b-4281-b951-d872f2087c98
* Don't install the incognito badge in anything other than a normal browser ↵pinkerton@chromium.org2009-07-231-0/+3
| | | | | | | | | | window. BUG=17531 TEST=incognito man doesn't show up in popups, but does in main windows. Review URL: http://codereview.chromium.org/159267 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21379 0039d316-1c4b-4281-b951-d872f2087c98
* TBR=gspencer@google.comgman@google.com2009-07-231-0/+2
| | | | | | | Fix for mac/linux for FindFile test. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21378 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: print function source in eval selection requests.pfeldman@chromium.org2009-07-231-0/+3
| | | | | | Review URL: http://codereview.chromium.org/155918 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21377 0039d316-1c4b-4281-b951-d872f2087c98
* Unbreak extension installation. Cleanup accidentally reversedaa@chromium.org2009-07-231-1/+1
| | | | | | | | | boolean logic. Difficult to test because this is way up close to the UI. Review URL: http://codereview.chromium.org/160002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21376 0039d316-1c4b-4281-b951-d872f2087c98
* Part 2 of secret plan to speed up valgrind log processing.dank@chromium.org2009-07-231-0/+2
| | | | | | | | | | | Commit after previous change to build-valgrind-for-chromium.sh is committed and run. BUG=17484 TEST=sh tools/valgrind/chrome_tests.sh -t base --tool_flags="--nocleanup_on_exit"; grep PossiblyLost valgrind.tmp/* should find no matches. Review URL: http://codereview.chromium.org/159252 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21374 0039d316-1c4b-4281-b951-d872f2087c98
* back out CL 21368 in case for some reason it's causing a crash on video-toggledpranke@google.com2009-07-231-75/+39
| | | | | | | | | | BUG=none TEST=none R=nsylvain@chromium.org Review URL: http://codereview.chromium.org/159260 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21373 0039d316-1c4b-4281-b951-d872f2087c98
* mark the loader tests as failing (bug 17509) so I can investigate tomorrowdpranke@google.com2009-07-231-1/+6
| | | | | | | | BUG=https://crbug.com/17509 Review URL: http://codereview.chromium.org/159259 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21372 0039d316-1c4b-4281-b951-d872f2087c98
* back out CLs 21367, 21366 - no idea why these keep breakingdpranke@google.com2009-07-236-33/+14
| | | | | | Review URL: http://codereview.chromium.org/155983 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21371 0039d316-1c4b-4281-b951-d872f2087c98
* This file is not building on Windows, and I have no time to investigate,nsylvain@chromium.org2009-07-231-1/+0
| | | | | | | | | | but we have to turn the tree green. Can you please take a look? Review URL: http://codereview.chromium.org/155981 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21370 0039d316-1c4b-4281-b951-d872f2087c98
* Build fix: ipc_tests.exe is not getting built for Windows release.agl@chromium.org2009-07-231-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | (Broke in r21342) <jamesr> agl: chromium XP release builder builds chrome.sln and then tries to run ipc_tests.exe. nothing in chrome.gyp depends on ipc_tests now so the executable doesn't exist on that builder <jamesr> agl/jrg: adding a dependency on ../ipc/ipc.gyp:ipc_tests to the 'coverage' target would solve both issues <jrg> jamesr: agl's change will only impact the coverage bots. Sounds like that't not what you want, right? <jamesr> jrg: i think it's correct but won't resolve the chromium XP issue. coverage should run for those tests either way <agl> jamesr: how about I tie it to unit_tests? <agl> jamesr: there's a long term solution and then there's getting the builder green. <jamesr> agl: yeah. trying to check super fast if getting that builder to not run ipc_tests.exe is easy http://codereview.chromium.org/155977 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21369 0039d316-1c4b-4281-b951-d872f2087c98
* modify test_shell's check-sys-deps to work on vista as well as xpdpranke@google.com2009-07-231-39/+75
| | | | | | | | | | | | | | Modify test_shell so that it will handle checking system dependencies on Vista and XP. Clean up a bunch of error messages so that we provide better diagnostics about what is and isn't configured correctly. BUG=none TEST=none R=ojan@chromium.org Review URL: http://codereview.chromium.org/159111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21368 0039d316-1c4b-4281-b951-d872f2087c98
* python 2.4's implementation of sys.popen() has a race conditiondpranke@google.com2009-07-231-0/+4
| | | | | | | | | | | | | | | python 2.4's implementation of sys.popen() keeps a list of subprocesses around to handle cleanup, but the list isn't safe against concurrent access, leading it to sometimes through a ValueError exception. The list is kind of pointless, and the exception can be ignored (which it is in 2.5). BUG=none R=maruel TEST=none Review URL: http://codereview.chromium.org/155782 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21367 0039d316-1c4b-4281-b951-d872f2087c98
* re-do CL 21252 - move image_diff to tools, add deps to test_shelldpranke@google.com2009-07-235-14/+29
| | | | | | | | | | | | | | | CL 21252 seems to have had some svn brokenness (not sure why). I've recreated it and resubmitted it. The changes are to move image_diff from chrome/tools/test to tools/, and to make test_shell depend on image_diff and npapi_layout_test_plugin (and test_worker, where applicable) R=nsylvain@chromium.org TEST=none BUG=none Review URL: http://codereview.chromium.org/155959 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21366 0039d316-1c4b-4281-b951-d872f2087c98
* Add new option --show-possible to valgrind for later use by valgrind_test.py ↵dank@chromium.org2009-07-232-0/+61
| | | | | | | | | | | to speed up log processing. BUG=17484 TEST=run to install new valgrind; sh tools/valgrind/chrome_tests.sh -t base --tool_flags="--nocleanup_on_exit --show-possible=no"; grep PossiblyLost valgrind.tmp/* should find no matches. Review URL: http://codereview.chromium.org/159251 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21365 0039d316-1c4b-4281-b951-d872f2087c98
* Tweak thumbnail sizes a bit so it the NNTP looks better side by side onarv@google.com2009-07-235-21/+23
| | | | | | | | | | | | | | | | | | a 1920x1200 screen. Also, tweak the default size of new windows slightly. In case we decide to use side by side windows size the window in such a way that 2 windows fit on the screen and have the kWindowTilePixels spacing between each other and the screen edges. BUG=None TEST=Show two windows side. On a 1920x1200 screen they should both be showing the thumbnails in normal size. Review URL: http://codereview.chromium.org/155930 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21364 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-01 05:05:22 +0000