| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
places.I'm also adding a constant for CEEE - I named it kCeee instead of kEnableCeee since it's also used in uninstalls.This change is just a beginning of being aware of having more than one product available in setup.
I added some todos and dcheck for myself to keep track of places that will need more significant changes when running multiple installs.
BUG=61609
TEST=All installations (chrome, chrome frame, ceee) should work as before with the exception that the CEEE switch is now --ceee and not --enable-ceee.
Review URL: http://codereview.chromium.org/4635006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4791002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Original CL: http://codereview.chromium.org/4058002
See the Original CL and revision for a full description. All bots have been reverified to have the XTest dependency added.
BUG=None
TEST=None
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Autofill model has been changed to strip off non-digit chars in credit card
input. Fix pyauto tests expectations.
Review URL: http://codereview.chromium.org/4812001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is more comprehensive than the current list.
Among the added zones are zones with non-integer hour offsets
(like Indian, Nepali and some timezones in Austrailia).
Change the display name generation as well to use "LONG"
name followed with the exemplar city of a zone. This is
necessary to distinguish between timezones like
Mountain Time (Phoenix) from Mountain Time (Denver).
BUG=chromiumos:2613
TEST=Go to the timezone setting UI and make sure
that all the timezones (including those with non-integer hour offset)
such as Indian and Nepali timezones are listed.
Review URL: http://codereview.chromium.org/3432015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=61942
TEST=set $MAILER and click on mailto: links when not using gnome/kde, it should open the mailer
Review URL: http://codereview.chromium.org/4769003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
CID=13648
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4771003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65848 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/4653006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65847 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
enabled.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4752006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=ran WebGL conformance tests
BUG=none
Review URL: http://codereview.chromium.org/4666004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If --port is specified on the command line, testserver.py will listen on that port, otherwise it will listen on an ephemeral port. If --startup_pipe is specified, the port number is written to the pipe as a 2 byte unsigned int in host order.
TestServer spawns testserver.py to listen on an ephemeral port and reads the port value from the pipe. A fixed port can not be specified.
BUG=56814
TEST=try bots pass
Review URL: http://codereview.chromium.org/4733005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65843 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some of the integration tests for themes fail due to
http://crbug.com/62779. Marking them as FAILS until the bug is fixed.
TBR=akalin@chromium.org
BUG=62779
TEST=sync_integration_tests
Review URL: http://codereview.chromium.org/4809001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65842 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
FTP sites tend to show long list of file names that can confuse the CLD. Don't translate them automatically.
BUG=50173
TEST=Navigate to a ftp site that contains a text in a foreign language.
Open that file in Chrome. No translation bar should be shown.
Review URL: http://codereview.chromium.org/4596001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65841 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The sync integration test framework does not provide tests with a way to
set a favicon for a bookmark and verify that it gets synced.
This patch adds a method called SetFavicon, that allows tests to set
either a generic favicon, or a variable favicon (using an index) for a
bookmark.
BUG=57234
TEST=sync_integration_tests
Review URL: http://codereview.chromium.org/4749003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Bug=62853
TBR=amit
Review URL: http://codereview.chromium.org/4696005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65839 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Restart an HTTP load when we mispredict the NPN protocol in a Snap Start connection.
Also, test the behaviour of the HTTP layer when SSL errors result
from the first Write() call. When we are doing Snap Start, we need to
merge the first application data record into the ClientHello. Thus the
SSL socket will report that it has connected immedately in order to get
a Write() call. This means that some errors, which would typically
result from the Connect(), are now returned on the first Write().
BUG=none
TEST=net_unittests
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65837 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=62739
TEST=none
Review URL: http://codereview.chromium.org/4708007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65836 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
places tolerant to tests
BUG=chromiumos:8931
TEST=Unittest should pass. Check manually according to bug description.
Review URL: http://codereview.chromium.org/4637006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65835 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of outgoing
headers in ChromeFrame sub requests. The crash occurs because the current headers passed
in the BeginningTransaction are NULL.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=62853
Bug=62853
Review URL: http://codereview.chromium.org/4792002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
An OTR profile does not have a PersonalDataManager, so check for its existence
before refreshing it after clearing autofill form data from browsing history.
BUG=62533
TEST=see bug
Review URL: http://codereview.chromium.org/4771006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65832 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Adds logic to filter out credit card submissions that are invalid, or to merge credit cards that match the card number.
BUG=57975
TEST=PersonalDataManagerTest.Aggregate*
Review URL: http://codereview.chromium.org/4734001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"warning: 'cloud_print::PrintSystemCUPS' has a field
'cloud_print::PrintSystemCUPS::printer_map_' whose type uses the
anonymous namespace"
For some reasons my machine did not produce such warnings and
print_system_cups.cc compiled just fine.
Eric, Could you please verify this fixes the issue?
BUG=none
TEST=Verify no warnings produced on Mac
Review URL: http://codereview.chromium.org/4632004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65829 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This lets us disable icons by default, which gets rid of the
ugly GTK+ copy/cut/paste icons in stock menus while still
showing icons for Views menu items that have explicitly asked
for them, like the ones in the Chrome OS network menu.
BUG=chromium-os:4345
TEST=built and ran it
Review URL: http://codereview.chromium.org/4708008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65828 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The crasher was fixed in WebKit:
https://bugs.webkit.org/show_bug.cgi?id=49108
BUG=61997
TEST=Run the browser tests.
Review URL: http://codereview.chromium.org/4642001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Change the protocol specific files to support the guid
BUG=
TEST=
Review URL: http://codereview.chromium.org/4675006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65826 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The popup menu holds a pointer back to the widget that spawned it, so
we should be sure to close it before we destroy our members.
BUG=62610
TEST=fixes an error in BookmarkBarGtkBrowserTest.ClickOnFloatingTest
Review URL: http://codereview.chromium.org/4780005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65825 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some users still have v1 safe-browsing databases, which were very
large. Track and delete them.
BUG=36380
TEST=Track histograms
Review URL: http://codereview.chromium.org/4688007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65824 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, full sync for the owner leads to ownership loss. This CL
disables full sync radio button in the view, that appears when password
was changed.
BUG=chromium-os:8630
TEST=Login to device. Log out. Change user password in Guest Session.
Try to login again. In the showed window notice, that full sync options
is grayed out.
Review URL: http://codereview.chromium.org/4699001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This avoids classifying partial hostnames ("www.subdomain").
BUG=none
TEST=PhishingUrlFeatureExtractorTest
Review URL: http://codereview.chromium.org/4650002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65822 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
signature
Without an expicit check we crash on a hard int3 when trying to allocate 0 bytes.
BUG=62791
TEST=None.
Review URL: http://codereview.chromium.org/4723007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65821 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
pathway
The functionality added to GoogleAuthenticator that handles HOSTED accounts,
ported to code paths used by ParallelAuthenticator.
BUG=chromium-os:8978
TEST=unit tests, install on device and run chrome with --parallel-auth
Review URL: http://codereview.chromium.org/4799001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also changes the testserver text replacement hooks to accept base64 encoded pairs, and to support multiple replacement texts.
These changes were needed for some of the "ssl/top_frame.html" based tests, which contained a frame with an HTML page referencing three URLs on three tdifferent test servers.
BUG=56814
TEST=browser_tests --gtest_filter="*SSLUI*"
Review URL: http://codereview.chromium.org/4664009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65819 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add plumbing to support tracking which datatypes are triggering nudges. This gets plumbed from the nudges to the actual sync session. Also added some histogramming for the frequency at which particular datatypes trigger syncs (as a result, also supports tracking how often datatypes are changing).
New histograms are of the form "Sync.Freq<datatype>", with bucket units in milliseconds.
BUG=None
TEST=unit_tests
Review URL: http://codereview.chromium.org/4659003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65818 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
instead of PipelineImpl
BUG=54110
TEST=PipelineImplTest
Review URL: http://codereview.chromium.org/4664005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65817 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=59068
TEST=none
Review URL: http://codereview.chromium.org/4667008
TBR=sky@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also adding a bit of logging for easier diagnostics when we can't remove a folder due to files being in use on uninstall.
TEST=Should improve our chances of being able to uninstall without needing to reboot.
BUG=61609
Review URL: http://codereview.chromium.org/4773002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65814 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=59068
TEST=none
Review URL: http://codereview.chromium.org/4667008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65813 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4744002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65812 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4777003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65811 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4747006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65810 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I believe this bug can only be triggered when there is a corresponding OpenGL bug. However, the i915 driver has this bug.
Patch from Kenneth Waters <kwaters@chromium.org>.
TEST=built and run against broken i915 driver
BUG=none
Review URL: http://codereview.chromium.org/4710002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65809 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Based on private communication with davidben.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65808 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Frame build bots, without turning them red.
BUG=62636
TEST=none
Review URL: http://codereview.chromium.org/4691006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Split out of http://codereview.chromium.org/4691003/
BUG=None
TEST=builds...
Review URL: http://codereview.chromium.org/4696004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65801 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add timings for first owner login
This is a redo of a previously lgtm'd cl but on the right branch.
TBR:sky@chromium.org
BUG=chromium-os:8670
TEST=On a new machine login. When picture screen appears skip immediately
before this change that could block for 10+ seconds. Now it should
show the browser w/in 2 seconds
Review URL: http://codereview.chromium.org/4767002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4694007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/4643009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65798 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65791 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The change depends on http://codereview.chromium.org/4520001/show
BUG=chromium-os:8384
TEST=confirmed that Canary appeared in the channel switching UI in Chrome built with branding=Chrome
Review URL: http://codereview.chromium.org/4565001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65789 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
AutomatedUITestBase.OpenCloseBrowserWindowWithAccelerator)
Suppress bug 62801 (invalid read in PR_Lock)
TBR=timurrrr
BUG=57949,62801
Review URL: http://codereview.chromium.org/4802001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65788 0039d316-1c4b-4281-b951-d872f2087c98
|