| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This contains a bug fix for the disappearing external strings bug
(http://crbug.com/9746) as well as a couple of other bug fixes.
In addition to bug fixes, this version of V8 allows the call as
function handler registered on non-function objects to be called in
construct calls.
BUG=9746
Review URL: http://codereview.chromium.org/109011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15289 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=evan
Review URL: http://codereview.chromium.org/109008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The bug was that we accidentally marked a plugin widget as visible if it's parent was visible, even if it was explicitly set as hidden.
BUG=8927
TEST=regression test included, also can verify that analytics doesn't display the gray rectangle per the bug
Review URL: http://codereview.chromium.org/106008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15285 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/100346
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15283 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
regression from my "start the throbber sooner" patch that made JS URLs keep
throbbing forever.
This patch just adds a check to see if the URL is JS, and doesn't synthesize
the load start message. It seems kind of like a hcak, but I think it's the
right thing. As I argued in the last patch (the comment for the block I
modified here), we really need the throbbing status to be synchronous. This
means we need to basically duplicate the logic for when WebKit will do the
throbber in this function.
BUG=11422
Review URL: http://codereview.chromium.org/105009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15280 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=mpcomplete
Review URL: http://codereview.chromium.org/108005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15279 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
shell_ being null. Moved the RevokeDragDrop call to the
TestShell destructor instead.
Eliminate webkit/glue/webhistoryitem* in favor of adding a
NavigateBackForwardSoon method WebViewDelegate. This moves
all of the hacky details of how we intercept "history.{back,
forward,go}" into the webkit layer. My eventual plan is to
teach WebCore how to make this not hacky.
BUG=11423
R=mpcomplete
Review URL: http://codereview.chromium.org/108004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15278 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15276 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/11387
Review URL: http://codereview.chromium.org/109001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15275 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
shell around base::Clipboard now.
http://crbug.com/11387
Review URL: http://codereview.chromium.org/105011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/11387
Review URL: http://codereview.chromium.org/107001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15272 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
-tabs.update()
-tabs.move()
-tabs.remove()
-tabs.update()
-tabs.create()
-tabs.get()
-all tab events, except onUpdated
implemented
-tabs.getSelected()
-tabs.getAllInWindow()
-windows.getCurrent()
-windows.getFocused()
-windows.getAll(populate)
-windows.onFocusedChanged()
-ExtensionBrowserEventRouter now uses BrowserList::Observer
Review URL: http://codereview.chromium.org/100345
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15271 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
beep if nothing was found on the page. The reason is
that it is gets called when you switch from one tab
to the other. I've added a function to FindBar that
the controller can call and each platform can
implement whatever sound they want to use.
BUG=10823
TEST=Open google.com, search for z0, it should beep
(no matches). Open new tab, switch back to the old
tab and it should not beep.
Review URL: http://codereview.chromium.org/99372
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
update
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15267 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
linux box.
Make sure we include gtk as a dependency on Linux.
Review URL: http://codereview.chromium.org/105006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15266 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15265 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
No changes to resource bundle yet, just the move to keep this CL as compact as possible.
Adds new vcproj and gyp file for app dir.
http://crbug.com/11387
Review URL: http://codereview.chromium.org/100354
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15264 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
weight. Also print out a few more statistics like the number
of URLs examined and the number of host + path pairs looked up.
Review URL: http://codereview.chromium.org/105005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15263 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/106001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15262 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
RenderProcessHost's process_. This is similar to RENDER_PROCESS_TERMINATED,
but the latter is not always sent since the process could get reused. It also
takes the place of RENDERER_PROCESS_CRASHED, where this one contains a boolean
Details indicating whether the process crashed (true) or just exited (false).
Review URL: http://codereview.chromium.org/100277
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15261 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We're constrained by hardcoded icon dimensions (pan_icon.png is limited to 20x20) in WebKit, but in the interest of time, we're going to play within those restrictions.
TBR=finnur
BUG=11277
TEST=Do some autoscrolling, verify that our icons are different to Safari's. Verify that they don't disappear on black-backgrounded webpages.
Review URL: http://codereview.chromium.org/105003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15260 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=crbug.com/11325
TEST=Open a page with controls, zoom in or out and check that they scale nicely.
Also, check that the "mouse down" and "clicked" states appear correctly.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Enable a lot of (already essentially working) automation code along the way.
Review URL: http://codereview.chromium.org/100278
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mirrors the BookmarkEditorView method, where the contents of BookmarkModel
are copied to a temporary model so changes can be discarded if the user hits
Cancel. In the GTK version, we copy not into another BookmarkModel, but into
a GtkTreeStore, which serves as a model to the GtkTreeView on screen.
Also ports the unit tests.
http://crbug.com/11250
Review URL: http://codereview.chromium.org/99361
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15257 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=11407
Review URL: http://codereview.chromium.org/105002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
find bar.
Review URL: http://codereview.chromium.org/99376
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
* Fix an 80-column issue
* Remove an unused param
* Remove an unnecessary setter
* Fix a variable capitalization style violation
Review URL: http://codereview.chromium.org/100361
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/99369
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Layout toolstrips on the left of the bookmark bar so that
something always obviously happens when you install one.
This is in response to some feedback I've gotten demoing
toolstrips for various people.
* Open the NTP on install if the bookmarkbar isn't visible.
Again, I'm trying to make something happen when you
install an extension. This won't be the permanent behavior
but it seems like doing nothing if you have your bookmark
bar detached is likely to confuse people.
* Fix a bug where we kept trying to resize the toolstrip
back to the width it had when it was first made visible.
* Fix a bug where we didn't always repaint the bookmarkbar
after the toolstrip preferred width changed.
This also seems to fix the issue where the buildbot sample
shows up overlayed on top of tab contents, though I didn't
mean to fix that with this CL.
Review URL: http://codereview.chromium.org/100310
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
an extra .h and .cc file.
This means I have to split it into it's own action since the other
grd files don't create this output.
This fixes a dependency in the make build.
Review URL: http://codereview.chromium.org/99362
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15248 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
PageAction code that serves the same purpose (and more).
BUG=9812
TEST=No test needed, this shouldn't result in any noticable difference
since the RSS parsing was disabled.
Review URL: http://codereview.chromium.org/100356
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=mpcomplete
Review URL: http://codereview.chromium.org/99370
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
correct fill_into_edit for keywords.
BUG=11416
TEST=see bug
Review URL: http://codereview.chromium.org/100350
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NavigateBackForwardSoon method WebViewDelegate. This moves
all of the hacky details of how we intercept "history.{back,
forward,go}" into the webkit layer. My eventual plan is to
teach WebCore how to make this not hacky.
BUG=11423
R=mpcomplete
Review URL: http://codereview.chromium.org/100353
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Also have --generate_suppressions output to normal log file
for now.
Review URL: http://codereview.chromium.org/99356
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15243 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/11327
Review URL: http://codereview.chromium.org/99359
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Comments from Ryan:
Some small changes to get chromium building on ARM. I tested these using the
standard Linux tool chain and crosstools-ng.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/99365
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/102002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15240 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/100149
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
code from HtmlDialogView.
BUG=http://code.google.com/p/chromium/issues/detail?id=9884
Review URL: http://codereview.chromium.org/99305
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
redid them a few months back.
- close button is properly centered horizontally
- animation looks correct - layout no longer dependent on current frame height
http://crbug.com/11389
Review URL: http://codereview.chromium.org/99332
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15237 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Merge latest changes from http://www.netlib.org/fp/dtoa.c into dtoa.cc
This should fix the gcc 4.4. strict aliasing issues. More info here:
http://patrakov.blogspot.com/2009/03/dont-use-old-dtoac.html
Also update gcc_warnings.patch to match.
BUG=9104
Original change by Craig Schlenter via
http://codereview.chromium.org/99315
Review URL: http://codereview.chromium.org/99367
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
after failing to map the index file.
BUG=11414
TEST=none
Review URL: http://codereview.chromium.org/100349
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
also re-enable tests that I disabled in an attempt to green the bot
TBR=tony
Review URL: http://codereview.chromium.org/100351
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This reverts commit r15232.
Review URL: http://codereview.chromium.org/99366
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This should fix the gcc 4.4. strict aliasing issues. More info here:
http://patrakov.blogspot.com/2009/03/dont-use-old-dtoac.html
Also update gcc_warnings.patch to match.
BUG=9104
Original change by Craig Schlenter <craig.schlenter@gmail.com> via
http://codereview.chromium.org/99315
Review URL: http://codereview.chromium.org/99364
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Only shows the text "tree: (open|closed)" initially now. When
you hover over it, it animates open to show the entire bar.
Review URL: http://codereview.chromium.org/100315
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=cpu
Review URL: http://codereview.chromium.org/100348
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This regressed with:
http://codereview.chromium.org/99161
I think more work is needed, such as:
1) Figure out if more combinations need to be added.
2) Figure out if we can consolidate the code into
one function, so that we don't need to keep three
ShouldLookupAccelerators in sync (one in TextField,
one in LocationBarView and potentially one in
AutocompleteEditViewWin as well (OnKeyDownOnlyWritable).
I'm not sure what all those magic keyboard constants like
0xBB do, so I think I'll leave the rest of the work to the
person who created the changelist noted above.
BUG=11326
TEST=Open google.com, press About link, press Ctrl+F,
press e, press BackSpace. Chrome should not navigate
back.
Review URL: http://codereview.chromium.org/100347
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15228 0039d316-1c4b-4281-b951-d872f2087c98
|