| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
ports through the automation postMessage interface.
See original review at: http://codereview.chromium.org/113461
Patch by Siggi Asgeirsson <sigurdur.asgeirsson@gmail.com>
Review URL: http://codereview.chromium.org/113538
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16396 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
app.gyp.
http://crbug.com/11387
Review URL: http://codereview.chromium.org/113588
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=11017,12056
Review URL: http://codereview.chromium.org/113587
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
omnibox text.
I used a static for the black text tag, but we need a separate instance
per omnibox (one per browser window).
BUG=11450
Review URL: http://codereview.chromium.org/115521
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
As a bonus, debugging of extensions now works. Go OOP inspector team!
Inspection code was calling RVHD::GetProfile(), which was not implemented by ExtensionHost. Looking into this, it seems better to just remove the method from the interface since Profile is already accessible by way of RVH.
The only caller to RVHD::GetProfile() besides the inspector was HWNDHtmlView which is itself dead code, so I removed it too.
Review URL: http://codereview.chromium.org/115501
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Initially just the two failed to delay-load bind exceptions
- Shows the same error dialog as the OS shows so no localization required
TEST= hard to test, but I'll give some pointers on the bug
BUG = 11919
Review URL: http://codereview.chromium.org/113492
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Leaving this on produces warnings with newer gccs.
In https://bugs.webkit.org/show_bug.cgi?id=25864, Darin Adler says, regarding
leaving strict aliasing rules on: "I would expect many, many problems in
WebCore. Not just warnings, but actual code generation problems."
BUG=9104
Review URL: http://codereview.chromium.org/115520
Patch from Craig Schlenter <craig.schlenter@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit r16383.
Session restore fails with this change.
TBR=willchan
Review URL: http://codereview.chromium.org/115519
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
It has more strict semantics than file_util::Move.
http://crbug.com/11585
Review URL: http://codereview.chromium.org/113207
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/12237
TEST=Scroll on a page with frames, make sure everything is drawn
correctly.
Review URL: http://codereview.chromium.org/113584
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16385 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115349
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I didn't bother messing with the selection color or cursor color.
BUG=11450
Review URL: http://codereview.chromium.org/115496
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/11066
Review URL: http://codereview.chromium.org/115400
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16382 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=10896
Review URL: http://codereview.chromium.org/115513
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16381 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
browser_view compiling on Linux. I haven't figured out what we'll do with these
things longer-term.
Review URL: http://codereview.chromium.org/113585
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=ben
Review URL: http://codereview.chromium.org/115512
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16379 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
the gyp file yet as BrowserView needs to be made compilable before I
turn this on.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/113562
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16378 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115495
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/113481
R=brettw
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/113567
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115511
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115412
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16374 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to a new class: BrowserFrameWin.
The major other change I had to make was the way that the TabStrip is set in
the BrowserRootView. Now there is a method on the frame that the view can
call when it creats the tabstrip that will set the tabstrip on the root view.
Review URL: http://codereview.chromium.org/113511
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Update the scripts to fetch values from the BRANDING files instead of hardcoding the values.
Review URL: http://codereview.chromium.org/113555
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/11996
Review URL: http://codereview.chromium.org/113543
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/11137
Review URL: http://codereview.chromium.org/115484
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
string based.
Review URL: http://codereview.chromium.org/115510
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16368 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
users opt in at that level, we just want to send the crashes.
Review URL: http://codereview.chromium.org/113553
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113580
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113577
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
cache size.
Review URL: http://codereview.chromium.org/115508
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16364 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
turns out that converting an object to an SVGNumber can't fail.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16363 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113563
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
eventually views targets.
http://crbug.com/11387
Review URL: http://codereview.chromium.org/113565
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Patch by Mohamed Mansour.
R=abarth
BUG=6646
TEST=compiles
http://codereview.chromium.org/113573
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Misalignment if clip top is odd.
Review URL: http://codereview.chromium.org/115499
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The index is currently built on the main thread (because that's where
we do the decoding now), but I'll change that after landing this.
BUG=6646
TEST=There are tests to cover this, but make sure the omnibox still
suggests bookmark titles.
Review URL: http://codereview.chromium.org/115403
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This mainly shows during navigations or new tab creation (or during render view resizing). White looks better than grey. On debug, set the color to green.
Review URL: http://codereview.chromium.org/113568
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When an HTML page has a title, it is used as the suggested file name in saving
the page. Then the file extension is guessed from the suggested file name.
This results in a wrong extension if the title contains a period ".".
This the source of Bug 10581.
Merely setting ignore_suggested_ext to true in win_util::SaveFileAsWithFilter
is not a good fix, because then we have an issue in saving a page without
a title, where the extension can be correctly derived from the suggested
file name.
This change solves the issue by appending ".htm" to the suggested file name
if the page content type is HTML and the suggested file name doesn't have a
proper extension.
BUG=10581
--------
patch by yuzo@google.com
review here: <http://codereview.chromium.org/115235>
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=11782
TEST=none needed, just removing obsolete file
Review URL: http://codereview.chromium.org/113566
Review URL: http://codereview.chromium.org/113569
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Only check for null if it is initialized.
Review URL: http://codereview.chromium.org/115498
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=10945
Review URL: http://codereview.chromium.org/113433
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the prototype new new tab page.
Split the DownloadsDOMHandler into its own file.
The prototype is rough and has bugs. Don't file any bugs on it!
TEST=Run with the command line above and you should see an alternative
new tab page.
Review URL: http://codereview.chromium.org/115426
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A direct path for rendering <video>, writes directly to
bitmap in SkDevice in SkCanvas. There's several criteria
for direct path:
1. No skew
2. SkDevice is ARGB8888
3. SkCanvas is opaque
Review URL: http://codereview.chromium.org/115281
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113560
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Defined the base interface SeekableBuffer and a thread safe implemntation of
ThreadSafeSeekableBuffer. This class is to be used for media resource loading
that does the meat of buffer queueing and handles short seeking for short distance
out-of-order read patterns.
Review URL: http://codereview.chromium.org/113213
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
by app.gyp.
This wasn't really a problem because Visual Studio looks at guids.
Review URL: http://codereview.chromium.org/113561
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1)Fix logic inversion in IsCrashReporterEnabled().
2)Don't intercept SIGPIPE in non-branded builds since it isn't fatal.
3)Roll DEPS to pickup a bunch of Mac Breakpad fixes.
When breakpad is disabled, we intercept a bunch of signals so that we can crash fast, without waiting for Apple's crash reporter. The problem was that the function we where using to test whether breakpad was enabled was wrong so we were always installing these signal handlers which where just calling exit().
By fixing the IsCrashReporterEnabled() call, we no longer install these signal handlers if Breakpad is enabled.
In any case SIGPIPE is non-fatal so we remove it from the list of signals we intercept.
There have been a number of fixes to the OSX version of Breakpad recently, so we pull those in as well.
BUG=11929
Review URL: http://codereview.chromium.org/115493
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
than usual...
BUG=http://crbug.com/11915
TEST=Open the Clear Browsing Data dialog on Japanese and Chinese-Traditional OS. There should be no truncation.
Review URL: http://codereview.chromium.org/115487
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
views/controls/menu/menu_win.{cc,h} to the gyp build.
Review URL: http://codereview.chromium.org/113557
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16344 0039d316-1c4b-4281-b951-d872f2087c98
|