summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* GTK: Fix label color and text color for DarkRoom.erg@chromium.org2010-02-101-2/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/596046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38702 0039d316-1c4b-4281-b951-d872f2087c98
* Fix test_output_xml_to_json.py not to fail when results_directory requires ↵kinuko@chromium.org2010-02-101-1/+1
| | | | | | | | | | | recursive mkdir BUG=32152 TEST=run test_output_xml_to_json.py with option "--results-directory=a/b" and see if it does not exit with "No such file or directory: 'a/b'" error. Review URL: http://codereview.chromium.org/595016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38701 0039d316-1c4b-4281-b951-d872f2087c98
* Add expectations for the test we pass, but Win upstream doesn't.dglazkov@chromium.org2010-02-102-1/+12
| | | | | | | | | | TBR=darin TEST=none BUG=33359 Review URL: http://codereview.chromium.org/601034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38700 0039d316-1c4b-4281-b951-d872f2087c98
* Added the GetAllAutofillEntries function to the WebDatabase class in ↵skrul@chromium.org2010-02-106-0/+97
| | | | | | | | | | | preparation for autofill sync. BUG=30959 TEST=WebDatabaseTest.GetAllAutofillEntries Review URL: http://codereview.chromium.org/598004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38699 0039d316-1c4b-4281-b951-d872f2087c98
* Update bug id on color-correction-related tests.dglazkov@chromium.org2010-02-101-4/+2
| | | | | | | | | | TBR=dimich TEST=none BUG=28317 Review URL: http://codereview.chromium.org/600057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38698 0039d316-1c4b-4281-b951-d872f2087c98
* Use Chrome update UI for Chrome OS updates.davemoore@chromium.org2010-02-106-41/+169
| | | | | | | | | BUG=279 (Chromium OS) (Not Complete) TEST=none Review URL: http://codereview.chromium.org/587006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38697 0039d316-1c4b-4281-b951-d872f2087c98
* Mark CookiesWindowControllerTest.RemoveButtonEnabled as flaky.rsesek@chromium.org2010-02-101-1/+7
| | | | | | | | | BUG=35327 TEST=Flaky on Mac Valgrind unit Review URL: http://codereview.chromium.org/603013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38696 0039d316-1c4b-4281-b951-d872f2087c98
* Update more test expectations to match reality.dglazkov@chromium.org2010-02-101-5/+3
| | | | | | | | | | TBR=zork TEST=none BUG=none Review URL: http://codereview.chromium.org/593048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38695 0039d316-1c4b-4281-b951-d872f2087c98
* Add some tests to CookieMonster for overwriting persistent cookies, and ↵eroman@chromium.org2010-02-1010-65/+234
| | | | | | | | checking that the PersistentCookieStore interface is exercised correctly. Review URL: http://codereview.chromium.org/600040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38694 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/600032stoyan@chromium.org2010-02-101-0/+9
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38692 0039d316-1c4b-4281-b951-d872f2087c98
* Pass the SWP_NOMOVE flag to SetWindowPos in ↵mpcomplete@chromium.org2010-02-101-1/+4
| | | | | | | | WebPluginDelegateImpl::WindowedReposition or all plugins will be incorrectly moved to (0,0). Review URL: http://codereview.chromium.org/577027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38691 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Temporarily turn off use of X shared memory extension.thestig@chromium.org2010-02-101-0/+9
| | | | | | | | BUG=25324 TEST=No more crashes in libX11? Review URL: http://codereview.chromium.org/598025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38690 0039d316-1c4b-4281-b951-d872f2087c98
* Make linux_views depend on new gtk_theme_provider dependencies.erg@chromium.org2010-02-101-0/+2
| | | | | | TBR=estade git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38689 0039d316-1c4b-4281-b951-d872f2087c98
* Dialog showed now only if profiles are loaded - if not it waits until they are.georgey@chromium.org2010-02-104-15/+60
| | | | | | | | | Added capability of multiple observers for profile loading. BUG=33026 TEST=If loading of profiles takes time (slow connection, for example), dialog does not appear until they are loaded. Review URL: http://codereview.chromium.org/601010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38688 0039d316-1c4b-4281-b951-d872f2087c98
* CL implementing focus-dismissal of the chrome.experimental.popup set of ↵twiz@chromium.org2010-02-1027-31/+423
| | | | | | | | | | | | | | | | | extension APIs. Specifically, these changes cause a displayed pop-up to be dismissed when the focus shifts away from both the pop-up view, and the extension-view that launched the pop-up.I had to do a lot of investigating and trial-and-error to converge to the solution present here. I was hoping to be able to piggy-back on the existing FocusManager's various listener routines, but because the pop-up is hosted in a BubbleWidget, which is a separate top-level window with its own focus manager, I could not rely on a given focus manager to take care of the focus change notifications. To get around the above issue, I added a new type of focus listener that can listen on native-window focus change events. I added invocations to this listener throughout the Widget classes in the system so that registered listeners will be notified on focus change. I found some of the focus change events problematic, as the system will arbitrarily reassign the focus to the main browser window when shifting activation between chrome windows. (SeefocusManagerWin::ClearNativeFocus). To prevent this focus bounce from confusing focus listeners, I added a means to suppress notification of focus change during these operations. I added GTK and Mac stubs for the new widget functions that will assert when called. GTK and Cocoa development is not my expertise, so I thought // TODO(port) would be wiser.I'm uncertain of the best means to unit-test these changes. Direction in this regard would be appreciated. BUG=None TEST=None Review URL: http://codereview.chromium.org/552167 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38685 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: lighten the color of the download item status/label text.estade@chromium.org2010-02-101-16/+36
| | | | | | | | | | | This doesn't use the same technique as windows/mac, which both draw the text first, then draw the download item shading over it. To do that for GTK results in very delicate and complicated code, so instead I just alpha-blended the text color manually with hard-coded values. BUG=21176 TEST=see bug Review URL: http://codereview.chromium.org/598033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38684 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Use color data from the MetaFrames class in newer versions of GTK+.erg@chromium.org2010-02-105-28/+80
| | | | | | | | | | | | | | | When codereviewing my r36867, evmar suggested that I implement our trying to match WM frames in terms of gtk_rc_get_style_by_paths(). This worked... on the version of gtk+ included with hardy. It notably doesn't work under the version included with Karmic. This is the original patch from CL 552092 with some cleanup, before I rewrote it. BUG=32173 TEST=New Wave has a dark border color under GNOME on Karmic. Review URL: http://codereview.chromium.org/564048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38682 0039d316-1c4b-4281-b951-d872f2087c98
* Sandbox: Add support for EAT interceptions in 64 bit.rvargas@google.com2010-02-107-20/+128
| | | | | | | | | | BUG=27218 TEST=manual integration tests. Review URL: http://codereview.chromium.org/600035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38681 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore .m files in addition to .mm on non-Macs.mark@chromium.org2010-02-101-1/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/594031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38680 0039d316-1c4b-4281-b951-d872f2087c98
* Wait a second before initializing the Mac notifier thread.willchan@chromium.org2010-02-102-9/+32
| | | | | | | | | This should prevent slowing down Mac startup. BUG=34926 Review URL: http://codereview.chromium.org/593039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38679 0039d316-1c4b-4281-b951-d872f2087c98
* Add new valgrind suppression to green the tree.estade@chromium.org2010-02-101-0/+17
| | | | | | | | | | BUG=35318 TEST=none TBR=zork Review URL: http://codereview.chromium.org/603012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38675 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to fix the Linux Views and ChromiumOS builds following r38658.mark@chromium.org2010-02-109-15/+224
| | | | | | | | | | | | | chrome/browser/views/tab_contents/render_view_context_menu_win.cc appears to be a views file, not a Windows file, so why is it named with _win.cc? This is a speculative change. BUG=none TEST=Linux Builder (Views dbg) and Linux Builder (ChromiumOS) compile steps turn green Review URL: http://codereview.chromium.org/600049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38672 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Chromium XP (clobber) build following r38658:mark@chromium.org2010-02-101-1/+1
| | | | | | | | | | | | | tools\test_shell\resources\test_shell.rc(3) : fatal error RC1015: cannot open include file 'resource.h'. This file is compiled in a different directory now. BUG=none TEST=Chromium XP Review URL: http://codereview.chromium.org/600048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38670 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to fix the Linux Views and ChromiumOS builds following r38658.mark@chromium.org2010-02-106-11/+11
| | | | | | | | | | | | | chrome/browser/views/tab_contents/render_view_context_menu_win.cc appears to be a views file, not a Windows file, so why is it named with _win.cc? This is a speculative change. BUG=none TEST=Linux Builder (Views dbg) and Linux Builder (ChromiumOS) compile steps turn green Review URL: http://codereview.chromium.org/596040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38669 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to fix the Linux Views and ChromiumOS builds following r38658.mark@chromium.org2010-02-101-2/+2
| | | | | | | | | | | | | | | chrome/browser/views/tab_contents/render_view_context_menu_win.cc appears to be a views file, not a Windows file, so why is it named with _win.cc? This is a speculative change. It may not work, in which case the file will need to be renamed. BUG=none TEST=Linux Builder (Views dbg) and Linux Builder (ChromiumOS) compile steps turn green Review URL: http://codereview.chromium.org/598042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38667 0039d316-1c4b-4281-b951-d872f2087c98
* Better alignment for Star button and location bar.avayvod@chromium.org2010-02-101-3/+7
| | | | | | | | | BUG=none TEST=Toggle compact location bar. Star button should be now aligned with Reload button, not be above it. Review URL: http://codereview.chromium.org/601012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38666 0039d316-1c4b-4281-b951-d872f2087c98
* base::SharedMemory does not set the size in other than the creatingsehr@google.com2010-02-103-3/+16
| | | | | | | | process. Create an API to get the size of the audio shared memory region. Review URL: http://codereview.chromium.org/596038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38665 0039d316-1c4b-4281-b951-d872f2087c98
* Include test_shell.gypi in webkit.gyp instead of maintaining a distinctmark@chromium.org2010-02-107-77/+90
| | | | | | | | | | | | | | | | | | test_shell.gyp. This allows the removal of webkit.gyp:pull_in_test_shell, eliminating the circular relationship between webkit.gyp and test_shell.gyp. The expected semantics of building all of test_shell during a webkit.gyp:All build is performed are retained. This change depends on GYP r781 (in Chromium at r38526) for GYP suffix operator path section treatment. It also depends on Chromium r38519 and r38658 for common.gypi treatment of chromium_code. BUG=33186 TEST=Xcode no longer holds stale project files in memory Review URL: http://codereview.chromium.org/602006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38664 0039d316-1c4b-4281-b951-d872f2087c98
* Update test expectations according to reality.dglazkov@chromium.org2010-02-101-17/+2
| | | | | | | | | | TBR=zork TEST=none BUG=many Review URL: http://codereview.chromium.org/593044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38663 0039d316-1c4b-4281-b951-d872f2087c98
* Per brakowski, the cookie prompt default should be "remember" and not "ask".pkasting@chromium.org2010-02-101-1/+1
| | | | | | | | BUG=none TEST=Turn on cookie prompting. The prompt default should be "remember". Review URL: http://codereview.chromium.org/593043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38661 0039d316-1c4b-4281-b951-d872f2087c98
* Check-in a script to visualize the host resolver traces.eroman@chromium.org2010-02-104-0/+527
| | | | | | Review URL: http://codereview.chromium.org/578026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38659 0039d316-1c4b-4281-b951-d872f2087c98
* Let the chromium_code variable be applied in target scope in addition to .gypmark@chromium.org2010-02-101-5/+18
| | | | | | | | | | | | | | | | | file scope. This extends r38519, which was incomplete. To resolve bug 33186, I am trying to turn test_shell.gyp into test_shell.gypi, and have webkit.gyp include it. webkit.gyp is not chromium_code, but the targets in test_shell.gypi are. BUG=33186 TEST=builds still work, -Werror and friends are still applied (or not) correctly Review URL: http://codereview.chromium.org/600047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38658 0039d316-1c4b-4281-b951-d872f2087c98
* Adds code to restore application extensions. I'm also enabling tabsky@chromium.org2010-02-1019-29/+326
| | | | | | | | | | | | pinning on views again as everything in place, except a couple of bugs. BUG=32845 TEST=none Review URL: http://codereview.chromium.org/598027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38657 0039d316-1c4b-4281-b951-d872f2087c98
* Change the name fields back to their previous name to unbreak the buildzork@chromium.org2010-02-102-2/+2
| | | | | | | BUG=none TEST=build chrome git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38656 0039d316-1c4b-4281-b951-d872f2087c98
* First stab at a DataTypeController.skrul@chromium.org2010-02-1027-206/+1143
| | | | | | | | This is my first stab at a DataTypeController, plus a BookmarkDataTypeController implementation. It is not fully wired into the PSS yet :) Review URL: http://codereview.chromium.org/545074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38655 0039d316-1c4b-4281-b951-d872f2087c98
* Update the .proto files to change the fields to optional.zork@chromium.org2010-02-102-4/+4
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/598035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38654 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash when parsing address fields. It's possible we've run out of ↵jhawkins@chromium.org2010-02-101-0/+4
| | | | | | | | | | fields while parsing the zip code. The other fields check this in ParseText, but ParseZipCode opens up the field to get at the name. BUG=35176 TEST=none Review URL: http://codereview.chromium.org/604002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38653 0039d316-1c4b-4281-b951-d872f2087c98
* xpdual/intl1 got faster, update expectations.chase@chromium.org2010-02-101-1/+1
| | | | | | | | | | | | Perf improved on this test by 40ms. Not sure why yet, none of the CLs are obviously a cause. BUG=none TEST=xpdual/intl1 stays green Review URL: http://codereview.chromium.org/597024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38652 0039d316-1c4b-4281-b951-d872f2087c98
* Update NSS to NSS 3.12.6 Beta 1 and NSPR to NSPR 4.8.4wtc@chromium.org2010-02-101-1/+1
| | | | | | | | | | | Beta 1. R=agl BUG=none TEST=none Review URL: http://codereview.chromium.org/598031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38651 0039d316-1c4b-4281-b951-d872f2087c98
* Fill in the preference sync TODOs using the preference specifics proto andalbertb@google.com2010-02-107-53/+115
| | | | | | | | | | | client tags. BUG=32409 TEST=none Review URL: http://codereview.chromium.org/593029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38650 0039d316-1c4b-4281-b951-d872f2087c98
* Re-add suppression for the un-fixed leak from r38619.rsesek@chromium.org2010-02-101-0/+7
| | | | | | | | | | TBR=dglazkov BUG=31586 TEST=Mac Valgrind unit_tests Review URL: http://codereview.chromium.org/604003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38649 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure that ResourceQueue is shut down before destruction.phajdan.jr@chromium.org2010-02-106-375/+315
| | | | | | | | | | | | | Rewrite UserScriptListener unit test to not use ResourceDispatcherHost. Share more code with ExtensionsServiceTest. TEST=Covered by unit_tests. BUG=none Review URL: http://codereview.chromium.org/601005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38648 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enabled test - worker-messageport-gc.html.atwilson@chromium.org2010-02-101-2/+1
| | | | | | | | | BUG=22947 TEST=re-enabled test. Review URL: http://codereview.chromium.org/602010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38647 0039d316-1c4b-4281-b951-d872f2087c98
* Cleaning up invocations of grit and grit_info.bradnelson@google.com2010-02-102-28/+21
| | | | | | | | | | | Making webkit grd dependencies more correct. BUG=19866 TEST=None Review URL: http://codereview.chromium.org/600029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38646 0039d316-1c4b-4281-b951-d872f2087c98
* API changes and protocol changes for supporting the latest SPDY spec.mbelshe@chromium.org2010-02-108-88/+142
| | | | | | | | | | | | | | | | | | Changes include: rename FIN_STREAM to RST_STREAM update enums Add associated-to field to SYN_STREAM Update SYN_STREAM APIs Fix up unit tests. I think these are all the on-wire compatibility changes in the spec. More semantic changes are necessary, of course. BUG=none TEST=none Review URL: http://codereview.chromium.org/599018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38645 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Build fixerg@chromium.org2010-02-101-1/+1
| | | | | | TBR=sheriff git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38644 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Implements the content settings window and the minor changes to the ↵erg@chromium.org2010-02-1019-150/+823
| | | | | | | | | | | | | | options dialog. The "Exceptions" dialogs are still not implemented; they're the next step but this changelist is already getting pretty huge. BUG=35178 TEST=none Review URL: http://codereview.chromium.org/602005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38642 0039d316-1c4b-4281-b951-d872f2087c98
* Make path absolute so URL Fixer Upper unittest does not fail if invoked ↵jochen@chromium.org2010-02-101-1/+3
| | | | | | | | | | | | using something like ../../out/Debug/unit_tests BUG=none TEST=Run the unit_tests executable with a path containing a "/../". It should pass. Review URL: http://codereview.chromium.org/595005 Patch from Bernhard Bauer. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38641 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a bug where if there are only localstorage nodes, but nocookies nodes, ↵ian@chromium.org2010-02-109-38/+93
| | | | | | | | | the Remove and Remove All buttons are disabled.BUG=34886 TEST=clear all cookies, go to www.ianfette.com/localstorage.html and open cookies dialog, check that remove button is enabled. Review URL: http://codereview.chromium.org/596002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38640 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the temporary scaffolding stubs.phajdan.jr@chromium.org2010-02-1026-278/+303
| | | | | | | | | | | | | They have served they purpose well, but now it's time to retire. It's one of the things that draggen in the bad dependency of chrome/common on chrome/browser, and is sufficiently small now to stub things out individually. TEST=none BUG=none Review URL: http://codereview.chromium.org/593037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38639 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-02 20:47:55 +0000