| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
attempt to land the patch 598014. Now with concatenated file name changed from devtools.js to DevTools.js
BUG=34411
Review URL: http://codereview.chromium.org/601025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38606 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Some also say it's good for reducing flakiness.
TEST=Changing ui_tests.
BUG=none
Review URL: http://codereview.chromium.org/593018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38605 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also update the test infrastructure to support the required features.
TEST=browser_tests
BUG=30405
Review URL: http://codereview.chromium.org/572038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38604 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=pfeldman
Review URL: http://codereview.chromium.org/602019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=34411
Review URL: http://codereview.chromium.org/598014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=34411
Review URL: http://codereview.chromium.org/599005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=35157
TEST=Run chrome with --login-manager=create_accout and verify that screen
works as intended.
Review URL: http://codereview.chromium.org/600003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38588 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=start chrome and run tcpdump -A. Should be contain any referer header.
Review URL: http://codereview.chromium.org/600008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38587 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
not exist there.
1. URLRequestTest.DoNotSendCookies
2. URLRequestTest.DoNotSendCookies_ViaPolicy_Async
3. URLRequestTest.CancelTest_During_OnGetCookiesBlocked
4. URLRequestTest.CancelTest_During_OnSetCookieBlocked
TBR=amit
Review URL: http://codereview.chromium.org/601020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38585 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=dpranke
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38584 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
read request in the automation job.
The crash based on the dump occurs while dereferencing a NULL message filter, which means that we received
a read request for a disconnected/terminated job. This happens when a request is paused while waiting for
the renderer to ack sent data packets
Following fixes:-
1. NULL check the message_filter pointer before dereferencing it in URLRequestAutomationJob::ReadRawData.
2. Only complete the job when we receive a Read request for it or if we have a pending read.
Added ASSERTS in OnDataAvailable to check if we receive unexpected data.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=34819
Bug=34819
Test=Covered by ui test.
Review URL: http://codereview.chromium.org/577033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38583 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/601016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38582 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=jorlow
Review URL: http://codereview.chromium.org/596031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
A few layout test changes.
TBR=jorlow
Review URL: http://codereview.chromium.org/593032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=levin
BUG=35224
TEST=none
Review URL: http://codereview.chromium.org/597018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38579 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
together at the bottom.
BUG=35089
TEST=Clear browsing data dialog should look OK in Windows Classic
Review URL: http://codereview.chromium.org/600034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38577 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change the way different things ensure the floating bar is visible. The new
model is that things can "lock bar visibility" (and this locking can continue
even outside fullscreen mode). Set up explicit timers for showing/hiding.
BUG=31638
TEST=Things still work normally.
Review URL: http://codereview.chromium.org/587015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38574 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
AutoFill does not have the same conditions. This required manipulating
the FormField data structure to add necessary field data."
This reverts commit r38570.
TBR=jhawkins
Review URL: http://codereview.chromium.org/602014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Some new svg tests.
TBR=jorlow
Review URL: http://codereview.chromium.org/598032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38572 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
OmxInputBuffer is now ref counted, but some code still try to
delete it explicitly. This delete call is hidden in a template
function so it was hard to find!
Review URL: http://codereview.chromium.org/601015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38571 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
does not have the same conditions. This required manipulating the FormField data structure to add necessary field data.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/602008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38570 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=35088
TEST=Open preferences window, go to third page, top two buttons shouldn't look related to stuff below them.
Review URL: http://codereview.chromium.org/598030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38568 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=35224, 28439
TBR=levin
Review URL: http://codereview.chromium.org/601017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38567 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Just some tests that are new or changed upstream.
TBR=jorlow
Review URL: http://codereview.chromium.org/600031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the second half of http://codereview.chromium.org/597013.
TBR=pkasting
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/596027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38565 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
for GTK, although GTK has not yet moved the Clear Data button to the third page of the options.
This also eliminates a number of not-referenced strings, and makes the options dialog shorter now that we have the space to do so.
BUG=35085
TEST=Open options dialog, look on second page, Import button should have no text above it.
Review URL: http://codereview.chromium.org/597013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38563 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
even for short hostnames.
BUG=35083
TEST=Visit b/ with image blocking on, click the content blocked icon, bottom link and button shouldn't be smashed together.
Review URL: http://codereview.chromium.org/593030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38561 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=35211
TEST=see bug
Review URL: http://codereview.chromium.org/601014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=29375
TEST=see bug
Review URL: http://codereview.chromium.org/594020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38559 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=mpcomplete
Review URL: http://codereview.chromium.org/595015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38558 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This changes the API slightly. Previously, if someone called update with an empty object ({}) it would set the title to "". This was only documented in the code and not on the API page. Now that we support updating both the url and title it seems more reasonable to ignore a missing title.
BUG=34841
TEST=browser_tests.exe --gtest_filter=ExtensionApiTest.Bookmarks
Review URL: http://codereview.chromium.org/591006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38555 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
from the cache transaction destructor.
BUG=31723
TEST=unittests
Review URL: http://codereview.chromium.org/594018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38554 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
lack of implementation.
BUG=29898
TEST=Run ExtensionBrowserTest.* and PageActionPopupTest.* and make sure they all pass.
Review URL: http://codereview.chromium.org/601011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38553 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(ChromeFrameAutomationClient) is destroyed before launch callback is invoked. Happens when underlying automation proxy is going to be shared to new instance of ChromeFrameAutomationClient and we destroy that instance before receiving LaunchComplete callback.
Still have a race (and possible crash) for automation_server_ in ReleaseAutomationServer and LaunchComplete,
TEST=test added.
Review URL: http://codereview.chromium.org/582018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
shared worker is started.
Added tests for worker close and queued shared worker cases.
BUG=29998
TEST=new UI tests added.
Review URL: http://codereview.chromium.org/580007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
results.
TBR=jorlow
Review URL: http://codereview.chromium.org/599015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38548 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
window's scrollbars, etc.
BUG=none
TEST=none (ran Pepper test plugin, resized and scrolled window)
Review URL: http://codereview.chromium.org/595011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38546 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/572014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38545 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
from pepper. Notably, the existing pepper implementation was, by
default, creating a high-priority producer thread. For the NaCl
version this thread should be in the NaCl module, and hence we
need to separate thread creation from pre-filling with the callback.
The latter is used to send an RPC to NaCl to pass the shared memory
and sync socket. Getting the shared memory was done by the first
reserved state value. Getting the sync socket required allocating
a second. Also changed the pepper test plugin to use the
new startThread member.
Review URL: http://codereview.chromium.org/593023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38544 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=34755,34078
TEST=none
Review URL: http://codereview.chromium.org/600026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Added waitForProgress field to NPDeviceContext3D to select between a flush (that pushes more work to the GPU process and waits for at least some of it to have been completed) and getting the current state as quickly as possible. The previous method of checking to see if the put offset had advanced was incorrect.
TEST=trybots
BUG=none
Review URL: http://codereview.chromium.org/561058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38538 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=34805
TEST=New Tab page should still work if you disable script + images
Review URL: http://codereview.chromium.org/588011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38536 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
rows in bookmark manager.
BUG=32239
TEST=manual
Review URL: http://codereview.chromium.org/587010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38535 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the "show" function to work more like a number of our other dialogs (i.e. delcared in browser_dialogs.h), and adds a TabContentsDelegate function so the content blocked info bubbles can ask the appropriate window to show the dialog.
BUG=35084
TEST=Open the content settings dialog from either the options or a content blocked info bubble. Click its parent window. The dialog should stay on top of the parent.
Review URL: http://codereview.chromium.org/597009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38534 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=23066
TEST=notify_demo.html
Review URL: http://codereview.chromium.org/548208
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38533 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/548221
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38530 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Updated libjingle README and diff.
BUG=none
TEST=compiled
Review URL: http://codereview.chromium.org/597010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38529 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
version.
Review URL: http://codereview.chromium.org/600024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38528 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change involves two significant bits:
1- Add URLRequest::Delegate methods to report a blocked attempt to set a cookie
or get cookies, respectively.
2- Generalize the mechanisms we use to proxy notifications to the RenderViewHost
from the IO thread. See render_view_host_notification_task.h.
Finally, these are used together in ResourceDispatcherHost.
Note: Additional work is required to notify when JS attempts to set a cookie
fail.
R=brettw,eroman
BUG=34573
TEST=Configure the browser to block cookies, and then visit a site that tries to
set a cookie (e.g., cnn.com). You should see a cookie icon appear in the location
bar. If you click that it should report that cookies were blocked.
Review URL: http://codereview.chromium.org/600009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38527 0039d316-1c4b-4281-b951-d872f2087c98
|