| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
This is some cleanup of cl 14998.
R=wtc
BUG=9258
TEST=none
Review URL: http://codereview.chromium.org/115157
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15812 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=11651
TEST=Build Google Chrome branded Release configuration of chrome.exe and it should not throw deps check fail error.
Review URL: http://codereview.chromium.org/113234
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15810 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(No code change.)
git ls-tree -r HEAD | grep '^100755' | cut -f2 |
egrep '\.(png|txt|mm|cc|h|checksum|asm|js|html|c|css|xml|grd|json)$' |
xargs chmod a-x
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15809 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
set GYP_MSVS_VERSION).
Review URL: http://codereview.chromium.org/113230
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15808 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113231
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
Review URL: http://codereview.chromium.org/115211
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15806 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=huanr
Review URL: http://codereview.chromium.org/115213
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15805 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
Review URL: http://codereview.chromium.org/115209
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
Review URL: http://codereview.chromium.org/115208
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15802 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
It broke ui_tests.
Review URL: http://codereview.chromium.org/112017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15801 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This makes the findbar look like the rest of the toolbar.
Review URL: http://codereview.chromium.org/113214
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113179
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15798 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=11717
Review URL: http://codereview.chromium.org/113225
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
for a prefix that the SafeBrowsing servers have, but
that the full hashes provided in the response don't
match the URL we're looking up.
Review URL: http://codereview.chromium.org/115201
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15795 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
crashes in layout tests.
TBR=erik.corry@gmail.com
Review URL: http://codereview.chromium.org/115205
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15794 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Adds support for GTK buttons.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/113212
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15793 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
In Windows this doesn't matter, since the interstitial page just renders on top of the original RWHV.
In Linux, the two RWHV widgets are in the same content view vbox, so we need to hide one of them so they both don't render on the screen.
BUG=http://www.crbug.com/8486
Review URL: http://codereview.chromium.org/112014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Canary shows coast is clear; updating to right before aa'a change.
TBR=dglazkov
TEST=0
Review URL: http://codereview.chromium.org/113226
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15791 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TabContents has a facility for storing a bag of stuff across
current-tab changes. Wire up AutocompleteEditViewMac to use that
facility. Unfork some code in Browser::TabSelectedAt() so that the
new code gets used, and straighten up the Mac code along the code path
between there and AutocompleteEditViewMac.
This overall change also exposed a couple bugs/mis-features in the
AutocompleteEditViewMac code.
TEST=Text field maintains contents and selection across tab changes, even when edited.
Review URL: http://codereview.chromium.org/114017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115198
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15789 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115203
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15788 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Explicitly using vs2005 when on the buildbots.
Review URL: http://codereview.chromium.org/113220
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
URLs were typed more.
We should alwys look up whether we have an exact match, regardless of the input type, and use it if we have it. My change to not add the "exact match" entry for UNKNOWN input should have only affected the case where that match doesn't, in fact, exist.
BUG=1844093
Review URL: http://codereview.chromium.org/113223
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15786 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
See also http://codereview.chromium.org/113204 .
TBR=sky
Review URL: http://codereview.chromium.org/113224
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15785 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
search Google" doesn't show correctly in a "New Tab" for RTL locales.
(http://crbug.com/2780)
Previous fix at http://codereview.chromium.org/100360 may have regressed the startup time by about 5ms/6.7% due to multiple call of PosFromChar().
Ts regression chart is at:
http://build.chromium.org/buildbot/perf/xp-release-dual-core/startup/report.html?history=150
I am reverting the CL while working on solutions.
Review URL: http://codereview.chromium.org/113221
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15784 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115147
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15783 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113219
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15782 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=11743
TEST=follow the steps described in the bug
Review URL: http://codereview.chromium.org/113204
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15781 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The tests baselined are for the following reasons:
LayoutTests/editing/inserting/4960120-1.html
LayoutTests/fast/forms/textarea-scrollbar.html
LayoutTests/fast/forms/textarea-scrolled-type.html
LayoutTests/fast/overflow/overflow-focus-ring.html
Margins changed with <http://trac.webkit.org/changeset/43355> requiring rebaseline.
LayoutTests/fast/js/postfix-syntax.html
Test was modified with <http://trac.webkit.org/changeset/43446>.
LayoutTests/fast/layers/self-painting-outline.html
New test with <http://trac.webkit.org/changeset/43458>. Not too sure that this baseline is actually correct, but dglazkov thinks it is a known junction issue so we won't worry too much about it...
LayoutTests/editing/style/apply-through-end-of-document.html
New test added with <http://trac.webkit.org/changeset/43420>.
LayoutTests/fast/css/compare-content-style.html
New test added with <http://trac.webkit.org/changeset/43474>.
LayoutTests/webarchive/test-link-rel-icon.html
New test added with <http://trac.webkit.org/changeset/43501>. We don't support webarchive, but I generated a new baseline for this anyway to keep it from complaining.
Review URL: http://codereview.chromium.org/115196
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/11757
Review URL: http://codereview.chromium.org/115199
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
branding).
- Stop using CPP on the info.plist since we have to run a script anyways.
- Set the bundleid into a build setting for simple info.plist processing to pick up.
- Add a script for the chrome/app target to manually tweak the info.plist:
- collect the version number from the build tree
- collect the svn revision from the build tree
- update the info.plist keys that need the version number based on collected data.
- record the svn revision into the info.plist for trouble shooting.
Review URL: http://codereview.chromium.org/115187
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The style is based on the gtk code (autocomplete_popup_view_gtk.cc), with some local tweaks. I broke this off from the rest of the review so I could experiment with making it nail omnibox-v2, but eventually realized that I don't have enough data for that. This at least makes things look nicer, and I believe it provides all of the function that will be needed (the remainder is precisely defining fonts and colors and possibly minor highlighting variations).
Summary: I want something concrete so that complaints about v2 wrongness can be specific.
Review URL: http://codereview.chromium.org/99312
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115195
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15775 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
dependency of targets that need it (that is, any target with
'rules' or 'actions').
Review URL: http://codereview.chromium.org/115154
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15774 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This version contains a register allocation crash fix and a
JSC compatibility fix which should fix issues with facebook.
BUG=1717
BUG=11675
Review URL: http://codereview.chromium.org/115194
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15772 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115192
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15771 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
committed in issue 114012.
Review URL: http://codereview.chromium.org/115191
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
I probably got bitten by precompiled headers. :-/
Review URL: http://codereview.chromium.org/115193
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15769 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is another step towards porting the TaskManager.
TEST=Launch Chrome, open the task manager. You should see correctly reported and updated resource data.
http://crbug.com/11461
Review URL: http://codereview.chromium.org/115031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=ben
Review URL: http://codereview.chromium.org/113209
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=11616
Review URL: http://codereview.chromium.org/112013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15761 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The patch is contributed by Ibrar Ahmed <ibrar.ahmad@gmail.com>.
Original review: http://codereview.chromium.org/39130
R=wtc
http://crbug.com/4965
TEST=None. Work in progress.
Review URL: http://codereview.chromium.org/115137
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15760 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Fixes a bug we've had for a long time drawing the wrench button. We would
over-tile the center portion, and draw the right images on top of it.
- Move away from x1 .. x2 parameters to more clear width and height.
- Makes the code significantly more straightforward and efficient.
Review URL: http://codereview.chromium.org/115181
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
up in the packaging step.
Review URL: http://codereview.chromium.org/113196
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115182
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
base::DIR_EXE could be a very long path, which causes socket creation to fail because socket paths have a limited length. Let's use a temp directory instead. We should also clean up the temp dir when we're done. Also abort if the socket path is too long.
Reviewed in issue 115107
Review URL: http://codereview.chromium.org/113193
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
function RenderViewTest::SendKeyEvent() that sends a keyboard event to a RenderView object.To emulate not only US keyboards but also non-US keyboards, this change adds a new class "MockKeyboard", which implements a mapping function from a triple <keyboard type, key code, modifiers> to a Unicode character so that engineers can write RenderViewTest cases without taking care of keyboard types.As samples for this new function, I updated my test RenderViewTest.OnHandleKeyboardEvent and added another test RenderViewTest.InsertCharacters.I wish this class help engineers write more RenderViewTest cases.
Review URL: http://codereview.chromium.org/92122
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15748 0039d316-1c4b-4281-b951-d872f2087c98
|