| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
GRIT is not thread safe, we shouldn't be running multiple copies at one time. This is causing the header files to have duplicates when it shouldn't.
I also removed some code in build.py which tried to prevent an identical regenerated header file from being used (so stuff doesn't rebuild unnecessarily). This code isn't necessary for our build since VS/xcode/scons handles the dependency for us (i.e., this isn't a blanket prebuild step).
Review URL: http://codereview.chromium.org/21191
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21212
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=darin
Review URL: http://codereview.chromium.org/20200
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
have any plans for implementing this mode.
Review URL: http://codereview.chromium.org/20206
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'm deferring these four. They weren't working for beta, and it hardly seem
important now:
LayoutTests/http/tests/xmlhttprequest/cache-override.html
LayoutTests/http/tests/xmlhttprequest/methods-lower-case.html
LayoutTests/http/tests/xmlhttprequest/methods-async.html
LayoutTests/http/tests/xmlhttprequest/methods.html
This one no longer crashes, so I'm defering it per the comments:
LayoutTests/fast/forms/input-text-maxlength.html
Another pre-beta bug. Doesn't look urgent now.
LayoutTests/http/tests/navigation/post-goback1.html
This one no longer crashes, so I'm deferring.
LayoutTests/plugins/bindings-test.html
And we don't have applets on the buildbots yet, so defer.
chrome/fast/dom/java-applet-calls.html
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/20212
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9482 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=avi
Review URL: http://codereview.chromium.org/21215
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=amanda
Review URL: http://codereview.chromium.org/21214
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
is not initialized. Simply refusing access to prevent
the crash.
BUG=7330
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
found the automation tests not hanging.
I also took a look at the logs from the hanging buildbots and the reverted change didn't touch on any of the code that appeared to be hanging.
I also put breakpoints on the modified functions while running ui_tests.exe and nothing hit, so it looks like a fluke.
I did get a hang though when running an old build of ui_tests.exe with a new version of chrome.dll.
Is there any chance that there could have been a stale version on the build bots?
Review URL: http://codereview.chromium.org/20214
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When we are looking for a fallback font, we don't want the usual
family name matching to stop us from finding one. The only case where
we should fail to find a fallback is when fontconfig doesn't know
about /any/ fonts on the system.
This patch adds a flag argument to FontMatch which tells it when we're
in fallback mode.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the ViewMsg_New, we pass a NativeViewId to the renderer. When
WebKit wishes to know the metrics of the window, it echos that id back
in a ViewHostMsg_GetScreenInfo. Without this patch, it echos back NULL
and the browser crashes.
This highlights a semi-major TODO for the porting effort at some
point. We need to abstract the NativeViewIds from the NativeViews as
we cannot trust pointer values from the renderers.
The conversion code is in base/gfx/native_widget_types.h and currently
just casts between them (which is correct for Windows, where both
typedefs are HWNDs). One, maybe interresting idea is that we could
generate a random secret key in the browser and HMAC sign the pointer
values.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=amanda
Review URL: http://codereview.chromium.org/20217
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Currently we don't have a HistoryService. This stops the
VisitiedLinkMaster from sucessfully calling Init(). In that case, no
message is ever sent to the renderer with the VisitiedLink shared
memory region and we end up crashing with SIGFPE as we try to hash by
taking a fingerprint mod 0.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Windows doesn't have a DescriptorSet, so don't try to copy it.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Sometimes the IPC Message logging code parses the message multiple
times. When we have a side array of FileDescriptors, this fails
because the array is consumed by the first parse and so the second
parse fails - causing a DCHECK failure.
Although we could write a system to all the side array to be parsed
multiple times, this code is only enabled in debugging mode and the
only advantage would be that we could log the actual descriptor
numbers. It doesn't appear that the performance hit would be
worthwhile.
Thus, we make hitting the end of the descriptor array a non-fatal
error. The returned descriptor will be -1. Since we have the number of
descriptors in the message header, the only case where this could mask
an actual issue would be where the browser and renderer disagree on
the structure of a given message. However, such a mismatch will
probably cause much more grevious errors anyway.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
The kernel sets msghdr.msg_controllen to the length of the received
control data on successful return. Thus, we need to reset this
variable to the length of the buffer before each call.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9471 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Although descriptor passing was working fine in tests, it didn't work
at all in real code. When a Message is taken off the wire, it's copied
before processing. Message has an explicit copy constructor which
wasn't copying the list of FileDescriptors.
This changes makes the Message copy constructor steal the
FileDescriptors from the source Message.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9469 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
accordingly.
TBR=amanda
Review URL: http://codereview.chromium.org/20216
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=amanda
Review URL: http://codereview.chromium.org/21206
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
methods. I also slipped in the critical section code stuff here too.
Review URL: http://codereview.chromium.org/19547
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9466 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Commit a few cleanups from my tree before starting on getting async
resources working.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9465 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
LayoutTests\http\tests\navigation\javascriptlink-frames . I forgot to svn add the text file.
BUG=none
TEST=none
TBR=tc
Review URL: http://codereview.chromium.org/21205
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9464 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
M VERSION
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9463 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=amanda
Review URL: http://codereview.chromium.org/21197
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/24008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tests. LayoutTests/fast/history/subframe-is-visited.html is not
crashing, so I'm defer'ing as the comment suggests.
Defering two Java related layout tests. We didn't do these before
beta, so they hardly seem that important now.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/20203
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
LayoutTests/http/tests/navigation/javascriptlink-frames.html . As far
as I can tell the only thing wrong here is the image because of text
differences. In particular it looks like we previously were using the
wrong font.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/21195
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
RVH is getting deleted some how and the RVHM isn't cleanly up
correctly.
BUG=6316
TEST=none
Review URL: http://codereview.chromium.org/20185
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9455 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9451 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9450 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
also update the WebContents display hack to not crash on startup
Review URL: http://codereview.chromium.org/21204
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9449 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We can't link in any more of these fixed .cc files because of a chain of
dependencies:
- temp_scaffolding_stubs defines the same symbols as these files
- removing the scaffolding pulls in more source
- pulling in that extra source breaks on Mac.
I have resigned myself to checking in this small bit.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
and I lack the patience to diagnose why mac doesn't link in libjpeg.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9447 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9446 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
* implement some stubbed functions
* comment out some unimplemented IPC calls
* hack a webcontents widget into BrowserWindow so that something displays
Review URL: http://codereview.chromium.org/20204
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- history
- autocomplete
- bookmarks
These were all reviewed separately but turned out to be interdependent. :~(
Review URL: http://codereview.chromium.org/21170
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=glen
Review URL: http://codereview.chromium.org/24007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21198
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Split FD tests into a separate file in preparation for additional tests.
Review URL: http://codereview.chromium.org/20202
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9439 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
For example, ./Hammer/chrome --renderer-cmd-prefix="gdb --args"
Review URL: http://codereview.chromium.org/21190
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I forgot to to update the browser_resources.rc path in
unit_tests.vcproj.
TBR=deanm
Review URL: http://codereview.chromium.org/21196
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The computed-style tests needed to have the text output
rebaselined since the expectations have changed upstream.
The text-overflow-ellipsis test looks like it is working
to me (only difference I see is that our font doesn't look
like the Mac font, which is expected).
Review URL: http://codereview.chromium.org/21189
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21179
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=amanda
Review URL: http://codereview.chromium.org/21193
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
refactoring. More cleanup. Change tabstrip layout to match opaque frame.
BUG=5054
Review URL: http://codereview.chromium.org/20161
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21185
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9432 0039d316-1c4b-4281-b951-d872f2087c98
|