summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Publish DEPS for Chromium 42.0.2278.142.0.2278.1chrome-tpm2015-01-162-771/+1449
|
* Incrementing VERSION to 42.0.2278.1chrome-tpm2015-01-161-1/+1
| | | | | Cr-Commit-Position: refs/branch-heads/2278@{#1} Cr-Branched-From: ddaf644b623a16181e580a01d01889fa694907c5-refs/heads/master@{#311861}
* Revert of Swarm media_unittests. (patchset #3 id:40001 of ↵ricow2015-01-166-91/+21
| | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/851013002/) Reason for revert: This seems to be causing us to not trigger new builds Original issue's description: > Swarm media_unittests. > > BUG=448877 > > Committed: https://crrev.com/21d6f8e72b63fb5840951160030980ee63666ba5 > Cr-Commit-Position: refs/heads/master@{#311756} TBR=scherkus@chromium.org,jam@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=448877 Review URL: https://codereview.chromium.org/851123004 Cr-Commit-Position: refs/heads/master@{#311861}
* Revert of Swarm gpu_unittests. (patchset #3 id:60001 of ↵ricow2015-01-166-137/+9
| | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/848173004/) Reason for revert: This seems to be causing builds to not be triggered Original issue's description: > Swarm gpu_unittests. > > BUG=448877 > > Committed: https://crrev.com/ceca415be1b0af7f18dd22e8058c8b88401c46ef > Cr-Commit-Position: refs/heads/master@{#311755} TBR=sievers@chromium.org,jam@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=448877 Review URL: https://codereview.chromium.org/810453007 Cr-Commit-Position: refs/heads/master@{#311860}
* Roll src/third_party/WebKit d84267b:86d46c4 (svn 188519:188520)blink-deps-roller2015-01-161-1/+1
| | | | | | | | | | | Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/d84267b..86d46c4 TBR=yutak@chromium.org,morrita@chromium.org Review URL: https://codereview.chromium.org/850953006 Cr-Commit-Position: refs/heads/master@{#311859}
* Cleanup shell_integration_linux_unittest.cc.thestig2015-01-161-88/+89
| | | | | | | | | | - Correctly check base::WriteFile() return values - Print out better failure messages - Stop trying to be OS agnostic Review URL: https://codereview.chromium.org/856493006 Cr-Commit-Position: refs/heads/master@{#311858}
* [Android] Fix geolocation infobar testsnewt2015-01-163-38/+44
| | | | | | | | | | | | These tests now mock out the system location setting as being enabled, which allows them to succeed even on devices where system location is disabled. BUG=449341 Review URL: https://codereview.chromium.org/855543004 Cr-Commit-Position: refs/heads/master@{#311857}
* Cleanup: Remove unused code from json_schema_compiler.pneubeck2015-01-162-61/+0
| | | | | | Review URL: https://codereview.chromium.org/851943002 Cr-Commit-Position: refs/heads/master@{#311856}
* Change SuspendObserverDelegate::DoOnDeviceChanged to release |devices|.perkj2015-01-161-1/+5
| | | | | | | | The reason is to avoid a potential race before device enumeratio is done in VideoCaptureManager an AudioCaptureManager. Review URL: https://codereview.chromium.org/809313005 Cr-Commit-Position: refs/heads/master@{#311855}
* Automated Commit: Committing new LKGM version 6693.0.0 for chromeos.chromeos-commit-bot2015-01-161-1/+1
| | | | Cr-Commit-Position: refs/heads/master@{#311854}
* [VideoPlayer test] Make the video player tests run in the test app, instead ↵yoshiki2015-01-1612-249/+239
| | | | | | | | | | | | | | of in the app This patch rewrites the test of the video player using the same framework as Files.app test. Previously, the video player tests ran in the video player app world (not in the test app world) so it was very complex. Now, it is same way as the Files.app tests and gets easily understandable. BUG=448742 Review URL: https://codereview.chromium.org/854813002 Cr-Commit-Position: refs/heads/master@{#311853}
* ServiceWorker: Remove unnecessary references to ServiceWorkerVersionnhiroki2015-01-162-36/+26
| | | | | | | | | | | | | | | | ServiceWorkerRegistrationHandle doesn't have to own references to the associated workers because |registration_| owns them. SetVersionAttributes() via OnRegistrafionFailed() might send an invalid version info for the previously cleared attribute, but that's harmless and just clears it again. BUG=n/a TEST=should pass all existing tests Review URL: https://codereview.chromium.org/850273002 Cr-Commit-Position: refs/heads/master@{#311852}
* Update {virtual,override,final} to follow C++11 style in chromeos/dbus.dcheng2015-01-16130-1870/+1658
| | | | | | | | | | | | | | | | The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with a ChromeOS build using a variation of https://codereview.chromium.org/598073004. BUG=417463 R=hashimoto@chromium.org Review URL: https://codereview.chromium.org/817853005 Cr-Commit-Position: refs/heads/master@{#311851}
* Roll src/third_party/WebKit a3d3e0b:d84267b (svn 188517:188519)blink-deps-roller2015-01-161-1/+1
| | | | | | | | | | | Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/a3d3e0b..d84267b TBR=yutak@chromium.org,morrita@chromium.org Review URL: https://codereview.chromium.org/855003002 Cr-Commit-Position: refs/heads/master@{#311850}
* Added code to disable save button if no text is present in name or number fieldankitkumar2015-01-161-20/+6
| | | | | | | | | | | | | Currently if some text is first typed in any of the fields then save button gets enabled. But when all text is deleted from field, save button is not disabled. Added code to enable/disable properly. BUG=446760 Review URL: https://codereview.chromium.org/837613003 Cr-Commit-Position: refs/heads/master@{#311849}
* MacViews: Add IsMacViewsAppListListEnabled() and --enable-mac-views-app-listtapted2015-01-163-14/+39
| | | | | | | | | | | | | | We need to ensure the folder UI doesn't start appearing on the Cocoa app list when toolkit_views flips. Most of these flags were pinned on TOOLKIT_VIEWS, which is now only used (when not defined) to "always" disable the views app list on mac. BUG=365977 Review URL: https://codereview.chromium.org/829913007 Cr-Commit-Position: refs/heads/master@{#311848}
* Roll src/third_party/WebKit e25bba3:a3d3e0b (svn 188514:188517)blink-deps-roller2015-01-161-1/+1
| | | | | | | | | | | Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/e25bba3..a3d3e0b TBR=yutak@chromium.org,morrita@chromium.org Review URL: https://codereview.chromium.org/856703002 Cr-Commit-Position: refs/heads/master@{#311847}
* Introduce printerProviderInternal APItbarzic2015-01-1615-22/+236
| | | | | | | | | | | | | | | | | | | | | | | | | The API will be used to implement callbacks for printerProvider API events. Just before dispatching an printerProvider event to listeners, in custom bindings, the event argument list will be appended a callback that wraps printerProviderInternal function. The function will run the callback associated with the event (which will be cached in the API event router). To identify the callback to be run, the event will be added a requestId argument, which will be passed on to the internal API function. This cl only adds internal API idl and stub implementation (the rest to follow). Also, move printerProvider IDL file from chrome/ to extensions/ and enable printerProvider permission/feature on dev channel. BUG=408772 TEST=None (will be added in subsequent cls) Review URL: https://codereview.chromium.org/812343003 Cr-Commit-Position: refs/heads/master@{#311846}
* Update {virtual,override,final} to follow C++11 style in ↵dcheng2015-01-1611-135/+125
| | | | | | | | | | | | | | | | | | chrome/browser/chromeos/file_manager. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with a ChromeOS build using a variation of https://codereview.chromium.org/598073004. BUG=417463 R=yoshiki@chromium.org Review URL: https://codereview.chromium.org/850343003 Cr-Commit-Position: refs/heads/master@{#311845}
* Revert of Debugging patch to help track down skipped cleanup of ↵kouhei2015-01-1618-75/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ScriptContexts. (patchset #3 id:40001 of https://codereview.chromium.org/853793002/) Reason for revert: Causing dom_perf to crash in perf bots. BUG=449415 Original issue's description: > Debugging patch to help track down skipped cleanup of ScriptContexts. > > The current theory is that cleanup for some ScriptContexts is getting > skipped, due to willReleaseScriptContext() notifications not being sent. > Alias a few things into the debug crash dump to try to narrow down what > could be causing this. > > BUG=441968 > > Committed: https://crrev.com/b97e8b25a46aeeecd26cba5ebba9a8b5ecf4a4e7 > Cr-Commit-Position: refs/heads/master@{#311802} TBR=kalman@chromium.org,dcheng@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=441968 Review URL: https://codereview.chromium.org/858493002 Cr-Commit-Position: refs/heads/master@{#311844}
* Allow reuse of test partner customizations provider.newt2015-01-162-20/+21
| | | | | | | | | | | | This allows TestPartnerBrowserCustomizationsProvider and its subclasses to be included in multiple test APKs using different authorities and still work properly. BUG=444675 Review URL: https://codereview.chromium.org/847843004 Cr-Commit-Position: refs/heads/master@{#311843}
* Re-enable AppCache.mgiuca2015-01-161-0/+1
| | | | | | | | | | This feature was inadvertently disabled in r310975. BUG=449016 Review URL: https://codereview.chromium.org/853713004 Cr-Commit-Position: refs/heads/master@{#311842}
* Files.app: Fix typo in fileOperationUtilkenobi2015-01-161-1/+1
| | | | | | | | BUG=None Review URL: https://codereview.chromium.org/837703004 Cr-Commit-Position: refs/heads/master@{#311841}
* Mark some members const.eroman2015-01-162-5/+5
| | | | | | | | | | For consistenty with other AlgorithmImplementations. const-ness is a useful reminder that these classes should not mutate state. Review URL: https://codereview.chromium.org/750233002 Cr-Commit-Position: refs/heads/master@{#311840}
* Abort streams when the containing RenderFrameHost navigates or closes.sammc2015-01-1617-125/+466
| | | | | | | | | | | | | | | Previously, streams used by MimeHandlerViewGuest can be leaked if the guest is closed before it finishes reading from the stream, blocking further access to that resource. This CL adds tracking of RenderFrameHosts containing MimeHandlerViewGuests and aborts the corresponding streams when the containing RenderFrameHost navigates or closes. BUG=436345 Review URL: https://codereview.chromium.org/834113003 Cr-Commit-Position: refs/heads/master@{#311839}
* Fix spelling and remove bogus formatting from README.chromiumnoel2015-01-161-2/+2
| | | | | | | | | | TBR=darin@chomium.org NOTRY=true BUG=401971 Review URL: https://codereview.chromium.org/854623003 Cr-Commit-Position: refs/heads/master@{#311838}
* Roll src/third_party/skia f77156e:0598236skia-deps-roller2015-01-161-1/+1
| | | | | | | | | | | | Summary of changes available at: https://chromium.googlesource.com/skia/+log/f77156e..0598236 CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg TBR=djsollen@google.com Review URL: https://codereview.chromium.org/850413004 Cr-Commit-Position: refs/heads/master@{#311837}
* Roll .../hunspell_dictionaries 06517db:94eb94c (svn 292711:292714)hichris1232015-01-162-1/+7
| | | | | | | | | | | Summary of changes available at: https://chromium.googlesource.com/chromium/deps/hunspell_dictionaries/+log/4560bdd..94eb94c BUG=331684, 239579, 338973, 287853, 153249, 170748, 412813, 251657, 304272, 334550 Review URL: https://codereview.chromium.org/684993004 Cr-Commit-Position: refs/heads/master@{#311836}
* Roll src/third_party/WebKit 17c89a8:e25bba3 (svn 188507:188514)blink-deps-roller2015-01-161-1/+1
| | | | | | | | | | | Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/17c89a8..e25bba3 TBR=yutak@chromium.org,morrita@chromium.org Review URL: https://codereview.chromium.org/829013003 Cr-Commit-Position: refs/heads/master@{#311835}
* Importing certain bookmarks from firefox and HTML file as search engines.ghose.tapu2015-01-1626-112/+267
| | | | | | | | BUG=52344 Review URL: https://codereview.chromium.org/616763002 Cr-Commit-Position: refs/heads/master@{#311834}
* Mac: Fix and enable tests OmniBoxViewTests: UndoRedo and ↵tapted2015-01-162-14/+37
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | BackspaceDeleteHalfWidthKatakana The tests were compiled only when TOOKLIT_VIEWS is defined. On a regular Mac build, the code compiled but the tests failed. To fix: First, UndoRedo needs to send Cmd rather than Ctrl - use kCtrlOrCmdMask for this. Then, Cmd+Shift+Z (i.e. Redo) was being ignored on Mac. The root cause is that ui_controls_mac's SynthesizeKeyEvent() was not including shift modifiers on the charactersIgnoringModifiers argument which, confusingly, *should* include shift modifiers (but not others). See code comments for details. The root cause is a mismatch with the behaviour of MacKeyCodeForWindowsKeyCode()'s charactersIgnoringModifiers argument which is fixed in http://crrev.com/812263005 In BackspaceDeleteHalfWidthKatakana, there is a mismatch in text-editing behaviour between Cocoa and Views for a character followed by a "voiced sound mark" character. Cocoa deletes the character along with the sound mark whereas views just deletes the sound mark. Note this fixes the test on regular builds as well toolkit_views builds on Mac. BUG=192743, 402679 Review URL: https://codereview.chromium.org/847633003 Cr-Commit-Position: refs/heads/master@{#311833}
* Hook UBSAN, MSAN to exit handler(s) to give time for coverage data to be ↵inferno2015-01-162-3/+6
| | | | | | | | | | | | generated. For context, see https://code.google.com/p/chromium/issues/detail?id=430160 BUG=444896 Review URL: https://codereview.chromium.org/837633008 Cr-Commit-Position: refs/heads/master@{#311832}
* Remove unused fields from PP_PdfPrintPresetOptions_Devraymes2015-01-164-46/+2
| | | | | | | | | | | | | Work was started which would use these fields to convey information to the printing system but this work was never finished (see https://code.google.com/p/chromium/issues/detail?id=169120). This fields are never initialized. BUG=448798 Review URL: https://codereview.chromium.org/828233004 Cr-Commit-Position: refs/heads/master@{#311831}
* Enable Surfaces on Android.jbauman2015-01-161-1/+1
| | | | | | | | | | All the contents (browser and renderer) are put into a single Surface. BUG=449319 Review URL: https://codereview.chromium.org/847423002 Cr-Commit-Position: refs/heads/master@{#311830}
* Roll Web Page Replay to pick-up HTTPS certificate fixes.slamm2015-01-161-1/+1
| | | | | | | | | | | | | | | | | | | Includes fixes for: Generated certificates use different common name than original. https://github.com/chromium/web-page-replay/issues/37 Replay uses wrong root CA during replay. https://github.com/chromium/web-page-replay/issues/38 Android: Error installing cert from Mac host https://code.google.com/p/chromium/issues/detail?id=431686 BUG=431686 Review URL: https://codereview.chromium.org/855603002 Cr-Commit-Position: refs/heads/master@{#311829}
* Roll src/third_party/skia a2ef642:f77156eskia-deps-roller2015-01-161-1/+1
| | | | | | | | | | | | Summary of changes available at: https://chromium.googlesource.com/skia/+log/a2ef642..f77156e CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg TBR=djsollen@google.com Review URL: https://codereview.chromium.org/816543008 Cr-Commit-Position: refs/heads/master@{#311828}
* Update V8 to version 4.2.8 (based on d3cd92a2f844352b4192c67ae51af1b651991701).v8-autoroll2015-01-161-1/+1
| | | | | | | | TBR=machenbach@chromium.org Review URL: https://codereview.chromium.org/851223002 Cr-Commit-Position: refs/heads/master@{#311827}
* Update {virtual,override,final} to follow C++11 style in device.dcheng2015-01-1618-347/+297
| | | | | | | | | | | | | | | | The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with a ChromeOS build using a variation of https://codereview.chromium.org/598073004. BUG=417463 R=reillyg@chromium.org Review URL: https://codereview.chromium.org/799933008 Cr-Commit-Position: refs/heads/master@{#311826}
* LocalServerController currently has a dependency on browser_backend. Weariblue2015-01-1612-48/+69
| | | | | | | | | | | | | want to instead depend on platform_backend. To remedy this, we move the forwarder_factory property and GetRemotePort() function from browser_backends to the corresponding platform_backends. BUG=423962 Review URL: https://codereview.chromium.org/814123004 Cr-Commit-Position: refs/heads/master@{#311825}
* Fix DXVA decoder flush.ananta2015-01-161-13/+9
| | | | | | | | | | | | | | | | | | | | | | | The DXVA decoder only supports 1 output frame at any given time. This alleviates the need for attempting to retrieve as many output frames as possible during the Flush operation. Currently we loop in the Flush function waiting for the state to change to kStopped which means that the decoder does not have any more output frames. We don't need the loop. A call to the decode function followed by a check for whether we have an output frame is good enough. If we don't have an output frame then the Flush is complete. The other change is to use the pending_flush_ flag instead of the state in the ReusePictureBuffer and CopySurfaceComplete functions to post the FlushInternal task. This is because the state may have changed to kStopped due to the DoDecode call in the FlushInternal function. We need this change to ensure that the flush completes and we notify the renderer of the same. It is safe to use the pending_flush_ flag from these functions as these functions execute on the main thread and the pending_flush_ flag is referenced and set only on the main thread. BUG=365434 R=dalecurtis TEST=Tested the case in the bug and online H.264 videos like quirksmode to verify that Flush does complete correctly. Review URL: https://codereview.chromium.org/845793006 Cr-Commit-Position: refs/heads/master@{#311824}
* WebAuthFlow should use owner WebContents instead embedder WebContentsfsamuel2015-01-161-2/+2
| | | | | | | | | | | In order to support "display:none"'ed <webview>s, WebAuthFlow should use owner_web_contents() instead of embedder_web_contents BUG=434226 Review URL: https://codereview.chromium.org/858433003 Cr-Commit-Position: refs/heads/master@{#311823}
* ServiceWorker: Consolidate version manipulation functions in SWProviderContextnhiroki2015-01-164-140/+73
| | | | | | | | | | | | | | | | | | | | | | | | This is a preparation patch for exposing SWRegistration object into SWGlobalScope. According to the design doc[1], we're going to make SWProviderContext thread-safe using the lock mechanism so that the worker thread can also use the context. But, in the current implementation, functions to manipulate versions (eg. OnSetInstallingServiceWorker()) are fine-grained and they can be interleaved from multiple threads if we naively use the lock on a per function basis. To avoid the situation, this CL consolidates those functions as SetVersionAttributes() and makes it easier to protect by lock. [1] https://docs.google.com/document/d/1qDGbMlwKOXxCRBlw9IirK8Qmna3JqvnO3Aogkfu9UJQ/edit?usp=sharing BUG=437677 TEST=run-webkit-tests http/tests/serviceworker/ Review URL: https://codereview.chromium.org/849203002 Cr-Commit-Position: refs/heads/master@{#311822}
* Remove USE_ATHENA ifdef from chrome/browser/uipkotwicz2015-01-1622-195/+20
| | | | | | | | | BUG=449007 TEST=None Review URL: https://codereview.chromium.org/816223005 Cr-Commit-Position: refs/heads/master@{#311821}
* Update {virtual,override,final} to follow C++11 style ↵dcheng2015-01-1660-514/+476
| | | | | | | | | | | | | | | | | | chrome/browser/chromeos/file_system_provider. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with a ChromeOS build using a variation of https://codereview.chromium.org/598073004. BUG=417463 R=mtomasz@chromium.org Review URL: https://codereview.chromium.org/816353009 Cr-Commit-Position: refs/heads/master@{#311820}
* Roll ffmpeg to e74760aa626e18175dea1b089c7ed719263adb8bjamesr2015-01-161-1/+1
| | | | | | | | BUG=371125 Review URL: https://codereview.chromium.org/830043003 Cr-Commit-Position: refs/heads/master@{#311819}
* [Extensions] Check incognito windows for last active in browserAction.openPopuprdevlin.cronin2015-01-165-2/+66
| | | | | | | | | | | | The current implementation of browserAction.openPopup won't check incognito windows for the last active window, making it not work with incognito windows. Fix this. BUG=448853 Review URL: https://codereview.chromium.org/854893002 Cr-Commit-Position: refs/heads/master@{#311818}
* Roll src/third_party/WebKit 0db94e2:17c89a8 (svn 188496:188507)blink-deps-roller2015-01-161-1/+1
| | | | | | | | | | | Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/0db94e2..17c89a8 TBR=yutak@chromium.org,morrita@chromium.org Review URL: https://codereview.chromium.org/855613002 Cr-Commit-Position: refs/heads/master@{#311817}
* Refactor of page scale limit initialization. Part 2/5bokan2015-01-166-3/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch cleans up how default page scale limits are initialized. This patch is part 2/5; it adds uses of the new API stubs on the Chromium side but keeps the old API until the Blink implementation lands. The combined changes can be seen in https://codereview.chromium.org/843623002/ and https://codereview.chromium.org/827423006 Page scale limits in Blink are defined inside the PageScaleConstraintsSet class. This class has three PageScaleConstraints objects: defaultConstraints pageDefinedConstraints userAgentConstraints Each overriding the constraint above it. Prior to this patch, the default constraints were statically set so the minimum scale was 0.25 and maximum was 5.0, Android's desired limits. To prevent desktop browsers from scaling below 1, RenderViewImpl would set the userAgentConstraints to [1,4]. This is fragmented and problematic if we ever want to allow pages to set constraints on desktop browsers. This patch does a number of things: 1) Make the default constraints mutable so they can be made different for different platforms. Expose a method in WebView to allow the content layer to modify it. Move the platform-specific default values into WebPreferences in the content layer and out of Blink. Hook up initialization to set the defaults when initializing Blink. Both desktop and Android now set the desired limits to the defaultConstraints. For desktop, this is equivalent to the existing behavior since the viewport meta tag is disabled, pageDefinedConstraints will never be set. 2) Rename setPageScaleFactorLimits to setPageScaleFactorLimitsOverride. This method is ambiguous. Since it sets the userAgentConstraints, adding "override" makes it clear that these will supersede other constraints. It's also consistent with setInitialPageScaleOverride which sets the initial scale on userAgentConstraints. Also removed some related methods from the WebView interface that are no longer needed. 3) Since a minimum scale is now always available, remove the condition in PageScaleConstraintsSet::mainFrameSize that sets the frame size to the content width. 4) Use -1 as the default initial scale on all platforms. Previously, this was used on Android so that the absence of initial scale would use min-scale and pages would load fully zoomed out. Since the min-scale on desktop is 1, we can use -1 as the initial scale as well. TBR=avi@chromium.org,aelias@chromium.org,kenrb@chromium.org BUG=413285, 437034 Review URL: https://codereview.chromium.org/848423002 Cr-Commit-Position: refs/heads/master@{#311816}
* Mac: Refactor ui::MacKeyCodeForWindowsKeyCode to correct ↵tapted2015-01-166-61/+52
| | | | | | | | | | | | | | | | | | | | | | | | | | charactersIgnoringModifiers In an interactive_ui_test `Cmd+Shift+Z` was being synthesized incorrectly. Comparing with "real" events, Cmd+Shift+Z actually puts lowercase in `characters` and uppercase in `charactersIgnoringModifiers`, which is the reverse of what ui::MacKeyCodeForWindowsKeyCode() was doing. The fix: ui::MacKeyCodeForWindowsKeyCode() is refactored to better describe what it is doing, and all callers audited. Actually, *only* ui_control_mac's SynthesizeKeyEvent() was using the |charactersIgnoringModifiers| argument. Other callers either didn't populate it, or put |characters| into both |characters| and |charactersIgnoringModifiers|, avoiding the bug. BUG=402679 TBR=thakis@chromium.org reviewed in http://crrev.com/847633003/#ps140001 Review URL: https://codereview.chromium.org/812263005 Cr-Commit-Position: refs/heads/master@{#311815}
* Update Clear Key to support CDM_7jrummell2015-01-163-91/+158
| | | | | | | | | BUG=428384 TEST=layout tests for ECK pass Review URL: https://codereview.chromium.org/844613004 Cr-Commit-Position: refs/heads/master@{#311814}
generated by cgit v1.1 at 2024-06-09 11:12:59 +0000