| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
| |
Cr-Commit-Position: refs/branch-heads/2323@{#3}
Cr-Branched-From: f5ac85a3a52b67adfac27fe0ec07d1cf2cff4a84-refs/heads/master@{#319213}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We were discarding "Proxy-Authenticate: keep-alive" headers in HTTP/1.0 responses, which broke multi-step connection-level authentication methods for proxies that sent HTTP/1.0 responses.
BUG=463937
Review URL: https://codereview.chromium.org/982733002
Cr-Commit-Position: refs/heads/master@{#319219}
(cherry picked from commit 34f63b55b51e8fc46ad86334783a665d5f487738)
Review URL: https://codereview.chromium.org/978093005
Cr-Commit-Position: refs/branch-heads/2323@{#2}
Cr-Branched-From: f5ac85a3a52b67adfac27fe0ec07d1cf2cff4a84-refs/heads/master@{#319213}
|
|
|
|
|
| |
Cr-Commit-Position: refs/branch-heads/2323@{#1}
Cr-Branched-From: f5ac85a3a52b67adfac27fe0ec07d1cf2cff4a84-refs/heads/master@{#319213}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, when the local computer is shared under a different account, we
will show the host with an empty name.
In this CL, we will show a message saying, 'This computer is currently is shared
under a different account' and allows the user to disable the remote connection.
We also hide the pairing management or change PIN entry points when this happened.
BUG=456291
Review URL: https://codereview.chromium.org/978863002
Cr-Commit-Position: refs/heads/master@{#319213}
|
|
|
|
|
|
|
|
| |
BUG=464046
Review URL: https://codereview.chromium.org/983453002
Cr-Commit-Position: refs/heads/master@{#319212}
|
|
|
|
|
|
|
|
|
|
|
| |
To reduce the amount of data written out to the disk during shutdown to avoid slowing it down.
In practice, this results in about 30% size reduction of Preferences file.
BUG=463366
Review URL: https://codereview.chromium.org/974753002
Cr-Commit-Position: refs/heads/master@{#319211}
|
|
|
|
|
|
|
|
|
|
|
| |
Removing gpu_perftests from "Linux Perf (1)" since the display set when running these tests doesn't have direct rendering on.
TBR=phajdan.jr@chromium.org
BUG=
Review URL: https://codereview.chromium.org/977943006
Cr-Commit-Position: refs/heads/master@{#319210}
|
|
|
|
|
|
|
|
|
|
|
| |
This CL removes duplicate logic from the AppListMainView as a follow up
to https://codereview.chromium.org/958133005/.
BUG=462444
Review URL: https://codereview.chromium.org/968733002
Cr-Commit-Position: refs/heads/master@{#319209}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
side changes.
In this CL, we add appcontainer related attributes in PreSpawnTarget for renderer. Though we modify policy here, it is still not being honored, that will happen in next CL.
BUG=455496
R=cpu, jschuh, rvargas
Review URL: https://codereview.chromium.org/949943003
Cr-Commit-Position: refs/heads/master@{#319208}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/906493004/).
The failed tests were caused by missing the initialization of consumer_instance_type_ in UserScript.
BUG=463906
TBR=rdevlin
Review URL: https://codereview.chromium.org/976173002
Cr-Commit-Position: refs/heads/master@{#319207}
|
|
|
|
|
|
|
|
| |
BUG=463794
Review URL: https://codereview.chromium.org/976173003
Cr-Commit-Position: refs/heads/master@{#319206}
|
|
|
|
|
|
|
|
|
|
|
|
| |
CopyFileFromLocal is a method to copy a local file to the device. This method will be used in CopyInForeingFile of AsyncFileUtil.
A CL to connect CopyFileFromLocal to CopyInForeingFile will come later when all other write operations (e.g. delete) are implemented.
BUG=413541
TEST=none; manually tested with changing write_supported variable in volume_manager.cc to true.
Review URL: https://codereview.chromium.org/947943002
Cr-Commit-Position: refs/heads/master@{#319205}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Stats are saved to disk every five minutes. If a client is initializing
the cache, and it crashes before saving the stats for the first time,
the next run will see an empty stats storage, and will discard the cache
because it may indicate that the storage address was invalid.
Now, we check the contents to see if the storage was empty and re-initialize
things as needed.
BUG=none
TEST=net_unittests
Review URL: https://codereview.chromium.org/980003002
Cr-Commit-Position: refs/heads/master@{#319204}
|
|
|
|
|
|
|
|
|
|
|
|
| |
AppListControllerSearchResultsBrowserTest.UninstallSearchResult is now
run on the experimental app list, rather than being forced to run on the
classic app list, as crbug.com/438119 is now fixed.
BUG=438119
Review URL: https://codereview.chromium.org/972093002
Cr-Commit-Position: refs/heads/master@{#319203}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On Windows, message pump can re-enter. AsyncHandleWaiter should
be prepared for that.
R=viettrungluu@chromium.org
BUG=none
TEST=ExtensionApiTest.SharedModuleWhitelist (this hits the DCHECK)
Review URL: https://codereview.chromium.org/973213002
Cr-Commit-Position: refs/heads/master@{#319202}
|
|
|
|
|
|
|
|
|
|
|
|
| |
If a connection attempt is triggered while a connection is open, but not
active (for example due to a socket error), make sure the old connection
is closed before reattempting to connect.
BUG=462319
Review URL: https://codereview.chromium.org/980433003
Cr-Commit-Position: refs/heads/master@{#319201}
|
|
|
|
|
|
|
|
|
|
|
| |
record time in seconds, to align with server-side field names and units.
BUG=461610
Tested by running run_webapp_unittest.py with these changes; all tests passed.
Review URL: https://codereview.chromium.org/961053004
Cr-Commit-Position: refs/heads/master@{#319200}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This should've been covered by commit bot.
The bot configuration chagne will come with a separate CL.
R=viettrungluu@chromium.org, agl@chromium.org
TEST=ipc_channel_mojo_unittest.cc
BUG=
Review URL: https://codereview.chromium.org/976043003
Cr-Commit-Position: refs/heads/master@{#319199}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/972473005
Cr-Commit-Position: refs/heads/master@{#319198}
|
|
|
|
|
|
|
|
|
|
|
|
| |
These used to be necessary for enums, but those were moved to
public/platform/WebIDBTypes.h aeons ago. It looks like
content/browser/DEPS was updated but content/common/DEPS was missed.
R=jam@chromium.org
Review URL: https://codereview.chromium.org/966463004
Cr-Commit-Position: refs/heads/master@{#319197}
|
|
|
|
|
|
|
|
|
| |
R=jam@chromium.org
BUG=None
Review URL: https://codereview.chromium.org/977193003
Cr-Commit-Position: refs/heads/master@{#319196}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
client_screen.js currently defines a few global functions and a few 'private'
functions that are called in application.js and desktop_connected_view.js
This CL
1. Moves onClientStateChange_, updateStatistics_ into application.js as
they are called from there and their implementation depends on application.js.
2. Moves declaration of globals clientSession and desktopConnectedView
into application.js
3. Moves remoting.disconnect into remoting.Application.
4. Moves onResize and onVisibilityChanged into desktop_connected_view.js
5. Removes client_screen.js
BUG=461995
Review URL: https://codereview.chromium.org/952353002
Cr-Commit-Position: refs/heads/master@{#319195}
|
|
|
|
|
|
|
|
|
|
|
| |
Problem discovered during PPAPI out of process tests, where it launches multiple processes with different delegates.
BUG=455496
R=rvargas,cpu,jschuh
Review URL: https://codereview.chromium.org/977193002
Cr-Commit-Position: refs/heads/master@{#319194}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, inspector_backend would always throw a
DevtoolsTargetCrashException. Now, it throws either a
DevtoolsTargetCrashException or a TimeoutException. The CL also adds the
debugger_url to the exception as further debugging information.
There were exactly 2 files that tried to catch a DevtoolsTargetCrashException.
I changed fast_navigation_profile_extender to catch Error instead. I will be
improving this class in the future to have better exception handling.
chrome_proxy_measurements caught a DevtoolsTargetCrashException, but its
behavior is better suited by catching a TimeoutException.
BUG=460625
Review URL: https://codereview.chromium.org/959423003
Cr-Commit-Position: refs/heads/master@{#319193}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/82b33db..c877a71
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=joshualitt@google.com
Review URL: https://codereview.chromium.org/977243003
Cr-Commit-Position: refs/heads/master@{#319192}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
id:60001 of https://codereview.chromium.org/927183002/)
Reason for revert:
Causing crashes on Linux. Investigating.
Bug 464180.
Original issue's description:
> Adding StringPiece/StringPiece16 read/write support to pickle, and
> update unit tests.
>
> The IPC perf tests do a lot of allocations which can, with large block
> sizes, harm their performance. The high allocation counts also make
> their performance very dependent on the quirks of the Windows heap, as
> it applies undocumented heuristics to decide when to decommit memory
> and when to save it for later.
>
> And, doing unnecessary allocations is generally always a bad thing.
>
> So, this change adds StringPiece support to PickleIterator (reading)
> and Pickle (writing). The StringPiece function now handles all strings
> when writing, but must be requested explicitly when reading.
>
> ipc_mojo_perftests does more allocations than ipc_perftests. This
> removes one message-sized allocation from both tests.
>
> The unit tests were updated so that WriteString and WriteString16 are
> exercised with both string objects and char/char16 arrays (no
> allocations required!). Reading into StringPiece and StringPiece16 is
> also tested and the tests were verified with:
> out\Release\base_unittests --gtest_filter=PickleTest.*
>
> The main performance test command line used was:
>
> out\Release\ipc_mojo_perftests --gtest_filter=MojoChannelPerfTest.ChannelPingPong
>
> Typical test results on HP Z620 (Windows 8.1) with thread affinity and
> high-performance power settings prior to this change:
> IPC_Channel_Perf_50000x_12 1140.01 ms
> IPC_Channel_Perf_50000x_144 1182.55 ms
> IPC_Channel_Perf_50000x_1728 1266.42 ms
> IPC_Channel_Perf_12000x_20736 1289.19 ms
> IPC_Channel_Perf_1000x_248832 584.619 ms
>
> Typical test results with same settings but using base::StringPiece:
> IPC_Channel_Perf_50000x_12 1123.33 ms
> IPC_Channel_Perf_50000x_144 1164.53 ms
> IPC_Channel_Perf_50000x_1728 1242.99 ms
> IPC_Channel_Perf_12000x_20736 1186.84 ms
> IPC_Channel_Perf_1000x_248832 496.469 ms
>
> Modest improvement with small buffers, but significant speedup with large buffers.
>
> Typical test results with large-blocks only prior to this change:
> IPC_Channel_Perf_1000x_248832 1211.33 ms
> IPC_Channel_Perf_1000x_248832 961.404 ms
> IPC_Channel_Perf_1000x_248832 600.911 ms
> IPC_Channel_Perf_1000x_248832 468.356 ms
> IPC_Channel_Perf_1000x_248832 430.859 ms
> IPC_Channel_Perf_1000x_248832 425.147 ms
>
> Typical test results with large-blocks only (base::StringPiece):
> IPC_Channel_Perf_1000x_248832 909.571 ms
> IPC_Channel_Perf_1000x_248832 731.435 ms
> IPC_Channel_Perf_1000x_248832 493.697 ms
> IPC_Channel_Perf_1000x_248832 417.966 ms
> IPC_Channel_Perf_1000x_248832 397.377 ms
> IPC_Channel_Perf_1000x_248832 397.725 ms
>
> Note that it takes a while for the Windows heap to 'realize' that it
> should hang on to some of the large blocks which is why performance
> increases over multiple runs.
>
> Chrome will not immediately be affected because StringPiece reading has
> to be explicitly selected. Note that the effect on ipc_perftests is
> more variable due to the odd Windows heap heuristics.
>
> Reliable results require setting the power plan to high-performance.
> On Linux this is done with this command:
> sudo cpupower frequency-set --governor performance
>
> The ipc_perftests command-line is:
> out/Release/ipc_perftests --gtest_filter=IPCChannelPerfTest.ChannelPingPong
>
> Typical before/after Linux results for ipc_perftests are:
> IPC_Channel_Perf_50000x_12 465.271 ms
> IPC_Channel_Perf_50000x_144 480.224 ms
> IPC_Channel_Perf_50000x_1728 510.871 ms
> IPC_Channel_Perf_12000x_20736 318.016 ms
> IPC_Channel_Perf_1000x_248832 309.325 ms
>
> IPC_Channel_Perf_50000x_12 459.245 ms
> IPC_Channel_Perf_50000x_144 479.347 ms
> IPC_Channel_Perf_50000x_1728 506.57 ms
> IPC_Channel_Perf_12000x_20736 289.583 ms
> IPC_Channel_Perf_1000x_248832 255.083 ms
>
> Before after Linux results for ipc_mojo_perftests:
> IPC_Channel_Perf_50000x_12 670.727 ms
> IPC_Channel_Perf_50000x_144 713.6 ms
> IPC_Channel_Perf_50000x_1728 808.157 ms
> IPC_Channel_Perf_12000x_20736 464.221 ms
> IPC_Channel_Perf_1000x_248832 365.258 ms
>
> IPC_Channel_Perf_50000x_12 653.12 ms
> IPC_Channel_Perf_50000x_144 697.418 ms
> IPC_Channel_Perf_50000x_1728 772.575 ms
> IPC_Channel_Perf_12000x_20736 446.315 ms
> IPC_Channel_Perf_1000x_248832 348.38 ms
>
> So, consistent improvements on Linux.
>
> Committed: https://crrev.com/fcfde7d98209569fba81de4f1b26d0e26cd95848
> Cr-Commit-Position: refs/heads/master@{#319128}
TBR=thestig@chromium.org,cpu@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/981853002
Cr-Commit-Position: refs/heads/master@{#319191}
|
|
|
|
|
|
|
|
|
|
| |
Add the usual implicit-animation supression system.
BUG=463988
Review URL: https://codereview.chromium.org/983523002
Cr-Commit-Position: refs/heads/master@{#319190}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The WebContentsObserver.didNavigateMainFrame overload without an
http status code is deprecated. Stop using it, also fixing an issue
where the wrong overload was called by WebContentsObserverProxy.
BUG=440134
TBR=dtrainor@chromium.org
Review URL: https://codereview.chromium.org/962103003
Cr-Commit-Position: refs/heads/master@{#319189}
|
|
|
|
|
|
|
|
| |
BUG=454983
Review URL: https://codereview.chromium.org/982473002
Cr-Commit-Position: refs/heads/master@{#319188}
|
|
|
|
|
|
|
|
|
| |
R=orenb@chromium.org
BUG=
Review URL: https://codereview.chromium.org/976713007
Cr-Commit-Position: refs/heads/master@{#319187}
|
|
|
|
|
|
|
|
|
|
|
| |
There's no reason for VoiceSearchTabHelper to exist as a Java entity. It
simply routes a WebContentsObserver callback originating in native
code back to some more native code for processing, and has no Java
dependencies.
Review URL: https://codereview.chromium.org/979813004
Cr-Commit-Position: refs/heads/master@{#319186}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/977663004/)
Reason for revert:
Breaks linux valgrind,
needs libvpx side fixes and roll, http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28valgrind%29%283%29/builds/44420
Original issue's description:
> Use tiles when encoding with VP9.
>
> VP9's tile encoding feature allows for multithreaded parallelism on both the
> encoder and decoder side.
>
> TEST=Run remoting_perftests under VTune and see that two logical CPUs are used
> BUG=134202
>
> Committed: https://crrev.com/e67fefbf4f5a5a83ca8d487f422b09664dc4c8fe
> Cr-Commit-Position: refs/heads/master@{#319167}
TBR=wez@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=134202
Review URL: https://codereview.chromium.org/978133002
Cr-Commit-Position: refs/heads/master@{#319185}
|
|
|
|
|
|
|
|
| |
BUG=455047
Review URL: https://codereview.chromium.org/970023003
Cr-Commit-Position: refs/heads/master@{#319184}
|
|
|
|
|
|
|
|
|
|
| |
ProGuard outputs boring stuff to stdout (proguard version, jar path,
etc) as well as interesting stuff (notes, warnings, etc). If stdout is
entirely boring, this method suppresses the output.
Review URL: https://codereview.chromium.org/977253002
Cr-Commit-Position: refs/heads/master@{#319183}
|
|
|
|
|
|
|
|
|
| |
TBR=nyquist@chromium.org
BUG=411461
Review URL: https://codereview.chromium.org/973403002
Cr-Commit-Position: refs/heads/master@{#319182}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
factors above 1
We were not scaling the mouse coordinate by the scale factor before invoking the ClientToScreen API. With this
change the blink::WebMouseEvent.globalX and globalY values have to be converted back to DIP after convering them to screen.
This should fix the mouse locking issue.
BUG=411634
TEST= The main test case in bug 411634
Review URL: https://codereview.chromium.org/973123003
Cr-Commit-Position: refs/heads/master@{#319181}
|
|
|
|
|
|
|
|
|
| |
BUG=442982
TEST=media_unittests pass
Review URL: https://codereview.chromium.org/975983002
Cr-Commit-Position: refs/heads/master@{#319180}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This pulls in the following Native Client changes:
fd6546b: (dschuff@chromium.org) Update revision for PNaCl and x86 newlib nacl-gcc
edcd955: (mcgrathr@chromium.org) Add test for code_data_allocate after mmap PROT_EXEC,MAP_FIXED
1c07f10: (dschuff@chromium.org) Use the LLVM integrated assembler for x86-64 nacl-clang target lib builds
c162a1e: (dschuff@chromium.org) Test that invoking longjmp with an argument of 0 causes setjmp to return 1
5513033: (dschuff@chromium.org) Update revision for PNaCl
cfe4942: (jvoung@chromium.org) Add subzero nexe to the pnacl translator build (NaCl build scripts).
4d1385a: (dschuff@chromium.org) toolchain_build: Switch canonical push URL to https://chromium.googlesource.com
7b92e88: (inferno@chromium.org) Fix ASAN build failure with linking nacl_bootstrap.
ff68e26: (jvoung@chromium.org) Revert two recent nacl-gcc x86 newlib rolls and disable longjmp test.
68a738d: (shinyak@chromium.org) Avoid deadlock in build_nexe.py
99e2d42: (mseaborn@chromium.org) Cleanup: Move desc_metadata_types.h out of public/
5e7b602: (mcgrathr@chromium.org) Fix code_data_allocate after mmap PROT_EXEC,MAP_FIXED
19f11aa: (dschuff@chromium.org) Roll PNaCl back to ab8a5c605e1502be0605783bfe477d1a3d315817
Changes: https://chromium.googlesource.com/native_client/src/native_client/+log/dac922075e8f2e020b3538133d619c02a5a0e4fa..19f11aa481261f38f2a1e9a04e41a7e12aa70e32
BUG= https://code.google.com/p/chromium/issues/detail?id=463455
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_arm_compile,linux_nacl_sdk_build
Review URL: https://codereview.chromium.org/978073002
Cr-Commit-Position: refs/heads/master@{#319179}
|
|
|
|
|
|
|
|
|
|
| |
hostile to NULL key data.
BUG=395826
Review URL: https://codereview.chromium.org/975273002
Cr-Commit-Position: refs/heads/master@{#319178}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously on Android, we silently uniquified when there is a filename
conflict. Now we're changing the behavior to prompt the user with
an infobar.
BUG=333085,415711
TEST=1) Download same file twice, choose 'replace file', and checked that
file is overwritten.
2) Download same file twice, choose 'create new file', and checked
a new file is created.
3) Download same file twice, dismiss the infobar and checked download
did not happen.
4) Download file A twice, check the infobar, download file B twice,
and checked that two infobars have showed up, and checked that
both files can still be overwritten and new files can be created.
5) Download same file twice, check that infobar shows up, and navigate
to another link and checked that infobar is still there and you can
initiate the download.
Review URL: https://codereview.chromium.org/580043002
Cr-Commit-Position: refs/heads/master@{#319177}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
From 10.8 onwards, CoreText provides
CTFontCopyDefaultCascadeListForLanguages() which is exactly what we
want. For 10.6 and 10.7, use an older private interface,
CTFontCopyDefaultCascadeList().
Adds tests to ensure the feature detection and API behavior is sane
across all OSX versions we support.
BUG=439039, 462477
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/971673002
Cr-Commit-Position: refs/heads/master@{#319176}
|
|
|
|
|
|
|
|
|
|
|
| |
This adds javascript bindings for the functions in cast_receiver_session, allowing
a cast_receiver to be initiated from a whitelisted javascript extension.
Also fixes a crashing bug in udp_transport.cc.
Review URL: https://codereview.chromium.org/938903003
Cr-Commit-Position: refs/heads/master@{#319175}
|
|
|
|
|
|
|
|
|
|
|
| |
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ceac7ed..ce370d0
TBR=samli@chromium.org,aboxhall@chromium.org,dpranke@chromium.org,dpranke@chromium.org
Review URL: https://codereview.chromium.org/981703003
Cr-Commit-Position: refs/heads/master@{#319174}
|
|
|
|
|
|
|
|
|
|
| |
Followed a local Linux machine which was slower than expected to where the time was going. Stopped at the ExtensionManagement::Refresh level, and will measure if this is general slow.
BUG=454789
Review URL: https://codereview.chromium.org/977673002
Cr-Commit-Position: refs/heads/master@{#319173}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This verifies that we detect and report misspelled policy names
regardless of whether "RemoteAccessHost" appears as a prefix,
suffix or a substring. I felt adding this test is important
to "document" the behavior asked about in
https://codereview.chromium.org/966433002/diff/120001/remoting/host/policy_watcher.cc#newcode109
The new test verifies expected behavior via MockLog class moved to base/test in
crrev.com/966423003. I feel that the benefit of documenting and automatically
verifying the expected behavior outweights the small maintenence cost of an
additional test and the slight ickyness of verifying the behavior by looking at
log output.
BUG=
Review URL: https://codereview.chromium.org/979823004
Cr-Commit-Position: refs/heads/master@{#319172}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
id:310001 of https://codereview.chromium.org/955653003/)
Reason for revert:
Failed tests in drag_unittest.py:
http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac10.9%20Tests&number=3803
Original issue's description:
> Adding Maps page to page_sets for telemetry.
>
> This CL adds google maps page to telemetry, and runs a synthetic drag
> gesture on the page. This helps testing of maps page in telemetry to
> track the performance on desktop chrome.
>
> BUG=457148
>
> Committed: https://crrev.com/f502701b2bcc43c05d82e5780b2d6cf2d326bc23
> Cr-Commit-Position: refs/heads/master@{#319135}
TBR=skyostil@chromium.org,picksi@chromium.org,petrcermak@chromium.org,ssid@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=457148
Review URL: https://codereview.chromium.org/982683003
Cr-Commit-Position: refs/heads/master@{#319171}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ownership.
Otherwise, after transferring ownership the old
base_file will always be invalid and we get spurious
error logs, which can be confusing.
This started happening after the refactoring in r274783.
https://codereview.chromium.org/307173002/diff/80001/components/nacl/renderer/pnacl_translation_resource_host.cc
Alternatively, could have checked the file_handle variable that
ends up owning the base_file at the later point, but might as
well check it earlier.
BUG=none
(but it bugged ncbray =))
Review URL: https://codereview.chromium.org/982663002
Cr-Commit-Position: refs/heads/master@{#319170}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PepperVideoCaptureHost::OnFrameReady makes use of kUnknownFrameRate
which was previously only included in webrtc builds. Let's move
these constants to the header file instead, since it can be
included in both webrtc and non-webrtc builds.
Followup to https://codereview.chromium.org/955253002.
BUG=461116,463829
Review URL: https://codereview.chromium.org/973373002
Cr-Commit-Position: refs/heads/master@{#319169}
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://codereview.chromium.org/948803004
Cr-Commit-Position: refs/heads/master@{#319168}
|