| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
| |
Cr-Commit-Position: refs/branch-heads/2363@{#4}
Cr-Branched-From: ac561df1bc7f47f11af6a2569293bdd4942c09b5-refs/heads/master@{#324447}
|
|
|
|
|
| |
Cr-Commit-Position: refs/branch-heads/2363@{#3}
Cr-Branched-From: ac561df1bc7f47f11af6a2569293bdd4942c09b5-refs/heads/master@{#324447}
|
|
|
|
|
| |
Cr-Commit-Position: refs/branch-heads/2363@{#2}
Cr-Branched-From: ac561df1bc7f47f11af6a2569293bdd4942c09b5-refs/heads/master@{#324447}
|
|
|
|
|
| |
Cr-Commit-Position: refs/branch-heads/2363@{#1}
Cr-Branched-From: ac561df1bc7f47f11af6a2569293bdd4942c09b5-refs/heads/master@{#324447}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #2 id:20001 of https://codereview.chromium.org/1056533003/)
Reason for revert:
Speculative revert (https://code.google.com/p/chromium/issues/detail?id=474977)
BUG=474977
Original issue's description:
> Re-subimission of https://codereview.chromium.org/1041213003/
>
> 1. Use window.performance.timing instead of statsCollectionController to get page loading time.
> 2. Fix waiting condition to avoid racing condition
>
> BUG=472603,467964
>
> Committed: https://crrev.com/ad8d3f3d9182bb82f89c5d29e0c455d8deb8c15a
> Cr-Commit-Position: refs/heads/master@{#324118}
TBR=dtu@chromium.org,aiolos@chromium.org,cylee@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=472603,467964
Review URL: https://codereview.chromium.org/1072053002
Cr-Commit-Position: refs/heads/master@{#324447}
|
|
|
|
|
|
|
|
| |
BUG=466348
Review URL: https://codereview.chromium.org/1078743002
Cr-Commit-Position: refs/heads/master@{#324446}
|
|
|
|
|
|
|
|
|
| |
Committed: https://crrev.com/f4a6e44ff20c29a6410a698a06a45dd11666ef53
Cr-Commit-Position: refs/heads/master@{#324320}
Review URL: https://codereview.chromium.org/1070933002
Cr-Commit-Position: refs/heads/master@{#324445}
|
|
|
|
|
|
|
|
|
|
|
| |
The previous description for the zoomFactor parameter failed to indicate
that 0 can be input to set the tab to use its default zoom factor.
BUG=470550
Review URL: https://codereview.chromium.org/1061193005
Cr-Commit-Position: refs/heads/master@{#324444}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In tracing the target pages, we can get 'BlinkGCTimeMeasurement'
events which show time ranges to measure forced GC.
This CL makes oilpan_gc_times test to check each forced GC event is in the ranges.
Background:
OilpanGCTimes test runs forced GCs in each test run and also between them.
We want to track only former ones to measure GC marking time durations precisely.
BUG=438074,465997
TEST=./tools/perf/run_tests oilpan --browser=content-shell-release
TEST=./tools/perf/run_benchmark run oilpan_gc_times.blink_perf_stress --browser=content-shell-release
Review URL: https://codereview.chromium.org/1065573002
Cr-Commit-Position: refs/heads/master@{#324443}
|
|
|
|
|
|
|
|
|
|
| |
This manifest doesn't correspond to any still-existing webview target.
BUG=
Review URL: https://codereview.chromium.org/1074793002
Cr-Commit-Position: refs/heads/master@{#324442}
|
|
|
|
|
|
|
|
|
|
|
| |
We can avoid doing some memory allocation in MaybePostDoWorkOnMainRunner
by keeping two closures and choosing which to post.
BUG=
Review URL: https://codereview.chromium.org/1064423003
Cr-Commit-Position: refs/heads/master@{#324441}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove the android_webview_build conditions from components_tests.gyp
now that we no longer support that build configuration, and flatten out
the conditions appropriately. Also move the OS==android case to no
longer be nested inside OS!=ios since the former implies the latter.
BUG=440793
Review URL: https://codereview.chromium.org/1077663002
Cr-Commit-Position: refs/heads/master@{#324440}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/fbcf0bd..f57546e
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=msarett@google.com
Review URL: https://codereview.chromium.org/1078713003
Cr-Commit-Position: refs/heads/master@{#324439}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL enables namespace sandbox, which replaces suid
sandbox of nacl_helper_nonsfi.
TEST=browser_tests --gtest_filter=*Traditional*, ran bots.
BUG=464663
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_trusty32_rel,linux_arm
TBR=jln@chromium.org
Review URL: https://codereview.chromium.org/1058783002
Cr-Commit-Position: refs/heads/master@{#324438}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, property-tree-building code checks whether each
layer is axis-aligned with respect to its clip parent, as
part of determining whether a layer needs a new clip tree
node. This is an expensive check, since it involves computing
the transform from the layer's transform parent to its clip
parent's transform node. For most layers, axis alignment
doesn't actually change whether a clip node is needed, so
checking axis alignment is wasted work.
This CL defers checking axis alignment until we know that it
matters.
Testing locally on a z620, this improves property tree
computation time by 10% on Gmail, and also by 10% on rAF-driven
poster circle.
BUG=474725
Review URL: https://codereview.chromium.org/1070783003
Cr-Commit-Position: refs/heads/master@{#324437}
|
|
|
|
|
|
|
|
|
| |
BUG=475416
TEST=manually
Review URL: https://codereview.chromium.org/1074733002
Cr-Commit-Position: refs/heads/master@{#324436}
|
|
|
|
|
|
|
|
|
|
| |
-use the same blink instance for POSTs instead of going to the shell
-ensure redirects save the callback to the client
-fix UAF sincen any calls to WebURLLoaderClient can delete |this|
Review URL: https://codereview.chromium.org/1071023002
Cr-Commit-Position: refs/heads/master@{#324435}
|
|
|
|
|
|
|
|
|
|
|
|
| |
a getusermedia callback.
BUG=472617, 474370
TBR=tommi@chromium.org
Review URL: https://codereview.chromium.org/1075833002
Cr-Commit-Position: refs/heads/master@{#324434}
|
|
|
|
|
|
|
|
|
|
|
| |
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/b559582..d13e636
TBR=keishi@chromium.org
Review URL: https://codereview.chromium.org/1070063003
Cr-Commit-Position: refs/heads/master@{#324433}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is causing a ~1.46 mb increase in the binary size of chrome on android.
Preemptively reverting this to facilitate further discussion.
This change introduces a dummy target in gyp that deletes existing localized resources. The target as well as the python script can be removed once all buildbots have run this once (~ a day).
Thankfully this is is not required in gn.
BUG=450548
Review URL: https://codereview.chromium.org/1062213002
Cr-Commit-Position: refs/heads/master@{#324432}
|
|
|
|
|
|
|
|
|
|
| |
R=phajdan.jr@chromium.org
CC=akuegel@chromium.org
BUG=472612
Review URL: https://codereview.chromium.org/1063423003
Cr-Commit-Position: refs/heads/master@{#324431}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Split FaviconTabHelper into three classes depending on what can be
shared with iOS (FaviconDriverImpl), what only depends on //content
(ContentFaviconDriver) and what depends on //chrome (FaviconTabHelper).
FaviconTabHelper still exists to provide an easier factory (as
ContentFaviconDriver cannot access KeyedService factories defined in
//chrome) as FaviconTabHelper::CreateForWebContents() is called from
multiple locations in //chrome code and to provide an implementation for
FaviconTabHelper::ShouldDisplayFavicon (this method will be turned into
a free function in a followup CL as it only depends on WebContents
public interface, not on ContentFaviconDriver).
Introduce WebFaviconDriver, an iOS implementation of FaviconDriver that
uses FaviconDriverImpl to share as much code as possible with the
ContentFaviconDriver.
BUG=370877, 472117
Review URL: https://codereview.chromium.org/1064823002
Cr-Commit-Position: refs/heads/master@{#324430}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Especially for FSP, we'd like to know type of a volume, as the way they are
going to be displayed in Files app depends on it. Eg. SOURCE_FILE volumes will
be auto opened once they are mounted. SOURCE_NETWORK file systems will have
a button for configuration.
TEST=unit_tests, browser_tests
BUG=474146
Review URL: https://codereview.chromium.org/1055183003
Cr-Commit-Position: refs/heads/master@{#324429}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
preferences page.
Redirect user to Password manager preferences page, where auto sign in
checkbox is located.
BUG=454815
R=bauerb@chromium.org
Review URL: https://codereview.chromium.org/1076813002
Cr-Commit-Position: refs/heads/master@{#324428}
|
|
|
|
|
|
|
|
|
|
|
| |
This mirrors what other similar providers do:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/autocomplete/zero_suggest_provider.cc&rcl=1428507553&l=98
BUG=None.
Review URL: https://codereview.chromium.org/1072003002
Cr-Commit-Position: refs/heads/master@{#324427}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/35f5576..fbcf0bd
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=msarett@google.com
Review URL: https://codereview.chromium.org/1077583002
Cr-Commit-Position: refs/heads/master@{#324426}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We were leaking activity Contexts in ResourcesContextWrapperFactory's
cache of wrapped contexts, because WeakHashMap only references its
*keys* weakly, and the ContextWrapper objects used as values in the
hashmap have a strong reference to the Context being used as a key, so
nothing was ever removed from the map.
Fix this by deleting the cache entirely, as it's not really necessary;
the number of wrapped contexts we create is already bounded to two per
WebView (one for the activity context and one for the application
context), and the objects are very small, so it's not worth the
complexity of trying to avoid lifetime issues while reusing them.
We do still need to ensure that WebViewChromiumFactoryProvider always
uses the same wrapper for the application context, though, since in some
initialisation paths we set the application context more than once and
the underlying code only permits that if the same context object is used
each time.
BUG=473146
Review URL: https://codereview.chromium.org/1078693003
Cr-Commit-Position: refs/heads/master@{#324425}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebRTC 8955:8956
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/a4d326e..9e4853a
Libjingle 8954:8956
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/57c1e6f..32d6efb
TBR=perkj
Review URL: https://codereview.chromium.org/1071123002
Cr-Commit-Position: refs/heads/master@{#324424}
|
|
|
|
|
|
|
|
|
|
|
| |
New bubble implementation was done in https://crrev.com/319892
BUG=454815
R=vabr@chromium.org
Review URL: https://codereview.chromium.org/1078723002
Cr-Commit-Position: refs/heads/master@{#324423}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#324422}
|
|
|
|
|
|
|
|
|
|
| |
Drop "offline sign in" help article reference since HelpApp doesn't have that content.
BUG=468257,469459
Review URL: https://codereview.chromium.org/1058433002
Cr-Commit-Position: refs/heads/master@{#324421}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/1cb04a8e..ca308522
Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues
TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org
Review URL: https://codereview.chromium.org/1070053002
Cr-Commit-Position: refs/heads/master@{#324420}
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1072803002
Cr-Commit-Position: refs/heads/master@{#324419}
|
|
|
|
|
|
|
|
|
|
|
| |
Add a flag to the WebView manifest to ensure that webview apks are
compatible with the new mechanism for loading webview.
BUG=
Review URL: https://codereview.chromium.org/1075883002
Cr-Commit-Position: refs/heads/master@{#324418}
|
|
|
|
|
|
|
|
|
| |
- use ALIGNOF macro
- use variadic templates
Review URL: https://codereview.chromium.org/1070603003
Cr-Commit-Position: refs/heads/master@{#324417}
|
|
|
|
|
|
|
|
|
|
|
| |
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/eb1578b..b559582
TBR=keishi@chromium.org
Review URL: https://codereview.chromium.org/1071913003
Cr-Commit-Position: refs/heads/master@{#324416}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
#32 id:620001 of https://codereview.chromium.org/895543005/)
Reason for revert:
After this CL, content browsertest WebContentsViewAuraTest.RepeatedQuickOverscrollGestures started failing with segmentation fault on almost every run on Linux ChromiumOS Tests (dbg)(1).
See: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/850
Original issue's description:
> Refactor GestureNavigation to eliminate code redundancy
>
> Right now, Gesture Navigation has two very distinct phases: the initial
> one, where the web contents window receives events and is moved, and the
> follow up navigation, where the page still hasn't loaded and the user
> scrolls on the overlay. The meat of this patch is to unify as much of
> the logic as possible without sacrificing features. A new class is
> introduced, OverscrollWindowAnimation, and the responsibility of the
> existing OverscrollNavigationOverlay is steered into performing the
> actual navigation.
>
> TEST=Overscroll*
> BUG=467692,464532,420121
>
> Committed: https://crrev.com/5384f002f839439ef666ed9688069e42ca5ccdca
> Cr-Commit-Position: refs/heads/master@{#324275}
TBR=mfomitchev@chromium.org,sadrul@chromium.org,danakj@chromium.org,avi@chromium.org,nsatragno@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=467692,464532,420121
Review URL: https://codereview.chromium.org/1076743003
Cr-Commit-Position: refs/heads/master@{#324415}
|
|
|
|
|
|
|
|
|
|
|
| |
This CL makes it so that the helper functions used in RenderViewImpltest work
with browser-side navigation enabled. This makes 20 browser tests pass.
BUG=475027
Review URL: https://codereview.chromium.org/1064413003
Cr-Commit-Position: refs/heads/master@{#324414}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In application_lifetime.h, it is said that what ExitCleanly() does is "Shutdown chrome cleanly without blocking".
However, it actually calls BrowserProcessImpl::EndSession(), which blocks the UI thread waiting for Preferences file to be written.
This EndSession() call was added by https://codereview.chromium.org/7273038.
By getting rid of this EndSession() call in ExitCleanly(), we can avoid blocking the UI thread waiting for the disk IO.
Also, we'll be able to avoid writing the Preferences file multiple times during shutdown.
This should make it less likely to hit SessionManager's 3-second timeout.
BUG=470501
Review URL: https://codereview.chromium.org/1057533003
Cr-Commit-Position: refs/heads/master@{#324413}
|
|
|
|
|
|
|
|
|
|
| |
The android_aosp bot is gone and so these files are no longer used.
BUG=440793
Review URL: https://codereview.chromium.org/1071873003
Cr-Commit-Position: refs/heads/master@{#324412}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebRTC 8945:8955
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/f814f6d..a4d326e
Libjingle 8941:8954
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/82bd4f4..57c1e6f
TBR=perkj
Review URL: https://codereview.chromium.org/1078643002
Cr-Commit-Position: refs/heads/master@{#324411}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/ca9f7433..1cb04a8e
Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues
TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1076733002
Cr-Commit-Position: refs/heads/master@{#324410}
|
|
|
|
|
|
|
|
|
|
|
| |
Property tree verification was inadvertently disabled by
http://crrev.com/976553002.
This CL re-enables it.
Review URL: https://codereview.chromium.org/1068383002
Cr-Commit-Position: refs/heads/master@{#324409}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enterprise.DevicePolicyInvalidations can take the values [0, 1, 3, 4],
not [0, 1, 2, 3] as erroneously specified in histograms.xml.
BUG=None
TEST=None
Review URL: https://codereview.chromium.org/1067323002
Cr-Commit-Position: refs/heads/master@{#324408}
|
|
|
|
|
|
|
|
| |
BUG=444203
Review URL: https://codereview.chromium.org/1063413002
Cr-Commit-Position: refs/heads/master@{#324407}
|
|
|
|
|
|
|
|
|
|
|
| |
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ec58772..eb1578b
TBR=keishi@chromium.org
Review URL: https://codereview.chromium.org/1069983003
Cr-Commit-Position: refs/heads/master@{#324406}
|
|
|
|
|
|
|
|
|
|
| |
R=posciak@chromium.org, wuchengli@chromium.org
BUG=none
TEST=play h264 html5 video
Review URL: https://codereview.chromium.org/1048773002
Cr-Commit-Position: refs/heads/master@{#324405}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #3 id:40001 of https://codereview.chromium.org/1070933002/)
Reason for revert:
This CL introduces a typo to the GN build file, so that Windows GN builds fail.
It should be possible to reland after below line is changed from appending to assignment.
ERROR at //ui/gl/BUILD.gn:203:5: Undefined variable for +=.
data_deps += [
^--------
I don't have something with this name in scope now.
See: http://build.chromium.org/p/chromium.win/builders/Win8%20GN
Original issue's description:
> Make ui/gl depend on the necessary runtime targets on Windows.
>
> Committed: https://crrev.com/f4a6e44ff20c29a6410a698a06a45dd11666ef53
> Cr-Commit-Position: refs/heads/master@{#324320}
TBR=brettw@chromium.org,scottmg@chromium.org,jam@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1071113002
Cr-Commit-Position: refs/heads/master@{#324404}
|
|
|
|
|
|
|
|
| |
Addressing comments from CL 1004733003.
Review URL: https://codereview.chromium.org/1038203003
Cr-Commit-Position: refs/heads/master@{#324403}
|