| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
| |
Cr-Commit-Position: refs/branch-heads/2416@{#1}
Cr-Branched-From: 6c3c36136b4567f2225550f15e27d2720e1930d8-refs/heads/master@{#331886}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch starts including a list of connected printers supported by
printerProvider apps in the normal list of extension printers returned
to the print preview WebUI. These printers are given "provisional" IDs
because the devices are not yet known to the apps themselves.
BUG=468955
Review URL: https://codereview.chromium.org/1153173002
Cr-Commit-Position: refs/heads/master@{#331886}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently the presence of Infobars and devtools will affect the size of
a print preview dialog. Instead, the dialog should be sized based only
on the size of the window (and presence of toolbars). That is, in the
"regular" bounds (between 800x480 and 1000x660), the print preview
dialog should have an even border on the bottom and left/right sides
w.r.t. the window edge, and follow when the window is resized.
print_preview_dialog_controller.cc uses WebContentsModalDialogHost::
GetMaximumDialogSize() to determine the right size, but Cocoa browsers
currently do not have a WCMDH. This means the dialog sizes based only on
the WebContents, which is wrong.
This CL provides a simple WebContentsModalDialogHost to bridge to the
ConstrainedWindowSheetController. The logic currently in
SingleWebContentsDialogManagerCocoa to find the parent view is relocated
to the WebContentsModalDialogHost.
A WCMDH is also needed to provide web-modal toolkit-views dialogs on a
Cocoa browser, but it actually doesn't need to be any more complicated
than this.
Code coverage on Mac+Cocoa is given by PrintPreviewTest.PrintCommands
which relies on a WebContentsModalDialogHost to properly size the
dialog.
BUG=492990, 492967, 485854
TEST=Open (bottom-docked) DevTools, Hotdog->Print. The Print preview
dialog should extend over the devtools, and when resizing the browser
between 480 and 660 pixels in height, the dialog size should follow the
window border, and not get squished up above DevTools.
Review URL: https://codereview.chromium.org/1160443005
Cr-Commit-Position: refs/heads/master@{#331885}
|
|
|
|
|
|
|
|
| |
BUG=493393
Review URL: https://codereview.chromium.org/1159923009
Cr-Commit-Position: refs/heads/master@{#331884}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To preare for deprecating event.path as resolved by the WebApps-WG, but its
usage is as high as 3%, we would like to understand the usage of event.path.
Blink patch: https://codereview.chromium.org/1160883003/
BUG=491008
Review URL: https://codereview.chromium.org/1154463006
Cr-Commit-Position: refs/heads/master@{#331883}
|
|
|
|
|
|
|
|
| |
This allows quad creators to avoid including resource_provider.h and all that entails.
Review URL: https://codereview.chromium.org/1163473002
Cr-Commit-Position: refs/heads/master@{#331882}
|
|
|
|
|
|
|
|
|
| |
BUG=384152,492823
TEST=EME tests still pass
Review URL: https://codereview.chromium.org/1166453002
Cr-Commit-Position: refs/heads/master@{#331881}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mocha is a test framework that makes asynchronous tests simple
and helps batch multiple logical tests into a single browser test.
This makes writing a web component test framework much, much easier.
See http://crrev.com/1124873002 for an example of how mocha could be
used to write a simple in-browser test of a custom element.
BUG=492889
Review URL: https://codereview.chromium.org/1140003003
Cr-Commit-Position: refs/heads/master@{#331880}
|
|
|
|
|
|
|
|
|
| |
To avoid stretching, the finish only needs to be executed in the GPU process, not necessarily on the GPU, before the resize is over. Using shallowFinish is more efficient and prevents unnecessary blocking.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1161793004
Cr-Commit-Position: refs/heads/master@{#331879}
|
|
|
|
|
|
|
|
|
|
|
| |
This change adds a message to the distiller results page if the user
has javascript disabled.
BUG=408231
Review URL: https://codereview.chromium.org/1140183004
Cr-Commit-Position: refs/heads/master@{#331878}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To do otherwise means the delegate outlives the app, which is error
prone (I was hitting an asan error running apptests). Before this
patch the destruction order was:
1. app
2. messageloop
3. delegate
Between 2 and 3 we may pump events posted by the delegate, which is
problematic since the app has been deleted.
Now it's:
. delegate
. app
. messageloop
BUG=none
TEST=none
R=ben@chromium.org
Review URL: https://codereview.chromium.org/1160643003
Cr-Commit-Position: refs/heads/master@{#331877}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/1159973004
Cr-Commit-Position: refs/heads/master@{#331876}
|
|
|
|
|
|
|
|
|
|
|
| |
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/8517652..61eaf5a
TBR=dmurph@chromium.org,mnaganov@chromium.org
Review URL: https://codereview.chromium.org/1152173008
Cr-Commit-Position: refs/heads/master@{#331875}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The glEGLImageTargetTexture2DOES call is expensive on some
drivers. Move these calls in PullTextureUpdates outside of
the global lock to reduce lock contention.
Also change makes glFlush to onces per PullTextureUpdates
instead of once per texture update.
BUG=492315
Review URL: https://codereview.chromium.org/1153313003
Cr-Commit-Position: refs/heads/master@{#331874}
|
|
|
|
|
|
|
|
| |
BUG=492236
Review URL: https://codereview.chromium.org/1157163005
Cr-Commit-Position: refs/heads/master@{#331873}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
argv is suppose to be terminated with a null. Things like gtest rely
on this. Without it we hit an asan error when gtest tries to read
argv[argc].
BUG=none
TEST=none
R=msw@chromium.org
Review URL: https://codereview.chromium.org/1167433002
Cr-Commit-Position: refs/heads/master@{#331872}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Cherry-pick: Fix to visual studio build error:
https://codereview.chromium.org/1159133002
Cherry pick: VP8: For high overshoot, force drop frame and max-out QP:
https://codereview.chromium.org/1160103002
BUG=
R=tomfinegan@chromium.org
Review URL: https://codereview.chromium.org/1146423003
Cr-Commit-Position: refs/heads/master@{#331871}
|
|
|
|
|
|
|
|
|
| |
In this case, the deletion will happen on the current thread. This is necessary for android webview, because the Display lives on a thread without a task runner.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1158563005
Cr-Commit-Position: refs/heads/master@{#331870}
|
|
|
|
|
|
|
|
|
|
|
|
| |
If a grit target specifies a resource_ids file of "" (this has specific meaning
documented in the grit rule), don't set the empty string as an input to the
grit action.
The only time this comes up is in the java_strings_grd template.
Review URL: https://codereview.chromium.org/1157113003
Cr-Commit-Position: refs/heads/master@{#331869}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Took over Kevin's patch 1126923002.
This code bridges calls from the Media Router to the Media Router
Provider Manager. CL comprises:
- Logic for marshaling data across internal and Mojo structs via
Type Converters already upstreamed.
- Awareness of the MRPM extension's suspend state
- A BrowserContextKeyedServiceFactory for constructing and
managing Mojo service objects.
Also included are unit tests, supporting mock classes, and some trivial
miscellaneous name changes.
BUG=461815,464205
Review URL: https://codereview.chromium.org/1143603004
Cr-Commit-Position: refs/heads/master@{#331868}
|
|
|
|
|
|
|
|
|
| |
BUG=369661
TEST=No whammies!
Review URL: https://codereview.chromium.org/1164433002
Cr-Commit-Position: refs/heads/master@{#331867}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For systems with 4 or fewer cores, the number of encode threads is
unchanged. However, for higher-end systems, it makes sense to allow
more cores to be utilized to reduce frame encoding latency, especially
for key frames.
BUG=156767
Review URL: https://codereview.chromium.org/1152093004
Cr-Commit-Position: refs/heads/master@{#331866}
|
|
|
|
|
|
|
|
|
|
|
| |
https://chromium.googlesource.com/angle/angle.git/+log/44aedf3..57df19c
BUG=
TEST=bots
Review URL: https://codereview.chromium.org/1158143003
Cr-Commit-Position: refs/heads/master@{#331865}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
FillLayout asserts that it can have at most one child view. CastDuplexView
had only one active child (with the other being disabled), so everything worked
as expected - except the DCHECK. This commit changes the CastDuplexView
implementation so that there is at most one child view at a time.
BUG=492400
Review URL: https://codereview.chromium.org/1155283002
Cr-Commit-Position: refs/heads/master@{#331864}
|
|
|
|
|
|
|
|
|
|
|
|
| |
I suspect this is why the intro tables aren't updating, as the
intro tables JSON itself is properly updated on the server.
TBR=mkearney@chromium.org
BUG=None
Review URL: https://codereview.chromium.org/1160103003
Cr-Commit-Position: refs/heads/master@{#331863}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This sets the root node's source_node_id. Since this wasn't being
set, it was masking a missing needs_local_transform_update (since
having a source_node_id different from parent_id also triggers a
local transform update), which is also added here.
BUG=481585
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1156243003
Cr-Commit-Position: refs/heads/master@{#331862}
|
|
|
|
|
|
|
|
|
| |
TBR= ellyjones@chromium.org,mmenke@chromium.org,jochen@chromium.org
BUG=465789
Review URL: https://codereview.chromium.org/1159713005
Cr-Commit-Position: refs/heads/master@{#331861}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Simplify the browser side display manager by keeping all display related
logic within a DrmDisplayHost object. Now the display manager focuses
only on keeping track of the displays and updating them.
BUG=none
Review URL: https://codereview.chromium.org/1158493004
Cr-Commit-Position: refs/heads/master@{#331860}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Beamforming gets enabled if:
* googBeamforming is true
AND
{
* It is supported device (peach_pi, swanky), in which case it uses the hardcoded geometry for each device
OR
* A valid googArrayGeometry is provided using space delimited coordinates. For example, googArrayGeometry=-0.026 0 0 0.026 0 0
}
Review URL: https://codereview.chromium.org/1156073005
Cr-Commit-Position: refs/heads/master@{#331859}
|
|
|
|
|
|
|
|
|
|
| |
Answers in Suggest calls for mixed font styling. This CL allows for font size, color, and baseline to be controlled via the downloaded answer test style types.
BUG=449593
Review URL: https://codereview.chromium.org/1125513002
Cr-Commit-Position: refs/heads/master@{#331858}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/1160813006
Cr-Commit-Position: refs/heads/master@{#331857}
|
|
|
|
|
|
|
|
| |
BUG=464764
Review URL: https://codereview.chromium.org/1151013003
Cr-Commit-Position: refs/heads/master@{#331856}
|
|
|
|
|
|
|
|
|
|
| |
Using chrome.send with our own webUI handlers is significantly simpler and faster than implementing new APIs for each domain.
BUG=
Review URL: https://codereview.chromium.org/1153173003
Cr-Commit-Position: refs/heads/master@{#331855}
|
|
|
|
|
|
|
|
|
|
|
|
| |
The issue is that a function level static now takes a secret lock which is managed by the crt. Since the code in question executes before the crt has initialized, it uses an non-initialized lock.
Current sandbox tests suffice.
BUG=482784
Review URL: https://codereview.chromium.org/1138463005
Cr-Commit-Position: refs/heads/master@{#331854}
|
|
|
|
|
|
|
|
| |
the QUIC session prefers to use AES GCM because of hardware support.
Review URL: https://codereview.chromium.org/1152853003
Cr-Commit-Position: refs/heads/master@{#331853}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change allows content to be shown on the page prior to the
distillation of the first page of an article having completed.
The template HTML and the loading animation will show while the
distillation completes.
BUG=
Review URL: https://codereview.chromium.org/1130703003
Cr-Commit-Position: refs/heads/master@{#331852}
|
|
|
|
|
|
|
|
|
| |
BUG=369661
TEST=none for now; fewer crashes later
Review URL: https://codereview.chromium.org/1143423006
Cr-Commit-Position: refs/heads/master@{#331851}
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 2466c430c4341f2ecfafd8b4e846c46147ae54a7.
NOTRY=true
BUG=484934
Review URL: https://codereview.chromium.org/1149893011
Cr-Commit-Position: refs/heads/master@{#331850}
|
|
|
|
|
|
|
|
| |
BUG=480604
Review URL: https://codereview.chromium.org/1160813002
Cr-Commit-Position: refs/heads/master@{#331849}
|
|
|
|
|
|
|
|
|
|
|
| |
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/b4d2fd5..8517652
TBR=dmurph@chromium.org,mnaganov@chromium.org
Review URL: https://codereview.chromium.org/1157143003
Cr-Commit-Position: refs/heads/master@{#331848}
|
|
|
|
|
|
|
|
| |
BUG=492641
Review URL: https://codereview.chromium.org/1157383003
Cr-Commit-Position: refs/heads/master@{#331847}
|
|
|
|
|
|
|
|
|
| |
BUG= 437411, 437408
TBR=dmichael@chromium.org
Review URL: https://codereview.chromium.org/1157433007
Cr-Commit-Position: refs/heads/master@{#331846}
|
|
|
|
|
|
|
|
| |
cross-reference support.
Review URL: https://codereview.chromium.org/1165453002
Cr-Commit-Position: refs/heads/master@{#331845}
|
|
|
|
|
|
|
|
|
|
|
| |
Cycle time of linux_android_rel_ng is now reduced to 2m40s due to the following fix:
https://codereview.chromium.org/1153103007
BUG=379378
Review URL: https://codereview.chromium.org/1154383003
Cr-Commit-Position: refs/heads/master@{#331844}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This means that list_container.cc can no longer refer to quad types etc., so
instead the bulk of the logic is moved to the non-template class
ListContainerBase, which can be defined without any knowledge outside cc/base/.
Due to linking issues, the instantiations are no longer explicit. However, the
actual template to be instantiated is now much smaller, with most of the actual
code being in ListContainerBase (which defined in list_container.cc).
Effort has been made to make minimal changes aside from code movement. In
particular, other refactorings (including of the unit test) are intentionally
not in this CL.
BUG=492952
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1161883003
Cr-Commit-Position: refs/heads/master@{#331843}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/1162503004
Cr-Commit-Position: refs/heads/master@{#331842}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In tab capture (all platforms) and desktop/window capture (CrOS), a
timer fires when compositor updates stop occurring. This is to ensure
the video encoder receives multiple copies of the same content, to
incrementally apply quality-improving "deltas" that reduce the lossy
errors in complex content.
However, the existing mechanism goes overboard in two ways that this
change resolves: 1) The rate of capture is "full speed," whereas our
research suggests a frugal 8 FPS provides the same, rapid quality
improvements. 2) It's possible for the timer to initiate more than one
capture at the same time, which is not necessary since there is
logically no reason to capture static content "smoothly."
BUG=156767,492839
Review URL: https://codereview.chromium.org/1145383006
Cr-Commit-Position: refs/heads/master@{#331841}
|
|
|
|
|
|
|
|
|
|
| |
No semantic change. Just fixing an indent problem.
TBR=raymes@chromium.org
Review URL: https://codereview.chromium.org/1152213008
Cr-Commit-Position: refs/heads/master@{#331840}
|
|
|
|
|
|
|
|
|
|
| |
BUG=429053
TEST=gpu_unittests
R=sievers@chromium.org
Review URL: https://codereview.chromium.org/1159543002
Cr-Commit-Position: refs/heads/master@{#331839}
|