| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
Added a presubmit script to enforce that all future changes in the
data_reduction_proxy component are formatted with git cl format.
BUG=476041
Review URL: https://codereview.chromium.org/1078033003
Cr-Commit-Position: refs/heads/master@{#324682}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently mac_views_browser can link successfully, but with many duplicate
definitions of global functions that are defined in both browser/ui/cocoa and
browser/ui/views.
Exclude Cocoa browser window related sources from mac_views_browser, so
that it links cleanly.
omnibox, global_error and one_click_signin grouped both Views and Cocoa
implementations together. Split them to avoid duplicate symbols.
Includes minor fixes to link the Views versions of ScreenCaptureNotificationUI
and ExternalProtocolDialog.
BUG=425229
Review URL: https://codereview.chromium.org/1076943002
Cr-Commit-Position: refs/heads/master@{#324681}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A long time ago, they had been moved to browser_tests. This was
because of the OS X implementation was flaky and caused hanging tests,
and the absence of robust test timeouts in unit tests resulted in the
entire test binary hanging.
Things have changed significantly meanwhile: The new test launcher
provides robust test timeout handling, and the OS X implementation has
been fixed. Hence, it's safe to move the test over to base_unittests.
BUG=chromium:78722
Review URL: https://codereview.chromium.org/1055703004
Cr-Commit-Position: refs/heads/master@{#324680}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Create GLContext when OutputSurface is created, ie at the
same time as rest of chrome platforms.
This is possible because renderer compositor context run on
chrome's gpu thread, rather than android's thread which was
not always available.
This allows the explicit initialize/release code paths to
be deleted. Delete them from android_webview and content
in this CL.
BUG=474416
Review URL: https://codereview.chromium.org/1077783002
Cr-Commit-Position: refs/heads/master@{#324679}
|
|
|
|
|
|
|
|
|
|
| |
TBR=enne@chromium.org
BUG=416643
NOTRY=true
Review URL: https://codereview.chromium.org/1078293002
Cr-Commit-Position: refs/heads/master@{#324678}
|
|
|
|
|
|
|
|
|
|
| |
This test fails on the cronet bot.
TBR=mef@chromium.org
Review URL: https://codereview.chromium.org/1078233002
Cr-Commit-Position: refs/heads/master@{#324677}
|
|
|
|
|
|
|
|
|
| |
BUG=None
R=ellyjones@chromium.org
Review URL: https://codereview.chromium.org/1053543003
Cr-Commit-Position: refs/heads/master@{#324676}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/f6e97e6..25c40d2
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=msarett@google.com
Review URL: https://codereview.chromium.org/1076293002
Cr-Commit-Position: refs/heads/master@{#324675}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1/2 chromium: This cl.
2/2 blink: https://codereview.chromium.org/1079013002/
Screenshot: https://code.google.com/p/chromium/issues/detail?id=474459#c4
BUG=474459
Review URL: https://codereview.chromium.org/1064523003
Cr-Commit-Position: refs/heads/master@{#324674}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add html_viewer_apptests to the apptest list.
See the bot at:
http://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Linux
BUG=NONE
TEST=Bot runs and passes html_viewer_apptests.
R=sky@chromium.org
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/1065093002
Cr-Commit-Position: refs/heads/master@{#324673}
|
|
|
|
|
|
|
|
|
|
|
|
| |
instead.
Speeds up runtime from 1.6 seconds to 95ms on my workstation.
BUG=332112
Review URL: https://codereview.chromium.org/1070373002
Cr-Commit-Position: refs/heads/master@{#324672}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes CalculateVisibleRects try to re-use the to_target and
from_target transforms stored in transform nodes whenever it needs to
compute a transform. Since these baked transforms incorporate the
target's sublayer scale, the fallback path now also includes sublayer
scale for consistency.
Testing locally on a z620, this improves property tree computation time
by 25% on rAF-driven poster circle.
BUG=474725
Review URL: https://codereview.chromium.org/1060413002
Cr-Commit-Position: refs/heads/master@{#324671}
|
|
|
|
|
|
|
|
|
|
| |
one type of child process.
This is a followup to r323964 which did the same to AppChildProcess.
Review URL: https://codereview.chromium.org/1078003002
Cr-Commit-Position: refs/heads/master@{#324670}
|
|
|
|
|
|
|
|
|
|
|
| |
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f9182d3..71318f5
TBR=leviw@chromium.org,mvanouwerkerk@chromium.org
Review URL: https://codereview.chromium.org/1056253005
Cr-Commit-Position: refs/heads/master@{#324669}
|
|
|
|
|
|
|
|
|
|
| |
This class has already been moved from glue to aw.
BUG=
Review URL: https://codereview.chromium.org/1075313002
Cr-Commit-Position: refs/heads/master@{#324668}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The v8_gc_times benchmark was accidentally counting all the accumulated gc
times for previous pages in a page set instead of just the current page.
This CL fixes this.
Perf Sheriffs: This will cause movement in the V8 GC benchmark results but is
not a regression, just a correction in measurement.
Review URL: https://codereview.chromium.org/1073203002
Cr-Commit-Position: refs/heads/master@{#324667}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Multipling an int64 against a float causes the float type to
prevail which does not have enough precision for accurate
time value computations.
BUG=475964
TEST=forthcoming VideoRendererAlgorithm unittest.
Review URL: https://codereview.chromium.org/1053773005
Cr-Commit-Position: refs/heads/master@{#324666}
|
|
|
|
|
|
|
|
| |
TBR=mef@chromium.org
Review URL: https://codereview.chromium.org/1065503004
Cr-Commit-Position: refs/heads/master@{#324665}
|
|
|
|
|
|
|
|
| |
R=pasko@chromium.org
Review URL: https://codereview.chromium.org/1075143003
Cr-Commit-Position: refs/heads/master@{#324664}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In preparation for pulling cacheinvalidation library into
components/invalidation, we need to remove dependencies on cacheinvalidation
from components/gcm_driver (which components/invalidation depends on).
GCMListener is the only file that depends on cacheinvalidation, so move it into
chrome/android.
BUG=472898
TBR=mnaganov@chromium.org, benm@chromium.org
Review URL: https://codereview.chromium.org/1063633004
Cr-Commit-Position: refs/heads/master@{#324663}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original patch: crrev.com/1020743003.
The GN file is changed so that the tests are no longer depending on the target that was causing link errors on debug GN builds.
TEST=git cl try + mac_chromium_gn_dbg + win8_chromium_gn_dbg
[Media Router] MediaRouter interfaces with stub implementations.
- Updated Media Router data classes.
- Added MediaRouter interface with a stub MediaRouterImpl class.
- MRImpl is a KeyedService and is instantiated via
its BrowserContextKeyedServiceFactory implementation.
- Added MediaRoutesObserver / MediaSinksObserver interfaces which are
used by MediaRouter API.
BUG=461815,464199
Review URL: https://codereview.chromium.org/1076973002
Cr-Commit-Position: refs/heads/master@{#324662}
|
|
|
|
|
|
|
|
|
|
| |
other run.
BUG=475940
Review URL: https://codereview.chromium.org/1050943003
Cr-Commit-Position: refs/heads/master@{#324661}
|
|
|
|
|
|
|
|
| |
BUG=469853
Review URL: https://codereview.chromium.org/1077953002
Cr-Commit-Position: refs/heads/master@{#324660}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Web style is to have enums as ALL_CAPS, but we have done a horrible job of this
in our own enums, so we can't change that.
But we can ensure that the enum properties exposed on the API are like that,
e.g. make sure it's chrome.runtime.RestartRequired.BECAUSE_I_SAID_SO, instead of
chrome.runtime.RestartRequired.because_i_said_so.
BUG=463184
Review URL: https://codereview.chromium.org/1076563002
Cr-Commit-Position: refs/heads/master@{#324659}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We draw all contents in the IOSurface and remote CALayer paths into a
buffer, which we then draw to the screen. A partial swap here means that
we partially re-drew the buffer.
This isn't a complete partial swap, because, in both of these cases, we
still re-draw the full buffer to the screen.
While I'm in the neighborhood, clean up how we track the size of the
frame, since that is particularly confusing (especially when we have
partial swaps that would, more logically, pass in the damage rect).
BUG=474299
Review URL: https://codereview.chromium.org/1065123002
Cr-Commit-Position: refs/heads/master@{#324658}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add ax_provider_apptest.cc and a new html_viewer_apptest target.
Host net/data/test.html via net::SpawnedTestServer, check the AxTree.
Delay binding AxProvider interface requests until the document loads.
(this makes clients wait for a valid accessibility tree to be generated)
Remove the debug condition for building Mojo test targets.
Add TestTimeout init for net::SpawnedTestServer as in mojo CL:
https://codereview.chromium.org/952613004/
TODO: Update chromium_mojo.py recipe and mojo/tools/data/apptests:
https://codereview.chromium.org/1069503004/
https://codereview.chromium.org/1065093002/
TODO: Plumb actual command line args for test timeout init.
TODO: Move html_viewer test files to a subdirectory.
(this CL was split out from https://codereview.chromium.org/1049013004/)
BUG=NONE
TEST=New test passes.
R=sky@chromium.org,ben@chromium.org
Review URL: https://codereview.chromium.org/1062563002
Cr-Commit-Position: refs/heads/master@{#324657}
|
|
|
|
|
|
|
|
|
|
|
| |
This copies more of the content version of OnReceivedRedirect(), which
keeps track of the original WebURLRequest.
BUG=none
Review URL: https://codereview.chromium.org/1070323002
Cr-Commit-Position: refs/heads/master@{#324656}
|
|
|
|
|
|
|
|
| |
BUG=475191
Review URL: https://codereview.chromium.org/1075153003
Cr-Commit-Position: refs/heads/master@{#324655}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes logspam.
This is the same regexp that we're using in ExtensionBridge to determine if
it's the background page or a content script, but previously the content
script tried to run in the background page and failed with an error. This
just suppresses it earlier.
BUG=none
Review URL: https://codereview.chromium.org/1065993002
Cr-Commit-Position: refs/heads/master@{#324654}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add all the unit tests for code that is compiled and used on iOS so
that they are run on iOS bots (waterfall and CQ).
BUG=475512
Committed: https://crrev.com/e4c308a2736e5c80e35b5f9ebaf6f2d31dcd0523
Cr-Commit-Position: refs/heads/master@{#324624}
Review URL: https://codereview.chromium.org/1077733002
Cr-Commit-Position: refs/heads/master@{#324653}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/1078893003
Cr-Commit-Position: refs/heads/master@{#324652}
|
|
|
|
|
|
|
|
|
|
| |
Like FileEnumerator::ReadDirectory(), this function should be run on an IO-allowed thread.
BUG=None
Review URL: https://codereview.chromium.org/1079053002
Cr-Commit-Position: refs/heads/master@{#324651}
|
|
|
|
|
|
|
|
|
|
| |
Bluetooth target needs string to compile.
Targets that needs to decode bluetooth strings without dependencies can
depend only on uri_beacons target.
Review URL: https://codereview.chromium.org/1073443002
Cr-Commit-Position: refs/heads/master@{#324650}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/c5e0891..f6e97e6
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=msarett@google.com
Review URL: https://codereview.chromium.org/1078153002
Cr-Commit-Position: refs/heads/master@{#324649}
|
|
|
|
|
|
|
|
|
|
|
|
| |
According to testing, sqlite3 version used on iOS (3008005) already returns
SQLITE_NOTADB, so update SQLConnectionTest.RazeNOTADB to ignore that error
from that version.
BUG=475511,475512
Review URL: https://codereview.chromium.org/1075243002
Cr-Commit-Position: refs/heads/master@{#324648}
|
|
|
|
|
|
|
|
| |
BUG=474684
Review URL: https://codereview.chromium.org/1074003002
Cr-Commit-Position: refs/heads/master@{#324647}
|
|
|
|
|
|
|
|
|
|
|
| |
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/6f0b048..f9182d3
TBR=leviw@chromium.org,mvanouwerkerk@chromium.org
Review URL: https://codereview.chromium.org/1079553002
Cr-Commit-Position: refs/heads/master@{#324646}
|
|
|
|
|
|
|
|
|
|
|
|
| |
which will be needed by the WorkerScheduler. The idea is to
periodically check if any tasks (on non-control and idle task queues) have run since the last check. If they haven't the
system is deemed to be quiescent and we initiate a long idle period.
BUG=463143
Review URL: https://codereview.chromium.org/1073853002
Cr-Commit-Position: refs/heads/master@{#324645}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
//components/contents_settings for IPC
In preparation for moving chrome/renderer/content_settings_observer.cc into //components/contents_settings, this CL moves all IPC messages used in that file to a separate IPC declaration header in //components/contents_settings.
The main parts of the change:
* separating messages from chrome/common/render_messages.h to newly created components/content_settings/content/common/content_settings_messages.h
* adding the support files in components/content_settings/content/common/
* extending the filter in chrome/browser/renderer_host/chrome_render_message_filter.cc to catch content settings IPC
* and, of course, removing #include "chrome/common/render_messages.h" from content_settings_observer.cc
The rest is mostly adding #includes and mechanical changes.
BUG=384874,387075
Review URL: https://codereview.chromium.org/798923003
Cr-Commit-Position: refs/heads/master@{#324644}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is needed for the internet Settings UI to replace the following
properites passed using chrome.send(). It will also be used in the new
Settings UI to improve the UI for uninitalized and enabling
technologies.
cellularAvailable
cellularEnabled
wifiAvailable
wifiEnabled
wimaxAvailable
wimaxEnabled
BUG=465418
For chrome_browser_main_extra_parts_profiles.cc:
TBR=skuhne@chromium.org
Review URL: https://codereview.chromium.org/1059033002
Cr-Commit-Position: refs/heads/master@{#324643}
|
|
|
|
|
|
|
|
|
|
|
| |
This is a working version of the extension after merging with the
changes in our google3 code.
BUG=
Review URL: https://codereview.chromium.org/1072623003
Cr-Commit-Position: refs/heads/master@{#324642}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebRTC 8958:8976
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/578ea1a..cc8ca89
Libjingle 8958:8975
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/bf2f77d..61d33e5
TBR=pbos
Review URL: https://codereview.chromium.org/1074203002
Cr-Commit-Position: refs/heads/master@{#324641}
|
|
|
|
|
|
|
|
|
|
| |
Doesn't cover enrollment yet.
BUG=475937
Review URL: https://codereview.chromium.org/1072883002
Cr-Commit-Position: refs/heads/master@{#324640}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Convert CreateForWebContents() and ShouldDisplayFavicon() from static
method into free functions and move them into the favicon namespace.
Port client code to use favicon::ContentFaviconDriver::FromWebContents()
to access the favicon::FaviconDriver and prefer to use the public base
class instead of favicon::ContentFaviconDriver.
Rename FaviconTabHelperTest to ContentFaviconDriverTest.
BUG=359569
TBR=jochen
Review URL: https://codereview.chromium.org/1075443003
Cr-Commit-Position: refs/heads/master@{#324639}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/85ad564c..5be7c3a6
Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues
TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org
Review URL: https://codereview.chromium.org/1074163002
Cr-Commit-Position: refs/heads/master@{#324638}
|
|
|
|
|
|
|
|
|
|
|
| |
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/09a4b8a..6f0b048
TBR=leviw@chromium.org
Review URL: https://codereview.chromium.org/1072353003
Cr-Commit-Position: refs/heads/master@{#324637}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/9ff378b..c5e0891
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=msarett@google.com
Review URL: https://codereview.chromium.org/1063463006
Cr-Commit-Position: refs/heads/master@{#324636}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1077733002/)
Reason for revert:
I believe this CL is causing the IOS Simulator (DBG) bot to fail on gcm_unit_tests:
gcm_unit_tests (iPhone 5s iOS 8.1) gcm_unit_tests (iPhone 5s iOS 8.1) AppNotFoundError: App does not exist: /Volumes/data/b/build/slave/iOS_Simulator__dbg_/build/src/xcodebuild/Debug-iphonesimulator/gcm_unit_tests.app.
Example builder:
https://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_%28dbg%29/builds/25320
Original issue's description:
> Update the list of tests to run on iOS bots
>
> Add all the unit tests for code that is compiled and used on iOS so
> that they are run on iOS bots (waterfall and CQ).
>
> BUG=475512
>
> Committed: https://crrev.com/e4c308a2736e5c80e35b5f9ebaf6f2d31dcd0523
> Cr-Commit-Position: refs/heads/master@{#324624}
TBR=smut@google.com,droger@chromium.org,sdefresne@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=475512
Review URL: https://codereview.chromium.org/1074163003
Cr-Commit-Position: refs/heads/master@{#324635}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When re-paused during the same mouse move (e.g. because of step over)
debugger incorrectly blocked extra mouse move ACK. This happened
due to RenderWidget reporiting "paused in mouse move", while it should
actually report whether ACK was sent.
BUG=475834
Review URL: https://codereview.chromium.org/1060143003
Cr-Commit-Position: refs/heads/master@{#324634}
|
|
|
|
|
|
|
|
| |
BUG=472617, 474370
Review URL: https://codereview.chromium.org/1073783003
Cr-Commit-Position: refs/heads/master@{#324633}
|