| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
SkBitmapDevice. Right now Skia has typedefs redirecting SkBaseDevice and SkBitmapDevice to SkDevice. This CL begins the Chromium-side renaming process in preparation for the real change (https://codereview.chromium.org/22978012/)
BUG=278148
Review URL: https://chromiumcodereview.appspot.com/22796028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219568 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the account chooser or any detail section is clicked while a menu is
already showing from a previous click, the showing menu should be hidden rather
than quickly closed and reshown. This is accomplished by changing the controls
showing the menus to MenuButtons, which Just Work™.
This patch also modifies views::MenuController to better handle showing a menu
under the mouse cursor and wrangles some constants. Releasing the mouse on top
of a menu quickly after showing should now be ignored (based on some simple
heuristics).
R=estade@chromium.org,sadrul@chromium.org,sky@chromium.org
BUG=259553
TEST=menu hides when clicking on opening button
Review URL: https://chromiumcodereview.appspot.com/19272008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219567 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> This will make the WebRTC audio quality test run on Windows.
>
> The test relies on setting up the "stereo mix" output device as the default input device, e.g. that the default microphone records what is being played out on the system. Sound is recorded using SoundRecorder.exe.
>
> R=tommi@chromium.org
> BUG=225698
>
> Review URL: https://chromiumcodereview.appspot.com/23421002
TBR=phoglund@chromium.org
Review URL: https://codereview.chromium.org/23411005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219565 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Provide support for reparenting web contents modal dialogs under Win32
and Aura at the Views level. Reparenting occurs e.g. when dragging the
host tab out of its window while the dialog is displayed. Previously
reparenting was not done at all for Win32.
BUG=274050, 226739, 157161
R=pkotwicz@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/22986017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch adds the assets (png images) of large mouse cursor. Animated cursor will be added by another patch when ready.
BUG=247254
TEST=Enables the large cursor feature with https://codereview.chromium.org/23248008/, and confirm that big cursor icons are shown.
R=sky@chromium.org
Review URL: https://codereview.chromium.org/23072047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219563 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The test relies on setting up the "stereo mix" output device as the default input device, e.g. that the default microphone records what is being played out on the system. Sound is recorded using SoundRecorder.exe.
R=tommi@chromium.org
BUG=225698
Review URL: https://chromiumcodereview.appspot.com/23421002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219561 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To avoid future confusion regarding why PROCESS_DUP_HANDLE access rights
are necessary here. The behavior of DuplicateHandle is given at
http://msdn.microsoft.com/en-us/library/windows/apps/ms724251(v=vs.85).aspx
BUG=none
R=cpu@chromium.org, maruel@chromium.org
Review URL: https://codereview.chromium.org/23389006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219557 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/23155009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219556 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219555 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=jianli@chromium.org,dmazzoni@chormium.org
Review URL: https://codereview.chromium.org/23296009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219554 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
Review URL: https://chromiumcodereview.appspot.com/23258008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219553 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=279267
TBR=jeremy@chromium.org
Review URL: https://codereview.chromium.org/23004023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219552 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219548 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=jianli
Review URL: https://codereview.chromium.org/22999054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/23294006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219543 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
FileSystemURL has enough information to reconstruct the GURL instance,
but there is no utility method.
This adds the method. It will be used to implement, e.g., new file system
private API on Chrome OS.
BUG=278040
TEST=Ran content_unittests
Review URL: https://chromiumcodereview.appspot.com/22891022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219542 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=234181
Review URL: https://chromiumcodereview.appspot.com/22797010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=261628
Review URL: https://chromiumcodereview.appspot.com/22887045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It complicates the logic, may incur wrong overwrite of user operation
in a very rare case, and it doesn't bring much benefit (since we
now very timely update the metadata, refreshing here is not important).
BUG=278139
Review URL: https://chromiumcodereview.appspot.com/23415004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=n/a
TEST=n/a
Review URL: https://chromiumcodereview.appspot.com/23411003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219538 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On iOS and Android, the Clear Browsing Data button is fixed at the bottom
of the screen. When scrolling the list of history entries, the scrollbar
overlaps the button, and when you hit the bottom of the list, the button
overscrolls along with the history entries.
The solution is to add a separate scrolling container that does not overlap
with the Clear Browsing Data button. Unfortunately, this means we lose the
overscroll effect on Android (it no longer supports the -webkit-scrolling
property).
BUG=262219
Review URL: https://chromiumcodereview.appspot.com/23241025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219537 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=272083
Review URL: https://chromiumcodereview.appspot.com/23190038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219536 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
R=pfeldman@chromium.org
Review URL: https://codereview.chromium.org/23402002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219535 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Was getting this error when building forwarder2 on linux system:
../../base/message_loop/message_pump_gtk.cc:94: error:
undefined reference to 'XOpenDisplay'
Adding x11 dependency fixed it locally.
BUG=
Review URL: https://chromiumcodereview.appspot.com/23135014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219534 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
IBusCotrollerBase. This is a step to remove IBusControllerBase.
BUG=279050
Review URL: https://chromiumcodereview.appspot.com/22901033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219533 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=278118
TEST=manual
Review URL: https://chromiumcodereview.appspot.com/23037013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219532 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new GASP-based dashboard doesn't use the old-style expectation files. Hence, we can remove them.
R=kjellander@chromium.org
BUG=
NOTRY=True
Review URL: https://chromiumcodereview.appspot.com/22839021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219531 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
eradicate the discrepancy between find bar text and actual search term we'll always search for current find bar text on Mac. This is correct because find bar updates itself whenever the find pboard changes.
The test strengthened to reproduce the bug.
BUG=272291
TBR=estade@chromium.org
Review URL: https://chromiumcodereview.appspot.com/22796022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219530 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Removing unnecessary ref-countings.
Review URL: https://chromiumcodereview.appspot.com/22678007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219529 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch implements a function to change the asset set of mouse cursor icons, and adds the method of changing the cursor set into CursorManager.
This feature will be used with Large Cursor feature. Currently, it just enlarges the normal cursor assets. This patch makes it use the large-size cursor assets instead. The large assets will be added in an another patch after this patch is committed.
BUG=247254
TEST=manuallly. Tests pass.
Review URL: https://chromiumcodereview.appspot.com/22319004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219528 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219527 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The dependent CLs:
webrtc: https://webrtc-codereview.appspot.com/1966004/
libjingle: http://cl/49270949-p10
BUG=170345
TEST=Try http://apprtc.appspot.com/?debug=loopback on Chromebook Daisy. Play hardware-accelerated video.
Review URL: https://chromiumcodereview.appspot.com/19041006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219526 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=rmistry@google.com
Review URL: https://codereview.chromium.org/23373003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
not used
This issue was caused by a race. The drive metadata may not yet be ready when
filelist.decorateListItem() is called, which often happens with a directory
containing many files. We should lazily update the doc icon when the drive
metadata is ready.
BUG=279049
TEST=see the bug
Review URL: https://chromiumcodereview.appspot.com/23356003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219523 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Along the way, add tests for GetMimeTypesForPaths()
BUG=270469
TEST=none
Review URL: https://chromiumcodereview.appspot.com/22802022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Renamed to FilesGetRequest to reflect the Drive API v2's method name.
Simplify ctor, and moved file_id to setter.
Moved request to google_apis::drive namespace.
Renamed GetFileUrl() to GetFilesGetUrl().
Renamed ParseResourceEntryAndRun() to ConvertFileResourceToResourceEntryAndRun().
BUG=275233, 277253
TEST=Ran unit_tests
Review URL: https://chromiumcodereview.appspot.com/23407003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219521 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is for removing the dependency from c/b/google_apis/ to
the chrome/ directory and move the whole directory content
to more componentized, top-level google_api/ directory.
As discussed in http://crbug.com/146989#c28 - #c30, OAuth2TokenSerive,
which is the last dependency, is in fact written sorely using
google_api/ items and hence itself can easily be moved to there.
BUG=264570, 146989
Review URL: https://chromiumcodereview.appspot.com/23202015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219520 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This saves the app shim from having to look it up using Chrome's bundle
id. This also allows the shim to connect to Chrome processes started by
tests which are not associated with the bundle.
BUG=168080
Review URL: https://chromiumcodereview.appspot.com/22903025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219519 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also make this easier to spot in debug builds.
BUG=262975
TEST=unit_tests still pass.
Review URL: https://chromiumcodereview.appspot.com/21038005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219518 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Added missing OVERRIDEs.
* Made FileSystemTest free from TestingProfile (which also leads to less dependency to file_system_util.h).
* Changed to check the result of SetUpTestFileSystem by ASSER_NO_FAITAL_FAILURE; otherwise, failures in SetUpResourceMetadataAndFileSystem were ignored.
BUG=none
R=hashimoto@chromium.org
Review URL: https://codereview.chromium.org/23409005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219514 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
No functional change; only logging changed a bit.
BUG=NONE
TBR=stevenjb@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23072011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The CheckForUpdates() call rewritten in this CL was no-op,
because it's a newly created ChangeListLoader with is_loaded_ = false.
Clearly this is not what is intended in the test.
BUG=278139
R=hidehiko@chromium.org
Review URL: https://codereview.chromium.org/23418002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Filling the field with a resource ID is quite wrong.
Add another output argument to ConvertToResourceEntry for parent resource ID.
BUG=260514
TEST=unit_tests
R=kinaba@chromium.org
Review URL: https://codereview.chromium.org/23308007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219510 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=163111
TBR=nona@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/23419002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219509 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, both this.volumesList_ and this.pinnedList_ were full-regenerated (creating all object on each refresh) then either model is refreshed.
This patch prevents the full-regeneration and keeps non-deleted items, so only new item created is created on refresh.
This patch shouldn't change no functionality, but improves performance.
BUG=none
TEST=Navigation list works.
R=hirono@chromium.org
Review URL: https://codereview.chromium.org/23070007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219508 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also cleans up work-arounds for Windows' PostMessage macro definition in ChromotingInstance header includes.
BUG=275049
Review URL: https://chromiumcodereview.appspot.com/22923017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219507 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219506 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219505 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DEPS change might fail "steps" on "Android Webview AOSP Builder"
http://build.chromium.org/p/chromium.linux/builders/Android%20Webview%20AOSP%20Builder/builds/1581
http://build.chromium.org/p/chromium.linux/builders/Android%20Webview%20AOSP%20Builder/builds/1580
> Validate varying varibales matching for vertex/fragment shaders.
>
> BUG=249018
> TEST=gpu_unitests, webgl conformance test
> TBR=apatrick@chromium.org
>
> Review URL: https://chromiumcodereview.appspot.com/23125017
TBR=zmo@chromium.org
Review URL: https://codereview.chromium.org/23294005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219504 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=n/a
TEST=n/a
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/23273005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219503 0039d316-1c4b-4281-b951-d872f2087c98
|