summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* views: Make MenuDelegate constructor virtual.thakis@chromium.org2011-06-082-0/+4
| | | | | | | | | | | | | | | This fixes a real bug, because e.g. chrome/browser/chromeos/frame/browser_view.cc has a scoped_ptr<views::MenuDelegate> that it sets to a SimpleMenuModelDelegateAdapter object. (That class ends up not having a destructor and no non-POD members, so it's just a latent bug.) BUG=84424 TEST=none Review URL: http://codereview.chromium.org/7109037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88383 0039d316-1c4b-4281-b951-d872f2087c98
* CrOS - Fix incorrect user certs showing in enterprise Wi-Fi connect dialogjamescook@chromium.org2011-06-081-2/+21
| | | | | | | | | | | Only list user certificates in the TPM in the Wi-Fi connection certificate list, as those are the only ones available via PKCS#11 to flimflam and wpa_supplicant. BUG=chromium-os:16032 TEST=manual, see bug Review URL: http://codereview.chromium.org/7046051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88381 0039d316-1c4b-4281-b951-d872f2087c98
* Search all slots when looking for a key in NSSgspencer@google.com2011-06-083-40/+36
| | | | | | | | | | | This should make it possible to run on a VM, and still find the private key created for the owner in the software slot. BUG=chromium-os:15817 TEST=Built an image and tried it on a VM and a device. Both showed restricted users list. Review URL: http://codereview.chromium.org/7066070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88380 0039d316-1c4b-4281-b951-d872f2087c98
* The benchmarking tool calculates the population variance rather than the ↵leighton@cis.udel.edu2011-06-081-3/+7
| | | | | | | | | | | | | | | | sample variance. Since benchmarking results represent only a sample of the entire population of results, it would be better to calculate the sample standard deviation, which is an unbiased estimator of the population variance. Also, since the Array.avg function throws out the min and max, this function should not be used when calculating the variance. BUG=none TEST=none Review URL: http://codereview.chromium.org/7108006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88379 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Use object_destructInstance() if available.shess@chromium.org2011-06-083-41/+201
| | | | | | | | | | | | | 10.6 added object_destructInstance() as a wrapper around object_cxxDestruct() and also releasing associated objects. As a bonus, it's available via dlsym() rather than nlist(). BUG=82937 TEST=none Review URL: http://codereview.chromium.org/7084017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88378 0039d316-1c4b-4281-b951-d872f2087c98
* Fix errors caught by clang.stevenjb@google.com2011-06-082-5/+1
| | | | | | | | | | | Patch for 88373 (clang errors) BUG=chromium-os:15598 TEST=Clang compile succeeds Review URL: http://codereview.chromium.org/7046055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88377 0039d316-1c4b-4281-b951-d872f2087c98
* Removes RenderViewHostDelegate::GetBrowserWindowID. Instead the placessky@chromium.org2011-06-0817-47/+35
| | | | | | | | | | | | | | that care send the correct message. This change is motivated by wanting to remove SessionID from content. At later cl will remove TabContentsDelegate::RenderViewCreated. BUG=none TEST=none R=jam@chromium.org,mpcomplete@chromium.org Review URL: http://codereview.chromium.org/7046041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88376 0039d316-1c4b-4281-b951-d872f2087c98
* Revert stubs that were added in r88040. We need proper interfaces around ↵jam@chromium.org2011-06-085-225/+9
| | | | | | | | features that need to be compiled out, instead of adding stubs. Review URL: http://codereview.chromium.org/7046052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88374 0039d316-1c4b-4281-b951-d872f2087c98
* Fix window.open() from panels in ChromeOS.stevenjb@google.com2011-06-0815-35/+192
| | | | | | | | | | | This is a regression caused by http://codereview.chromium.org/6881073/ BUG=chromium-os:15598 TEST=Opening a large window using JS window.open from a panel should open a new tab in the parent browser. See issue for repro. Review URL: http://codereview.chromium.org/7101008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88373 0039d316-1c4b-4281-b951-d872f2087c98
* Disable pyauto instant tests on chromium pyauto linux botsnirnimesh@chromium.org2011-06-081-4/+4
| | | | | | | | BUG=85310 TBR= git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88371 0039d316-1c4b-4281-b951-d872f2087c98
* Fix remaining views_unittestsben@chromium.org2011-06-081-12/+12
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88370 0039d316-1c4b-4281-b951-d872f2087c98
* Simplify AlsaPcmOutputStream and AudioManagerLinux. Code was thread-safe, ↵enal@chromium.org2011-06-085-273/+159
| | | | | | | | | | | | | | but now client and audio threads are the same, so we don't need locks/ref counts/etc. http://codereview.chromium.org/7117001 BUG=62588 Review URL: http://codereview.chromium.org/7117001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88369 0039d316-1c4b-4281-b951-d872f2087c98
* file manager: enable context menus in all modesrginda@chromium.org2011-06-081-15/+6
| | | | | | | | | BUG=chromium-os:10766 TEST=manual testing in chromeos-chrome on linux Review URL: http://codereview.chromium.org/7044052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88368 0039d316-1c4b-4281-b951-d872f2087c98
* *Fixup about and chrome scheme URLs in URLFixerUpper::FixupURL.msw@chromium.org2011-06-0844-550/+562
| | | | | | | | | | | | | | | | | | | | | | | | *Update AboutSource to use the source_name of each about/chrome page. *Make WillHandleBrowserAboutURL fix up schemes and handle chrome://foo/ -Redirect memory to memory-redirect (wasn't handling chrome://memory/). -Catalog all kChromeUI*Hosts in url_constants.cc -Simplify paths (credits, os-credits, ipc, settings, about/version). -Nix web_ui_util::ChromeURLHostEquals (use scheme & host comparison). -Favor GURL::SchemeIs and url_constants, update & expand tests. -Add and fixup chrome://chrome-urls (the about:about page). -Update special_tabs.py from Nirnimesh's codereview.chromium.org/6995057/. This change was reverted with r88166 for sync_integration_tests failures. These failures are a tangential issue, crbug.com/85294; I'll re-land this soon. BUG=55771 TEST=Access about:, about://, chrome:, chrome:// pages. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88142 Review URL: http://codereview.chromium.org/7068007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88367 0039d316-1c4b-4281-b951-d872f2087c98
* Fix views_unittests bustage.ben@chromium.org2011-06-081-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88366 0039d316-1c4b-4281-b951-d872f2087c98
* In ChromeDriver, do not use timeouts for automation calls. WebDriver is a ↵hnguyen@chromium.org2011-06-081-0/+3
| | | | | | | | | | | | tool for general purpose testing, and has no notion of timeouts currently. Many users were running into cases where they wanted a longer timeout than the current 25s. BUG=82457 TEST=none Review URL: http://codereview.chromium.org/6995060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88365 0039d316-1c4b-4281-b951-d872f2087c98
* Adding chrome://sessions webui for prototyping tab sync NTP stuff.asvitkine@chromium.org2011-06-0811-0/+591
| | | | | | | | | | | | This adds the necessary plumbing for chrome://sessions webui page which shows a hierarchy of sessions and their windows and tabs as well as a "magic" list of suggested tabs. The magic list is currently just the last 10 tabs by timestamp for now - but can later be changed to prototype other heuristics. BUG=none TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88334 Review URL: http://codereview.chromium.org/6969016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88364 0039d316-1c4b-4281-b951-d872f2087c98
* ui/base/models: Add empty() accessor to TreeNode class.tfarina@chromium.org2011-06-0810-10/+12
| | | | | | | | | | | | | | - Replace all "child_count() == 0" with "empty()". - Change node is-empty check from "child_count() > 0" to "!empty()". BUG=None TEST=None R=sky@chromium.org Review URL: http://codereview.chromium.org/7003039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88363 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ProfileManagerTest.CreateProfileAsync failures on cros.jam@chromium.org2011-06-082-8/+2
| | | | | | | Per Alexey's debugging, the problem was because NotificationUIManager was being deleted after the testing PrefsService has gone away. So when the TestingBrowserProcess is told that PrefsService is going away, destruct the NotificationUIManager then. Review URL: http://codereview.chromium.org/7129009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88362 0039d316-1c4b-4281-b951-d872f2087c98
* Move GeolocationPermissionContextUnittest from subclassing ↵pkasting@chromium.org2011-06-083-67/+68
| | | | | | | | | | | | | | TabContentsWrapper to merely observing infobar removal notifications. (The existing comment about TestTabContents was made obsolete by r85835.) Keeping a set of closed delegates instead of tracking the last closed delegate for each tab seems slightly clearer. Also, back when I first wrote this code in http://codereview.chromium.org/4767001/ , I was convinced it was necessary to the infobar refactor, although I can no longer recall why! This also eliminates TestTabContentsWrapper::SetContentsWrapper(). BUG=62154 TEST=none Review URL: http://codereview.chromium.org/6993030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88360 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bustageben@chromium.org2011-06-081-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88359 0039d316-1c4b-4281-b951-d872f2087c98
* This change includes:imasaki@chromium.org2011-06-081-72/+85
| | | | | | | | | | | * adding -j option for track(caption) testing, * clean up setting CHROME_FLAGS related code * remove the loop for media cache testing and control it directly from commandline using -c option (enable/disable media cache) Review URL: http://codereview.chromium.org/7074060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88358 0039d316-1c4b-4281-b951-d872f2087c98
* Move more from Window onto Widget.ben@chromium.org2011-06-0880-974/+797
| | | | | | | | BUG=72040 TEST=none Review URL: http://codereview.chromium.org/7054052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88356 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Clean up sync loggingakalin@chromium.org2011-06-0820-228/+264
| | | | | | | | | | | | | | | | Add GetDebugName() method to Profile. Use it in ProfileSyncServiceHarness, SyncerThread, and LiveSyncExtensionHelper. Change VLOG(1)s in SyncerThread to VLOG(2)s. Turn on logging for the test server if VLOG is enabled for that file, and not just in general. BUG= TEST= Review URL: http://codereview.chromium.org/7024058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88355 0039d316-1c4b-4281-b951-d872f2087c98
* Don't forget the ffmpeg input buffer padding when allocating a codec'scevans@chromium.org2011-06-081-2/+4
| | | | | | | | | extradata buffer. BUG=82438 Review URL: http://codereview.chromium.org/7137002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88354 0039d316-1c4b-4281-b951-d872f2087c98
* Added license headersmus@chromium.org2011-06-086-10/+19
| | | | | | | | Updated broken screenshot sample to use domain permissions (only works for code.google.com) Review URL: http://codereview.chromium.org/7003059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88353 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 88111 - GTTF: Move --test-terminate-timeout logic to ↵rsimha@chromium.org2011-06-084-5/+16
| | | | | | | | | | | | | | | | | | | | | | | base/test/test_timeouts Reason for revert: This patch causes --test-terminate-timeout to be disregarded by out_of_proc_test_runner.cc, resulting in redness on the sync buildbots. This is the first step towards removing --test-terminate-timeout completely. In this CL --test-terminate-timeout becomes a synonym for --ui-test-action-max-timeout. This makes it possible to switch callers to --ui-test-action-max-timeout and remove --test-terminate-timeout. Removing number of different kinds of timeouts makes it easier to pick one. BUG=none Review URL: http://codereview.chromium.org/7111035 TBR=phajdan.jr@chromium.org Review URL: http://codereview.chromium.org/7104059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88352 0039d316-1c4b-4281-b951-d872f2087c98
* New security-related pyauto tests for Chrome on ChromeOS that verify ↵dennisjeffrey@chromium.org2011-06-082-1/+97
| | | | | | | | | | | extension permissions. BUG=chromium-os:15994 TEST=None Review URL: http://codereview.chromium.org/6969105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88351 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress test failures on mac.estade@chromium.org2011-06-081-0/+9
| | | | | | | | BUG=85387 TEST=tree green TBR=sky,simonjam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88350 0039d316-1c4b-4281-b951-d872f2087c98
* file manager: Prevent [ENTER] from completing the save-as dialog in bad ↵rginda@chromium.org2011-06-081-9/+18
| | | | | | | | | | | | | directories Previous code reset the disabled state of the ok button on-keypress of the filename input text box. This overwrote the fact the the ok button may have been disabled because we're in the / or /media directories. BUG=chromium-os:16276 TEST=manual testing on chromeos-chrome in linux Review URL: http://codereview.chromium.org/7108012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88349 0039d316-1c4b-4281-b951-d872f2087c98
* file manager: clean up rename click detectionrginda@chromium.org2011-06-082-8/+17
| | | | | | | | | | | This patch changes rename click detection so that a user must slow double click on the *same* file. The previous code usually required users to click on the same file, but relied on a side effect of the list control (that clicking on a new file resets the selection), which didn't always work. BUG=chromium-os:16270 TEST=manual testing on chromeos-chrome on linux Review URL: http://codereview.chromium.org/7134004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88348 0039d316-1c4b-4281-b951-d872f2087c98
* Use Delegate method to control context menu and eliminate ↵oshima@google.com2011-06-086-78/+56
| | | | | | | | | | | HtmlDialogWithoutContextMenuView BUG=none TEST=none. no functional change. all test should still pass. Review URL: http://codereview.chromium.org/7124001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88347 0039d316-1c4b-4281-b951-d872f2087c98
* Fix debug crash caused by NetworkChangeNotifierChromeos.rhashimoto@chromium.org2011-06-085-10/+9
| | | | | | | | | | | | | | | - Convert NetworkChangeNotifier::NotifyObserversOfOnlineStateChange() to static. - Remove ScopedRunnableMethodFactory member from NetworkChangeNotifierChromeos. The problem is that ScopedRunnableMethodFactory is not thread-safe, so tasks created by it can only be posted to the current thread. BUG=chromium-os:16197 TEST=none Review URL: http://codereview.chromium.org/7009002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88346 0039d316-1c4b-4281-b951-d872f2087c98
* re-landing after clang fix. clang bot is red due to bus error in linker.oshima@google.com2011-06-087-37/+143
| | | | | | | | | | | | | | | | | | Wait showing html dialog until renderre finish painting after page is loaded. This change keeps track of state transition to make sure we only show the window on the paint after page load. minor change; use gdk's debug paint. Views no longer manage the damaged rect by itself so we can simply use gdk's debug paint. Note to mazda. Please consider adding fade-in animation. I believe it will make it much nicer. BUG=chromium-os:15809 TEST=open keyboard overlay on device. no white flicker should be observed. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88271 Review URL: http://codereview.chromium.org/7024032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88345 0039d316-1c4b-4281-b951-d872f2087c98
* Roll clang 131950:132735thakis@chromium.org2011-06-082-2/+5
| | | | | | | | | | | | | | | | | Notable changes in the range: * r132735 (hopefully) fixes a bug introduced in r131951 that made gold 1.10 crash with /usr/bin/ld: internal error in set_offset, at output.cc:4030 * r132535 fixes the crash at -O3 on mac * r132565 adds a warning for "x + y ? a : b" to -Wparentheses BUG=85289,84424 TEST=none TBR=evan Review URL: http://codereview.chromium.org/7046048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88344 0039d316-1c4b-4281-b951-d872f2087c98
* Delete the download shelf before we destroy the browser in BrowserView.asanka@chromium.org2011-06-081-3/+5
| | | | | | | | | | BUG=84523 TEST=Sending WM_ENDSESSION to the browser while the download shelf is open doesn't crash Review URL: http://codereview.chromium.org/7105026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88343 0039d316-1c4b-4281-b951-d872f2087c98
* [ChromeOS] Add a "hardware-backed" suffix to tpm-backed cert.xiyuan@chromium.org2011-06-081-1/+21
| | | | | | | | | BUG=chromium-os:12302 TEST=Verify fix for chromium-os:12302 Review URL: http://codereview.chromium.org/7111014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88342 0039d316-1c4b-4281-b951-d872f2087c98
* Convert NativeTextFieldViews context menu from Menu2 to MenuItemView.rhashimoto@chromium.org2011-06-083-25/+39
| | | | | | | | | | BUG=chromium-os:13887 TEST=none Review URL: http://codereview.chromium.org/7104013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88340 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for CoreAudio stereo problem for unknown speakersannacc@chromium.org2011-06-081-2/+22
| | | | | | | | | | BUG=85100 TEST=HTML5 videos with stereo channel layout on Mac with unconfigured speakers can be heard. Review URL: http://codereview.chromium.org/7134001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88339 0039d316-1c4b-4281-b951-d872f2087c98
* Minor cleanup in bookmarkbarview. Converts a function that took asky@chromium.org2011-06-082-111/+108
| | | | | | | | | | | | number of arguments to take a struct. BUG=none TEST=none R=ben@chromium.org Review URL: http://codereview.chromium.org/6995058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88338 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Adding chrome://sessions webui for prototyping tab sync NTP stuff."agl@chromium.org2011-06-0811-591/+0
| | | | | | This reverts commit r88334. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88336 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert "net: followup to codereview for cl/7096014""agl@chromium.org2011-06-083-22/+66
| | | | | | | This reverts commit r88333, effectively reapplying r88331. The original failure turned out to be just a flake. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88335 0039d316-1c4b-4281-b951-d872f2087c98
* Adding chrome://sessions webui for prototyping tab sync NTP stuff.asvitkine@chromium.org2011-06-0811-0/+591
| | | | | | | | | | | This adds the necessary plumbing for chrome://sessions webui page which shows a hierarchy of sessions and their windows and tabs as well as a "magic" list of suggested tabs. The magic list is currently just the last 10 tabs by timestamp for now - but can later be changed to prototype other heuristics. BUG=none TEST=manual Review URL: http://codereview.chromium.org/6969016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88334 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "net: followup to codereview for cl/7096014"agl@chromium.org2011-06-083-66/+22
| | | | | | This reverts commit r88331. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88333 0039d316-1c4b-4281-b951-d872f2087c98
* Initial implementation of network screen WebUI handler.avayvod@chromium.org2011-06-0810-51/+196
| | | | | | | | | | R=altimofeev@chromium.org BUG=chromium-os:15923 TEST=Manual Review URL: http://codereview.chromium.org/7121013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88332 0039d316-1c4b-4281-b951-d872f2087c98
* net: followup to codereview for cl/7096014agl@chromium.org2011-06-083-22/+66
| | | | | | | | | BUG=none TEST=net_unittests http://codereview.chromium.org/6993027/ git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88331 0039d316-1c4b-4281-b951-d872f2087c98
* Update .DEPS.gitchrome-admin@google.com2011-06-081-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88330 0039d316-1c4b-4281-b951-d872f2087c98
* Added a test verifying that TimeFormat:: functions convertjoaodasilva@chromium.org2011-06-086-22/+90
| | | | | | | | | | | | | numbers to "NaN" on certain locales. This is a bug on icu. Rolled third_party/icu version to @88321. BUG=60476 TEST=browser_tests:TimeFormat.DecimalPointNotDot Review URL: http://codereview.chromium.org/7003028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88329 0039d316-1c4b-4281-b951-d872f2087c98
* Landing http://codereview.chromium.org/7033062/:glider@chromium.org2011-06-0813-22/+23
| | | | | | | Replaced ptrdiff_t with std::ptrdiff_t in all files. Review URL: http://codereview.chromium.org/7046043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88328 0039d316-1c4b-4281-b951-d872f2087c98
* Plumbing: Cache the resize callback so that we can call it later.backer@chromium.org2011-06-082-1/+15
| | | | | | | | | | | I am working towards having two surfaces that the GpuScheduler alternates between on SwapBuffers. Each surface should be resized once it is the backbuffer (via SwapBuffers). By caching the resize callback, I can (a) resize of the backbuffer immediately when the callback is initiated from the GLES2Decoder and (b) resize the frontbuffer once it becomes the backbuffer after a SwapBuffers. BUG=none TEST=none (should be no-op on all platforms) Review URL: http://codereview.chromium.org/6982060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88327 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-13 01:13:02 +0000