summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Disable Instant field trial when suggest has been disabled.sreeram@chromium.org2011-08-061-0/+1
| | | | | | | | | | | | | | | | | | | | | When suggest has been disabled, omnibox text is not sent to the default search engine. Instant's field trial should also be disabled in such a case, to avoid sending the omnibox text due to Instant. Note that if the Instant experiment has already been enabled, and *then* the user disables suggest, this won't disable the experiment immediately (since we don't listen for changes to prefs::kSuggestEnabled). Instead, it will be disabled at the next opportunity (some Instant pref changing, browser restart, etc). I think this is acceptable since, if the user is fiddling with preferences after Instant has been enabled, they can already click the Instant checkbox to turn it off. BUG=91730 TEST=Disable suggest. Verify that the Instant field trial doesn't get enabled. Review URL: http://codereview.chromium.org/7578014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95723 0039d316-1c4b-4281-b951-d872f2087c98
* Fix print preview draft page memory leaks.vandebo@chromium.org2011-08-063-15/+16
| | | | | | | | | | BUG=91862 TEST=NONE Review URL: http://codereview.chromium.org/7585012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95722 0039d316-1c4b-4281-b951-d872f2087c98
* Fix prerenders in the delete list not being returned bymmenke@chromium.org2011-08-061-1/+1
| | | | | | | | | | | | | | PrerenderManager::GetAsValue(). NetInternalsTest.NetInternalsPrerenderView expects to always see the prerender as active or in the history, once started. BUG=91799 TEST=NetInternalsTest.NetInternalsPrerenderView (Currently flaky) Review URL: http://codereview.chromium.org/7550031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95721 0039d316-1c4b-4281-b951-d872f2087c98
* Disabled a Password test failing on Win XPpucchakayala@chromium.org2011-08-061-0/+2
| | | | | | | | | | | passwords.PasswordTest.testInfoBarDisappearByNavigatingPage BUG=91887 Test=Run above Review URL: http://codereview.chromium.org/7583020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95720 0039d316-1c4b-4281-b951-d872f2087c98
* Video Capture Pepper APIpiman@chromium.org2011-08-0623-2/+783
| | | | | | | | | | | | The API is very simple at this point but works end-to-end. BUG=None TEST=VideoCapture sample (in a later CL) Review URL: http://codereview.chromium.org/7553003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95719 0039d316-1c4b-4281-b951-d872f2087c98
* - Added another class 'EnterpriseTestSetTwo'to test another set of policy ↵aocampo@chromium.org2011-08-062-2/+265
| | | | | | | | | | | | values. - Modified enterprise_helper_linux script to handle changing file permissions for multiple json files. BUG=NONE Review URL: http://codereview.chromium.org/7453062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95718 0039d316-1c4b-4281-b951-d872f2087c98
* Windows Breakpad: Allow the crash dump dir and pipe name to be overriddenmseaborn@chromium.org2011-08-063-9/+34
| | | | | | | | | | | | | | | | | | | | | | Change crash_service.exe so that the named pipe it listens on (normally global) and the directory it writes to (normally per-user) can both be overridden via command line options. Similarly, add an environment variable to Chromium for connecting to crash_service.exe via a non-default named pipe. This will allow automated tests of Chromium's Breakpad crash reporting to be more robust. A test runner can use a temp dir for crashes and a temporary named pipe, so that it does not have to worry about pre-existing instances of crash_service.exe or pre-existing dump files. BUG=http://code.google.com/p/nativeclient/issues/detail?id=2006 TEST=inbrowser_crash_test in the NaCl tree, with the change http://codereview.chromium.org/7569002 Review URL: http://codereview.chromium.org/7538036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95714 0039d316-1c4b-4281-b951-d872f2087c98
* Leaks in HTMLMediaElementdhollowa@chromium.org2011-08-061-0/+72
| | | | | | | | | | | | Adds suppressions for leaks related to HTMLMediaElement. Seems to have been introduced in r95685. BUG=91896 TEST=HeapCheck bot turns green. TBR=scottfr@chromium.org Review URL: http://codereview.chromium.org/7491075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95713 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of app/ directory as it's no longer used (finally).tfarina@chromium.org2011-08-063-76/+0
| | | | | | | | | | | BUG=72317 TEST=None R=tony@chromium.org Review URL: http://codereview.chromium.org/7491072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95711 0039d316-1c4b-4281-b951-d872f2087c98
* Initial version of web intents registrygroby@chromium.org2011-08-067-9/+278
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/7511005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95710 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk: fix GTK_TYPE_PERSERVE_WINDOW typo.mattm@chromium.org2011-08-061-1/+1
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/7569003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95709 0039d316-1c4b-4281-b951-d872f2087c98
* mac: Window buttons should keep "active" view when bubbles / tabpose are ↵thakis@chromium.org2011-08-062-0/+12
| | | | | | | | | | | | | | | | | | | | | | open on 10.7 This matches the behavior of NSPopover. This is done by overriding the SPI _sharesParentKeyState, which works on 10.7 but not on 10.6. If we want to get this right on 10.6, we could use the SPI described in http://code.google.com/p/chromium/issues/detail?id=44087#c42 , but since we didn't feel we need this until now, we can probably live with this being 10.7-only. I do need this functionality for the history-swipe-overlay. BUG=none TEST=Click e.g. bookmark star. Bookmark bubble should appear, browser window close button should still look active. Review URL: http://codereview.chromium.org/7585013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95708 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 95703 - Disabled an extension test that was failing across all platforms.nirnimesh@chromium.org2011-08-061-2/+0
| | | | | | | | | | | | | | extensions.ExtensionsTest.testSetExtensionStates BUG=91764 TEST=Run above Tests Review URL: http://codereview.chromium.org/7572045 TBR=pucchakayala@chromium.org Review URL: http://codereview.chromium.org/7550054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95707 0039d316-1c4b-4281-b951-d872f2087c98
* Leak with INIT_AppleEvents on Macdhollowa@chromium.org2011-08-061-0/+21
| | | | | | | | | | | | Suppresses leak reports on Mac Valgrind. BUG=91892 TEST=Valgrind Mac bot turns green. TBR=rsesek@chromium.org Review URL: http://codereview.chromium.org/7569026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95706 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 95698 - Implement touch selection for RWHVV.yzshen@chromium.org2011-08-0612-123/+18
| | | | | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/7570001 TBR=varunjain@chromium.org Review URL: http://codereview.chromium.org/7584021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95705 0039d316-1c4b-4281-b951-d872f2087c98
* Add origins to the extension permissions API.jstritar@chromium.org2011-08-0614-214/+510
| | | | | | | | | | BUG=48119,84507 TEST=*Extension* Review URL: http://codereview.chromium.org/7508029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95704 0039d316-1c4b-4281-b951-d872f2087c98
* Disabled an extension test that was failing across all platforms.pucchakayala@chromium.org2011-08-061-0/+2
| | | | | | | | | | | extensions.ExtensionsTest.testSetExtensionStates BUG=91764 TEST=Run above Tests Review URL: http://codereview.chromium.org/7572045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95703 0039d316-1c4b-4281-b951-d872f2087c98
* Make TabContentsView implementations use OVERRIDEevan@chromium.org2011-08-063-40/+42
| | | | | | | | | I want to change a function prototype and I'm scared of getting it wrong in a subclass. Review URL: http://codereview.chromium.org/7569022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95702 0039d316-1c4b-4281-b951-d872f2087c98
* Fix typo in SelectRect().xji@google.com2011-08-061-1/+1
| | | | | | | TEST=build with touchui=1, drag selection handles. Review URL: http://codereview.chromium.org/7569024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95701 0039d316-1c4b-4281-b951-d872f2087c98
* Leaks / Memory access violation in GPU list on Macdhollowa@chromium.org2011-08-061-0/+51
| | | | | | | | | | | | Suppresses memory access violations on GPU Valgrind Mac. BUG=91889 TEST=Valgrind bots turn green on Mac. TBR=thakis@chromium.org Review URL: http://codereview.chromium.org/7582023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95699 0039d316-1c4b-4281-b951-d872f2087c98
* Implement touch selection for RWHVV.varunjain@chromium.org2011-08-0612-18/+123
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/7570001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95698 0039d316-1c4b-4281-b951-d872f2087c98
* Fix DCHECK in P2PSocketClient.sergeyu@chromium.org2011-08-063-11/+9
| | | | | | | | | | | P2PSocketClient may DCHECK in Close() if Close() is called immediately after Init() because delegate_message_loop_ is initialized on the IPC thread. Initialize it in the constructor instead. BUG=None TEST=None Review URL: http://codereview.chromium.org/7584011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95697 0039d316-1c4b-4281-b951-d872f2087c98
* Add beforeUnload handler to confirm exit.jamiewalch@google.com2011-08-063-3/+39
| | | | | | | | | BUG=91835 TEST=Close the window at various points and check that you are prompted (or not) according to whether or not there is a connection pending or in progress. Review URL: http://codereview.chromium.org/7583018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95696 0039d316-1c4b-4281-b951-d872f2087c98
* Removing outline from language list.dbeam@chromium.org2011-08-061-0/+1
| | | | | | | | | | | BUG=77730 TEST=browse to chrome://settings/languages, click on a language and verify no outline on whole list R=estade@chromium.org Review URL: http://codereview.chromium.org/7460013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95695 0039d316-1c4b-4281-b951-d872f2087c98
* [ChromeOS] Make WebUILoginView play nicer with focus.xiyuan@chromium.org2011-08-062-0/+8
| | | | | | | | | | | | - RequestFocus in LoadURL so that WebUILoginView is focused after window creation; - Override TabContentsDelegate::TakeFocus and forward the focus back to web contents; This gets rid of the mysterious tab stop; BUG=chromium-os:18466 TEST=Verify fix for chromium-os:18466. Review URL: http://codereview.chromium.org/7506004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95694 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Fix encryption/passphrase handling.zea@chromium.org2011-08-066-78/+153
| | | | | | | | | | | | | | | | | We now ensure cached passphrases are always used. In addition, encryption now happens after configuration, allowing us to make use of the pending_encrypted_types to know if we're waiting for encryption (which affects how we prompt for passphrase). This is dependent on sync_setup_flow.cc always calling EncryptDataTypes before configuring the new datatypes and setting pending_encrypted_types_ appropriately, which then gets consumed on SYNC_CONFIGURE_DONE. BUG=91314 TEST=see bug Review URL: http://codereview.chromium.org/7551024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95693 0039d316-1c4b-4281-b951-d872f2087c98
* Disable SSLUITest.TestRefNavigation on chromiumos.yzshen@chromium.org2011-08-061-2/+2
| | | | | | | | | | TBR=apatrick@chromium.org BUG=84419 TEST=None Review URL: http://codereview.chromium.org/7583019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95692 0039d316-1c4b-4281-b951-d872f2087c98
* Improve IndexedDB's quota supportdgrogan@chromium.org2011-08-0511-45/+342
| | | | | | | | | | | | | * Check available quota before storing anything * Inform quota manager of storage updates * Evict an origin when quota manager requests BUG=83652 TEST=llvm/Debug/unit_tests --gtest_filter=IndexedDBQuotaClientTest.* && llvm/Debug/browser_tests --gtest_filter=IndexedDBBrowser* Review URL: http://codereview.chromium.org/7470008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95691 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some egregious bugs in Var.brettw@chromium.org2011-08-054-13/+27
| | | | | | | | | | | | | | | | Self-assignment was broken and would lose the reference. I uncovered this when running a test. It outputted a warning to the console, but we never looked at it. I made a more explicit test. This also fixes output exceptions. The OutException helper class detected whether the existing object had an exception or not incorrectly. This was exposed when var assignment was fixed. TEST=included BUG=none Review URL: http://codereview.chromium.org/7511026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95690 0039d316-1c4b-4281-b951-d872f2087c98
* Remeber active tab in tab bar instead of 'this'.xiyuan@chromium.org2011-08-051-4/+12
| | | | | | | | | | | OptionsPage.showTab could be called with wrong 'this' so remember activeNavTab in parent tab bar instead. BUG=chromium-os:18662 TEST=Verify fix for chromium-os:18662. Review URL: http://codereview.chromium.org/7572047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95689 0039d316-1c4b-4281-b951-d872f2087c98
* Always call the class methods to save/restore contexts.avi@chromium.org2011-08-058-99/+119
| | | | | | | | | | | | | | | If the current context was ever nil, sending a "restore" message would be a no-op and would likely leave an out-of-scope context as current. BUG=90140 TEST=repeatedly select items in an open file dialog in column mode; no crash Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95611 Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=95631 Review URL: http://codereview.chromium.org/7572031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95686 0039d316-1c4b-4281-b951-d872f2087c98
* Plumb media data from renderers up to MediaInternals in the browser process.scottfr@chromium.org2011-08-0521-6/+300
| | | | | | | | | | | Relanding 95542. Reverted due to issue caused by 95496. BUG=none TEST=manually Review URL: http://codereview.chromium.org/7480032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95685 0039d316-1c4b-4281-b951-d872f2087c98
* Remove +x from HTML files.evan@chromium.org2011-08-052-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95684 0039d316-1c4b-4281-b951-d872f2087c98
* Leaks in BrowserAccessibilityManagerdhollowa@chromium.org2011-08-051-1/+9
| | | | | | | | | | | Suppresses leaks introduced with r95572 related to BrowserAccessibilityManager. More suppressions. BUG=91845 TEST=Valgrind and HeapCheck bots turn green. Review URL: http://codereview.chromium.org/7582021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95683 0039d316-1c4b-4281-b951-d872f2087c98
* Add Remoting webapp to chrome_official_builder target.lambroslambrou@chromium.org2011-08-051-0/+1
| | | | | | | | | BUG=87632 TEST=Official Windows Chrome logs show Remoting webapp being built. Review URL: http://codereview.chromium.org/7461144 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95682 0039d316-1c4b-4281-b951-d872f2087c98
* Add OWNERS file for chromedriver.kkania@chromium.org2011-08-051-0/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/7582006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95681 0039d316-1c4b-4281-b951-d872f2087c98
* wstring: remove wstrings from ChildProcessInfoevan@chromium.org2011-08-0514-32/+35
| | | | | | | | | Convert MetricsServices' child_process_stats_buffer_ while I'm at it. Review URL: http://codereview.chromium.org/7583016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95680 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Avoid leaking in WeakHandle even when the owner thread is goneakalin@chromium.org2011-08-055-75/+205
| | | | | | | | | | | | | Destroy the underlying WeakPtr right before the owner thread is destroyed. Remove suppression for the leak in the bug. BUG=91465 TEST= Review URL: http://codereview.chromium.org/7572010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95679 0039d316-1c4b-4281-b951-d872f2087c98
* ipc: remove an unused function prototypeevan@chromium.org2011-08-051-5/+0
| | | | | | Review URL: http://codereview.chromium.org/7541054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95678 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Use gtk_dialog_get_content_area() throughout.tfarina@chromium.org2011-08-0513-20/+24
| | | | | | | | | | | BUG=None TEST=None R=tony@chromium.org Review URL: http://codereview.chromium.org/7569012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95677 0039d316-1c4b-4281-b951-d872f2087c98
* Add a browsertest for magic iframe.dimich@chromium.org2011-08-055-0/+147
| | | | | | | | | | The test verifies that in-progress XHR is still loading after transfer. BUG=55200 Review URL: http://codereview.chromium.org/7550021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95676 0039d316-1c4b-4281-b951-d872f2087c98
* Session/tab sync performance tests.braffert@chromium.org2011-08-054-16/+174
| | | | | | | | | | | This patch adds tab sync performance tests, similar to the tests for the existing datatypes in live_sync/performance. Changes to LiveSessionsSyncTest were required - most significantly the addition of AwaitSessionPropagation, which waits until a vector of urls can all be found in the model associator. This type of wait loop previously existed as part of OpenTab, and worked with a single url. AwaitSessionPropagation supports multiple urls, and is called from OpenTab, OpenMultipleTabs, and SessionsSyncPerfTest::UpdateTabs. BUG=none TEST=sync_performance_tests, sync_integration_tests Review URL: http://codereview.chromium.org/7575026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95675 0039d316-1c4b-4281-b951-d872f2087c98
* Update .DEPS.gitchrome-admin@google.com2011-08-051-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95674 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit Roll 92465:92488jianli@chromium.org2011-08-051-1/+1
| | | | | | | | | BUG=none TEST=none TBR=andreip Review URL: http://codereview.chromium.org/7550044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95673 0039d316-1c4b-4281-b951-d872f2087c98
* Update .DEPS.gitchrome-admin@google.com2011-08-051-3/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95672 0039d316-1c4b-4281-b951-d872f2087c98
* Roll skia 2034->2051.vandebo@chromium.org2011-08-051-1/+1
| | | | | | | | | | | Whitespace change: http://codereview.chromium.org/7576017 BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/7575020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95671 0039d316-1c4b-4281-b951-d872f2087c98
* Sync performance tests: append underscore to private variable names.braffert@chromium.org2011-08-052-9/+9
| | | | | | | | | BUG=none TEST=sync_performance_tests Review URL: http://codereview.chromium.org/7541052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95670 0039d316-1c4b-4281-b951-d872f2087c98
* Add unit test for the javascript: URL blocking code.tsepez@chromium.org2011-08-052-0/+29
| | | | | | | | BUG=91851 TEST=unit_tests:OmniboxView.* Review URL: http://codereview.chromium.org/7585016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95669 0039d316-1c4b-4281-b951-d872f2087c98
* Properly scope ScopedPlatformPaint so that the native drawing layer and Skia ↵dcheng@chromium.org2011-08-053-32/+63
| | | | | | | | | | | are in agreement on the state of the pixels. Also fix Windows to not return completely transparent bitmaps when the source image has color depth < 32 bpp. BUG=86085 TEST=Copy an image from MS Paint and paste it into Gmail using 32bpp for the display color depth. Review URL: http://codereview.chromium.org/7471008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95668 0039d316-1c4b-4281-b951-d872f2087c98
* Convert HtmlDialogUIDelegate::GetDialogTitle() to string16.tony@chromium.org2011-08-0530-147/+160
| | | | | | | | | | | | | Also sprinkle in some OVERRIDEs. It's not strictly necessary in this case since it's a pure virtual method, but it doesn't hurt and may help for future refactorings. BUG=23581 Review URL: http://codereview.chromium.org/7461136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95665 0039d316-1c4b-4281-b951-d872f2087c98