| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When suggest has been disabled, omnibox text is not sent to the default search
engine. Instant's field trial should also be disabled in such a case, to avoid
sending the omnibox text due to Instant.
Note that if the Instant experiment has already been enabled, and *then* the
user disables suggest, this won't disable the experiment immediately (since we
don't listen for changes to prefs::kSuggestEnabled). Instead, it will be
disabled at the next opportunity (some Instant pref changing, browser restart,
etc). I think this is acceptable since, if the user is fiddling with
preferences after Instant has been enabled, they can already click the Instant
checkbox to turn it off.
BUG=91730
TEST=Disable suggest. Verify that the Instant field trial doesn't get enabled.
Review URL: http://codereview.chromium.org/7578014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=91862
TEST=NONE
Review URL: http://codereview.chromium.org/7585012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PrerenderManager::GetAsValue().
NetInternalsTest.NetInternalsPrerenderView expects to always
see the prerender as active or in the history, once started.
BUG=91799
TEST=NetInternalsTest.NetInternalsPrerenderView (Currently flaky)
Review URL: http://codereview.chromium.org/7550031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95721 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
passwords.PasswordTest.testInfoBarDisappearByNavigatingPage
BUG=91887
Test=Run above
Review URL: http://codereview.chromium.org/7583020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The API is very simple at this point but works end-to-end.
BUG=None
TEST=VideoCapture sample (in a later CL)
Review URL: http://codereview.chromium.org/7553003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
values.
- Modified enterprise_helper_linux script to handle changing file permissions for multiple json files.
BUG=NONE
Review URL: http://codereview.chromium.org/7453062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change crash_service.exe so that the named pipe it listens on
(normally global) and the directory it writes to (normally per-user)
can both be overridden via command line options.
Similarly, add an environment variable to Chromium for connecting to
crash_service.exe via a non-default named pipe.
This will allow automated tests of Chromium's Breakpad crash reporting
to be more robust. A test runner can use a temp dir for crashes and a
temporary named pipe, so that it does not have to worry about
pre-existing instances of crash_service.exe or pre-existing dump
files.
BUG=http://code.google.com/p/nativeclient/issues/detail?id=2006
TEST=inbrowser_crash_test in the NaCl tree, with the change http://codereview.chromium.org/7569002
Review URL: http://codereview.chromium.org/7538036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds suppressions for leaks related to HTMLMediaElement. Seems to have been introduced in r95685.
BUG=91896
TEST=HeapCheck bot turns green.
TBR=scottfr@chromium.org
Review URL: http://codereview.chromium.org/7491075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=72317
TEST=None
R=tony@chromium.org
Review URL: http://codereview.chromium.org/7491072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7511005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7569003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
open on 10.7
This matches the behavior of NSPopover.
This is done by overriding the SPI _sharesParentKeyState, which works on 10.7 but
not on 10.6. If we want to get this right on 10.6, we could use the SPI described
in http://code.google.com/p/chromium/issues/detail?id=44087#c42 , but since we
didn't feel we need this until now, we can probably live with this being 10.7-only.
I do need this functionality for the history-swipe-overlay.
BUG=none
TEST=Click e.g. bookmark star. Bookmark bubble should appear, browser window close
button should still look active.
Review URL: http://codereview.chromium.org/7585013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
extensions.ExtensionsTest.testSetExtensionStates
BUG=91764
TEST=Run above Tests
Review URL: http://codereview.chromium.org/7572045
TBR=pucchakayala@chromium.org
Review URL: http://codereview.chromium.org/7550054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Suppresses leak reports on Mac Valgrind.
BUG=91892
TEST=Valgrind Mac bot turns green.
TBR=rsesek@chromium.org
Review URL: http://codereview.chromium.org/7569026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7570001
TBR=varunjain@chromium.org
Review URL: http://codereview.chromium.org/7584021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=48119,84507
TEST=*Extension*
Review URL: http://codereview.chromium.org/7508029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95704 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
extensions.ExtensionsTest.testSetExtensionStates
BUG=91764
TEST=Run above Tests
Review URL: http://codereview.chromium.org/7572045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
I want to change a function prototype and I'm scared of getting
it wrong in a subclass.
Review URL: http://codereview.chromium.org/7569022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TEST=build with touchui=1, drag selection handles.
Review URL: http://codereview.chromium.org/7569024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95701 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Suppresses memory access violations on GPU Valgrind Mac.
BUG=91889
TEST=Valgrind bots turn green on Mac.
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/7582023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7570001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
P2PSocketClient may DCHECK in Close() if Close() is called immediately after Init() because delegate_message_loop_ is initialized on the IPC thread. Initialize it in the constructor instead.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/7584011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95697 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=91835
TEST=Close the window at various points and check that you are prompted (or not) according to whether or not there is a connection pending or in progress.
Review URL: http://codereview.chromium.org/7583018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=77730
TEST=browse to chrome://settings/languages, click on a language and verify no outline on whole list
R=estade@chromium.org
Review URL: http://codereview.chromium.org/7460013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- RequestFocus in LoadURL so that WebUILoginView is focused after window creation;
- Override TabContentsDelegate::TakeFocus and forward the focus back to web contents; This gets rid of the mysterious tab stop;
BUG=chromium-os:18466
TEST=Verify fix for chromium-os:18466.
Review URL: http://codereview.chromium.org/7506004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95694 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We now ensure cached passphrases are always used. In addition, encryption now
happens after configuration, allowing us to make use of the
pending_encrypted_types to know if we're waiting for encryption (which
affects how we prompt for passphrase). This is dependent on sync_setup_flow.cc
always calling EncryptDataTypes before configuring the new datatypes and setting
pending_encrypted_types_ appropriately, which then gets consumed on
SYNC_CONFIGURE_DONE.
BUG=91314
TEST=see bug
Review URL: http://codereview.chromium.org/7551024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95693 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=apatrick@chromium.org
BUG=84419
TEST=None
Review URL: http://codereview.chromium.org/7583019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Check available quota before storing anything
* Inform quota manager of storage updates
* Evict an origin when quota manager requests
BUG=83652
TEST=llvm/Debug/unit_tests --gtest_filter=IndexedDBQuotaClientTest.* && llvm/Debug/browser_tests --gtest_filter=IndexedDBBrowser*
Review URL: http://codereview.chromium.org/7470008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Self-assignment was broken and would lose the reference. I uncovered this when
running a test. It outputted a warning to the console, but we never looked at
it. I made a more explicit test.
This also fixes output exceptions. The OutException helper class detected
whether the existing object had an exception or not incorrectly. This was
exposed when var assignment was fixed.
TEST=included
BUG=none
Review URL: http://codereview.chromium.org/7511026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
OptionsPage.showTab could be called with wrong 'this' so remember activeNavTab in parent tab bar instead.
BUG=chromium-os:18662
TEST=Verify fix for chromium-os:18662.
Review URL: http://codereview.chromium.org/7572047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the current context was ever nil, sending a "restore" message would be a no-op and would likely leave an out-of-scope context as current.
BUG=90140
TEST=repeatedly select items in an open file dialog in column mode; no crash
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95611
Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=95631
Review URL: http://codereview.chromium.org/7572031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95686 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Relanding 95542. Reverted due to issue caused by 95496.
BUG=none
TEST=manually
Review URL: http://codereview.chromium.org/7480032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95685 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95684 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Suppresses leaks introduced with r95572 related to BrowserAccessibilityManager. More suppressions.
BUG=91845
TEST=Valgrind and HeapCheck bots turn green.
Review URL: http://codereview.chromium.org/7582021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=87632
TEST=Official Windows Chrome logs show Remoting webapp being built.
Review URL: http://codereview.chromium.org/7461144
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7582006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Convert MetricsServices' child_process_stats_buffer_ while
I'm at it.
Review URL: http://codereview.chromium.org/7583016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Destroy the underlying WeakPtr right before the owner thread is destroyed.
Remove suppression for the leak in the bug.
BUG=91465
TEST=
Review URL: http://codereview.chromium.org/7572010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95679 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7541054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95678 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
R=tony@chromium.org
Review URL: http://codereview.chromium.org/7569012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95677 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The test verifies that in-progress XHR is still loading after transfer.
BUG=55200
Review URL: http://codereview.chromium.org/7550021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95676 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This patch adds tab sync performance tests, similar to the tests for the existing datatypes in live_sync/performance. Changes to LiveSessionsSyncTest were required - most significantly the addition of AwaitSessionPropagation, which waits until a vector of urls can all be found in the model associator. This type of wait loop previously existed as part of OpenTab, and worked with a single url. AwaitSessionPropagation supports multiple urls, and is called from OpenTab, OpenMultipleTabs, and SessionsSyncPerfTest::UpdateTabs.
BUG=none
TEST=sync_performance_tests, sync_integration_tests
Review URL: http://codereview.chromium.org/7575026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95674 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=andreip
Review URL: http://codereview.chromium.org/7550044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95673 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Whitespace change: http://codereview.chromium.org/7576017
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/7575020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=sync_performance_tests
Review URL: http://codereview.chromium.org/7541052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95670 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=91851
TEST=unit_tests:OmniboxView.*
Review URL: http://codereview.chromium.org/7585016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
are in agreement on the state of the pixels. Also fix Windows to not return completely transparent bitmaps when the source image has color depth < 32 bpp.
BUG=86085
TEST=Copy an image from MS Paint and paste it into Gmail using 32bpp for the display color depth.
Review URL: http://codereview.chromium.org/7471008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also sprinkle in some OVERRIDEs. It's not strictly necessary in this
case since it's a pure virtual method, but it doesn't hurt and may help
for future refactorings.
BUG=23581
Review URL: http://codereview.chromium.org/7461136
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95665 0039d316-1c4b-4281-b951-d872f2087c98
|