summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Change UTF8ToUTF16 to accept const StringPiece&.suzhe@google.com2011-01-2825-42/+57
| | | | | | | | | BUG=70936 TEST=All unit tests should pass. Review URL: http://codereview.chromium.org/6317016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72921 0039d316-1c4b-4281-b951-d872f2087c98
* Hitting Tab should always move cursor to end of omnibox text.suzhe@google.com2011-01-2823-170/+322
| | | | | | | | | BUG=66850 TEST=AutocompleteEditViewTest.TabMoveCursorToEnd and InstantTest.TabKey Review URL: http://codereview.chromium.org/5966006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72920 0039d316-1c4b-4281-b951-d872f2087c98
* Memory leak on ChromeOS in BrowserSessionRestoredhollowa@chromium.org2011-01-281-0/+13
| | | | | | | | | | | | Adds a Valgrind suppression for BrowserSessionRestore BUG=71152 TEST=ChromeOS memory bot goes green TBR=zea@chromium.org Review URL: http://codereview.chromium.org/6405001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72919 0039d316-1c4b-4281-b951-d872f2087c98
* For networks without any strenght info, we should show 0 bars as oppose to 1 ↵chocobo@chromium.org2011-01-281-3/+7
| | | | | | | | | | bar. BUG=chromium-os:10715 TEST=connect to other network and see that the network icon has no bars. Review URL: http://codereview.chromium.org/6240016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72918 0039d316-1c4b-4281-b951-d872f2087c98
* Rename WebNavigationObserver to TabContentsObserver.jam@chromium.org2011-01-2815-78/+64
| | | | | | Review URL: http://codereview.chromium.org/6404001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72916 0039d316-1c4b-4281-b951-d872f2087c98
* Fix regression from r11816 where we looked up a request from its request_id ↵jam@chromium.org2011-01-287-16/+16
| | | | | | | | | instead of request_context. BUG=68766 Review URL: http://codereview.chromium.org/6309022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72915 0039d316-1c4b-4281-b951-d872f2087c98
* Roll WebKit 76810:76820rniwa@chromium.org2011-01-281-1/+1
| | | | | | | TRB=yurys Review URL: http://codereview.chromium.org/6315018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72914 0039d316-1c4b-4281-b951-d872f2087c98
* PPAPI: move GLES2Implementation to PPAPI gluepiman@google.com2011-01-289-72/+152
| | | | | | | | | | | | | | This is in preparation for the proxy for the 3D interface. In the proxy case, we can't have the renderer access the command buffer directly, so we move the command buffer helper instantiation there. A follow-up CL will make that instantiation optional. BUG=none TEST=pepper flash Review URL: http://codereview.chromium.org/6293023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72913 0039d316-1c4b-4281-b951-d872f2087c98
* views: Make ShouldUseVistaFrame a static method of WidgetWin.tfarina@chromium.org2011-01-2812-38/+40
| | | | | | | | | | | Move it from hwnd_util.[cc,h] to widget_win.h and rename to IsAeroGlassEnabled. BUG=70143 TEST=trybots Review URL: http://codereview.chromium.org/6348019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72912 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the routing id parameter from the desktop notification IPCs sent by ↵ananta@chromium.org2011-01-286-24/+17
| | | | | | | | | | | | | the renderer. We can retrieve the routing id from the message. BUG=70690 TEST=no change in functionality. Review URL: http://codereview.chromium.org/6299022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72911 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 72877 - Make BookmarkModelVerifier wait for favicons to load before ↵rsimha@chromium.org2011-01-283-50/+8
| | | | | | | | | | | | | | | | | | | | | | | | extracting them Reason for revert: Favicon sync test is still flaky on the buildbots. The test case for bookmark favicon sync was failing in its verification step because GetFavicon sometimes returned a blank favicon for a URL. This was because GetFavicon can be asynchronous if the favicon of a bookmark node is not already loaded. This patch modifies the method that compares favicons, and takes care of cases where the favicon has not yet loaded by adding a conditional wait. BUG=69694 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/6347016 TBR=rsimha@chromium.org Review URL: http://codereview.chromium.org/6359017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72910 0039d316-1c4b-4281-b951-d872f2087c98
* Reverted suppressions for 70782.ahendrickson@chromium.org2011-01-281-0/+13
| | | | | | | | | BUG=70782 TEST=Valgrind Review URL: http://codereview.chromium.org/6274019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72909 0039d316-1c4b-4281-b951-d872f2087c98
* Roll gtm 425:427thakis@chromium.org2011-01-281-1/+1
| | | | | | | | | | | r426 is a wiki edit r427 picks up a fix for a new clang warning BUG=none TEST=none TBR=motownavi git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72908 0039d316-1c4b-4281-b951-d872f2087c98
* linux: Avoid crash on right-click in omnibox with empty clipboard.derat@chromium.org2011-01-281-1/+1
| | | | | | | | | | | | gtk_clipboard_wait_for_text() returns NULL if the clipboard is empty, and we were blindly dereferencing its return value. BUG=71104 TEST=right-clicked in omnibox and got a menu instead of a browser crash Review URL: http://codereview.chromium.org/6388007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72907 0039d316-1c4b-4281-b951-d872f2087c98
* Remove ChromeURLRequestContext::IsExternal().willchan@chromium.org2011-01-284-41/+15
| | | | | | | | | | | It doesn't appear to be used anywhere. BUG=68766 TEST=none Review URL: http://codereview.chromium.org/6273018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72906 0039d316-1c4b-4281-b951-d872f2087c98
* Disable LoginPromptBrowserTest.IncorrectConfirmationcbentzel@chromium.org2011-01-281-1/+1
| | | | | | | | | BUG=69266 TEST=None Review URL: http://codereview.chromium.org/6401005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72904 0039d316-1c4b-4281-b951-d872f2087c98
* DOMUI: Fix nits from UI review.stuartmorgan@chromium.org2011-01-2710-45/+67
| | | | | | | | | | | | | | | | | | | * Home page URL field now styled. * Fixed jiggling rows in search engine manager list. * Fixed 'make default' button margins. * Added better margin for 'Get themes' link. * Fixed margins of AF add buttons. * Revamped search page title. * Fixed the margin of the content of language options page. * Added indent for 'Clear browser data' checkboxes. * Removed default height of cookies list. BUG=none TEST=none Review URL: http://codereview.chromium.org/6279018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72898 0039d316-1c4b-4281-b951-d872f2087c98
* lastchange: use shell=True on Windowsevan@chromium.org2011-01-271-1/+2
| | | | | | | | | | | I regressed this by refactoring some code together then splitting it again. Originally it was fixed in r18533. BUG=71016 Review URL: http://codereview.chromium.org/6265031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72897 0039d316-1c4b-4281-b951-d872f2087c98
* 11 (eleven) (pronounced /ɨˈlɛvɨn/ ( listen) or /iˈlɛvɛn/) is the ↵laforge@chromium.org2011-01-271-1/+1
| | | | | | natural number following 10 and preceding 12. It is the first number which cannot be represented by a human counting their eight fingers and two thumbs additively. Eleven is the smallest positive integer requiring three syllables in English, and it is also the largest prime number with a single-morpheme name in this language (although etymologically the word eleven originated from a Germanic compound *ainlif meaning "one left" [1]). git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72896 0039d316-1c4b-4281-b951-d872f2087c98
* svn-delete gmocksail@chromium.org2011-01-270-0/+0
| | | | | | | | TBR=nsylvain Review URL: http://codereview.chromium.org/6376015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72894 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding this as this was reverted.ananta@chromium.org2011-01-2713-52/+172
| | | | | | | | | | | | | | | | | | | | Move the handling of Desktop notification IPCs coming in from the renderer into a helper object DesktopNotificationHandler whose lifetype is dependent on the TabContents which instantiates it. This object implements the WebNavigationObserver interface which enables it to handle IPCs on the UI thread. The DeskopNotificationHandler object is also instantiated by the ExtensionHost object as it expects the desktop notification IPC's to be handled. I also changed the desktop notification IPCs to carry the routing id as an additional parameter as the notification handling in the browser needs the routing id. BUG=70690 TEST=no change in functionality. TBR=jam Review URL: http://codereview.chromium.org/6240015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72892 0039d316-1c4b-4281-b951-d872f2087c98
* Recommit attempt for rev 72685.zea@chromium.org2011-01-2722-97/+595
| | | | | | | | | | | [SYNC] Refactor SyncSourceInfo and add support in chrome invalidation client and syncer thread for passing a datatype-specific payload originating in the invalidation server and directed at the sync frontend server. Also fixes bug with last_sync_time and PostTimeToTypeHistogram, which would get hit when the unit tests were being run. BUG=68572, 69558 TEST=unit Review URL: http://codereview.chromium.org/6313018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72891 0039d316-1c4b-4281-b951-d872f2087c98
* Add owners file in chrome/test/{functional,pyautolib}nirnimesh@chromium.org2011-01-272-0/+2
| | | | | | | | | | | | These are pyauto directories. Add myself to owners. BUG= TEST= Review URL: http://codereview.chromium.org/6370018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72890 0039d316-1c4b-4281-b951-d872f2087c98
* Memory leak on Mac in test MenuButtonTest.OpenOnClickdhollowa@chromium.org2011-01-271-0/+25
| | | | | | | | | | | | | Adds a Valgrind suppression on Mac for MenuButtonTest.OpenOnClick (error hash=#000000002AECF383#) BUG=71111 TEST=Mac Valgrind bot goes green TBR=rsesek@chromium.org Review URL: http://codereview.chromium.org/6283016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72886 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure Mac plugin focus doesn't outlast plugin lifetimestuartmorgan@chromium.org2011-01-271-0/+12
| | | | | | | | | | | Ensures that if a plugin is removed from the page, or crashes, the renderer doesn't continue to think that it has focus (thus interfering with non-plugin IME). BUG=70982 TEST=Try to type on a page after a plugin with focus is removed or crashes. Review URL: http://codereview.chromium.org/6298018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72885 0039d316-1c4b-4281-b951-d872f2087c98
* wstring: use a few more FilePaths to remove Hack functionsevan@chromium.org2011-01-279-55/+52
| | | | | | | | BUG=69467 Review URL: http://codereview.chromium.org/6332018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72884 0039d316-1c4b-4281-b951-d872f2087c98
* Don't show the "new! password sync" message in settings when a ↵johnnyg@chromium.org2011-01-271-6/+3
| | | | | | | | | | | sync-everything person is upgraded and needs to re-login. Only do that on the NTP. BUG=70997 TEST=upgrade a sync everything user, check settings. Review URL: http://codereview.chromium.org/6336015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72883 0039d316-1c4b-4281-b951-d872f2087c98
* Route LOG messages generated on the GPU process to the about:gpu page.nduca@chromium.org2011-01-279-4/+96
| | | | | | | | | BUG=57069 TEST= Review URL: http://codereview.chromium.org/6262017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72881 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the crash in SpdyNetworkTransactionTest.CorruptFrameSessionError.wtc@chromium.org2011-01-271-6/+5
| | | | | | | | | | | | | | | Instead of changing the frame length to a huge number, which would require that many bytes of frame data to match, I change the frame length to a smaller number, so that we won't read beyond the end of a valid data buffer. R=mbelshe,willchan BUG=48588 TEST=net_unittests --gtest_filter=*.CorruptFrameSessionError* should not crash in memcpy. Review URL: http://codereview.chromium.org/6286008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72880 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor PPAPI proxy resource handling to maintain which host they came from,brettw@chromium.org2011-01-2764-831/+1670
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | and to map back to that host when calling functions on them. Adds a mapping between resources generated by the hosts to a new list inside the plugin so there can't be overlaps. This means there are now two meanings for a PP_Resource, one in the plugin process and one in the host process. This is potentially very confusing. I introduced a new object called a HostResource that always represents a "host" PP_Resource to try to prevent errors. In the plugin side of the proxy, it only deals with PP_Resources valid in the plugin, and SerializedResources valid in the host. It also encapsulates the associated instance, which simplifies some code. Each PluginResource object maintains its SerializedResource which the proxy uses to send to the host for requests. This requires getting the PluginResource object in more proxy calls. This fixes a bug in var sending introduced in my previous patch. The var releasing from EndSendPassRef used the host var rather than the plugin var. I had to add more plumbing to get the dispatcher at this location and convert to a plugin var. I removed the separate file for ImageData and put it in ppb_image_data_proxy like for the other resource types. TEST=some unit tests included BUG=none Review URL: http://codereview.chromium.org/6334016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72879 0039d316-1c4b-4281-b951-d872f2087c98
* Make BookmarkModelVerifier wait for favicons to load before extracting themrsimha@chromium.org2011-01-273-8/+50
| | | | | | | | | | | | | | | | | The test case for bookmark favicon sync was failing in its verification step because GetFavicon sometimes returned a blank favicon for a URL. This was because GetFavicon can be asynchronous if the favicon of a bookmark node is not already loaded. This patch modifies the method that compares favicons, and takes care of cases where the favicon has not yet loaded by adding a conditional wait. BUG=69694 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/6347016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72877 0039d316-1c4b-4281-b951-d872f2087c98
* Unit tests that use ProfileSyncServiceMock are leaking due to adding a ↵ahendrickson@chromium.org2011-01-274-16/+16
| | | | | | | | | | | | | | | DataSource (SyncResourcesSource) to ChromeURLDataManager. The basic problem is that the destructors need to be called on the UI thread, but at shutdown the UI thread (which is the only thread left) is not recognized so the destruction is thrown to the thread even though the message loop is no longer running. This means that the messages are dropped and memory is leaked. I added cleanup code to the destructor. BUG=70782 TEST=Valgrind Review URL: http://codereview.chromium.org/6317017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72876 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded includes of notification_registrar.h.thestig@chromium.org2011-01-2715-18/+8
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6309018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72874 0039d316-1c4b-4281-b951-d872f2087c98
* Disable OVERRIDE for clang for a while.thakis@chromium.org2011-01-271-2/+3
| | | | | | | | | | | This blocks rolling clang, and I need to roll clang for the plugin stuff. BUG=71088 TEST=none Review URL: http://codereview.chromium.org/6329027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72873 0039d316-1c4b-4281-b951-d872f2087c98
* widget-gtk: Make it possible to grab focus.sadrul@chromium.org2011-01-271-1/+2
| | | | | | | | | | | | | For a touchui build, there is only one native-view shared for all the components in the browser window, and gtk_widget_grab_focus requires this flag to be set on the widget to work. BUG=none TEST=none Review URL: http://codereview.chromium.org/6400004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72872 0039d316-1c4b-4281-b951-d872f2087c98
* touch: Fix default cursor on re-display.sadrul@chromium.org2011-01-272-14/+15
| | | | | | | | | | | | | | Unsetting the invisible cursor may not restore the default cursor for the window. So restore the arrow cursor for the root window when making the cursor visible again. If child windows had requested other cursors (e.g. hand cursor for RWHVV) then that is automatically restored. BUG=none TEST=none Review URL: http://codereview.chromium.org/6357023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72871 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash when actual_mime_type is NULL.jam@chromium.org2011-01-271-1/+2
| | | | | | Review URL: http://codereview.chromium.org/6379014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72869 0039d316-1c4b-4281-b951-d872f2087c98
* Use shorter adobe flash settings string for tabbed options link.estade@chromium.org2011-01-271-1/+1
| | | | | | | | | BUG=63843 TEST=visual Review URL: http://codereview.chromium.org/6386007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72868 0039d316-1c4b-4281-b951-d872f2087c98
* Create a Header struct to define the structure of the file header in just ↵jeanluc@chromium.org2011-01-272-15/+16
| | | | | | | | | | | | | one place. Previously, knowledge of the format of that header was found in three places (2 in the .cc and 1 in .h). Also, it fixes a warning/error in Visual Studio 2010. BUG=70995 TEST=session_backend_unittest Review URL: http://codereview.chromium.org/6366020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72867 0039d316-1c4b-4281-b951-d872f2087c98
* Pull in gmock through DEPSthakis@chromium.org2011-01-2783-38632/+3
| | | | | | | | | | | | README.chromium hints that we didn't do this previously because of gmock using svn externals. But maruel recently landed a patch that makes gclient --ignore-externals. BUG=none TEST=none Review URL: http://codereview.chromium.org/6241018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72866 0039d316-1c4b-4281-b951-d872f2087c98
* Add downloads owners file.rdsmith@chromium.org2011-01-271-0/+2
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/6268019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72864 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 72861 (chrome/browser/desktop_notification_handler.cc:53:warning: ↵thakis@chromium.org2011-01-2713-172/+52
| | | | | | | | | | | | | | | | | | | | | | | unused variable 'process')- Move the handling of Desktop notification IPCs coming in from the renderer into a helper object DesktopNotificationHandler whose lifetype is dependent on the TabContents which instantiates it. This object implements the WebNavigationObserver interface which enables it to handle IPCs on the UI thread. The DeskopNotificationHandler object is also instantiated by the ExtensionHost object as it expects the desktop notification IPC's to be handled. I also changed the desktop notification IPCs to carry the routing id as an additional parameter as the notification handling in the browser needs the routing id. BUG=70690 TEST=no change in functionality. Review URL: http://codereview.chromium.org/6340017 TBR=ananta@chromium.org Review URL: http://codereview.chromium.org/6354027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72863 0039d316-1c4b-4281-b951-d872f2087c98
* Move the handling of Desktop notification IPCs coming in from the renderer ↵ananta@chromium.org2011-01-2713-52/+172
| | | | | | | | | | | | | | | | | | | | into a helper object DesktopNotificationHandler whose lifetype is dependent on the TabContents which instantiates it. This object implements the WebNavigationObserver interface which enables it to handle IPCs on the UI thread. The DeskopNotificationHandler object is also instantiated by the ExtensionHost object as it expects the desktop notification IPC's to be handled. I also changed the desktop notification IPCs to carry the routing id as an additional parameter as the notification handling in the browser needs the routing id. BUG=70690 TEST=no change in functionality. Review URL: http://codereview.chromium.org/6340017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72861 0039d316-1c4b-4281-b951-d872f2087c98
* [NTP] Use regular mouse events for app drag & drop.jstritar@chromium.org2011-01-276-127/+149
| | | | | | | | | | | This fixes a lot of annoying issues with HTML5 drag & drop. BUG=70795 TEST=None. Review URL: http://codereview.chromium.org/6360017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72860 0039d316-1c4b-4281-b951-d872f2087c98
* O2D: Add an API for setting the texture filter.tschmelcher@chromium.org2011-01-273-3/+62
| | | | | | | | | TEST=loaded O2D and verified that choosing different filters gives different results BUG=none Review URL: http://codereview.chromium.org/6254021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72859 0039d316-1c4b-4281-b951-d872f2087c98
* The server will happily propagate invalid SPDY headers, which Chrome willmbelshe@chromium.org2011-01-271-0/+5
| | | | | | | | | | | reject. Strip headers with 0 length header names or 0 length header values. BUG=none TEST=none Review URL: http://codereview.chromium.org/6286012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72858 0039d316-1c4b-4281-b951-d872f2087c98
* DOMUI Prefs: Remove the startup page managment sub-pagestuartmorgan@chromium.org2011-01-2713-186/+39
| | | | | | | | | | | Removes the length restricting from the main page list, and adds the Add button to the button strip there. BUG=70994 TEST=Startup pages should be completely controlable from the Basics page. Review URL: http://codereview.chromium.org/6292014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72857 0039d316-1c4b-4281-b951-d872f2087c98
* Land 6266021 for David.jorlow@chromium.org2011-01-275-3/+23
| | | | | | | | | | | Plumbing for initial close() support for indexed db. BUG=64049 TEST=browser_tests --gtest_filter=IndexedDBBrowserTest.* Review URL: http://codereview.chromium.org/6348027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72856 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the use-reader-by-default infobar for now.jam@chromium.org2011-01-271-0/+5
| | | | | | Review URL: http://codereview.chromium.org/6397010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72854 0039d316-1c4b-4281-b951-d872f2087c98
* Provide better error messages when grit fails to open a file whiletony@chromium.org2011-01-271-2/+10
| | | | | | | | | | flattening. BUG=70185 Review URL: http://codereview.chromium.org/6401001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72853 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-12 09:04:42 +0000