summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Remove lock.h from resource_bundle.h and histogram.h.erg@chromium.org2010-07-1610-13/+24
| | | | | | | | | | | Use a scoped_ptr<Lock> instead of Lock in resource bundle. BUG=none TEST=none Review URL: http://codereview.chromium.org/3038005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52730 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: access GNOME Keyring on the GLib main thread, rather than the DB thread.mdm@chromium.org2010-07-162-208/+490
| | | | | | | | | I was unable to reproduce the crash, but it's happening to a lot of people and the web suggests that moving access to GNOME Keyring to the GLib main thread should fix the problem. BUG=48343, 25404 TEST=hopefully it won't crash for some people any more Review URL: http://codereview.chromium.org/2953006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52729 0039d316-1c4b-4281-b951-d872f2087c98
* Add methods to LocalStrings to fetch strings without Windows-style accelerators.csilv@chromium.org2010-07-163-7/+144
| | | | | | | | BUG=48715 TEST=View options window using --enable-tabbed-options, verify that advanced panel shows Browse button without ampersand. Review URL: http://codereview.chromium.org/2832056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52728 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 52721 - Refactor the implementation of InputWindowDialog.tfarina@chromium.org2010-07-165-207/+202
| | | | | | | | | | | | | | | | - Move the implementation of each platform under its respective source directory. - Rename the classes to match with pattern used in the chrome source. - In the gtk side, use the gtk signal macros for the callback events. BUG=None TEST=open the bookmark editor dialog, everything should works as before on windows and linux. Review URL: http://codereview.chromium.org/2832028 TBR=tfarina@chromium.org Review URL: http://codereview.chromium.org/2835043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52727 0039d316-1c4b-4281-b951-d872f2087c98
* Separate the PasswordManagerDelegate out of PasswordManager.erg@chromium.org2010-07-1622-96/+134
| | | | | | | | | | | | | | | Previously, anyone who included tab_contents.h would bring in a bunch of implementation details of the password manager from webkit_glue. This breaks the delegate interface out of the rest of password manager system and makes FillData not an inner-class so anyone can forward declare FillData instead of having to include the header to meet a delegate interface. BUG=none TEST=none Review URL: http://codereview.chromium.org/2877022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52726 0039d316-1c4b-4281-b951-d872f2087c98
* Update libxml to 2.7.7.evan@chromium.org2010-07-16124-36507/+31867
| | | | | | | | | | | In doing so, I recreated all the patches and organized them under a patches/ subdirectory. BUG=32197 Review URL: http://codereview.chromium.org/2951008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52725 0039d316-1c4b-4281-b951-d872f2087c98
* This checkin contains 2 new types of sync integration tests.rsimha@chromium.org2010-07-1610-4/+180
| | | | | | | | | | | | | The first type of tests ("multiple client") creates a small number of clients (3) that make simultaneous, sometimes conflicting updates to a sync item and verifies that the system reaches a sane state in spite of racy conditions. The second type of tests ("many client") creates several clients (10) that all sync to the same account and process updates sent out due to one or more of them syncing a change, and verifies that the system reaches a known sane state at the end of the test. BUG=49035 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/2897017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52724 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Guess the thread id for crashing renderers in a different PID namespace.thestig@chromium.org2010-07-164-8/+113
| | | | | | | | BUG=48997 TEST=Google Chrome gets valid crash reports for about:crash most of the time. Review URL: http://codereview.chromium.org/2961008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52723 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Fix gpu::gles2::GetCommandName range check.mattm@chromium.org2010-07-161-5/+2
| | | | | | | | | | CID=7802 BUG=none TEST=none Review URL: http://codereview.chromium.org/2813056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52722 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the implementation of InputWindowDialog.tfarina@chromium.org2010-07-165-202/+207
| | | | | | | | | | | | | - Move the implementation of each platform under its respective source directory. - Rename the classes to match with pattern used in the chrome source. - In the gtk side, use the gtk signal macros for the callback events. BUG=None TEST=open the bookmark editor dialog, everything should works as before on windows and linux. Review URL: http://codereview.chromium.org/2832028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52721 0039d316-1c4b-4281-b951-d872f2087c98
* Skip test broken by ENABLE_WEB_TIMING. The updated expectations are landedtonyg@chromium.org2010-07-161-0/+9
| | | | | | | | | | upstream, so these should be removed upon the next roll. BUG=None TEST=None Review URL: http://codereview.chromium.org/2877023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52720 0039d316-1c4b-4281-b951-d872f2087c98
* First change to add safebrowsing service test. lzheng@chromium.org2010-07-164-0/+199
| | | | | | | | | | | | | | Right now, the test only launch the browser and makes sure no auto update is scheduled. Later, the test suite server will be launched within the test and requests will be issued, BUG=47318 TEST=this is the test. Review URL: http://codereview.chromium.org/2845035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52719 0039d316-1c4b-4281-b951-d872f2087c98
* Disable AutocompleteBrowserTest.Basic instead of FLAKY_oshima@chromium.org2010-07-161-2/+2
| | | | | | | | | BUG=49324 TEST=none Review URL: http://codereview.chromium.org/3039007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52718 0039d316-1c4b-4281-b951-d872f2087c98
* Now spdy in enabled by default to 50% of users. We could remove the special ↵lzheng@chromium.org2010-07-161-11/+0
| | | | | | | | | | | case for sxs. TEST=none BUG=none Review URL: http://codereview.chromium.org/2861058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52716 0039d316-1c4b-4281-b951-d872f2087c98
* [GTK] Don't access a destroyed widget.estade@chromium.org2010-07-162-11/+14
| | | | | | | | | BUG=49133 TEST=no DCHECKs when following bug repro steps Review URL: http://codereview.chromium.org/2878031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52715 0039d316-1c4b-4281-b951-d872f2087c98
* Fix chrome mini installer test.mirandac@google.com2010-07-162-20/+9
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3014010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52714 0039d316-1c4b-4281-b951-d872f2087c98
* Restore previous dribbling-subprocess-output code for non-Windows.jrg@chromium.org2010-07-161-0/+39
| | | | | | | | | | | | | | | | | | | | | | | | (Windows code adds buffering when used on POSIX adding uncomfortable delays in output). Windows code retained for use on Windows only. Add command line flag --dont-clear-coverage-data to facilitate tester use. Workflow: 1. compile for coverage 2. run chrome and do whatever 3. Run coverage script by hand; e.g. tools/code_coverage/coverage_posix.py --directory out/Debug --genhtml out/index.html --dont-clear-coverage-data The coverage_posix.py tool otherwise deletes all coverage data when it starts since it assumes it only wants coverage data generated by it's subprocesses. BUG=none TEST=coverage bots stay green; Anantha happier. Review URL: http://codereview.chromium.org/2870054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52713 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Fix drawing when the device's transform has a scaling part.thakis@chromium.org2010-07-162-8/+11
| | | | | | | | | | | This currently never happens in practice, but I have a patch which uses the PaintAt IPC, which doesn't work without this fix. Without this, the clip rect is scaled down too, which means if I send a PaintAt IPC that draws the renderer at 800x600 into a 400x300 pixmap, the clip rect is 200x150, because render_view sets the scale t0 0.5 and the clip rect to 400x300. BUG=none TEST=Everything still paints correctly. Review URL: http://codereview.chromium.org/3033005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52712 0039d316-1c4b-4281-b951-d872f2087c98
* Stuff the MCX policy file into the app bundle where it belongs.avi@chromium.org2010-07-164-6/+53
| | | | | | | | | BUG=http://crbug.com/45334 TEST=build chromium, open the package, look in the resources folder, see either "org.chromium.Chromium.manifest" or "com.google.Chrome.manifest" (depending on the build). Open the file, see either "Chromium" or "Google Chrome" at the top (again, depending on the build). Review URL: http://codereview.chromium.org/2809057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52710 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a theme testnirnimesh@chromium.org2010-07-161-2/+4
| | | | | | | | | Fix a theme test by using absolute path to the theme file. Review URL: http://codereview.chromium.org/2861056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52709 0039d316-1c4b-4281-b951-d872f2087c98
* STOP. Grammartime!mark@chromium.org2010-07-161-1/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3032003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52708 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill labels removed from preferences dialog on Macdhollowa@chromium.org2010-07-1612-648/+1608
| | | | | | | | | | | | | | | | | | This removes the labels data entry fields on the AutoFill preferences dialog on Mac. Labels are now derived fields so user input is not needed. Nib changes made are AutoFillAddressSheet.xib: removed "Label" entry and status indicator, adjusted layout to account for new space. AutoFillCreditCardSheet.xib: removed "Label" entry and status indicator, adjusted layout to account for new space. AutoFillDialog.xib: removed the table header, removed the "Label" column, adjusted sizing of remaining "Summary" column to account for new space, move the buttons lower to top-align with table. BUG=47430 TEST=AutoFillAddressModelTest.*, AutoFillCreditCardModelTest.*, AutoFillDialogText.* Review URL: http://codereview.chromium.org/2813052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52707 0039d316-1c4b-4281-b951-d872f2087c98
* Add string for password protected PDFs.jam@chromium.org2010-07-161-0/+4
| | | | | | Review URL: http://codereview.chromium.org/2834050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52706 0039d316-1c4b-4281-b951-d872f2087c98
* Add string for import bookmarks promo message.mirandac@google.com2010-07-161-0/+5
| | | | | | | | | BUG=49328 TEST=none Review URL: http://codereview.chromium.org/3013008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52705 0039d316-1c4b-4281-b951-d872f2087c98
* Build Fix: Fix signature for a ChromeOS class.jhawkins@chromium.org2010-07-161-1/+2
| | | | | | | | | | TBR=mmoss BUG=none TEST=none Review URL: http://codereview.chromium.org/3013009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52704 0039d316-1c4b-4281-b951-d872f2087c98
* Mark CaptureVisibleTab as flaky.oshima@chromium.org2010-07-161-1/+8
| | | | | | | | | | | This is failing on kermic 64 machine, which only exists in tryservers. BUG=49040 TEST=none Review URL: http://codereview.chromium.org/2979006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52703 0039d316-1c4b-4281-b951-d872f2087c98
* temporary fix for OMX port setting change eventwjia@google.com2010-07-162-7/+15
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/2868050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52702 0039d316-1c4b-4281-b951-d872f2087c98
* Mark AutocompleteBrowserTest.Basic as flaky.oshima@chromium.org2010-07-161-1/+9
| | | | | | | | | | TBR=phajdan.jr@chromium.org BUG=49324 TEST=none Review URL: http://codereview.chromium.org/3020007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52701 0039d316-1c4b-4281-b951-d872f2087c98
* WifiConfigView::Init(): Fetch the localized string for the certstevenjb@chromium.org2010-07-161-1/+2
| | | | | | | | | | | | | | | | | button, rather than using the cert button ID directly, which produces garbage. BUG=http://crosbug.com/4490 TEST=Click network dropdown and select a 802.1x network that has not been configured by the system (google-A when logged in to a non-corp account, for example). Check that the button to the right of the "Certificate:" label contains text ("Select certificate file"), rather than the not-a-character glyph. Review URL: http://codereview.chromium.org/2952006 Patch from Nathan Williams <njw@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52700 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill: Use unique IDs to identify the profile or credit card to fill.jhawkins@chromium.org2010-07-1611-90/+142
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3019001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52699 0039d316-1c4b-4281-b951-d872f2087c98
* Enable WEB_TIMING to match WebKit r63559.tonyg@chromium.org2010-07-161-0/+1
| | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/3034009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52698 0039d316-1c4b-4281-b951-d872f2087c98
* Implement some of URLResponseInfo properties.darin@chromium.org2010-07-163-6/+78
| | | | | | | | | | | | R=brettw BUG=47222 TEST=none Originally reviewed at: http://codereview.chromium.org/3032002 Review URL: http://codereview.chromium.org/3014009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52697 0039d316-1c4b-4281-b951-d872f2087c98
* Added mock libraries for GSSAPI.ahendrickson@google.com2010-07-166-30/+1037
| | | | | | | | | BUG=33033 TEST=None Review URL: http://codereview.chromium.org/2833049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52696 0039d316-1c4b-4281-b951-d872f2087c98
* Remove more definitions from header files.erg@chromium.org2010-07-1614-16/+84
| | | | | | | | | | | This patch only concerns itself with places where we have more than 100 copies of methods being generated. (For example, the destructor and other random methods in FilePath weren't being inlined, leading to several hundred copies being generated.) BUG=none TEST=none Review URL: http://codereview.chromium.org/3039001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52694 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash bug in new SSLClientSocketPool.vandebo@chromium.org2010-07-167-63/+58
| | | | | | | | | | | We also need to push additional error state out of the SSLClientSocketPool on a ERR_SSL_CLIENT_AUTH_CERT_NEEDED error. BUG=49197 TEST=no crash when visiting https://foafssl.org/srv/idp?authreqissuer=http://foaf.me/index.php Review URL: http://codereview.chromium.org/2827053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52693 0039d316-1c4b-4281-b951-d872f2087c98
* Remove extraneous uses of iostream in x509_cert_types.h, which creates ↵davemoore@chromium.org2010-07-161-1/+0
| | | | | | | | | | | static initializers BUG=None TEST=None Review URL: http://codereview.chromium.org/3006004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52692 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r52688 to fix build bustage.darin@chromium.org2010-07-163-78/+6
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52691 0039d316-1c4b-4281-b951-d872f2087c98
* Removing the code that are no longer in use.oshima@chromium.org2010-07-1631-1596/+18
| | | | | | | | | | | | | | | | | | * CompactNavigationBar this feature has been discontinued * BrowserStatusAreaView status area used to have a menu, but it's gone and this class no longer needed. * BrowserExtender used to implement chromeos specific feature, which has been replaced by chromeos/browser_view BUG=49229 TEST=no functional chagne. all test should pass. Review URL: http://codereview.chromium.org/3035004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52690 0039d316-1c4b-4281-b951-d872f2087c98
* Set the options dialog as the parent window of the sync wizard when thealbertb@chromium.org2010-07-1615-29/+46
| | | | | | | | | | | wizard is started from options. BUG=19776 TEST=manually tested Review URL: http://codereview.chromium.org/2976009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52689 0039d316-1c4b-4281-b951-d872f2087c98
* Implement some of URLResponseInfo properties.darin@chromium.org2010-07-163-6/+78
| | | | | | | | | | R=brettw BUG=47222 TEST=none Review URL: http://codereview.chromium.org/3032002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52688 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for Issue 4211: window.open(,, 'type=FullWindow,fullscreen') should not ↵stevenjb@chromium.org2010-07-161-2/+4
| | | | | | | | | | | | | open full screen page. In chromeos create a foreground tab if the width or height is 0 (instead of a tab sized popup) http://code.google.com/p/chromium-os/issues/detail?id=4211 BUG=chromeos:4211 TEST=If a third argument is provided to window.open() and either width or height is unspecified, a new tab should be opened instead of a full screen popup. Review URL: http://codereview.chromium.org/2947009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52687 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Convert page-action icons to PageActionDecoration.shess@chromium.org2010-07-1615-751/+502
| | | | | | | | | | | | | | | | Removes specific knowledge of page-actions from AutocompleteTextField (and Cell and Editor). LocationBarViewMac owns and manages them. PageActionDecoration class pulls some of the specific knowledge out of location_bar_view_mac.mm. BUG=none TEST=Page actions still appear in the right place. TEST=Page action clicks work. TEST=Page action context menus work. Review URL: http://codereview.chromium.org/2861050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52686 0039d316-1c4b-4281-b951-d872f2087c98
* Add a note to the docs to explain that sendResponse can only be called oncempcomplete@chromium.org2010-07-162-0/+12
| | | | | | | | | | | per sendRequest. BUG=36322 TEST=no Review URL: http://codereview.chromium.org/2825045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52685 0039d316-1c4b-4281-b951-d872f2087c98
* Remove SetAnimation() call for tab close button.stevenjb@chromium.org2010-07-161-0/+2
| | | | | | | | | | http://code.google.com/p/chromium-os/issues/detail?id=3929 BUG=chromium-os:3929 TEST=manual (hover over close button, should fade in/out same as other hover behavior) Review URL: http://codereview.chromium.org/2809054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52684 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a way for user to report errors in language detectionjcivelli@chromium.org2010-07-168-11/+77
| | | | | | | | | | Adding a menu to the translate infobar that let users report when the language of a page has been incorrectly detected. BUG=48739 TEST=Visit a page in a language that triggers the translate infobar. Select the menu to report an error. A new tab should be opened that references the page and language and let you report the error. Review URL: http://codereview.chromium.org/2911005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52683 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the decrement zoom button appear before the increment button.sky@chromium.org2010-07-162-15/+15
| | | | | | | | | | BUG=48332 TEST=make sure the wrench menu has the decrement zoom button before the increment zoom button. Review URL: http://codereview.chromium.org/3008004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52682 0039d316-1c4b-4281-b951-d872f2087c98
* New first run sequence for Windows, with no UI. Organic builds will display ↵mirandac@google.com2010-07-1613-1177/+132
| | | | | | | | | | | | | the Search Engine Dialog, otherwise search engine is set to Google or silently imported, depending on master_preferences. (see go/chromefirstrun for details). I also removed a no-longer-used SearchSelectObserver from FirstRunSearchView. BUG=42612 TEST=First run import works as intended (see go/chromefirstrun). master_preferences file can still turn off import of history, search engine, and home page. Review URL: http://codereview.chromium.org/2934011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52679 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore extraneous notification when setting find textdavemoore@chromium.org2010-07-162-0/+24
| | | | | | | | | | | | | | | | | | | | | | | | Because gtk generates a notification when the text is set programatically it would end up highlighting the text even after the find UI was dismissed. Also switch back and forth between 2 tabs would progress the currently found item each time. BUG=46876 TEST=On chromeos: - Open tab 1, browse to first page - Open tab 2, browse to different page - Switch back to tab 1, open find UI - Type a character that occurs in page 1 - Switch to tab 2, open find UI - Type a character that occurs in page 2 - Switch back to page 1. Confirm that the currently selected found text doesn't change. - Close the find UI - Switch back and forth between tabs 1 & 2...tab 1 shouldn't show any highlights. Review URL: http://codereview.chromium.org/3005007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52677 0039d316-1c4b-4281-b951-d872f2087c98
* Initial accounts options page.xiyuan@chromium.org2010-07-1627-55/+856
| | | | | | | | | | | | | | | | | | | | - Add a "Accounts" subpage for ChromeOS; - Two checkboxes for allowing BWSI and allowing guest signin; - Make measureItem in list.js returns 0 instead of -1. The itemHeight is -1 when the list is not visible. And 0 will let redraw to call measureItem again; - Add an onVisibilityChanged callback that is called when "visible" property is changed; And use that to trigger user list's redraw; - Use a mock settings object so that the UI flow could be tested; - Update options_page.css to add a few css missed from dhg's overlay cl; BUG=chromium-os:4734 TEST=None. This is a draft version and will be changed after UX feedbacks. Review URL: http://codereview.chromium.org/2935011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52676 0039d316-1c4b-4281-b951-d872f2087c98
* Implement search engine selection in DOMUI prefsstuartmorgan@chromium.org2010-07-166-26/+157
| | | | | | | | | BUG=48713 TEST=Changing search engines in DOMUP prefs should be persisted. Review URL: http://codereview.chromium.org/2883024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52675 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-13 02:15:50 +0000