| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
Avoid using wall clock time, which can be changed by the user,
or impacted by Daylight Savings transitions etc.
BUG=14193
r=eroman
Review URL: http://codereview.chromium.org/1253005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46821 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(unfortunately this approach is not available on OpenBSD though)
patch from sprewell
Review URL: http://codereview.chromium.org/1979006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=apatrick@chromium.org
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46819 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Open the app launcher. The browser and app launcher location bars
should be exactly the same height.
Review URL: http://codereview.chromium.org/2056001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46818 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
. Once stopped the animation would never restart.
. The animation wouldn't stop when a tab went phantom.
BUG=43573
TEST=none
Review URL: http://codereview.chromium.org/2047004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46817 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
possible for a phantom tab to show the crashed icons. This should make
it so that can never happen.
BUG=40118
TEST=none
Review URL: http://codereview.chromium.org/2035008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46816 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=40095
TEST=none
Review URL: http://codereview.chromium.org/2002011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=42645
TEST=Compiling still works.
Review URL: http://codereview.chromium.org/2003009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46814 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixing 35050, one of the tests I wrote for EPSV required NULS go through the
testing framework. That created issue 42432 which covers permitting NULs through
our socket tests. I added an interface to SimulateRead which passes in an explicit
length, and moved as much of that into ftp_network_transaction_unittest as possible.
BUG=42432
TEST=see the modified Epsv test in ftp_network_transaction_unittest.cc
Review URL: http://codereview.chromium.org/1949003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46813 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1989005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46812 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46811 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1989007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46810 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The first one is: http://src.chromium.org/viewvc/chrome?view=rev&revision=46679
- Removed prefs::kLanguagePinyinDoublePinyinSchema and prefs::kLanguagePinyinLookupTablePageSize to fix issue 3009. I should've removed them in the first patch...
- Added a comment.
- Sorted prefs by name.
BUG=chromium-os:3009
TEST=none
Review URL: http://codereview.chromium.org/2043007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46809 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change is necessary since the "settings.language.hotkey_next_engine" user pref for some users is polluted (i.e. the bad value "Shift+space" is written) and currently there's no way for users to reset the value. Please check issue 3009 for details.
BUG=chromium-os:3009
TEST=none
Review URL: http://codereview.chromium.org/2055005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46808 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
extensions.
TEST=This is an attempt to reduce flakiness of Chrome Frame net tests.
BUG=none
TBR=ananta
Review URL: http://codereview.chromium.org/2051004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
need it to compile and this reduces a potential circular
dependency.
Review URL: http://codereview.chromium.org/2032005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46805 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=43254
TEST=Open the drop down menu and toggle the tips.
Review URL: http://codereview.chromium.org/1981001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=42216
TEST=See bug
Review URL: http://codereview.chromium.org/2045007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=25232
TEST=Loading a web page, make a suggestions popup visible. Pressing Ctrl+/Ctrl- to change the zoom. The popup should disappear.
Review URL: http://codereview.chromium.org/1948001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=jcivelli
BUG=none
TEST=On Windows, start Chromium with --app-launcher-new-tab --enable-extension-apps and press newtab button. The bubble shouldn't jump and arrow location should be somewhere in the middle.
Review URL: http://codereview.chromium.org/1990008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46798 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1986006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46794 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2013010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46793 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The problem was we assumed ProcessPendingRequest() would always make progress once the group's releasing socket went down to zero. However, in OnAvailableSocketSlot(), since the top stalled group might still have a releasing socket, it won't necessarily make progress. The algorithmic solution is to simply never do any socket slot processing in DoReleaseSocket() if there are any releasing sockets. This requires us to search for any stalled groups after releasing sockets gets back down to 0, so it requires the full group scan each time num_releasing_sockets goes back to 0. There is a performance hit here, but I think a linear search through 256~ groups in the worst case is ok.
TODO(willchan): evaluate the perf hit and consider adding a secondary data structure to improve the stalled group search.
BUG=42267
Review URL: http://codereview.chromium.org/2013009
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/1992010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
detached. Otherwise the dragged tab remains in the tab strip, it's
just moved around. I also made it so the tab that originated the drag
can be deleted.
I'm doing this for a couple of reasons:
. make it easier to use dragged tab controller with side tabs.
. chromeos doesn't allow detaching, and only created the window when
we really need it makes for a better experience there.
. no flicker!
BUG=none
TEST=thoroughly test tab dragging to make sure I haven't broken
anything.
Review URL: http://codereview.chromium.org/1998009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46791 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
download issue.
See also:
http://codereview.chromium.org/1718025 (initial change)
http://codereview.chromium.org/1829001 (fix for Head test)
http://codereview.chromium.org/1887001 (fix for download issue)
TEST=Monitor the Chrome Frame IE6 build bot for flakiness. Particularly the net tests.
BUG=none
Review URL: http://codereview.chromium.org/1821001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46786 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
instead of using #if 0 (so that the code
doesn't rot).
This is http://codereview.chromium.org/1990007 done right,
this time should not break tsan.
TBR=maruel
TEST=none
BUG=10611
Review URL: http://codereview.chromium.org/2022003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46784 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2041005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46783 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
prefixes, so the code doesn't rot.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2035009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46782 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a temporary measure until we have a better throbber for
extension app tabs (or we remove them).
BUG=None
TEST=Pass in --disable-throbber-for-extension-apps and make
sure the icon for nano tabs don't get replaced by a throbber.
Review URL: http://codereview.chromium.org/2032003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2016002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46775 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
issued by AddTrust External CA Root because it causes
CertGetCertificateChain to report CERT_TRUST_IS_NOT_VALID_FOR_USAGE.
This is a temporary workaround. The proper fix is to modify
NSS to provide all the certificates sent by the server to
the certificate verification callback.
Fix a certificate context leak.
R=agl,willchan
BUG=43538
TEST=On a Windows computer that doesn't have the
COMODO EV SGC CA certificate issued by COMODO Certification
Authority, visit https://mixi.jp/ . Chrome should not
display the "certificate invalid" error page.
Review URL: http://codereview.chromium.org/2036005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46774 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The code did not handle cancellation properly, and DCHECKs
were firing. Recrafted code to avoid checking for runs
"on origin_thread" after a cancellation (which destroys
the record of the orgin_thread_).
BUG=43600
r=willchan
Review URL: http://codereview.chromium.org/2050002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46769 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=43347
TEST=none
Review URL: http://codereview.chromium.org/2044005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=43569
TEST=manual
Review URL: http://codereview.chromium.org/2021006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in workers. Everything is still stubbed out at runtime (runtime feature is still disabled in the worker process, and the values in the IPC messages are all zero'd out).
* Widen the CreateWorker IPC message sent from the browser to the worker process to contain additional data needed to initialize an appcache for that worker.
* Add a new worker specific WorkerWebApplicationCacheHostImpl class and instantiate one with the initialization data received in the IPC.
* Give the WorkerThread an AppCacheDispatcher.
* Propagate the cmd-line argument to disable the appcache to the worker process.
* Fixup DEPs to show that chrome/workers depends on webkit/appcache
BUG=39368
TEST=thinking about what tests to put together for this CL
Review URL: http://codereview.chromium.org/1719007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=vitalyr
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2017006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=43172
Review URL: http://codereview.chromium.org/2044002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46763 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reverting change by gman@chromium.org, Fri 07 May 2010 16:35:41,
r46756, original comment:
This CL adds the option to support buffers that are bound
to more than one target.
<snip>
original review URL: http://codereview.chromium.org/1992008
TBR=gman@chromium.org
BUG=none
TEST=Mac waterfall green
Review URL: http://codereview.chromium.org/1988007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
up, which will require some changes in render_view as well as the plugin list.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/1697008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46760 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Manually ran the js tests
Review URL: http://codereview.chromium.org/2014005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Ideally this dependency on chrome from net should not exist, but
until that is resolved, we can at least avoid the dependency when
using net.gyp from the standalone webkit build (which lacks a
checkout of chrome/).
R=nick
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1996010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The problem was we assumed ProcessPendingRequest() would always make progress once the group's releasing socket went down to zero. However, in OnAvailableSocketSlot(), since the top stalled group might still have a releasing socket, it won't necessarily make progress. The algorithmic solution is to simply never do any socket slot processing in DoReleaseSocket() if there are any releasing sockets. This requires us to search for any stalled groups after releasing sockets gets back down to 0, so it requires the full group scan each time num_releasing_sockets goes back to 0. There is a performance hit here, but I think a linear search through 256~ groups in the worst case is ok.
TODO(willchan): evaluate the perf hit and consider adding a secondary data structure to improve the stalled group search.
BUG=42267
Review URL: http://codereview.chromium.org/2013009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to more than one target.
We had originally decided that this would be an disallowed.
glBindBuffer(GL_ARRAY_BUFFER, some_buffer_id);
glBindBuffer(GL_ELEMENT_ARRAY_BUFFER, some_buffer_id);
Unfortunately the GLES2 conformance tests require this
behavior.
This CL makes this behavior possible but it has to be
turned on because it means all buffers have to have CPU
side backing (not just ELEMENT_ARRAY_BUFFERs) and it
means a slowdown for dynamic vertex related stuff
like skinning because an extra copy has to be made
every time they are updated.
So, by default it will be off but we'll come up with
some way to turn it on. Al's suggestion is to use
eglCreateContext with a custom intialization attribute.
My #1 question: What about the name of the command,
the name of the constant and the filename the constant
is in. Any thoughts?
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/1992008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I was going to do Show(std::stringi d), but it'd require some refactoring on notification framework,
so I decided to have UPdateAndShow first. I'll do refactoring once I finish screen lock and will
update the code accordingly.
other minor changes:
* removed is_visible() as it's unnecessary.
* cleanup browsertests code.
BUG=http://crosbug.com/2692
TEST=added test cases to existing browser tests.
Review URL: http://codereview.chromium.org/1933008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=42943
TEST=none
Review URL: http://codereview.chromium.org/2008003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1998012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=22588
Review URL: http://codereview.chromium.org/1998008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
when URL is modified in non-empty input field - RTL
In RTL chrome in windows, the text get from "Pattern" text field is wrapped
with LRE/POP, which makes the pattern invalid. Trim explicit bidi control characters
off in NativeTextfieldWin::GetText().
BUG=http://crbug.com/42867
TEST=
1. Launch Chrome with RTL language UI
2. click Wrench => Options => Under the Hood => Content settings => Exceptions
=> Edit...
3. modify an existing url on the Pattern field.
The "OK" button should not be grayed out.
Review URL: http://codereview.chromium.org/1703026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Set the color of the text for the app icons.
Since we do not have a background on sections any more
BUG=43578
TEST=None
Review URL: http://codereview.chromium.org/2016007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46749 0039d316-1c4b-4281-b951-d872f2087c98
|