| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Chrome Sync works
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48798
Review URL: http://codereview.chromium.org/2255007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48811 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change just pulls the hunspell dictionaries moved by my r48011.
TBR=estade
BUG=44543
TEST=none
Review URL: http://codereview.chromium.org/2074023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:2624
TEST=Open the IME settings window. Add Traditional Chinese. Open the options dialog, and check that the integer prefs are there
Review URL: http://codereview.chromium.org/2457001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48806 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
UTF16ToUTF8 conversions.
BUG=41862
TEST=trybots
Review URL: http://codereview.chromium.org/2481003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48805 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=tkent
Review URL: http://codereview.chromium.org/2556001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Chrome Sync works
Review URL: http://codereview.chromium.org/2255007
TBR=sergeyu@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
into line with worst-case expectations on Vista.
BUG=None
TeST=run GCF perftests
Review URL: http://codereview.chromium.org/2544003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Chrome Sync works
Review URL: http://codereview.chromium.org/2255007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48798 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In particular, make it work better when using backup jobs / late binding (the display was very confused before because of how these asynchronous events would nest).
Also changed the paradigm for how PassiveLogCollector preserves these async associations -- this fixes how it replays the events to net-internals. (Before we would collapse the event streams into the SOURCE_URL_REQUEST which lost some hiearchy.. now I keep the separate streams).
Some of the particular changes to the event streams:
* ConnectJobs now create their own source stream internally.
* Sockets are now bounded by +SOCKET_ALIVE / -SOCKET_ALIVE events (removed the one-off SOCKET_DONE event).
* The socket log streams contains +SOCKET_IN_USE / -SOCKET_IN_USE event blocks to show which URLRequest was controlling it at various points in time (this makes it much easier to understand which read/writes belonged to a particular network transaction when a socket gets re-used).
* ConnectJobs are bounded by +SOCKET_POOL_CONNECT_JOB / - SOCKET_POOL_CONNECT_JOB events.
* ConnectJobs log the net error they failed with.
* Removed the SOCKET_BACKUP_TIMER_EXTENDED event.
Review URL: http://codereview.chromium.org/2363003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=dhg
TEST=green chromeos compile
Review URL: http://codereview.chromium.org/2544002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=45148
TEST=compile chrome with PRODUCT_VERSION manually set to something higher than the current version (e.g. 7.0.0.0), and manually set the upgrade detector time to something short (like 10 seconds). Launch chrome and wait a short time for the update notification to appear. The update notification should pulse every few seconds, and should stop pulsing when the user opens the wrench menu. The about menu item should launch a dialog that allows the user to restart chrome, restoring the current session.
Review URL: http://codereview.chromium.org/2365003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48795 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=tkent
Review URL: http://codereview.chromium.org/2546001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48794 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=StringUtilTest.TokenizeStringPiece
Review URL: http://codereview.chromium.org/2463007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
preparation for using Chrome sockets.
Made TalkMediator explicitly non-thread-safe.
BUG=45612
TEST=manual testing of notifications
Review URL: http://codereview.chromium.org/2471006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48791 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:3715
TEST=none
Review URL: http://codereview.chromium.org/2496002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
port to call it during resizing. Because the Mac port does all of its
rendering offscreen, the back buffer must be resized immediately
rather than waiting until the next SwapBuffers call.
Tested with npapi_pepper_test_plugin and GPU unit tests.
BUG=45246
TEST=none
Review URL: http://codereview.chromium.org/2466003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48789 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
that we can quickly decide at glDrawXXX time whether
or not we have to do more work.
TEST=unit tests
BUG=42671
Review URL: http://codereview.chromium.org/2429005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
there are also flow control problem. but it is not addressed in this CL.
BUG=None.
Test=dev board.
Review URL: http://codereview.chromium.org/2441006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48786 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=something
Review URL: http://codereview.chromium.org/2507001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48785 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=aa
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2516001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48783 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=30710,30706
TEST=Invoke a contextual menu in the Sync sign-in dialog, navigation items
should not appear.
Review URL: http://codereview.chromium.org/2487002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48781 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Don't connect to the drag events more than once.
BUG=45270
TEST=dragging that box in debug mode, no backtrace
Review URL: http://codereview.chromium.org/2514001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
because it does not affect what we ship.
BUG=none
TEST=built on Linux; verified no significant change in shipped file size
Review URL: http://codereview.chromium.org/2439005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
2. Store the thumbnail score in the database.
BUG=None
TEST=TopSitesTest
Review URL: http://codereview.chromium.org/2499003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Retry up to 30 seconds (1 sec x 30) even if it fails to grab inputs.
BUG=none
TEST=manual: scree lock should work after chrome crash.
Review URL: http://codereview.chromium.org/2458002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Use real transient parent for hosted native dialogs since window manager
supports transient of transient now;
- Use last active normal browser window as parent for option dialogs since
we don't want to use panel popups as parent;
BUG=chromium-os:3708
TEST=none. This CL gives real transent parent for dialogs but we still need to way to show the dialogs, either exit fullscreen or put them on top of fullscreen.
Review URL: http://codereview.chromium.org/2501001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48773 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Tested with client application.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2451002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
asynchronous. So far PipelineImpl handles asynchronous MediaFilter::Stop(). The actual change to make MediaFilter::Stop() asynchronous will be in another check in.
BUG=16059
TEST=Unit tests still runs
Review URL: http://codereview.chromium.org/2101015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48769 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
an app tab to a regular tab.
BUG=45480
TEST=None
Review URL: http://codereview.chromium.org/2425004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=39250
TEST=Select a folder with no items. The sort command should be disabled.
Review URL: http://codereview.chromium.org/2467007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Currently, two (2) overloaded versions of Histogram::FactoryGet() exist. Google's C++ style guide discourages such implementations. I refactored the methods into Histogram::FactoryGet() (no name change), which takes 'Sample' types as arguments, and Histogram::FactoryTimeGet(), which takes base::TimeDelta types as arguments.
r = jar
Review URL: http://codereview.chromium.org/2423004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
without --enable-vertical-tabs, and even then, don't expect it to work.
BUG=44773
TEST=infobars, bookmark bar, tab strip, etc should all behave correctly when showing, hiding, and widnow resizing. This cl should have no visible impact without the above flag on the command line.
Review URL: http://codereview.chromium.org/2475002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
returns NULL.
BUG=45664
TEST=none
Review URL: http://codereview.chromium.org/2501002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Original review URL: http://codereview.chromium.org/2173002
Review URL: http://codereview.chromium.org/2375003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48763 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If a sync integration test runs for 30 seconds or more, OutOfProcTestRunner
forcibly kills the test case executable. This leaves an orphaned python
server instance in memory. When a subsequent test case is run, it
attempts to kick off a new python server and immediately checks for the
existence of a running server, following which it pumps messages to the
server instance. If the server detected by the test case happens to be
the old orphaned instance (that goes on to die when a new server
instance is started), test cases can fail.
This change list restricts the lifetime of the python.exe process started by
a test case such that if the test case is killed by OutOfProcTestRunner,
the python server instance it created dies with it.
In order to restrict the lifetime of a test server, it needs to be
started as a job. When a test server is spawned as a child process by a
test case that is running under a debugger, the child process needs to
be created using the CREATE_BREAKAWAY_FROM_JOB flag to first
disassociate it from the JobObject created by the debugger.
TestServerLauncher::Start() used to invoke base::LaunchApp() in order to
create the child process. This changelist implements a new method in
class TestServerLauncher called LaunchTestServerAsJob(). The call to
base::LaunchApp() in TestServerLauncher::Start() is replaced with a call
to TestServerLauncher::LaunchTestServerAsJob().
BUG=43777
TEST=sync_integration_tests
Review URL: http://codereview.chromium.org/2344001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
logging in through"
This reverts commit 4ffcb495af72106fe243c6982119d799325d86ba.
The following tests were failing with this change.
NetworkScreenTest.Basic
NetworkScreenTest.NetworksConnectedNotSelected
NetworkScreenTest.EthernetSelected
NetworkScreenTest.WifiSelected
NetworkScreenTest.CellularSelected
NetworkScreenTest.WifiWaiting
LoginScreenTest.TestBasic
LoginScreenTest.AuthenticationFailed
LoginScreenTest.IncognitoLogin
grd files are excluded from revert to avoid build failures.
TBR=avayvod@chromium.org
BUG=none
TEST=chromeos build bot should cycle green
Review URL: http://codereview.chromium.org/2498003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48761 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=39057
TEST=tree greener
TBR=dhg
Review URL: http://codereview.chromium.org/2502001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48760 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=32615,45675
TEST=tree greener
TBR=creis
Review URL: http://codereview.chromium.org/2450006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
we had to use uniform.
TEST=On vendor's board.
BUG=None.
Review URL: http://codereview.chromium.org/2436007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There is a issue in adding new composited child after the ref count of painter became zero.
RefCount::Release does not tell if it's been deleted so it can't remove the painter key from G_OBJECT(widget).
I could have changed RefCounted::Release to return true, but I took this approach because new child will be added
later in most use case (like info bubble), and it's more efficient to keep the painter rather than
creating and deleting each time.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2449010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
longer failing or to gather more data on the crashes since I cannot get them to fail on my local machine.
BUG=40002,40133
TEST=ExtensionBrowserTest, BrowserActionApiTest
Review URL: http://codereview.chromium.org/2495002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This CL cannot be checked in until the patch for:
https://bugs.webkit.org/show_bug.cgi?id=39917
has landed.
BUG=45373
Review URL: http://codereview.chromium.org/2330004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=tkent
Review URL: http://codereview.chromium.org/2494003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=17113
TEST=none
Review URL: http://codereview.chromium.org/2390001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
on Linux cause crashes.
BUG=45002
TEST=none
Review URL: http://codereview.chromium.org/2486003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
enqueueing an item is available from the menu.
Review URL: http://codereview.chromium.org/2436008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2418003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
internal structure.
BUG=http://crbug.com/45363
TEST=no crash on unreleased systems
Review URL: http://codereview.chromium.org/2417008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
selection. Refactor form field enumeration into ForEachMatchingFormField().
BUG=38582
TEST=FormManagerTest.PreviewForm
Review URL: http://codereview.chromium.org/2138005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=41234
TEST=none
Review URL: http://codereview.chromium.org/2464002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48745 0039d316-1c4b-4281-b951-d872f2087c98
|