| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
Before this fix the function was returning true when comparing two invalid URLs. After this fix, if one or both of the URLs are invalid the function will return false.
Checking incoming arguments of the function for validity is a good practice and may prevent future problems. (Currently the PSLMatchingHelper::IsPublicSuffixDomainMatch is never called with invalid arguments, but this can change in the future.)
BUG=391529
Review URL: https://codereview.chromium.org/365313002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TextInput_TextInputStateChangedTest.OpenNewTabOnloadTest seems to be
flaky. http://crbug.com/391582
BUG=391582
NOTRY=true
NOTREECHECKS=true
TBR=nona@chromium.org
Review URL: https://codereview.chromium.org/376433002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=391513
TBR=b.kelemen@samsung.com
NOTRY=true
Review URL: https://codereview.chromium.org/365373002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=391556
TBR=ager@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/370103002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=340952
NOTRY=true
TBR=haraken@chromium.org
Review URL: https://codereview.chromium.org/370053004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281471 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Many users want to copy the image of <canvas> to clipboard. (like <img>)
As well as being useful, The feature is already supported in Firefox and IE.
Blink side:
https://codereview.chromium.org/270613004/
BUG=369092
Review URL: https://codereview.chromium.org/275833002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Put it in content namespace while doing this.
BUG=338338
TEST=None
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/370833002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281469 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
API, as outlined in
https://docs.google.com/a/chromium.org/document/d/1sCZjx1J3_M2a02T8NXd-ufGKZDoBHI5Ixis1DaGLQCA/edit?usp=sharing.
Based on code from https://codereview.chromium.org/232773011/, with various
fixes and rebased against changes in https://codereview.chromium.org/287093002/
Depends on changes in https://codereview.chromium.org/302603012/
BUG=30583
Review URL: https://codereview.chromium.org/301733006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/351933003/)
Reason for revert:
Appears to have broken http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/12029/steps/browser_tests/logs/stdio
"isolate" in the error message is suspicious: http://www.chromium.org/developers/testing/isolated-testing
[ RUN ] QUnitBrowserTestRunner.Remoting_Webapp_Js_Unittest
Xlib: extension "RANDR" missing on display ":9".
Xlib: extension "RANDR" missing on display ":9".
[12246:12246:0704/181239:WARNING:password_store_factory.cc(213)] Using basic (unencrypted) store for password storage. See http://code.google.com/p/chromium/wiki/LinuxPasswordStorage for more information about password storage options.
../../chrome/test/remoting/qunit_browser_test_runner.cc:43: Failure
Value of: PathExists(file)
Actual: false
Expected: true
Error: The QUnit test suite </mnt/data/b/build/slave/Linux_Tests/isolate-2014-07-043CUE8r/out/Release/remoting/unittests/unittest.html> does not exist.
[12246:12310:0704/181239:WARNING:raw_channel_posix.cc(214)] recvmsg: Connection reset by peer
[ FAILED ] QUnitBrowserTestRunner.Remoting_Webapp_Js_Unittest, where TypeParam = and GetParam() = (329 ms)
Original issue's description:
> JavaScript unit test framework - Part II
>
> This change enables running the JavaScript unit test on try bots using the browser test infrastructure.
>
> To run a QUnit test suite as a browser test.
> 1. include third_party/qunit/src/browser_test_harness.js in your qunit test suite.
> 2. Derive your browser test from QUnitBrowserTestRunner, and call RunTest with the URL of the test suite.
> 3. modify chrome_tests.gypi to add the c++ source of your browser test and add your test suite as a run time dependency of the browser_tests executable
>
> Summary of changes:
> 1. QUnit_browser_test_runner.h serves as a base class for a QUnit browser test. It navigates the browser to the QUnit test suite, calls browserTestHarness.run() and listens for the test results.
>
> 2. browser_test_harness.js serves as a test took on the QUnit test suite. Using the window.domAutomationController, browser_test_harness.js detects whether it is running under the browser test infrastructure to auto-enable itself and report results back to the browser test.
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281451
TBR=sergeyu@chromium.org,rmsousa@chromium.org,jamiewalch@chromium.org,anandc@chromium.org,kelvinp@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/372563002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
In the goal of making the 'suggestions' component soon, remove dependence on profile. This meant disabling the service for incognito profile, but this actually makes sense (a later check will verify signed-in identity).
BUG=387751
TEST=SuggestionsServiceTest
Review URL: https://codereview.chromium.org/365323002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281456 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move TemplateURLService, SearchHostToURLsMap, util.cc from chrome/browser/search_engines to components/search_engines
Move KeywordTable and KeywordWeDataService from chrome/browser/webdata to components/search_engines
Fix DEPS, OWNERS and gyp.
Replace HistoryDatabase in keyword_table.cc with URLDatabase.
BUG=386367
TEST=build and checkdeps
R=blundell@chromium.org, jochen@chromium.org, pkasting@chromium.org
TBR=atwilson@chromium.org as an owner of sync, erikwright@chromium.org as an owner of sql
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281350
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281403
Review URL: https://codereview.chromium.org/367023002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281455 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This config.h was brought back from commit:
https://chromium.googlesource.com/chromium/chromium/+/ace16e7626c7ba33a630960b913b54e1513187fc
This should make possible to build snappy_unittest target again on Mac.
BUG=None
TEST=snappy_unittest builds and runs on Mac.
R=jsbell@chromium.org
Review URL: https://codereview.chromium.org/362433002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This file was merged with user_agent.h and moved into
content/public/commmon
BUG=None
TEST=./buildtools/checkdeps/checkdeps.py
TBR=jamescook@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/364333004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Filed http://llvm.org/PR20208 to discuss if this is required, and that the
diagnostic for this is not very good at the moment.)
BUG=82385
TBR=cpu@chromium.org
Review URL: https://codereview.chromium.org/365333003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281452 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change enables running the JavaScript unit test on try bots using the browser test infrastructure.
To run a QUnit test suite as a browser test.
1. include third_party/qunit/src/browser_test_harness.js in your qunit test suite.
2. Derive your browser test from QUnitBrowserTestRunner, and call RunTest with the URL of the test suite.
3. modify chrome_tests.gypi to add the c++ source of your browser test and add your test suite as a run time dependency of the browser_tests executable
Summary of changes:
1. QUnit_browser_test_runner.h serves as a base class for a QUnit browser test. It navigates the browser to the QUnit test suite, calls browserTestHarness.run() and listens for the test results.
2. browser_test_harness.js serves as a test took on the QUnit test suite. Using the window.domAutomationController, browser_test_harness.js detects whether it is running under the browser test infrastructure to auto-enable itself and report results back to the browser test.
Review URL: https://codereview.chromium.org/351933003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281451 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch adds a text widget to the window overview in Ash that allows the user
to filter the windows, making it easier to select among multiple active items.
Windows that do not match the pattern are set to 0.5 transparency and their
selection is prevented. The pretarget event handler in WindowSelector has been
removed in favour of handling the key events in the widget, which produces
cleaner code.
BUG=388726
TEST=WindowSelectorTest.BasicTextFiltering
TBR=oshima@chromium.org
Review URL: https://codereview.chromium.org/358553004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281450 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Do not change value of |ToplevelWindowEventHandler::drag_reverted_| if
ET_MOUSE_CAPTURE_CHANGED is received after ET_MOUSE_RELEASED but before
the move loop has ended. This is currently the case with views::Widget.
This CL does not fix all of the possible places where CompleteDrag() may be
called after the drag was completed for the sake of being easier to merge
back to M-37
BUG=380481
TEST=ToplevelWindowEventHandlerTest.CaptureLossAfterMouseRelease
Review URL: https://codereview.chromium.org/354343002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implemented paring UI for host side. This implementation lacks styling,
transitions, images and real strings. However it is fully functional, and can
be used with FakeHostPairingController or with real controller when it will be
implemented.
For testing purposes "show-host-pairing-demo" switch was added. If this
switch is set, paring procedure will be emulated during OOBE. Demo
flow can be configured with a value of "show-host-pairing-demo" option, if the
value is empty default config is used.
For config format see comments in fake_host_pairing_controller.h.
BUG=375191
TEST=none
Review URL: https://codereview.chromium.org/364613002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281447 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=82385
TBR=ch.dumez@samsung.com
Review URL: https://codereview.chromium.org/364363002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281446 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also suppress a -Wwritable-strings warning while here.
BUG=82385
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/374443003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Attempts to fix this clang error:
..\..\media\base\container_names.cc(1555,10) : error(clang): case value evaluates to -272908453, which cannot be narrowed to type 'uint32' (aka 'unsigned int') [-Wc++11-narrowing]
case TAG('\xef','\xbb','\xbf','['):
^
..\..\media\base\container_names.cc(19,5) : note(clang): expanded from macro 'TAG'
((static_cast<uint8>(a) << 24) | (static_cast<uint8>(b) << 16) | \
^
1 error generated.
This happens because uint << integer literal results in int.
(One reason why functions should be preferred over macros.)
BUG=82385
TBR=acolwell@chromium.org
Review URL: https://codereview.chromium.org/369193002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DeepCopy() has a covariant return type, so its result needs to be explicitly
cast to base::Value. Use an explicit call to scoped_ptr<base::Value> instead of
make_scoped_ptr(...).PassAs<base::Value> in a few other places too, as that
seems a bit simpler.
BUG=82385
TBR=joaodasilva@chromium.org
Review URL: https://codereview.chromium.org/369303004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=391513
TBR=b.kelemen@samsung.com
NOTRY=true
Review URL: https://codereview.chromium.org/369283004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We crash if Initialize() failed and the surface is NULL.
TEST=chrome on link_freon image
BUG=none
NOTRY=true
Review URL: https://codereview.chromium.org/370043003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=chrisha@chromium.org
BUG=
Review URL: https://codereview.chromium.org/364353002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281439 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
didn't fully fix it.
BUG=389104
TBR=scherkus@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/366343002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
fixed.
BUG=391503
TBR=b.kelemen@samsung.com
NOTRY=true
Review URL: https://codereview.chromium.org/373593003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=391510
TBR=sdefresne@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/370043002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The methods in that header are inline assembly which require inlining, so
instrumentation doesn't work with them, and also doesn't matter.
BUG=
Review URL: https://codereview.chromium.org/369833003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL does not fix a bug because it is not possible to enter app immersive
fullscreen on Windows.
BUG=None
TEST=None
TBR=benwells
Review URL: https://codereview.chromium.org/275373002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add gypi and python files to support packing ARM relative relocations
during the build process.
Define a use_relocation_packer gyp variable to turn ARM relocation
packing on and off (currently set to 0).
BUG=385553
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281286
Review URL: https://codereview.chromium.org/358863002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
When there is no touch event taking place, suppress calls to onPull
that may come in after the users finger has left the screen.
BUG=391464
Review URL: https://codereview.chromium.org/366283004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=danno@chromium.org
Review URL: https://codereview.chromium.org/372483002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Only sizeof expr can be written without them.)
BUG=82385
TBR=jochen@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/369203002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=375191
TEST=none
Review URL: https://codereview.chromium.org/363663005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Always make the background of the layer tree host
in the parent compositor transparent to avoid
covering up the background color of the WebView.
BUG=391462
Review URL: https://codereview.chromium.org/368273008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281426 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=177450:177545&mode=html
TBR=lushnikov@chromium.org,pilgrim@chromium.org
BUG=
Review URL: https://codereview.chromium.org/370813002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=364716
Review URL: https://codereview.chromium.org/350243005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL...
- records controlled page loads in SWControlleeRequestHandler
- renames ServiceWorkerHistograms to ServiceWorkerMetrics
BUG=390060
TEST=tools/metrics/actions/extract_actions.py
Review URL: https://codereview.chromium.org/369473007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281422 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
browser/page actions repeatedly. Make extension popup behavior
the same as Windows. The behavior is clicking browser action a
popup is shown, and clicking again on it will make it close
just like Windows does.
BUG=376511
R=
Review URL: https://codereview.chromium.org/370683002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281421 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=dmichael@chromium.org
BUG=389084
Review URL: https://codereview.chromium.org/373553002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281420 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Related to contextual search feature.
BUG=374932
Review URL: https://codereview.chromium.org/371463010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281419 0039d316-1c4b-4281-b951-d872f2087c98
|