| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
HostedTab overrides the external navigation handler and
delegate in ChromeTab, so that when if we fail to find a
default receiver of an intent, we never show an intent
picker.
BUG=492865
Review URL: https://codereview.chromium.org/1160493005
Cr-Commit-Position: refs/heads/master@{#334107}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The method RenderText::SetDirectionalityMode is supposed to allow the
client to override the default directionality mode (getting the
directionality from the text). However, a bug in BiDiLineIterator means
that it is largely ignored (in the majority of cases, it will use the
directionality of the text regardless).
Fixed BiDiLineIterator to honour the supplied direction.
This should have almost no noticeable effect, as almost all text fields
use the default directionality mode anyway.
BUG=496023,495933
Review URL: https://codereview.chromium.org/1153603004
Cr-Commit-Position: refs/heads/master@{#334106}
|
|
|
|
|
|
|
|
|
| |
BUG=494910
TEST=manually
Review URL: https://codereview.chromium.org/1179823003
Cr-Commit-Position: refs/heads/master@{#334105}
|
|
|
|
|
|
|
|
|
|
| |
the cast extension.
BUG=495805
Review URL: https://codereview.chromium.org/1162093003
Cr-Commit-Position: refs/heads/master@{#334104}
|
|
|
|
|
|
|
|
|
| |
BUG=none
TBR=xhwang@chromium.org
Review URL: https://codereview.chromium.org/1182693002
Cr-Commit-Position: refs/heads/master@{#334103}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently VideoCaptureOracle rejects out-of-order captures. This can cause
issues if a capture fast-fails, delivering a failed out of order capture
result. This failed result will cause pending successful results to be
incorrectly discarded.
With browser impl side painting on, this behavior causes a regression in
tab capture performance.
This change ensures that we only reject out-of-order successful captures
(ignoring out-of-order failures).
R=miu@chromium.org
BUG=498910
Review URL: https://codereview.chromium.org/1183553002
Cr-Commit-Position: refs/heads/master@{#334102}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some of these suppressions are recent regressions, but the redness of
the bots is causing the sheriffs difficulty.
Tested locally on Nexus 5, 6, and 9.
BUG=499555
TBR=bajones@chromium.org,sievers@chromium.org,zmo@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/1178233005
Cr-Commit-Position: refs/heads/master@{#334101}
|
|
|
|
|
|
|
|
|
|
|
| |
This CL updates the title of custom toolbar upon navigation, so that the
title won't be cleared every time the user clicks back button.
BUG=499574
Review URL: https://codereview.chromium.org/1181913002
Cr-Commit-Position: refs/heads/master@{#334100}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
relnote: splitting quic client session into a virtual function (no-op)
Move the creation of the quic client session into a function
we can override to create custom sessions for quic-to-backend.
Merge internal change: 95324185
https://codereview.chromium.org/1174173008/
relnote: Reorder some commonly used QUIC structs according
ClassLayoutOptimizer's suggestions.
Merge internal change: 95320291
https://codereview.chromium.org/1178273005/
Fix QuicSession::GetCryptoStream() in tests to return non-null during
initialization.
Previously in some tests GetCryptoStream() was returning nullptr when
called during initialization and the stream was created later. That
wouldn't work if the crypto stream needs to be used during
initialization. Fixed tests that had this issue and added DCHECK in
Initialize().
relnote: Minor cleanup in QUIC tests
Merge internal change: 95316723
https://codereview.chromium.org/1180943004/
relnote: adding a default response to the quic cache (not used in
production).
Addding the option for a default value to be set for the quic in-memory
cache. This is needed for quic-to-backend because the internal server
tests assume a default response and one-offing per-url is silly. Plus
I've run up against this lack of feature in annoying ways a few times
now.
Merge internal change: 95297412
https://codereview.chromium.org/1177043007/
relnote: Reverse the sense of flag quic_stop_early and rename it to
FLAGS_quic_stop_early_2. This causes QUIC frames to not be processed
after the connection is terminated.
FIXED=21370767
Merge internal change: 95296106
https://codereview.chromium.org/1183543002/
Test handshake message handling on packet generator level.
This tests the flush-on-handshake logic, and also verifies that the
packet is correctly padded (which would be helpful for subsequent
changes in which the packets will be tagged for padding by generator
itself).
relnote: n/a (test-only change)
Merge internal change: 95202648
https://codereview.chromium.org/1178253002/
Remove implementation of pure virtual functions in QuicFramerVisitorInterface.
relnote: n/a (removing dead code)
Merge internal change: 95197850
https://codereview.chromium.org/1184503002/
Avoid overloading QuicSession::InitializeSession().
Previously QuicServerSession and QuicClientSession were overloading
QuicSession::InitializeSession() with parameters. Moved the parameters
to the constructors so these child classes now can override
QuicSession::InitializeSession() instead of overloading it. Also made
the method virtual.
relnote: QuicSession cleanup, doesn't affect functionality
Merge internal change: 95174532
https://codereview.chromium.org/1173343002/
Minor change to keep the code similar to internal source.
Merge internal change: 95167379
https://codereview.chromium.org/1181533005/
relnote: Increase QUIC flow control window sizes dynamically if data
flows quickly enough. Flag protected by
FLAGS_quic_receive_window_auto_tune, and new AFCW connection tag.
QUIC receivers send WINDOW_UPDATE when the flow passes the 1/2 point of
the current window position. Analysis shows that WINDOW_UPDATES must be
more than 1 * RTT apart to prevent the sender from being impeded due to
insufficient window size, and a minimum receive window size of 2 * BDP.
To avoid the sender becoming blocked, we monitor the timing of window
updates relative to the flow rate, and if necessary increase the window
size. To add some padding for transients, this algorithm uses trigger
of 2 * RTT to increase receive window size, on the interval between
successive WINDOW_UPDATES, which corresponds to targeting a receive
window size of ~ 4 * BDP.
Merge internal change: 95154188
https://codereview.chromium.org/1180693004/
Reversed if statements check for FEC_ANY_TRIGGER with FEC_ALARM_TRIGGER
check.
From jri: Since FEC_ANY_TRIGGER is the "catch-all" policy, it seems more
readable to have the if clause reversed... i.e., check for
FEC_ALARM_TRIGGER and the catch-all be in the else clause.
relnote: n/a. Test only readability change.
Merge internal change: 95122056
https://codereview.chromium.org/1175113004/
R=rch@chromium.org
Review URL: https://codereview.chromium.org/1181643003
Cr-Commit-Position: refs/heads/master@{#334099}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* TabDelegate, which is used to create tabs in document-mode
now subclasses the TabCreator class that tabbed-mode uses.
* Being consolidating methods for creating tabs in the TabDelegate
class.
- Various methods for opening new Tabs under specific conditions
(e.g. for devtools, or for opening an NTP) in document mode are
cleaned up.
- DocumentActivity's SingleTabModelSelector now defers to the
DocumentTabModelSelector when opening new Tabs.
- DocumentTabModelImpl uses generic methods in TabDelegate to
create Tabs as similarly as possible to the TabModelImpl.
In contrast to how TabModelImpl works with
ChromeTabbedActivity, the DocumentTabModel has no specific
Activity to grab TabCreators from. Instead, the
DocumentTabModelSelector becomes a TabCreatorManager and
passes out its TabCreators when necessary.
* TabCreator.createFrozenTab now returns a Tab to line up with how
document mode creates frozen tabs.
* DocumentTabChromeWebContentsDelegateAndroidImpl no longer stores
a mapping between the WebContents' URL and its native pointer.
Instead, the URL is grabbed via JNI before the new Activity is
launched.
BUG=451453
Review URL: https://codereview.chromium.org/1176943002
Cr-Commit-Position: refs/heads/master@{#334098}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before this change, the SetupCommand() call in service_runtime.cc
connected to the SRPC trusted command channel. We replace this with a
subset of what SetupCommand() did. (Note that the renderer can still
connect to the *untrusted* SRPC command channel, which is used by the
PNaCl translator.)
Before, we were not sending any messages on the trusted command
channel, but the NaCl loader process was detecting EOF on the channel
and exiting in response (via a call to NaClAppShutdown() in
nacl_secure_service.c). We replace this with new logic in
nacl_trusted_listener.cc which detects EOF on a Chrome IPC channel.
* This happens to be tested indirectly via tests for the GDB debug
stub. They hang if the NaCl loader process sticks around after an
<embed> element is deleted.
* This change changes the debug stub's behaviour slightly: If a NaCl
process is forcibly terminated (such as by its <embed> being
deleted), GDB will get an EOF on the debug socket without seeing a
SIGKILL (-9) exit status being reported first. I'm not sure it's
worthwhile doing the extra plumbing to keep the original "-9"
status reporting (which was added for https://crbug.com/157881).
Before, GDB prints:
Program terminated with signal SIGKILL, Killed.
The program no longer exists.
After, GDB prints:
Remote connection closed
* Remove the existing OnChannelError() because it never gets called.
A call to it get queued on the main thread, but the main thread
gets blocked in NaClChromeMainAppStart().
BUG=496287
TEST=debug stub tests: NaClGdbDebugStubTest.*, NaClBrowserTestPnaclDebug.*
Review URL: https://codereview.chromium.org/1153293003
Cr-Commit-Position: refs/heads/master@{#334097}
|
|
|
|
|
|
|
|
| |
BUG=427122
Review URL: https://codereview.chromium.org/1175423002
Cr-Commit-Position: refs/heads/master@{#334096}
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1181003002
Cr-Commit-Position: refs/heads/master@{#334095}
|
|
|
|
|
|
|
|
|
|
| |
This most often occurs during a tab cast, because the tab title is included inside of the message displayed to the user.
BUG=497853
Review URL: https://codereview.chromium.org/1177033004
Cr-Commit-Position: refs/heads/master@{#334094}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These classes were no longer tested, and were not even used by the
ui compositor.
R=enne, vmpstr
BUG=413479
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1173203002
Cr-Commit-Position: refs/heads/master@{#334093}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GpuMemoryBuffer allocation can fail when using native
GpuMemoryBuffers as they are allocated by the GPU process.
This is a minimal set of changes to keep as much logic as
possible the same in lost context situations.
BUG=486922
TEST=content/test/gpu/run_gpu_test.py context_lost --extra-browser-args=--enable-native-gpu-memory-buffers --story-filter=GpuCrash.GPUProcessCrashesExactlyOnce
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1178303003
Cr-Commit-Position: refs/heads/master@{#334092}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before Contextual Search gets back a resolution from the server we
show gray surrounding text for the given selection. This surrounding
text often contains [obj] characters for images. This CL removes such
characters.
This CL also adds me to OWNERS for this directory.
BUG=489826
Review URL: https://codereview.chromium.org/1173263002
Cr-Commit-Position: refs/heads/master@{#334091}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/1422ec8..0a24297
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=djsollen@google.com
Review URL: https://codereview.chromium.org/1178033003
Cr-Commit-Position: refs/heads/master@{#334090}
|
|
|
|
|
|
|
|
|
|
|
| |
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/7ad4145..8bccdfe
TBR=dglazkov@chromium.org,haraken@chromium.org
Review URL: https://codereview.chromium.org/1179033003
Cr-Commit-Position: refs/heads/master@{#334089}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Which grew a dependency on the media router mojo bindings in #333534.
R=kmarshall@chromium.org
TBR=brettw@chromium.org
BUG=499158
Review URL: https://codereview.chromium.org/1185493002
Cr-Commit-Position: refs/heads/master@{#334088}
|
|
|
|
|
|
|
|
|
|
|
|
| |
These will be updated and re-enabled once the first real commit type
for subframes in Blink is fixed.
BUG=498559
TEST=Tree stays green after https://codereview.chromium.org/1173513002/.
Review URL: https://codereview.chromium.org/1180013002
Cr-Commit-Position: refs/heads/master@{#334087}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Update MEDIA_LOG macro to accecpt MediaLog.
- Plumb MediaLog through many core classes in our media stack.
- Report MEDIA_LOG in these class when error happens.
If needed, we could report MEDIA_LOG in more places.
TBR=jrummell@chromium.org
BUG=492845
TEST=Manually test with various failure cases.
Review URL: https://codereview.chromium.org/1176233002
Cr-Commit-Position: refs/heads/master@{#334086}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When a reload occurs (or other inert commits), we leave the history tree alone.
However, if iframes are dynamically created, we end up with both the old
iframes and the new iframes in the history tree, and we never prune them.
Instead, if a different-document inert commit occurs, remove the committing
node's children, since the corresponding frames are no longer in the frame tree.
This reverts commit 5c8a902ebf5277d4c621d9c190cf659fbebcfc7a. It was reverted
due to a variety of crashes caused by failure to remove deleted HistoryNodes
from HistoryController's lookup maps. This should be resolved as of
https://crrev.com/740b2ff5e2da9041c3d3e80cb612c82e27d15300
BUG=485385
Review URL: https://codereview.chromium.org/1149563006
Cr-Commit-Position: refs/heads/master@{#334085}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To help identifying issues with the connectivity feedback data, this CL
adds data about timeouts and the elapsed time before the data was
gathered.
Some of the flows where this data is used, there is a very short or no
delay between starting the connectivity checks and gathering the results
so this should help identify such cases.
BUG=386395
Review URL: https://codereview.chromium.org/1178703010
Cr-Commit-Position: refs/heads/master@{#334084}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It is not currently possible to use scoped_ptr values in a std::map, due
to lack of C++11 library support; this class is a placeholder mapping
type that allows scoped_ptr values.
Internally, ScopedPtrMap does not use scoped_ptrs; it uses raw pointers
and automatically deletes its values when it is destroyed, or elements
are removed from the map. It is therefore safer to use than a map with
owned raw pointers as values, even when using an STLValueDeleter. It
also makes ownership much clearer, as you can insert elements into the
map via scoped_ptrs.
BUG=478594
Review URL: https://codereview.chromium.org/1076273004
Cr-Commit-Position: refs/heads/master@{#334083}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The crash happens because the CommandBufferImpl can be destroyed on
another thread. This is because the CommandBufferImpl uses a
strongbinding that is created on another thread. This means if there
is a connection error the CommandBufferImpl is destroyed on the
background thread. CommandBufferImpl has references to a bunch of
things that need to be destroyed on the main thread.
BUG=none
TEST=none
R=jam@chromium.org
Review URL: https://codereview.chromium.org/1179933003
Cr-Commit-Position: refs/heads/master@{#334082}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Counts how often:
1. Lo-Fi is temporarily disabled for the remainder of the
session (This occurs if a user clicks 'show images' for k
pages in a session)
2. Lo-Fi is disabled for the user (This occurs if
LoFi is temporarily disabled for j consecutive sessions)
3. Lo-Fi is turned back on using a new implicit opt out
version number.
BUG=495689
Review URL: https://codereview.chromium.org/1161773013
Cr-Commit-Position: refs/heads/master@{#334081}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There is almost nothing remaining in port.h, just the API_CALL macro.
Since these files are not using it we can remove this include from them.
BUG=138542
R=thestig@chromium.org,mnissler@chromium.org,dmazzoni@chromium.org,dalecurtis@chromium.org,mattm@chromium.org,zea@chromium.org
Review URL: https://codereview.chromium.org/1181713004
Cr-Commit-Position: refs/heads/master@{#334080}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
still running.
- Requires implementing onNewIntent in the activity. This seemed unnecessary/unneeded in MojoShellActivity so I took this opportunity to fork the activity impl and provide a Mandoline-specific implementation.
- This required additional paramaterization of some of the run scripts to support a different package (org.chromium.mandoline) and start activity.
- Added an interface LaunchHandler that allows the shell embedder to connect to the browser & pass the subsequently requested URLs along.
- Added a script that only installs Mandoline on the device and doesn't run it. Not all pushes need to be run (e.g. when debugging launch via intent).
- Renamed/moved the run/install scripts to a subdir for easier autocomplete.
- Moved the Omnibox and ViewEmbedder interfaces into the canonical public/interfaces subdir along with LaunchHandler.
- Light cleanup in ShellMain - ShellMain.Start() can no longer fail.
R=sky@chromium.org
Review URL: https://codereview.chromium.org/1177893002
Cr-Commit-Position: refs/heads/master@{#334079}
|
|
|
|
|
|
|
|
|
| |
BUG=499527
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_nexus5_perf_bisect
Review URL: https://codereview.chromium.org/1183533003
Cr-Commit-Position: refs/heads/master@{#334078}
|
|
|
|
|
|
|
|
|
|
| |
Move public image_processing modules to util.
BUG=499033
Review URL: https://codereview.chromium.org/1174183002
Cr-Commit-Position: refs/heads/master@{#334077}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chrome originally had 0 text relocations, but ffmpeg has always had a
few (steadily decreasing). Since static linking ffmpeg, chrome's
count has come to contain those from ffmpeg. Pinning the max/min to
match the count from ffmpeg preserves our enforcement that chrome
should have no wiggle room to contribute additional text relocations.
This is a follow up cl to the expectations update I made upon landing
ffmpeg static linking.
https://codereview.chromium.org/1161633003
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/1177233007
Cr-Commit-Position: refs/heads/master@{#334076}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Seems it's now failing on the linux bots as well. Disabled everywhere.
TBR=alancutter@chromium.org
NOTRY=true
BUG=499472
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect
Review URL: https://codereview.chromium.org/1178373002
Cr-Commit-Position: refs/heads/master@{#334075}
|
|
|
|
|
|
|
|
|
|
|
| |
Start dismissing the contextual search panel when user clears
the selection (e.g. when pressing copy in context menu).
BUG=487688
Review URL: https://codereview.chromium.org/1182553003
Cr-Commit-Position: refs/heads/master@{#334074}
|
|
|
|
|
|
|
|
| |
BUG=498232
Review URL: https://codereview.chromium.org/1182623002
Cr-Commit-Position: refs/heads/master@{#334073}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes test failures introduced by
https://codereview.chromium.org/1163403005/ where PageScrollState
tests would hang since the applied scroll state didn't match the
current navigation item's.
BUG= 493427
Review URL: https://codereview.chromium.org/1184533002
Cr-Commit-Position: refs/heads/master@{#334072}
|
|
|
|
|
|
|
|
| |
BUG=499570
Review URL: https://codereview.chromium.org/1184553002
Cr-Commit-Position: refs/heads/master@{#334071}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Granular per-file permissions will allow feature owners to make changes
without needing to pester top-level owners.
R=finnur@chromium.org,mfoltz@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1179813005
Cr-Commit-Position: refs/heads/master@{#334070}
|
|
|
|
|
|
|
|
|
|
| |
(per http://crrev.com/1146873002/#msg26)
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/1172553002
Cr-Commit-Position: refs/heads/master@{#334069}
|
|
|
|
|
|
|
|
|
|
|
| |
chrome/browser/extensions/browser_context_keyed_service_factories.cc
Move some include files to:
extensions/browser/browser_context_keyed_service_factories.cc
Review URL: https://codereview.chromium.org/1178673006
Cr-Commit-Position: refs/heads/master@{#334068}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/1178943003
Cr-Commit-Position: refs/heads/master@{#334067}
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: https://codereview.chromium.org/1178313002
Cr-Commit-Position: refs/heads/master@{#334066}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
They didn't show in my local run, so might be GPU specific.
For now, just exclude then on the OS.
BUG=483282
TEST=GPU FYI waterfall
R=bajones@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/1183593002
Cr-Commit-Position: refs/heads/master@{#334065}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Required for use of the cardboard-java library.
src/third_party/cacheinvalidation/src/proto/android_channel.proto must be updated to include "option allow_alias = true;" in the MajorVersion enum. Otherwise a build-blocking warning about duplicate enum values is raised after this roll.
BUG=389343
Review URL: https://codereview.chromium.org/1149283005
Cr-Commit-Position: refs/heads/master@{#334064}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ImageManager was decoding and storing cached images during load, taking 1.27MiB
for 6 NTP tiles in the Clank's case (6 * 296 * 188 * 4). Since NTP tiles are only
requested when NTP page is created, it makes sense to decode them on demand and
store encoded image data in the cache instead.
BUG=493883
Review URL: https://codereview.chromium.org/1156003008
Cr-Commit-Position: refs/heads/master@{#334063}
|
|
|
|
|
|
|
|
|
|
| |
Also adding a trailing / to blocksingle, block, fallback urls. Without the / we get a 301 permanent redirect which can be cached and cause issues if we want to change the response behavior later on.
BUG=489886
Review URL: https://codereview.chromium.org/1181513003
Cr-Commit-Position: refs/heads/master@{#334062}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MojoCdmServiceContext will serve as a bridge between a MojoRendererService and a
MojoCdmService such that the renderer service can use the CDM service to decrypt
(and decode) encrypted contents.
With this change, now MojoCdmServiceContext owns and manages all MojoCdmService
instances so that MojoRendererService can find the correct CDM to use given a
|cdm_id|. As a result, MojoCdmService is not strongly bound to the pipe anymore.
An alternative to this is to have MojoCdmService still strongly bound to the
pipe, but notifies the MojoCdmServiceContext when the service is created and
destroyed. Here I was just following existing code like PermissionServiceContext
and GeolocationServiceContext.
TBR=sky@chromium.org
BUG=432998
Review URL: https://codereview.chromium.org/1165633004
Cr-Commit-Position: refs/heads/master@{#334061}
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://chromium.googlesource.com/angle/angle.git/+log/e754fb8..6ffeb74
BUG=
TEST=bots
Review URL: https://codereview.chromium.org/1180613006
Cr-Commit-Position: refs/heads/master@{#334060}
|
|
|
|
|
|
|
|
|
|
| |
This CL removed an unused data member |parent_| and uses instancetype as the return value from inits. There is also a comment fix.
BUG=
Review URL: https://codereview.chromium.org/1177943002
Cr-Commit-Position: refs/heads/master@{#334059}
|
|
|
|
|
|
|
|
| |
BUG=499533
Review URL: https://codereview.chromium.org/1183583002
Cr-Commit-Position: refs/heads/master@{#334058}
|