| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1159023005
BUG=496588
TEST=None
Review URL: https://codereview.chromium.org/1158263003
Cr-Commit-Position: refs/heads/master@{#332909}
|
|
|
|
|
|
|
|
|
|
|
| |
Added a CreateGaiaAuthFetcher method to the SigninClient to allow
the usage of a platform-specific GaiaAuthFetcher.
BUG=
Review URL: https://codereview.chromium.org/1162303002
Cr-Commit-Position: refs/heads/master@{#332908}
|
|
|
|
|
|
|
|
|
|
|
| |
Many places in ash were checking that window types were NORMAL or PANEL.
The wm::IsWindowUserPositionable(...) encapsulates this check.
BUG=None
Review URL: https://codereview.chromium.org/1157843009
Cr-Commit-Position: refs/heads/master@{#332907}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
were killed by oom-killer.
Removed obsolete UMA stats (SadTab.Created)
This depends on https://codereview.chromium.org/1157163008/
BUG=493978
Review URL: https://codereview.chromium.org/1146893003
Cr-Commit-Position: refs/heads/master@{#332906}
|
|
|
|
|
|
|
|
|
|
|
| |
This CL checks Cronet native library version with java version and make sure
the versions match.
BUG=493222
Review URL: https://codereview.chromium.org/1158323007
Cr-Commit-Position: refs/heads/master@{#332905}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
line switch or if Auto LoFi is on.
Also, adds few histograms to track compression benefit of LoFi and
to track the state of Auto LoFi.
BUG=485639, 470596
Review URL: https://codereview.chromium.org/1135333003
Cr-Commit-Position: refs/heads/master@{#332904}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL uses the new methods content::BrokerDuplicateSharedMemoryHandle() and
base::SharedMemory::DuplicateHandle() to remove some duplicated code. This CL
changes the implementation of ShareSharedMemoryhandleWithRemote() to no longer
assume that the SharedMemoryHandle is backed by a POSIX fd.
BUG=466437
Review URL: https://codereview.chromium.org/1166443004
Cr-Commit-Position: refs/heads/master@{#332903}
|
|
|
|
|
|
|
|
|
| |
BUG=496707
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect
Review URL: https://codereview.chromium.org/1165033002
Cr-Commit-Position: refs/heads/master@{#332902}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, the ConnectivityCheckerCollector only collects data about
a set number of connection types. It will soon also include more
network connectivity information, and this CL prepares it so it will
be cleaner to add such data in upcoming CLs.
BUG=386395
Review URL: https://codereview.chromium.org/1166803002
Cr-Commit-Position: refs/heads/master@{#332901}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Flaking on LinuxChromiumOS bot.
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20(dbg)(1)
TBR=nkostylev@chromium.org
BUG=496832
Review URL: https://codereview.chromium.org/1151173008
Cr-Commit-Position: refs/heads/master@{#332900}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
#1 id:1 of https://codereview.chromium.org/1159493010/)
Reason for revert:
Broke Linux ChromiumOS compile.
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Builder/builds/17764/steps/compile/logs/stdio#error1
Original issue's description:
> ozone: Remove singleton pattern for SurfaceFactoryOzone.
>
> OzonePlatform is sigleton already, so it's not necessary for
> SurfaceFactoryOzone to be singleton.
>
> Committed: https://crrev.com/48b0a7165bd6c9d889fc6d6959a6e59cf7ef9dc6
> Cr-Commit-Position: refs/heads/master@{#332889}
TBR=spang@chromium.org,sievers@chromium.org,alexst@chromium.org,dongseong.hwang@intel.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1167533007
Cr-Commit-Position: refs/heads/master@{#332899}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/321fa70..270fe6a
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=caryclark@google.com
Review URL: https://codereview.chromium.org/1151263009
Cr-Commit-Position: refs/heads/master@{#332898}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
By using the operator DCHECKs, debug output is cleaner in the case of
failure (showing potentially useful information), and code readability
is improved.
BUG=None
R=jkarlin@chromium.org
Review URL: https://codereview.chromium.org/1152693004
Cr-Commit-Position: refs/heads/master@{#332897}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
interval.
max_bytes_per_copy_operation provides a mechanism to split one-copy
work into smaller units to prevent the GPU service from being
blocked for too long. The flush interval groups a number of
copy operations into one from the GPU service POV so it makes
sense to use the same limit to determine how frequently to
issue flush tasks.
This keeps the flush interval at 4 copy operations when using a
512x512 tile size by using a 4MB default value for
max_bytes_per_copy_operation.
BUG=460288
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1148413007
Cr-Commit-Position: refs/heads/master@{#332896}
|
|
|
|
|
|
|
|
|
|
|
| |
Updates isolate to 0.2.2. Updates Go toolset to 1.4.2.
R=vadimsh@chromium.org
BUG=496268
Review URL: https://codereview.chromium.org/1146123005
Cr-Commit-Position: refs/heads/master@{#332895}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently Android telemetry tests only use touch, but
there's no reason to not test mouse input as well.
This patch enables mouse wheel input, which will be used in
https://codereview.chromium.org/1157093002/.
BUG=317007
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_nexus5_perf_bisect
Review URL: https://codereview.chromium.org/1159513004
Cr-Commit-Position: refs/heads/master@{#332894}
|
|
|
|
|
|
|
|
|
| |
BUG=369661
TEST=everything should still pass
Review URL: https://codereview.chromium.org/1163983003
Cr-Commit-Position: refs/heads/master@{#332893}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Trace-viewer currently maintains two copies of its input files. This
causes duplicate work each time we add a file. I'd like to share a
single .gypi file between GYP and GN but need to use exec_script
in order to do so.
This CL adds an exeception to allow trace-viewer to use exec_script
in its BUILD.gn file.
Review URL: https://codereview.chromium.org/1160793005
Cr-Commit-Position: refs/heads/master@{#332892}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Motivations:
1. Eliminates a large number of windows crashes hit while loading the DLL (see bugs)
2. Reducing the size of binary (about 400KB on linux, about 265KB on 32bit windows) due to dead-code elimination
3. Simplifying media library initialization (Remove bool-ness, it just works)
Licensing:
We've audited all the licenses for the files we actually use and have the green light from legal as long as we include the license text in the credits.
BUG=435455, 429131, 441908
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1141703002
Cr-Commit-Position: refs/heads/master@{#332891}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The API for RenderFrames is cleaner than that of blink::WebFrame, and,
generally, since the content layer exists specifically to abstract out blink
stuff, we should use it when we can. (Note this doesn't change it
everywhere, but is a good start.)
Also, update blink::WebFrame to blink::WebLocalFrame where
applicable.
Also clean up the ScriptInjectionCallback interface.
BUG=455776
Review URL: https://codereview.chromium.org/1154643005
Cr-Commit-Position: refs/heads/master@{#332890}
|
|
|
|
|
|
|
|
|
| |
OzonePlatform is sigleton already, so it's not necessary for
SurfaceFactoryOzone to be singleton.
Review URL: https://codereview.chromium.org/1159493010
Cr-Commit-Position: refs/heads/master@{#332889}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#332888}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) make (x) dialog buttons update whether focus outline is visible
2) don't restore focus when keyboard triggered dialogs are closed by mouse
3) make chrome://extensions overlays act more sanely
4) remove odd code that required activeElement != body to set initial focus
R=dmazzoni@chromium.org
BUG=472031,481502
Review URL: https://codereview.chromium.org/1162293008
Cr-Commit-Position: refs/heads/master@{#332887}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Telemetry renamed GetUserStorySet to GetStorySet causing our test to fail
when we try to override this function. The test works as expected after
updating the name here.
BUG=496828
Review URL: https://codereview.chromium.org/1164083002
Cr-Commit-Position: refs/heads/master@{#332886}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
extension is uninstalled
We should call InstanceID::DeleteID which contains the logic not to
delete tokens when the ID does not exist, instead of calling directly
into GCMDriver.
BUG=496032
TEST=Manual test by uninstall an extension/app w/ gcm permission
TBR=kalman@chromium.org
Review URL: https://codereview.chromium.org/1153413005
Cr-Commit-Position: refs/heads/master@{#332885}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds the v8 heap object counts recorded from the previous GC
into chrome://tracing. This is the second part of adding v8 heap
memory statistics into tracing.
Note: Chrome should be run with --js-flags='--track_gc_object_stats
--noincremental-marking' for object tracking.
BUG=476013
Review URL: https://codereview.chromium.org/1131263005
Cr-Commit-Position: refs/heads/master@{#332884}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is very strong signal that they were killed by oom killer.
Following UMA stats are added, as subsets of its parent UMA stats.
ChildProcess.Killed2.OOM
BrowserRenderProcessHost.ChildKills.OOM
BUG=493978
TEST=ProcessUtilTest.GetTerminationStatusSigTerm, manual
Review URL: https://codereview.chromium.org/1157163008
Cr-Commit-Position: refs/heads/master@{#332883}
|
|
|
|
|
|
|
|
|
|
| |
I think the reference needs to roll for this to work.
BUG=496684
Review URL: https://codereview.chromium.org/1170503002
Cr-Commit-Position: refs/heads/master@{#332882}
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1153393007
Cr-Commit-Position: refs/heads/master@{#332881}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome://tracing
This CL changes the memory maps dump provider to dump private dirty
and private clean as separate counters and similarly for shared memory.
It also adds swapped memory counter.
BUG=488383
Review URL: https://codereview.chromium.org/1160143003
Cr-Commit-Position: refs/heads/master@{#332880}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The SkBitmap's internal pixel ref is taken when the SkCavas is drawing
the image. SkCanvas deferrs the drawing operation. Since the XImage
would be destroyed when CopyAreaToCanvas()'s scope ends, the saved
pixel ref now points into deallocated memory.
This change pushes the ownership of the XImage into the SkBitmap such
that it is released when the SkCanvas releases the SkBitmap's pixel ref.
TEST=Ran ASAN build on x86-alex
BUG=492921
Review URL: https://codereview.chromium.org/1158233006
Cr-Commit-Position: refs/heads/master@{#332879}
|
|
|
|
|
|
|
|
|
|
|
| |
For a full list of changes, see
https://github.com/chromium/web-page-replay/commit/5da5975950daa7b30a6938da73fd0b3200901b0c
BUG=493869
Review URL: https://codereview.chromium.org/1157943008
Cr-Commit-Position: refs/heads/master@{#332878}
|
|
|
|
|
|
|
|
| |
BUG=492787
Review URL: https://codereview.chromium.org/1162103003
Cr-Commit-Position: refs/heads/master@{#332877}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
users" in Chrome OS' People settings.
Still TODO:
1. Do client side / JS validation of the user name / email entered in the "Add users" field.
2. Add the desired prefs to the whitelist in prefs_util.cc.
3. Use an inverted pref (we need to make this first in a separate cl) for the 'restrict sign-in to the following users' checkbox.
4. Gray out checkboxes / fields when user isn't the owner, and hide the user list when the settings isn't managed.
5. Prevent the owner from deleting herself/himself.
6. Verify that everything works right with the fully implemented usersPrivate API.
7. Make the Users page a subpage rather than a top level page. I'm making it a top level page for now since otherwise there's no way to access it. Once we add the top level People page we'll move this underneath it.
BUG=495858
Review URL: https://codereview.chromium.org/1145423008
Cr-Commit-Position: refs/heads/master@{#332876}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch removes GetMaxTilePriorityBin in favor of exposing
HasValidTilePriorities directly. Although, initially we thought
GetMaxTilePriorityBin was a nicer abstraction, this makes it difficult
to separate layer knowledge from raster iterators (they check whether
layers have valid tile priorities). This patch allows tiling sets to
be passed to the raster iterators and the equivalent check to be
performed via tiling client.
R=danakj, enne
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1154263002
Cr-Commit-Position: refs/heads/master@{#332875}
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=sadrul@chromium.org
TBR=sadrul@chromium.org
Review URL: https://codereview.chromium.org/1155243009
Cr-Commit-Position: refs/heads/master@{#332874}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
An undocumented feature of CAOpenGLLayer is that it will drain your
battery. Add a path that renders content via a NSOpenGLContext (which
has an undocumented feature of not draining your battery as much).
Keep all of this behind a --enable-ns-gl-surfaces flag.
Because a NSOpenGLContext needs to be attached to an NSView, this
implies that we will have to use the cross-process IOSurface currently
in use by 10.6 through 10.8.
For the moment, have one NSOpenGLContext per window, and disable
eviction of IOSurfaces in this mode to keep the implementation simple.
This version is enough to employ for reliable perf testing. It still needs
robustness work (how and when to do eviction, recycling and context
sharing if needed, etc).
BUG=496484
Committed: https://crrev.com/8bed35093799d2c9b9156c0ef83edc6c8f0b03c1
Cr-Commit-Position: refs/heads/master@{#332843}
Review URL: https://codereview.chromium.org/1154903007
Cr-Commit-Position: refs/heads/master@{#332873}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
OverviewButtonTray was showing up on the Add-User screen. It should only be
available when a user is logged in and in the active state.
Update OverviewButtonTray to observe SessionState changes to determine
visibility.
Update WindowSelectorController to not allow overview mode while on the
add-user screen.
TEST=OverviewButtonTrayTest.VisibilityChangesForLoginStatus
BUG=488464, 482591
Review URL: https://codereview.chromium.org/1149833006
Cr-Commit-Position: refs/heads/master@{#332872}
|
|
|
|
|
|
|
|
| |
BUG=493809
Review URL: https://codereview.chromium.org/1149833013
Cr-Commit-Position: refs/heads/master@{#332871}
|
|
|
|
|
|
|
|
| |
BUG=496737
Review URL: https://codereview.chromium.org/1165043002
Cr-Commit-Position: refs/heads/master@{#332870}
|
|
|
|
|
|
|
|
|
|
|
| |
Log also audio_finished/video_finished values, to make it
easier to spot issues with EOS processing.
BUG=none
Review URL: https://codereview.chromium.org/1165013004
Cr-Commit-Position: refs/heads/master@{#332869}
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=erg@chromium.org
Review URL: https://codereview.chromium.org/1159253003
Cr-Commit-Position: refs/heads/master@{#332868}
|
|
|
|
|
|
|
|
|
|
| |
This was mistakenly removed in https://codereview.chromium.org/656383002
BUG=none
Review URL: https://codereview.chromium.org/1151313005
Cr-Commit-Position: refs/heads/master@{#332867}
|
|
|
|
|
|
|
|
|
| |
BUG=488064
R=gavinp@chromium.org
Review URL: https://codereview.chromium.org/1159413003
Cr-Commit-Position: refs/heads/master@{#332866}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The print command is specified in the PrintCommand value in the cloud print registry key. The print command specified may contain the following place holders will will be filled by the printer driver:
1. %%Document_Path%%
2. %%Document_Type%%
3. %%Job_Title%%
Please let me know if a different escape sequence for the place holder is preferred.
If a print command is not specified in the cloud print key, the chrome cloud print dialog will be launched by default.
BUG=496788
Review URL: https://codereview.chromium.org/1162043006
Cr-Commit-Position: refs/heads/master@{#332865}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch pulls in recent Trace Viewer changes.
Summary of changes available at:
https://chromium.googlesource.com/external/trace-viewer/+log/473c6c4..cd91381
BUG=458295
TBR=petrcermak@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/1149203007
Cr-Commit-Position: refs/heads/master@{#332864}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are still three pages hosted on aws where we need to add an equivelant to googlezip before we can make the switch client side. But this covers 9 of the 14 occurences we depend on aws for test pages. The remaining pages are:
aws1.mdw.la/static
aws1.mdw.la/test/cors
aws1.mdw.la/exptest
BUG=489886
Review URL: https://codereview.chromium.org/1165893003
Cr-Commit-Position: refs/heads/master@{#332863}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rename SpdyFramerPeer::kControlFrameBufferSize() to ControlFrameBufferSize(),
since it is not a constant but a method.
This lands the last changeset of server change 95032665 by bnc.
BUG=489278
Review URL: https://codereview.chromium.org/1166963003
Cr-Commit-Position: refs/heads/master@{#332862}
|
|
|
|
|
|
|
|
|
|
|
|
| |
We're now not using the NotificationService.
R=nick@chromium.org
BUG=470988, 268984
TEST=browser_tests --gtest_filter=BackgroundContentsTests.*
Review URL: https://codereview.chromium.org/1132663005
Cr-Commit-Position: refs/heads/master@{#332861}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implement MediaRouterAction to use MediaRouterDialogController to show
and hide the Media Router Dialog.
Added a views browser test for
MediaRouterUI, that uses the ToolbarActionView as the delegate that
provides the initiator WebContents to the MediaRouterAction.
Re-ordered media router browser tests definitions in gyp to exclude
the views specific test in non toolkit_views builds.
BUG=464216
Review URL: https://codereview.chromium.org/1149893020
Cr-Commit-Position: refs/heads/master@{#332860}
|