| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
the correct command. Update the unit test to verify. BUG=12260 TEST=click stop button while loading page.
Review URL: http://codereview.chromium.org/115540
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TaskManager is a singleton, so it's destroyed by AtExitManager. At the time
of destruction it cannot register AtExit callbacks (AtExitManager requires
that). It turns out that some Windows view code wants to register an AtExit
callback during destruction.
For more info about view code, see http://src.chromium.org/viewvc/chrome?view=rev&revision=9161
The fix is to destroy the view early, using EnsureShutdown static method
of TaskManager. It was also necessary to delete child views a bit earlier
to avoid another crashed.
Added a regression browser_test and verified that it's broken without this fix.
http://crbug.com/11180
Review URL: http://codereview.chromium.org/114031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
formal ones they will be available in the arguments array as elements without names. We shouldn't show such properties in the scope variables panel.
Review URL: http://codereview.chromium.org/113630
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This new version only contains two minor changes:
Fix for problem with newer gcc versions.
Exposing an API to get the context of the calling JavaScript code.
Review URL: http://codereview.chromium.org/113632
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
a NULL SVGElement which makes no sense.
BUG=12105
Review URL: http://codereview.chromium.org/113627
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16471 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115560
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The only tests that are newly failing are new tests added for WCSS
which are also skipped by desktop platforms (osx, windws, etc.)
upstream as well.
BUG=12310
TEST=no additional test regressions.
Review URL: http://codereview.chromium.org/113624
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16469 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebCore::multipleFileUploadText() is already declared in LocalizeStrings.h, and
implemented and used in other platforms.
This patch won't change Chromium's behavior for now. We need to change
WebCore/platform/chromium/FileChooserChromium.cpp to use this string.
Patch by Kent Tamura (tkent@google.com)
R=darin
BUG=8740
Review URL: http://codereview.chromium.org/113620
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
navigating to a new url. If a reload is in progress, 'loading' will not be accompanied by 'url'.
Also, refactored some code so that string constants are defined and shared.
BUG=11200
R=erikkay
Review URL: http://codereview.chromium.org/113552
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115550
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16466 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of turning on strict HTTPS error processing for every site, we now track which sites have opted in. Our implementation is still experimental and hidden behing the command line switch --force-https.
R=darin
TEST=No tests yet because this is just an experiment.
Review URL: http://codereview.chromium.org/113503
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16464 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
crash in CodeGenerator::IsUnsafeSmi.
Review URL: http://codereview.chromium.org/115539
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16463 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
created for has long been closed. This code causes crashes when the browser is closed with the task manager open (in debug builds at the very least).
Review URL: http://codereview.chromium.org/115553
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I added a command line for the renderer that accepts a FieldTrial
name and value, and forces that value to be activated in the
renderer. As a result, any FieldTrial setting that is specified
by the browser process can be set (forced) in the renderer
process. Such settings can then be used to establish names
of histograms, which means all processes can work in sync
on a single field trial (and generate data). This should
allow A/B tests to be run that modulate the page load times.
Dave: Please review/confirm that you are happy with the changes to
render_view.cc. Note that all I did was change the names and limits
for the histograms (they now go up to 3 minutes). The MakeName()
allows me to get an A/B test of the impact of DNS pre-resolution.
Mike: Please review the code for passing along switch settings.
r=davemoore,mbelshe
Review URL: http://codereview.chromium.org/115525
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113615
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=0
TEST=no additional test regressions.
Review URL: http://codereview.chromium.org/115546
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Use SeekableBuffer as internal cache for BufferedResourceLoader.
By switch to SeekableBuffer that supports short seek within
buffered data in both backward and forward direciton. The amount
of range request is greatly reduced.
Review URL: http://codereview.chromium.org/115453
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16456 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16455 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
to avoid using WebKitClient outside the main thread.
Review URL: http://codereview.chromium.org/115103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Previously we were using integer math to convert to microseconds, but depending on the frame rate and packet size we could introduce enough error that could accumulate and introduce audio/video synchronization drift. av_rescale_q() is a simple function but is designed to minimize error as much as possible.
Review URL: http://codereview.chromium.org/113598
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113602
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16452 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=12052
Review URL: http://codereview.chromium.org/115548
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16451 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/12259
Review URL: http://codereview.chromium.org/113609
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16450 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
of assistive technologies (accessibility). Also cleans up the handling of WM_GETOBJECT in RenderWidgetHostViewWin and WidgetWin, as well as in BrowserAccessibilityManager.
Review URL: http://codereview.chromium.org/115374
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16449 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=12052
Review URL: http://codereview.chromium.org/113592
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16447 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
child windows so that we can paint out of process HWNDs asynchronously. The problem is that the function parameter that was passed in to the first RedrawWindow was modified since it's a member variable of the class. OnPaint would empty the rectangle, and so nothing was painted for children.
BUG=12010
TEST=unsafe downloads should have their save/discard buttons painted normally.
Review URL: http://codereview.chromium.org/115545
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16446 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Nor do we have support for alternate file formats; nor do we have a default icon.
BUG=http://crbug.com/8631
Review URL: http://codereview.chromium.org/113571
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=Scripting in the browser. This should be pretty well covered by other testing.
BUG=http://crbug.com/12063
Review URL: http://codereview.chromium.org/115542
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/11387
Review URL: http://codereview.chromium.org/112038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moved detection from -controlTextDidEndEditing: to
-control:textShouldEditEditing: in case any of the code depends on
still having focus when this happens.
http://crbug.com/12252
TEST=Type "word" in omnibox. Click on page. Popup should dissappear.
Review URL: http://codereview.chromium.org/116006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=mirandac
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16439 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/115265
Original text:
"""
This addresses 3 of the 4 issues described in Issue 9223:
1) Creates a new streamlined bubble with less text.
2) Incorporates a close [x].
3) Driven by configuration option in master_preferences file; this alternate
bubble will be used only if "oem_bubble": true is set.
Requested longer linger time feature will involve mucking with the focus
manager; this change will be uploaded separately.
BUG=9223
TEST=Add "oem_bubble": true to master_preferences file. Run chrome with
--first-run option. Alternate, smaller OEM bubble should appear over the Chrome
browser in the place of the standard first-run bubble.
"""
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
rendering of the close button to TabRendererGtk (where it belongs).
Review URL: http://codereview.chromium.org/115543
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Go eventually calls LocationBarViewMac::AcceptInputWithDisposition(),
which was NOTIMPLEMENTED(). Implement.
http://crbug.com/12253
TEST=Type some text into omnibox. Click the Go button rather than hitting enter.
Review URL: http://codereview.chromium.org/113595
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
r=wtc
Review URL: http://codereview.chromium.org/113535
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115544
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The TabContentsContainerGtk now uses a GtkFixed to store its
children, and the status bubble is now a child of that GtkFixed
so that it can be absolutely positioned on top of the rendered
data. Since it is no longer a GTK_WINDOW_POPUP, all the weird
stuff related to different window managers goes away.
http://crbug.com/11635
Review URL: http://codereview.chromium.org/113590
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/112040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
and GetWidget to match windows.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/113603
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/12059
Review URL: http://codereview.chromium.org/113601
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/113600
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=11696
TEST=Verify that the grey line between toolbar and content exists in restored and maximized mode and *not* on the new tab page, and when an infobar (e.g. default browser infobar) is present.
Review URL: http://codereview.chromium.org/113556
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Take advantage of new String::createUninitialized() call in webkit.
This allows us to have one malloc node per string, without an
extra copy of the characters
2) Take advantage of new V8 behavior, to return NULL from
GetExternalStringResource() if it hasn't been externalized,
speeding up our usage by not requiring us to call isExternal
3) Check if string type is an integer. If it is, don't call into V8 to
get string...instead do it in C++, caching previous integer strings less
than 100.
Also removed unnecessary test for IsEmpty() as the called function also
tests for it.
Review URL: http://codereview.chromium.org/115517
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
it needs) compile on GTK.
Review URL: http://codereview.chromium.org/113589
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16426 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=12060
TEST=Enable this extension, browse to a page with a Feed and an RSS icon should show up in the Omnibox. Clicking it brings you to a subscribe page. No feed preview is displayed.
Review URL: http://codereview.chromium.org/115536
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=12262
Review URL: http://codereview.chromium.org/113599
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115541
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16423 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Landing a patch written by myself, which is originally reviewed at <http://codereview.chromium.org/113489>.
BUG=7633
Review URL: http://codereview.chromium.org/115524
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16422 0039d316-1c4b-4281-b951-d872f2087c98
|