| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
will crash if free'ed memory is accessed (hoping to detect the
memory corrupters).
BUG=76891
TBR=jar
Review URL: http://codereview.chromium.org/6676098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79257 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This change adds a test case for the Serbian (Latin) dictionary and removes a comment for the test case for the Portuguese (Brazil) dictionary.
BUG=53018,57494
TEST=unit_tests --gtest_filter=SpellCheckTest.SpellCheckText
Review URL: http://codereview.chromium.org/6708081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:12244
TEST=see the bug
Review URL: http://codereview.chromium.org/6726021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=manually done with try.
Review URL: http://codereview.chromium.org/6722023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:13411
TEST=manual and try
Review URL: http://codereview.chromium.org/6705026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79253 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
to r79069.
BUG=44127, 18323
TEST=64-bit base should all (mostly) build
Review URL: http://codereview.chromium.org/6723016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/nsprpub/pr/include/prtypes.h&rev=HEAD&mark=3.43
This picks up a 64-bit Mac OS X fix from upstream bug 478687.
https://bugzilla.mozilla.org/show_bug.cgi?id=478687
BUG=44127, 18323
TEST=64-bit base should all (mostly) build
Review URL: http://codereview.chromium.org/6722011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=36520
TEST=browser_tests --gtest_filter=FormAutocompleteTest.DynamicAutoCompleteOffFormSubmit
Review URL: http://codereview.chromium.org/6732012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=kbr
BUG=
TEST=
Review URL: http://codereview.chromium.org/6732015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
not dispatch
all window messages specifically if we are in the context of a Windows modal loop, i.e.
a Windows API like TrackPopupMenu, etc. This is because these API's expect to handle
input messages like keyboard and mouse messages by peeking them from the queue and handling
them. Our message pump currently dispatches all windows messages while processing the tickler
message which causes the windows modal loop to not see keyboard and mouse messages at times.
Added a flag in the windows message loop which indicates if we are in the context of an
os modal loop. If yes we just peek for WM_PAINT and timer and dispatch those and get out.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=59864
BUG=59864
Review URL: http://codereview.chromium.org/6676099
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79248 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
R=jeanluc@google.com
TBR=jeanluc@google.com
Review URL: http://codereview.chromium.org/6696060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
remove a contents-chrome dependency.
BUG=76795
TEST=none
R=arv@chromium.org
Review URL: http://codereview.chromium.org/6675017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tab. backward button, forward button and reload button have the same problem.
XIB Changes:
* Add ToolbarButton for buttons which should handle middle clicking.
* Switch the home button to be ToolbarButton instead of NSButton.
* Back/forward and reload buttons inherit from ToolbarButton instead of
NSButton.
BUG=45795
TEST=Middle click on the home button create new tab with home page, or on the
reload button create new tab with current page. Middle click on the
back/forward buttons also work with new tab. unit_tests include
TestbarButtonTest.* suites for testint that.
R=pinkerton@chromium.org,avi@chromium.org,viettrungluu@chromium.org,mark@chromium.org,shess@chromium.org,rohitrao@chromium.org
Review URL: http://codereview.chromium.org/6703004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:10821
TEST=Chrome should build.
Review URL: http://codereview.chromium.org/6730011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=linux_valgrind
BUG=73830
Review URL: http://codereview.chromium.org/6594103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79243 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This should fix Cloud Print proxy.
TBR=jamiewalch@chromium.org,hclam@chromium.org,dmaclach@chromium.org,sanjeevr@chromium.org,ajwong@chromium.org,scottbyer@chromium.org
BUG=76991
TEST=Run "chrome --type=service" without a DISPLAY set.
Review URL: http://codereview.chromium.org/6696047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Because the callback object uses const An& for the type of the Run() function in argument forwarding, the code breaks for An=T& or An=T[]. This CL adds in code to modify the parameter type to remove duplicate references, and other fun.
BUG=35223
TEST=new unittests
Review URL: http://codereview.chromium.org/6718021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make serial_number() private because it strips the leading 0 bytes
required for proper DER encoding of the ASN.1 INTEGER type.
Add info on the certificates on the blacklist so we know what hostnames
they can be used for and when they can be safely removed from the blacklist.
Use UMA_HISTOGRAM_ENUMERATION instead of UMA_HISTOGRAM_CUSTOM_COUNTS.
R=agl
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6696059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79237 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=71473
TEST=chrome://settings/passwords
Review URL: http://codereview.chromium.org/6705021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also do a bunch of cleanup:
-move safe browsing messages together
-get rid of webkit_param_traits and common_param_trait since they're no longer needed
-remove the multiple include of IPC files from places that don't need it
TBR=tsepez
Review URL: http://codereview.chromium.org/6713084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=cmp
Review URL: http://codereview.chromium.org/6734001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
R=darin@chromium.org,brettw@chromium.org,jam@chromium.org,ben@chromium.org
Review URL: http://codereview.chromium.org/6534012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reason: it does a memcpy on the stack.
BUG=None
TEST=None
R=avi@chromium.org,maruel@chromium.org
Review URL: http://codereview.chromium.org/6730002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=cmp
TBR=ericu@google.com
Review URL: http://codereview.chromium.org/6733014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=cmp
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove unused header includes.
Original review:
http://codereview.chromium.org/6712006/
BUG=
TEST=
Review URL: http://codereview.chromium.org/6711051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Instead, return the FileSystem URI of the root. This will make it easier
to swap in different filesystem implementations.
BUG=71635
TEST=Just a couple in FileSystemUtilTests, but a bunch of existing ones [this doesn't add much new functionality].
Review URL: http://codereview.chromium.org/6603034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Linux dual monitor environment", FireFox uses Xinerama to get screen width/height information. If we cannot use Xinerama, return the same width/height info as before.
BUG=28560
TEST=1, Prepare dual monitor Linux system which can use Xinerama. 2, Launch browser and run javascript "document.write("screen.witdh = " + screen.width + "<br>");". 3, Make sure the width is in single monitor width size.
Patch by Takano.Naoki@gmail.com.
Original Review: http://codereview.chromium.org/6714036/
Review URL: http://codereview.chromium.org/6725024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This value is accrued without locking, and hence is too
commonly corrupted. Even if it is gathered
perfectly, I've been informed that for very large
samples the computed variance is "not a stable
metric" and can diverge." If we did want to
look at the variance for most distribution, then
we need to look at the variance of the log
normal distribution, which would mean we wanted
to take the sum-of-squares of the log, which is
computationally intense... and probably of little
value.
Bottom line: Remove the useless metric.
I still need to change the protobufs so that
this value is optional in uploads, but other than
that tiny point, this CL removes almost all
traces of this metric.
r=rtenneti
Review URL: http://codereview.chromium.org/6672071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Disabled the TCMalloc double-free detection,
which should restore much of the performance loss
caused by this experiment (to find double frees,
if any). This should resolve bug 76640
As an alternate experiment to better illuminate our
memory corruption problem, this CL also enables
WinHeap (default Windows allocator) in the browser
process. There is a chance that this will cause a
very tiny reduction in performance, but it will surely
increase our crash rate (based on what we saw recently
on the dev channel).
BUG=76640
r=rtenneti
Review URL: http://codereview.chromium.org/6705027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79224 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/6705015 /
http://trac.webkit.org/changeset/81821 .
TBR=tkent@chromium.org,tony@chromium.org
Review URL: http://codereview.chromium.org/6676103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=71097
TEST=none; no visible change
Review URL: http://codereview.chromium.org/6672059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
While this slightly degeneralizes some stats-collection code,
the svn history shows that this code has, over several years, only been used for SDCH,
and thus it's worth some degeneralization in order to greatly simplify URLRequestJob.
BUG=none
TEST=try bots
Review URL: http://codereview.chromium.org/6713019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=unit tests
BUG=none
Review URL: http://codereview.chromium.org/6719014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=ben@chromium.org
Review URL: http://codereview.chromium.org/6725027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=set kGpuMaxCrashCount to zero and verified the test fails
Review URL: http://codereview.chromium.org/6705008
TBR=amarinichev@chromium.org
Review URL: http://codereview.chromium.org/6730014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Move ExtractCompositionInfo method in chrome/browser/renderer_host/gtk_im_context_wrapper.cc to ui/base/gtk/gtk_im_context_util.cc
BUG=75003
TEST=none
Review URL: http://codereview.chromium.org/6709023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=72040
TEST=none
Review URL: http://codereview.chromium.org/6719006
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/6696053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79212 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=72040
TEST=none
Review URL: http://codereview.chromium.org/6719006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6674041
Patch from Huyen Nguyen <hnguyen@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
enum histogram.
BUG=
TEST=ClientSideDetectionHostTest
Review URL: http://codereview.chromium.org/6725036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:11613
TEST=imageburner should download the latest mario beta and burn it on a usb stick.
Review URL: http://codereview.chromium.org/6312143
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=70659
TEST=none
Review URL: http://codereview.chromium.org/6731009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
window.open to launch a popup
BUG=70659
TEST=Tests should not fail on Pyauto bots
Review URL: http://codereview.chromium.org/6731008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Patch from Fabien Tassin <fta@sofaraway.org>.
R=tony@chromium.org,darin@chromium.org
Review URL: http://codereview.chromium.org/6729004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes made by this CL:
1. Adds OnBeforeUserAction() and OnAfterUserAction() in TextfieldController.
2. Adds Textfield::HasSelection().
3. Changes NativeTextfieldViews to use KeyEvent::GetCharacter().
3. Refactors AutocompleteEditViewViews to use new TextfieldController methods.
BUG=75003
TEST=views_unittests --gtest_filter=*Textfield* and interactive_ui_tests --gtest_filter=AutocompleteEditViewViews*
Review URL: http://codereview.chromium.org/6685082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=mirandac,dmaclach
Review URL: http://codereview.chromium.org/6730007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
work for any source.
BUG=none
TEST=none
R=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/6722027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
startup urls and last of pinned tabs.
BUG=67227
TEST=see bug
R=brettw@chromium.org
Review URL: http://codereview.chromium.org/6705010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79198 0039d316-1c4b-4281-b951-d872f2087c98
|