| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
| |
Cr-Commit-Position: refs/branch-heads/2570@{#2}
Cr-Branched-From: 44d232c33e46199f9247a68bd6cc368374367c16-refs/heads/master@{#360972}
|
|
|
|
|
| |
Cr-Commit-Position: refs/branch-heads/2570@{#1}
Cr-Branched-From: 44d232c33e46199f9247a68bd6cc368374367c16-refs/heads/master@{#360972}
|
|
|
|
|
|
|
|
| |
BUG=557900
Review URL: https://codereview.chromium.org/1470593003
Cr-Commit-Position: refs/heads/master@{#360972}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This came up in another CL ( https://codereview.chromium.org/1433253003/ )
where we needed to nullify a private LineLayoutText object and couldn't do
the obvious m_lineLayoutText=nullptr solution. This CL will let anyone do
the obvious thing and have it work properly, without casting or separate
methods.
BUG=499321
Review URL: https://codereview.chromium.org/1460923003
Cr-Commit-Position: refs/heads/master@{#360971}
|
|
|
|
|
|
|
|
|
| |
TBR=pfeldman
NOTRY=true
Review URL: https://codereview.chromium.org/1464983002
Cr-Commit-Position: refs/heads/master@{#360970}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Measure the number of naturally occurring cookies that begin with
$Secure- or $Host- so that we know if cookie prefixes will break real
sites.
BUG=557083
Review URL: https://codereview.chromium.org/1455693007
Cr-Commit-Position: refs/heads/master@{#360969}
|
|
|
|
|
|
|
|
|
|
|
| |
Concatenate any required links to the end of the InfoBar's main message
instead of showing them as tertiary buttons.
BUG=543205
Review URL: https://codereview.chromium.org/1455353002
Cr-Commit-Position: refs/heads/master@{#360968}
|
|
|
|
|
|
|
|
| |
BUG=558589
Review URL: https://codereview.chromium.org/1463463003
Cr-Commit-Position: refs/heads/master@{#360967}
|
|
|
|
|
|
|
|
| |
TBR=caseq@chromium.org
Review URL: https://codereview.chromium.org/1468733002 .
Cr-Commit-Position: refs/heads/master@{#360966}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Additionally, xtends components/test_runner's generated
WebMediaStream to have a ChromeMock AudioTrack and Source
components/test_runner is used by Blink LayoutTest to
generate a MediaStream. But this MS has only Blink-side
objects, whereas some tests (e.g. MediaRecorder) need
to have Chrome counterparts of those objects. This CL
adds those, for audio.
Since components/ has a strict dependency requirement,
the added code goes into a subfolder of
components/test_runner.
BUG=528519,548290
Review URL: https://codereview.chromium.org/1448203002
Cr-Commit-Position: refs/heads/master@{#360965}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Must land at the same time as the ANGLE-side CL to change the gyp, so that we
don't break the GPU FYI bots.
https://android.googlesource.com/platform/external/deqp/+log/92f7752da8..cc0ded6c
BUG=angleproject:1092
R=geofflang@chromium.rog
Review URL: https://codereview.chromium.org/1462133002
Cr-Commit-Position: refs/heads/master@{#360964}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove mojo:desktop_ui and mojo:omnibox aliases from core_services.
Note: mojo:desktop_ui wasn't even resolving to mojo://core_services/.
(mojo scheme isn't registered prior to mandoline/app/desktop/main.cc)
Upload the additional mojo:omnibox component with Mandoline binaries.
(mojo:desktop_ui was already being uploaded for the app+resources)
Also, don't build mandoline/ui/phone_ui for Linux desktop builds.
BUG=NONE
TEST=Mandoline still works as intended.
R=ben@chromium.org
Review URL: https://codereview.chromium.org/1465843003
Cr-Commit-Position: refs/heads/master@{#360963}
|
|
|
|
|
|
|
|
|
| |
TBR=piman@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1459393002
Cr-Commit-Position: refs/heads/master@{#360962}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chromium for Linux opens a Gtk file-picker for file browsing, but it is not
modal because there is no GtkWindow as parent of file-picker.
This patch allows the X11 host window to disable input event handling to make
a file-picker modal
The original CL was reverted due to wrong DCHECK with modal_dialog_xid_:
https://codereview.chromium.org/1243503002
BUG=408481
TEST=BrowserSelectFileDialogTest, ModalTest
Review URL: https://codereview.chromium.org/1233913009
Cr-Commit-Position: refs/heads/master@{#360961}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
[14421->5901/20355 ~33] ASM obj/third_party/crashpad/crashpad/util/util/capture_context.obj
MASM : warning A4018:invalid command-line option : /SAFESEH
MASM : warning A4018:invalid command-line option : /SFESEH
MASM : warning A4018:invalid command-line option : /SESEH
MASM : warning A4018:invalid command-line option : /SSEH
MASM : warning A4018:invalid command-line option : /SEH
MASM : warning A4018:invalid command-line option : /SH
BUG=546288
R=brettw@chromium.org
Review URL: https://codereview.chromium.org/1470483002
Cr-Commit-Position: refs/heads/master@{#360960}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently the OfflinePageModel::Observer::OfflinePageDeleted is only
issued when a page is marked for deletion (for bookmark delete undo).
This page also issues it when the offline copy is directly removed
and takes care that it not duplicated when a page has been previously
marked for deletion.
BUG=559100
R=jianli@chromium.org
Review URL: https://codereview.chromium.org/1460413002
Cr-Commit-Position: refs/heads/master@{#360959}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This pulls in the following Native Client changes:
1a71811: (stichnot@chromium.org) PNaCl: Update subzero revision in pnacl/COMPONENT_REVISIONS
26a11d1: (stichnot@chromium.org) Update revision for PNaCl
3658d8e: (phosek@chromium.org) PNaCl: Update clang revision in pnacl/COMPONENT_REVISIONS
7a60f36: (mcgrathr@chromium.org) Remove an unused variable from src/shared/imc/win/nacl_imc.cc
1b746e8: (mcgrathr@chromium.org) PNaCl: Update clang revision in pnacl/COMPONENT_REVISIONS
0f0cb21: (mcgrathr@chromium.org) pnacl-strip: Handle --strip-unneeded switch
9d811a5: (mcgrathr@chromium.org) toolchain_build: Disable gold build for Mac host
7f130ff: (erikchen@chromium.org) Suppress Clang warning for dirfd() on OSX.
18e2d27: (erikchen@chromium.org) Add code to check for the OS X version.
bad8503: (erikchen@chromium.org) Fix an invocation to find_sdk.py.
079650c: (stichnot@chromium.org) PNaCl: Update subzero revision in pnacl/COMPONENT_REVISIONS
4dbae34: (mcgrathr@chromium.org) Fix PNaCl toolchain build on Mac
db88d57: (mcgrathr@chromium.org) Fix build/update_pnacl_tool_revisions.py for @-less user names
d5112f1: (mcgrathr@chromium.org) Update revision for PNaCl
b6ec17d: (erikchen@chromium.org) Make a NaCl descriptor for Mach-based shared memory.
Changes: https://chromium.googlesource.com/native_client/src/native_client/+log/546ef11ffcbedf8c33bfa12643408c1182b6839e..b6ec17db8c2958f3455043e29000f17354336fb8
BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_arm_compile,linux_nacl_sdk_build
Review URL: https://codereview.chromium.org/1460063003
Cr-Commit-Position: refs/heads/master@{#360958}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #1 id:1 of https://codereview.chromium.org/1461183002/ )
Reason for revert:
Going to improve the fix a bit.
Original issue's description:
> DevTools: local storage view is cloned upon each selection.
>
> BUG=558724
>
> Committed: https://crrev.com/df92587b535a747850c32dc862498af36aaf98bb
> Cr-Commit-Position: refs/heads/master@{#360764}
TBR=dgozman@chromium.org,caseq@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=558724
Review URL: https://codereview.chromium.org/1469583003
Cr-Commit-Position: refs/heads/master@{#360957}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To support recording modes for testing in sync painting mode.
m_painter->paint() and paintController->commitNewDisplayItems() will be
nearly no-op if called with the same interest rect as that used during
the last sync painting.
BUG=552548
Review URL: https://codereview.chromium.org/1467723002
Cr-Commit-Position: refs/heads/master@{#360956}
|
|
|
|
|
|
|
|
|
|
| |
I noticed the main thread is being starved which slows down execution. On a Z620 using the new default improves generation speed for Chrome by 20%.
This also adds trace events for the OnResolved step of target resolution which is a bottleneck in some cases.
Review URL: https://codereview.chromium.org/1464463003
Cr-Commit-Position: refs/heads/master@{#360955}
|
|
|
|
|
|
|
|
|
| |
R=sky@chromium.org
BUG=none
Review URL: https://codereview.chromium.org/1455833005
Cr-Commit-Position: refs/heads/master@{#360954}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ThreadChecker instead.
Relanding http://crrev.com/1456993004 after sorting out a bot
that failed to compile.
Original CL description ------------------------------------------------
This CL removed the |task_runner| passed on construction to
FFmpegVideoDecoder since: "... is used in just one location
for PostTask()ing. The class itself is otherwise mostly single
threaded (except perhaps construction), and passing a
|task_runner| as ctor argument is confusingly indicating the
opposite. A |thread_checker_| basically tells that a(ll) methods
are run in a given thread, whichever this is."
(from discussion in http://crrev.com/1438233003, which has
sadly been reverted for unrelated issues, and is going to be
relanded as http://crrev.com/1447343004).
Removal of this |task_runner| is also necessary for using these
two classes from WebRtc, see the linekd bug.
BUG=554737
TEST=This is a tiny change, all unittest and content_browsertests should cover it.
TBR=dalecurtis@chromium.org, bbudge@chromium.org(for video_decoder_shim.cc)
Review URL: https://codereview.chromium.org/1464573003
Cr-Commit-Position: refs/heads/master@{#360953}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/5d3aabf3..3c19105e
Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org
Review URL: https://codereview.chromium.org/1464753003
Cr-Commit-Position: refs/heads/master@{#360952}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
All squashed layers have the same clip and transform space, so
we can use the first squashed layer's layoutObject to map the squashing
layer's bounds into viewport space, with offsetFromOwningLayoutObject
to translate squashing layer's bounds into the owning object's space.
Also enable interest rect computation for scrolling contents layer.
BUG=553327,553356
TEST=CompositedLayerMappingTest.InterestRectChagneOnScroll
TEST=CompositedLayerMappingTest.InterestRectOfSquashingLayer
TEST=CompositedLayerMappingTest.InterestRectOfSquashingLayerComplex
Review URL: https://codereview.chromium.org/1462713002
Cr-Commit-Position: refs/heads/master@{#360951}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change has two purposes; handle the cases when there is no
panel to close and make testing easier by overriding close
functionality without creating a test panel.
BUG=557526
Review URL: https://codereview.chromium.org/1460753002
Cr-Commit-Position: refs/heads/master@{#360950}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This mistake was possible because removeEventListener's arguments are
all optional, and these calls would throw exceptions if the argument
were non-optional.
Since these code paths supposedly current work, removing the event
listeners cannot be critical, but do it anyway as was originally
intended.
BUG=353484
Review URL: https://codereview.chromium.org/1463763002
Cr-Commit-Position: refs/heads/master@{#360949}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL did the following:
1. implement CreateBrowserNonClientFrameView for AuraAndroid
2. implement CreateImmersiveModeController for AuraAndroid
3. rename browser_non_client_frame_view_factory_aura to browser_non_client_frame_view_factory__ash as it depends on ash
4. gypi file change
BUG=557285
Review URL: https://codereview.chromium.org/1457353002
Cr-Commit-Position: refs/heads/master@{#360948}
|
|
|
|
|
|
|
|
|
| |
BUG=555171
R=jsbell@chromium.org
Review URL: https://codereview.chromium.org/1470493002
Cr-Commit-Position: refs/heads/master@{#360947}
|
|
|
|
|
|
|
|
|
|
|
| |
https://chromium.googlesource.com/chromium/src/+/d9328a9fd
BUG=559240
TBR=fmalita@chromium.org
Review URL: https://codereview.chromium.org/1461003008 .
Cr-Commit-Position: refs/heads/master@{#360946}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DnsConfigServicePosix is creating two SerialWorker instances that
run jobs on worker thread, however, these workers hold a raw pointer
to the service instance and access the pointer on the worker thread
to check testing values. When the instance is destroyed before the
serial workers finish a crash occurs.
This fix is to never access the raw pointer from the worker thread,
instead binding the serial worker to a given mock value for testing.
If the value changes the worker is canceled and recreated.
BUG=558788
Review URL: https://codereview.chromium.org/1447163008
Cr-Commit-Position: refs/heads/master@{#360945}
|
|
|
|
|
|
|
|
| |
BUG=508270
Review URL: https://codereview.chromium.org/1455043002
Cr-Commit-Position: refs/heads/master@{#360944}
|
|
|
|
|
|
|
|
| |
BUG=272790
Review URL: https://codereview.chromium.org/1451483002
Cr-Commit-Position: refs/heads/master@{#360943}
|
|
|
|
|
|
|
|
|
|
|
| |
* Do ui::RegisterUIAndroidJni() only when not using Aura.
* Exclude desktop_aura from the build.
BUG=507792
Review URL: https://codereview.chromium.org/1466463004
Cr-Commit-Position: refs/heads/master@{#360942}
|
|
|
|
|
|
|
|
| |
BUG=551029
Review URL: https://codereview.chromium.org/1462953004
Cr-Commit-Position: refs/heads/master@{#360941}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adding a RELEASE_ASSERT at the suspected crash position.
GlyphpageTree should give us a node here, but may not. Perhaps another
case of relying on a non-null fontDataAt(0) call.
BUG=446566
R=eae,szager
Review URL: https://codereview.chromium.org/1468563002
Cr-Commit-Position: refs/heads/master@{#360940}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1463303003/ )
Reason for revert:
Collided with the skia roll (which already marked this test for rebaselining)
Original issue's description:
> Fix Skia Depsroll
>
> BUG=559300
>
> Committed: https://crrev.com/1e37d76d682ec823d16163e9129999f714f41e0b
> Cr-Commit-Position: refs/heads/master@{#360920}
TBR=robertphillips@chromium.org,fmalita@chromium.org,robertphillips@google.com,tfarina@chromium.org,stephana@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=559300
Review URL: https://codereview.chromium.org/1463923004
Cr-Commit-Position: refs/heads/master@{#360939}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also revert https://codereview.chromium.org/1375193005 for bootstrap builds,
else compiler-rt won't build in that config. See comment 45 on the bug.
BUG=538614
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/1461003007 .
Cr-Commit-Position: refs/heads/master@{#360938}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This simplifies the implementation of HistoryEntryCompareLess()
and avoids the use of tolower() which is locale sensitive.
BUG=None
TEST=content_unittests
R=brettw@chromium.org
Review URL: https://codereview.chromium.org/1458573002
Cr-Commit-Position: refs/heads/master@{#360937}
|
|
|
|
|
|
|
|
|
|
|
| |
Shorten some test names so they fit in 80 columns.
R=enne
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1468523003
Cr-Commit-Position: refs/heads/master@{#360936}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I added two tests for memory leaks in the attachment brokering process. The
first checks memory usage after brokering a single, large, shared memory object.
The second checks memory usage after brokering a thousand, smaller memory
objects.
BUG=557387
Review URL: https://codereview.chromium.org/1465623002
Cr-Commit-Position: refs/heads/master@{#360935}
|
|
|
|
|
|
|
|
| |
BUG=395297
Review URL: https://codereview.chromium.org/1444663002
Cr-Commit-Position: refs/heads/master@{#360934}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1.) Get the renderer process ID on the UI thread to ensure
it is updated correctly.
2.) Switch to a standard tab loading function that adds the loading
signal before attempting to load to ensure it is triggered as
expected.
BUG=474543
Review URL: https://codereview.chromium.org/1466813002
Cr-Commit-Position: refs/heads/master@{#360933}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds CRWTestWKWebViewEvaluator class to replace
CRWTestUIWebViewEvaluator once UIWebView is no longer used. Also updates
TODO on set of script managers in WKWebView.
BUG=486840
Review URL: https://codereview.chromium.org/1451163002
Cr-Commit-Position: refs/heads/master@{#360932}
|
|
|
|
|
|
|
|
| |
BUG=554289
Review URL: https://codereview.chromium.org/1449323004
Cr-Commit-Position: refs/heads/master@{#360931}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
..\..\skia\ext\platform_device.cc(20,6) : error: unused function 'SetBoolMetaData' [-Werror,-Wunused-function]
void SetBoolMetaData(const SkCanvas& canvas, const char* key, bool value) {
^
..\..\skia\ext\platform_device.cc(25,6) : error: unused function 'GetBoolMetaData' [-Werror,-Wunused-function]
bool GetBoolMetaData(const SkCanvas& canvas, const char* key) {
^
BUG=82385
TBR=tomhudson
Review URL: https://codereview.chromium.org/1464783003 .
Cr-Commit-Position: refs/heads/master@{#360930}
|
|
|
|
|
|
|
|
| |
BUG=558198
Review URL: https://codereview.chromium.org/1463793004
Cr-Commit-Position: refs/heads/master@{#360929}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The thread check error addressed by https://codereview.chromium.org/1450433002
Was the result of an unnecessary thread check before thread attachment, which
was causing the thread checker to initialize itself on the wrong thread.
This CL reverts https://codereview.chromium.org/1450433002 and removes thread
checks from all the places where there were no thread checks prior to
https://codereview.chromium.org/1414683003/
BUG=556725
R=piman@chromium.org
Review URL: https://codereview.chromium.org/1459193003
Cr-Commit-Position: refs/heads/master@{#360928}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows other classes that will be created within the directory to
return BattOrErrors as part of their interface without having to worry
about circular dependencies if BattOrAgent tries to #include them.
BUG=542837
Review URL: https://codereview.chromium.org/1463323002
Cr-Commit-Position: refs/heads/master@{#360927}
|
|
|
|
|
|
|
|
| |
BUG=556678
Review URL: https://codereview.chromium.org/1461703009
Cr-Commit-Position: refs/heads/master@{#360926}
|