summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Add a few more cases to NetUtilTest.IDN* tests. Because IDN*Slow test is ↵jshin@chromium.org2009-07-152-16/+42
| | | | | | | | | | | much faster ( > 20 times) than before (on my linux box - single core p4, it takes 5700 ms now.), enable the test under Linux valgrind. BUG=None TEST=Pass NetUtil*.IDN* and NetUtil*.IDN*Slow runs fast enough under valgrind on Linux. Review URL: http://codereview.chromium.org/149640 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20747 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: add comment to the sandbox binary as suggested by Markus.agl@chromium.org2009-07-151-1/+3
| | | | | | | (Because, otherwise, that chunk of code looks pretty scary.) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20746 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Splitting media filter's Initialize() into Create() + callback and ↵scherkus@chromium.org2009-07-1524-697/+159
| | | | | | | | | Seek() + callback." Review URL: http://codereview.chromium.org/149682 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20745 0039d316-1c4b-4281-b951-d872f2087c98
* Splitting media filter's Initialize() into Create() + callback and Seek() + ↵scherkus@chromium.org2009-07-1524-159/+697
| | | | | | | | | | | callback. BUG=16014,16031 TEST=media_unittests, layout tests Review URL: http://codereview.chromium.org/155469 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20744 0039d316-1c4b-4281-b951-d872f2087c98
* First extensions doc putback (if Raf doesn't beat me).kathyw@google.com2009-07-1515-0/+410
| | | | | | | | | | | | This is a tutorial page that should be viewable at a URL such as http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/helloworld.html BUG=none TEST=none Review URL: http://codereview.chromium.org/149652 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20743 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: don't leak file descriptors in the sandbox host.agl@chromium.org2009-07-151-0/+3
| | | | | | | | | | (This patch appeared to me, fully formed, in my sleep) BUG=16426 http://codereview.chromium.org/149678 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20742 0039d316-1c4b-4281-b951-d872f2087c98
* Update the archiving for Hive runs to work from Buildbot. Remove deadlock ↵thomaslewis@google.com2009-07-152-16/+45
| | | | | | | | from Selenium tests if no free ports are available. Review URL: http://codereview.chromium.org/149596 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20741 0039d316-1c4b-4281-b951-d872f2087c98
* Roll WebKit DEPS to r45916 and mark some tests (mostly MAC only) as failing ↵japhet@chromium.org2009-07-152-1/+85
| | | | | | | | | | | | for now. BUG=none TEST=Green canaries TBR=dglazkov Review URL: http://codereview.chromium.org/149679 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20740 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/155428 for Thiago, which changessky@chromium.org2009-07-1521-58/+59
| | | | | | | | | | | | | | from me to get the thing to work. Merging two versions of BookmarkNodeRemoved into one. BUG=None TEST=Remove some bookmarks from BookmarkBar or Bookmarks Manager and make sure everything works ok. Review URL: http://codereview.chromium.org/155572 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20739 0039d316-1c4b-4281-b951-d872f2087c98
* Removed the bool parameter from PipelineCallback and cleaned up ↵scherkus@chromium.org2009-07-155-141/+101
| | | | | | | | | | | | | WebMediaPlayerImpl::Proxy. This forces clients to check Pipeline::GetError() instead of using a simple true/false check for success. Also the bool parameter wasn't being used for Seek() and Stop() callbacks, further hinting at its removal. BUG=16009 TEST=media_unittests pass, layout tests pass Review URL: http://codereview.chromium.org/149584 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20738 0039d316-1c4b-4281-b951-d872f2087c98
* Implement drops on web view.pinkerton@chromium.org2009-07-156-25/+443
| | | | | | | | BUG=13155, 15657 TEST=Dragging from other applications to web view should load urls or drop text depending on where in the view the drop occurs. Same with drags from the desktop. Drags within text fields on a webpage should work. Review URL: http://codereview.chromium.org/149626 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20737 0039d316-1c4b-4281-b951-d872f2087c98
* Use tinted icons for menu buttons.tc@google.com2009-07-153-11/+33
| | | | | | | | | | Add a notification registrar for theme changes to the browser toolbar and update the images when the theme changes. Review URL: http://codereview.chromium.org/155473 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20736 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for late binding of sockets.willchan@chromium.org2009-07-153-44/+694
| | | | | | | | | | There are tests for this, but the code is not activated yet. The old behavior is maintained. I will follow up this patch with a change to enable an A/B test for this optimization. Credit to jar&mbelshe for the optimization idea. BUG=13289 TEST=Covered by new unit tests. Not activatable yet. Review URL: http://codereview.chromium.org/151190 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20735 0039d316-1c4b-4281-b951-d872f2087c98
* Privacy Blacklist IOImplemented parsing of input (text) blacklists. This is ↵idanan@chromium.org2009-07-1512-18/+753
| | | | | | | | | | the format in which we will download privacy blacklist.Implemented storing and reading of aggregated blacklists in a binary format. This is the repository which Chromium will read on startup which is more efficient to load than the downloaded blacklists.Added concept of providers to blacklist entries so that we can determine the source of a pattern match, for future display in the UI.Unit tests added for the new IO classes. Privacy Blacklist conversion tool implemented to a single text blacklist into the binary format. Still needs options for storing multiple blacklists (TODO). BUG=none TEST=Blacklist* Review URL: http://codereview.chromium.org/155298 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20734 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: propagate LD_LIBRARY_PATH through the SUID sandbox.agl@chromium.org2009-07-152-0/+22
| | | | | | | | | | | | With the SUID sandbox, certain environment variables (esp LD_LIBRARY_PATH) are cleared for security reasons. This means that the child zygote process isn't run with the correct environment and can fail to start. BUG=16815 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20733 0039d316-1c4b-4281-b951-d872f2087c98
* Delete RGBColor and use the upstreamed version BUG=none TEST=none japhet@chromium.org2009-07-153-93/+0
| | | | | | Review URL: http://codereview.chromium.org/149541 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20732 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bunch of minor Coverity issues.phajdan.jr@chromium.org2009-07-1512-20/+22
| | | | | | | | | - pass more things by const reference - check return codes (minor severity) Review URL: http://codereview.chromium.org/149643 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20731 0039d316-1c4b-4281-b951-d872f2087c98
* Fix two races in DirectoryWatcherInotify:phajdan.jr@chromium.org2009-07-151-18/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1. In DirectoryWatcherImpl::Watch we have to initialize delegate_, root_path_ and other members before calling InotifyReader::AddWatch, because otherwise the following race is possible: 1. InotifyReader::AddWatch 2. DirectoryWatcherImpl::OnInotifyEvent, where we want to use delegate_ and root_path_ 3. Now-late initialization of delegate_ and root_path_ in DirectoryWatcherImpl::Watch 2. In InotifyReader::OnInotifyEvent we can't just copy things under a lock and notify without a lock. Otherwise the following race is possible: 1. Things get copied in InotifyReader::OnInotifyEvent, lock is released 2. DirectoryWatcherImpl is destroyed, removing its watch 3. But it's still in the copied set of watchers to be notified. When we get to notifying it, it's invalid, and we have a crash. To fix race #2, I decided to just do everything under the lock. Notifications shouldn't be a bottleneck, and I don't want to prematurely add more complexity. TEST=Manually with RaceChecker, see bug. http://crbug.com/15473 Review URL: http://codereview.chromium.org/149630 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20730 0039d316-1c4b-4281-b951-d872f2087c98
* Implements the AppendRadioMenuItem and AppendCheckboxMenuItem functionspinkerton@chromium.org2009-07-152-19/+35
| | | | | | | | for the mac platform. Patch from pwicks86@gmail.com (Paul Wicks) BUG=None TEST=None git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20728 0039d316-1c4b-4281-b951-d872f2087c98
* Move TrimWhitespaceUTF8 back to string_util_utf8.ccdeanm@chromium.org2009-07-152-14/+17
| | | | | | | | | Apparently it was there for a reason, but wasn't documented. Review URL: http://codereview.chromium.org/155511 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20727 0039d316-1c4b-4281-b951-d872f2087c98
* Disable WorkerHttpLayoutTests which is flaky (both debug and release winxp).sverrir@chromium.org2009-07-151-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/155571 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20726 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the log error message about proxy authentication insdoyon@chromium.org2009-07-151-4/+10
| | | | | | | | | | | | | ProxyConfigServiceLinux: the proxy auth parameters are still not supported, but proxy auth is supported. Also see http://crbug.com/16709 BUG=13530 TEST=none Review URL: http://codereview.chromium.org/149614 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20725 0039d316-1c4b-4281-b951-d872f2087c98
* SOCKS v5 implementationarindam@chromium.org2009-07-156-9/+1027
| | | | | | | | | | | The implementation is incomplete as it does not support any authentication methods and does not have a UDP layer. BUG=469 TEST=unittests (included) Review URL: http://codereview.chromium.org/150187 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20724 0039d316-1c4b-4281-b951-d872f2087c98
* Update V8 in Chromium to version 1.2.14.2 to get fix for duplicate labelkasperl@google.com2009-07-151-1/+1
| | | | | | | | | | issue when compiling certain try-catch-finally constructs. BUG=http://code.google.com/p/v8/issues/detail?id=345 TEST=none Review URL: http://codereview.chromium.org/155566 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20722 0039d316-1c4b-4281-b951-d872f2087c98
* Update V8 in Chromium to version 1.2.14.1. This is a smallkasperl@google.com2009-07-151-1/+1
| | | | | | | | | | | compatibility fix that allows RegExps to be called as functions. BUG=http://code.google.com/p/v8/issues/detail?id=132 TEST=none Review URL: http://codereview.chromium.org/149669 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20721 0039d316-1c4b-4281-b951-d872f2087c98
* Add in macro to abstract the differences in library naming conventions ↵ajwong@chromium.org2009-07-151-6/+11
| | | | | | | | | | | between mac and linux. TEST=none BUG=16736 Review URL: http://codereview.chromium.org/149632 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20720 0039d316-1c4b-4281-b951-d872f2087c98
* Various minor fixes:aa@chromium.org2009-07-1514-256/+117
| | | | | | | | | | | | | | | | * --load-extension no longer requires --enable-extensions * No longer support chrome:// URLs for user scripts * Remove old unused Greasemonkey test * Enable Greasemonkey API emulation in linux/mac BUG=16720,16007,4476 TEST=Added several unit tests Original review: http://codereview.chromium.org/149619 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20719 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Fix sandbox defineagl@chromium.org2009-07-151-1/+1
| | | | | | | | | | build/common.gypi used CHROME_DEVEL_SANDBOX, while sandbox.cc was looking for DEVELOPMENT_SANDBOX (Patch by Joel Stanley) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20718 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r20667, which broke dropdown menus.estade@chromium.org2009-07-153-18/+6
| | | | | | | | TBR=evan Review URL: http://codereview.chromium.org/155557 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20717 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily disable media layout tests until we can sort something out with ↵scherkus@chromium.org2009-07-151-2/+36
| | | | | | | | | | | the try bots. BUG=16779 TEST=clobber builds of test_shell should not have unexpected failures Review URL: http://codereview.chromium.org/155551 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20716 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 20714.finnur@chromium.org2009-07-1518-190/+92
| | | | | | | Rietveld showed all green try bots, but looks like one ui test is failing Review URL: http://codereview.chromium.org/149668 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20715 0039d316-1c4b-4281-b951-d872f2087c98
* EFD now notifies EPM of renderviews created, which in turn notifies the ↵finnur@chromium.org2009-07-1518-92/+190
| | | | | | | | | | | | | | | | renderer of page actions that it knows about. Remove generic event "page-action-executed" in favor of page action specific event (sent as extension_id/page_action_id). In the bindings, we now setup events for each page action we know about so we can register for specific events, and not receive broadcast events from all page actions. To setup these events I added a GetCurrentPageActions() to extension_process_bindings.cc and a helper function GetCurrentExtensionId(). And, finally, I simplified the page action background page by removing the check to see if we are already subscribed to the feed (since we now support multiple feed readers, it doesn't make sense anymore to always check Google Reader). This check might make a comeback later in a different form. BUG=13936 TEST=The RSS sample extension should work as before. Review URL: http://codereview.chromium.org/155514 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20714 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes for bitmap and GL/CBgman@google.com2009-07-157-109/+114
| | | | | | Review URL: http://codereview.chromium.org/155556 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20713 0039d316-1c4b-4281-b951-d872f2087c98
* Fix DOA problem with dev channel. If there is nojrg@chromium.org2009-07-151-0/+9
| | | | | | | | | | | | | | | | | ~/Library/Preferences/com.google.Chrome.plist, we do a 1st run dialog. This dialog spins a run loop and messes up MessageLoop. "Choke brutally" means, among other things, "never process IPC messages to/from render". Reference CLs: http://codereview.chromium.org/149082 http://codereview.chromium.org/149029 http://codereview.chromium.org/146006 Review URL: http://codereview.chromium.org/149662 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20712 0039d316-1c4b-4281-b951-d872f2087c98
* Makes it so that if you drag a tab to the left edge of the tab stripsky@chromium.org2009-07-152-10/+76
| | | | | | | | | | | | and hold the mouse for a little bit, the tab is pinned. BUG=16634 TEST=on linux with no tabs pinned drag until your close to the right edge of the tab and wait a second. The tab should be pinned. Review URL: http://codereview.chromium.org/155543 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20711 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: various sandbox changesagl@chromium.org2009-07-152-3/+16
| | | | | | | | | | | | | * In development mode, don't let the sandbox run SUID or SGID binaries * Only obay CHROME_DEVEL_SANDBOX if the binary UID matches the read UID. * Change the default sandbox path to save those who do nothing. R=markus git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20710 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: fix for developing on a machine with google-chrome packages installed.agl@chromium.org2009-07-154-4/+63
| | | | | | | | | | | | | | | | | | | | | | | The latest google-chrome packages contain a sandbox binary, which the development builds of chromium will pick up on automatically. However, for safety reasons, the sandbox binary will only exec a fixed chrome binary location. Since development builds will be somewhere else in the filesystem, this means that they will fail to start their zygote processes and generally be very sad. However, we /do/ want people developing with the sandbox, but we don't want the general sandbox binary to be able to exec anything. We could have chromium try and find its sandbox binary relative to the build directory, but some people build on NFS and, since the sandbox binary needs to be SUID, this won't work for them. Instead, we add a new target: chrome_devel_sandbox which developers can use. This builds a sandbox binary that will exec anything which is owned by the running user. This alternative sandbox binary can be selected by exporting CHROME_DEVEL_SANDBOX. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20709 0039d316-1c4b-4281-b951-d872f2087c98
* Couple of changes for chrome os startup:sky@chromium.org2009-07-153-1/+22
| | | | | | | | | | | | | | . Adds command line option specifying some tabs should be pinned on startup. . Disables crash dialog on startup. . Disables linux warning page on startup. BUG=none TEST=none Review URL: http://codereview.chromium.org/149641 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20708 0039d316-1c4b-4281-b951-d872f2087c98
* Handle failure of de-serialization of IPC messages in RenderViewHostcpu@google.com2009-07-154-23/+67
| | | | | | | | | | | | | - first pass at better bad-message handling - Created infraestructure to test compliance with this BUG=16673 TEST=unit tests included Review URL: http://codereview.chromium.org/149578 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20707 0039d316-1c4b-4281-b951-d872f2087c98
* Fix: Linux file:// listings are sorted but not fully internationalizedyuzo@chromium.org2009-07-151-12/+67
| | | | | | | | | | | | | | | | | Changed the code such that file names are converted to UTF-16 before comparison. Ideally, the locale should be considered, but my conclusion is that ignoring it is a reasonable tradeoff. Passing a locale-aware comparator (collator) from src/chrome(or src/app?) to src/base requires too much effort, in my opinion. BUG=16179 TEST=Open a file:// URL for a directory that contains non-ascii-named files. Observe that files are sorted properly in the list, in a case-sensitive manner. Review URL: http://codereview.chromium.org/149449 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20706 0039d316-1c4b-4281-b951-d872f2087c98
* NNTP: Lots of small tweaksarv@google.com2009-07-153-84/+70
| | | | | | | | | | | | | | | | | | | * Remove focus outline for buttons * Thumbnail links should not have underline (and be black) * Make the edit bar animation slide up from the thumbnail * Make animations a lot faster * Fix issue where a thumbnail got stuck in hover mode after DnD. * Make the thumbnails come first when tabbing * Remove focus outline for the buttons and clean up focus outline in the list mode. BUG=16061, 16449, 16342, 16542 TEST=See bugs Review URL: http://codereview.chromium.org/155542 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20705 0039d316-1c4b-4281-b951-d872f2087c98
* Make theme provider remember display properties settings and color's alpha.glen@chromium.org2009-07-152-5/+9
| | | | | | | | | BUG=15527 Review URL: http://codereview.chromium.org/155033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20703 0039d316-1c4b-4281-b951-d872f2087c98
* Make use of the new Js Template i18n for print domuimhm@chromium.org2009-07-152-6/+5
| | | | | | | | | | | Provides a simpler js template engine for print tab which is optimized better than JsTemplate. BUG=173, 947 TEST=print page loads fine. Review URL: http://codereview.chromium.org/155479 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20702 0039d316-1c4b-4281-b951-d872f2087c98
* Don't try to set transparency on pixbufs that don't have any transparency ↵estade@chromium.org2009-07-151-2/+12
| | | | | | | | | | | | | | | channel. Also add DCHECK to make sure the assumption rowstride >= width * 4 is true. The reason this didn't cause any crashes or graphical corruption is because the non-transparent images don't have any white in them (luckily we are not making a browser for an ipod). BUG=16749 TEST=valgrind the browser, open find bar Review URL: http://codereview.chromium.org/155547 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20701 0039d316-1c4b-4281-b951-d872f2087c98
* expose bitmap in js.yux@google.com2009-07-1529-570/+2019
| | | | | | Review URL: http://codereview.chromium.org/150058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20700 0039d316-1c4b-4281-b951-d872f2087c98
* Exclude upstreamed files so they may be added to WebCore.gypi safely.ajwong@chromium.org2009-07-151-0/+9
| | | | | | Review URL: http://codereview.chromium.org/149636 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20699 0039d316-1c4b-4281-b951-d872f2087c98
* linux: destroy browser-side plugin windows on plugin crashevan@chromium.org2009-07-1514-20/+71
| | | | | | | | | | | | | | | | Because the plugin windows must be destroyed by the UI thread, we store the map of plugin PID -> plugin windows there, on the RenderWidgetHostView. This differs slightly from Windows, where the map is stored on the PluginProcessHost, but is otherwise pretty similar. TEST=crash a windowed plugin; you should see a sad plugin icon in the place of the plugin Review URL: http://codereview.chromium.org/155517 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20693 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt fixing a crash. Looks like NativeMenuWin was getting leaked by ↵ben@chromium.org2009-07-151-2/+3
| | | | | | | | | | | Menu2... meaning a NativeMenuWin could outlive its model potentially! http://crbug.com/14594 TEST=none Review URL: http://codereview.chromium.org/149635 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20692 0039d316-1c4b-4281-b951-d872f2087c98
* test_shell: set a title on the home pageevan@chromium.org2009-07-151-0/+1
| | | | | | | | | | | | This seems pointless, but for debugging purposes internally we use the page title as an annotation on OS-level windows which helps track them down when looking at a list of all windows. For reasons too complicated for me to care about this doesn't work when a page lacks a title, hence this fix. Review URL: http://codereview.chromium.org/149642 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20691 0039d316-1c4b-4281-b951-d872f2087c98
* Disable tests failing due webkit (Roll WebKit DEPS 45843:45873). Introduced ↵stoyan@chromium.org2009-07-151-5/+10
| | | | | | | | | | in r20680. See http://crbug.com/16767. TBR=dimich Review URL: http://codereview.chromium.org/155545 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20690 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-20 14:45:50 +0000