summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* linux: drop temp_scaffolding_stubsevan@chromium.org2009-09-258-13/+57
| | | | | | | | | It was mostly unneeded, but I had to excise the last bits of RLZ and move some NOTIMPLEMENTED bits to where they belong. Review URL: http://codereview.chromium.org/219042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27161 0039d316-1c4b-4281-b951-d872f2087c98
* Roll back Markus's CL ( http://codereview.chromium.org/196053)jshin@chromium.org2009-09-256-58/+14
| | | | | | | | | BUG=none TEST=UI test and valgrind test pass TBR=markus Review URL: http://codereview.chromium.org/222031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27160 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed some warnings.apatrick@google.com2009-09-254-14/+14
| | | | | | Review URL: http://codereview.chromium.org/231027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27159 0039d316-1c4b-4281-b951-d872f2087c98
* More fixes for WorkerFastLayoutTests: enable them on Mac and Win, ↵dimich@google.com2009-09-251-1/+7
| | | | | | | | | | | reintroduce Linux guard that was removed by http://codereview.chromium.org/220034, since the test that fails on all platforms was disabled earlier: http://codereview.chromium.org/219033 BUG=none TEST=none TBR=jshin Review URL: http://codereview.chromium.org/224022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27158 0039d316-1c4b-4281-b951-d872f2087c98
* Set background to tabbed pane's content.oshima@chromium.org2009-09-251-0/+10
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/235012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27157 0039d316-1c4b-4281-b951-d872f2087c98
* Change my email address in watchlists so that I can filter the CCs more ↵ben@chromium.org2009-09-251-2/+2
| | | | | | | | | | effectively. TBR=jrg Review URL: http://codereview.chromium.org/208004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27156 0039d316-1c4b-4281-b951-d872f2087c98
* Add the stack signature of a small memory leak found in ↵jshin@chromium.org2009-09-251-0/+22
| | | | | | | | | | | SessionHistoryTest.HistorySearchXSS to the valgrind suppression list. BUG=22984 TEST=Valgrind bot does not report this leak any more when running SessionHistoryTest.HistorySearchXSS TBR=dank Review URL: http://codereview.chromium.org/223030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27155 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION build from 219.2 to 219.3laforge@chromium.org2009-09-251-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27154 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION build from 219.1 to 219.2laforge@chromium.org2009-09-251-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27153 0039d316-1c4b-4281-b951-d872f2087c98
* Convert the BrowerThemeProvider pointer from being ref counted totony@chromium.org2009-09-255-16/+11
| | | | | | | | | not being ref counted. It's owned by the profile and it doesn't need to be ref counted. Review URL: http://codereview.chromium.org/223027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27152 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up a few bits of files that I'm about to modify. The only visible ↵pkasting@chromium.org2009-09-256-82/+66
| | | | | | | | | | change is the removal of some extra spacing Ben erroneously added to the link infobar a while back (clients already do their own spacing as needed, so this just added extra whitespace in mid-sentence). BUG=none TEST=none Review URL: http://codereview.chromium.org/223029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27151 0039d316-1c4b-4281-b951-d872f2087c98
* Updated comment in tab_switching.cc to replect that Tab-switching test in ↵sidchat@chromium.org2009-09-251-1/+1
| | | | | | | | | | buildbot was outputting 0 because it was missing command line flag -log-level=0. log-level decides the amount of output in the log file, and histograms come under log-level 0. The default was 1, which meant that histograms were not logged - hence the results always showed 0. BUG=www.crbug.com/22965 TEST=none Review URL: http://codereview.chromium.org/239006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27150 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION build from 219.0 to 219.1laforge@chromium.org2009-09-241-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27149 0039d316-1c4b-4281-b951-d872f2087c98
* Wait for the history backend to load, which makes ↵phajdan.jr@chromium.org2009-09-241-1/+30
| | | | | | | | | | | AutocompleteBrowserTest.Autocomplete not flaky. TEST=Covered by browser_tests. BUG=19876 Review URL: http://codereview.chromium.org/218038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27147 0039d316-1c4b-4281-b951-d872f2087c98
* When converting between units of time or data types of different precision,markus@chromium.org2009-09-246-14/+58
| | | | | | | | | | | | | | | | | | | we have to be careful to consistently round in the same direction. Timeout checks usually check if Now() is less or equal to a deadline in order to determine if a timeout has occurred. This correctly handles the case where actual sleep times are equal or longer than requested sleep times. But if we round down when setting the sleep delay, this can result in unnecessary and expensive looping. Make sure, we always round up when converting to a format with less precision. BUG=none TEST=none Review URL: http://codereview.chromium.org/196053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27146 0039d316-1c4b-4281-b951-d872f2087c98
* Fix hottracking on button views.The hottracking on the toolbar was broken, ↵mhm@chromium.org2009-09-243-4/+17
| | | | | | | | | | | | | the expected behavoir is when focus is set to the toolbar (by hitting SHIFT+ALT+T) and toolbar buttons are traversed by right/left arrow keys, a bevel should appear on the button (HOT Image). This patch fixes the initial hottracking issue where the first item is not hottracked. BUG=10942 TEST=ALT+SHIFT+T and traverse with arrow keys, observe hot tracking. Review URL: http://codereview.chromium.org/194037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27145 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the json_schema_unittest since it crashes after a WebKit deps roll.jorlow@chromium.org2009-09-241-12/+14
| | | | | | | | | | TBR=nsylvain TEST=Unit tests now work. BUG=22971 Review URL: http://codereview.chromium.org/231024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27144 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r27137: "Create renderers for ExtensionHosts one at a time to avoidmpcomplete@chromium.org2009-09-246-85/+9
| | | | | | | | | blocking the UI" BUG=14040 TBR=erikkay git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27143 0039d316-1c4b-4281-b951-d872f2087c98
* Mark redirect-cross-origin-post.html failing both debug/release on Windowsjshin@chromium.org2009-09-241-1/+1
| | | | | | | | | BUG=10476 TEST=NONE TBR=dglazkov Review URL: http://codereview.chromium.org/239005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27141 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize statement_cache_ in the constructor.jhawkins@chromium.org2009-09-241-2/+4
| | | | | | | | | CID=1640 BUG=none TEST=none Review URL: http://codereview.chromium.org/225020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27140 0039d316-1c4b-4281-b951-d872f2087c98
* Roll WebKit to 48734. Includes 2 sided patch of mine.jorlow@chromium.org2009-09-243-3/+3
| | | | | | | | | | | | Match the new interfaces used for StorageNamespace in WebKit. TBR=dglazkov BUG=none TEST=none Review URL: http://codereview.chromium.org/219038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27139 0039d316-1c4b-4281-b951-d872f2087c98
* Simplify life for people trying to pick a "readable" foreground color by not ↵pkasting@chromium.org2009-09-244-37/+36
| | | | | | | | | | requiring them to provide two choices. This also speeds the call up a tiny bit by not calculating the background luminance twice. BUG=none TEST=none Review URL: http://codereview.chromium.org/220029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27138 0039d316-1c4b-4281-b951-d872f2087c98
* Create renderers for ExtensionHosts one at a time to avoid blocking the UI.mpcomplete@chromium.org2009-09-246-9/+85
| | | | | | | | | BUG=14040 TEST=Install a bunch of extensions with toolstrips, then restart Chrome. The UI should be responsive while the toolstrips are loading. Review URL: http://codereview.chromium.org/220028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27137 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize statement_cache_ in the constructor.jhawkins@chromium.org2009-09-241-1/+5
| | | | | | | | | CID=1608 BUG=none TEST=none Review URL: http://codereview.chromium.org/222024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27136 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize statement_cache_ in the constructor.jhawkins@chromium.org2009-09-241-1/+4
| | | | | | | | | CID=1602 BUG=none TEST=none Review URL: http://codereview.chromium.org/223026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27135 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize updating_ in the constructor.jhawkins@chromium.org2009-09-241-1/+2
| | | | | | | | | CID=1484 BUG=none TEST=none Review URL: http://codereview.chromium.org/222026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27134 0039d316-1c4b-4281-b951-d872f2087c98
* Make Chromium Linux work over VNC again.thestig@chromium.org2009-09-241-2/+6
| | | | | | | | BUG=none TEST=Run a debug copy of Chromium over VNC, should not hit the DCHECK. Review URL: http://codereview.chromium.org/218024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27133 0039d316-1c4b-4281-b951-d872f2087c98
* Change rebaselining tool to pull win baselines from xp botvictorw@chromium.org2009-09-241-2/+2
| | | | | | | | | | | | instead of vista bot which is not stable now. TBR=dpranke TEST=none BUG=none Review URL: http://codereview.chromium.org/224013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27132 0039d316-1c4b-4281-b951-d872f2087c98
* Add about: and chrome:* to history. Patch by Pierre-Antoine LaFayette (see ↵pkasting@chromium.org2009-09-241-3/+3
| | | | | | | | | http://codereview.chromium.org/193071 ), r=me,brettw. BUG=2958 TEST=Visit "about:", then hit ctrl-h and make sure it's in your history. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27131 0039d316-1c4b-4281-b951-d872f2087c98
* Implement BrowserList::AllBrowsersClosed for Linux.tony@chromium.org2009-09-244-5/+29
| | | | | | | | | | | This fixes leaks caused by not calling gtk_widget_destroy on dialog windows when we exit. While I'm here, fix a GList leak on Linux toolkit views. Review URL: http://codereview.chromium.org/223015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27130 0039d316-1c4b-4281-b951-d872f2087c98
* Correctly talk to VMS servers (translate UNIX paths to VMS and vice versa).phajdan.jr@chromium.org2009-09-247-12/+445
| | | | | | | | | | | | This way we get a native VMS listing and not a UNIX emulation mode, which is slightly different than native UNIX and confuses the parser. TEST=Covered by net_unittests. BUG=22193 Review URL: http://codereview.chromium.org/215058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27129 0039d316-1c4b-4281-b951-d872f2087c98
* Fix FTP directory listings for servers which use \n as the line break.phajdan.jr@chromium.org2009-09-241-4/+7
| | | | | | | | | | | | | The previous version of the code assumed that \r\n (CRLF) will always be used. The FTP spec is extremely imprecise about the LISTing format. TEST=See bug. BUG=22879 Review URL: http://codereview.chromium.org/238001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27128 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Support option-return to open in new foreground tab.rohitrao@chromium.org2009-09-241-2/+2
| | | | | | | | | | BUG=http://crbug.com/22882 TEST=Type something into the omnibox. Option-return should open it in a new foreground tab. TEST=After using Option-return to open something in a new foreground tab, switch back to the original tab and verify that the url in the omnibox has reverted to the original page's url. TEST=Option-leftclick on a link in a webpage should still prompt you to "save as." Review URL: http://codereview.chromium.org/218032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27127 0039d316-1c4b-4281-b951-d872f2087c98
* Re-disable all Worker tests until I can figure out exact set of failing ones.dimich@google.com2009-09-241-1/+1
| | | | | | | TBR=atwilson Review URL: http://codereview.chromium.org/239004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27126 0039d316-1c4b-4281-b951-d872f2087c98
* Added command buffer unit tests to gyp.apatrick@google.com2009-09-2413-50/+147
| | | | | | | | | | | | | | | | | | | Can optionally override default renderer with environment variable. One of: GYP_DEFINES = "renderer=d3d9" GYP_DEFINES = "renderer=gl" GYP_DEFINES = "renderer=cb cb_service=d3d9" GYP_DEFINES = "renderer=cb cb_service=gl" Fixed some warnings. Works on windows with D3D9 but not GL, mac or linux yet. TEST=none BUG=none Review URL: http://codereview.chromium.org/208037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27125 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 27117.davemoore@chromium.org2009-09-2415-1631/+257
| | | | | | Review URL: http://codereview.chromium.org/235010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27124 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable WorkerFastTests and disable only one that fails.dimich@google.com2009-09-241-3/+3
| | | | | | | | BUG=22947 TEST=none Review URL: http://codereview.chromium.org/219033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27123 0039d316-1c4b-4281-b951-d872f2087c98
* Downstreamed v8 extension building & webkit_chromium_port flagyaar@chromium.org2009-09-242-0/+22
| | | | | | | | | | 1. Downstreamed building webkit/extension/v8/*.cc files, which were built by upstream webcore by mistake. Now glue will build them. I tested that even though webcore still builds them, there are no errors if glue also builds them. 2. Added webkit_chromium_port variable to build/common.gypi which is turned off by default. Currently, nothing uses it but the chrome port will need it. Review URL: http://codereview.chromium.org/220026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27122 0039d316-1c4b-4281-b951-d872f2087c98
* Another draft of the overview, now with figures. Made related changes to the ↵kathyw@google.com2009-09-2410-364/+243
| | | | | | | | background pages and content scripts pages. Review URL: http://codereview.chromium.org/225023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27121 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize tab_contents_ and wait_state_ in the constructor.jhawkins@chromium.org2009-09-241-0/+2
| | | | | | | | | CID=1510 BUG=none TEST=none Review URL: http://codereview.chromium.org/218036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27120 0039d316-1c4b-4281-b951-d872f2087c98
* manual code review: update ignoresthomasvl@chromium.org2009-09-240-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27119 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Use "Set to Classic theme" instead of reset in the options dialog.erg@google.com2009-09-242-1/+4
| | | | | | Review URL: http://codereview.chromium.org/238003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27118 0039d316-1c4b-4281-b951-d872f2087c98
* Use chrome/base synchronization primitives and threads instead oftim@chromium.org2009-09-2415-257/+1631
| | | | | | | | | | | | | | | | | | | | | | | | | | pthreads in SyncerThread. The old pthread impl can be used by specifying --syncer-thread-pthreads for comparison until we settle fully on the final impl (I have a MessageLoop-based impl in progress). The default SyncerThread is as close to the pthreads-impl semantics as I could get, with one exception: it does not offer a time-out when calling Stop(), because it greatly simplifies the implementation. I first implemented it *with* the timeout, and for sake of experimentation while this is in shuffle I am checking it in as SyncerThreadTimedStop, available by using --syncer-thread-timed-stop. I'm not sure which we want ultimately, but it's useful to have around when building the MessageLoop based impl. I had to refactor the interface slightly to allow multiple implementations, I think it will be quite useful while working on the MessageLoop impl. Added several tests to SyncerThreadUnittest, which all impls now pass ( just pass the command line flag to try each out). TEST=SyncerThreadTest, SyncerThreadWithSyncerTest, integration tests Review URL: http://codereview.chromium.org/214033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27117 0039d316-1c4b-4281-b951-d872f2087c98
* Add the stack for a small amount of memory leak introduced between r27050 ↵jshin@chromium.org2009-09-241-0/+13
| | | | | | | | | | | and r27060. BUG=22932 TEST=Linux valgrind bots do not fail. TBR=dank Review URL: http://codereview.chromium.org/235009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27116 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 27113, it breaks the ChomeOS build.jcampan@chromium.org2009-09-2423-268/+121
| | | | | | | TBR=ben Review URL: http://codereview.chromium.org/231022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27115 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: fix a process name setting bug that doesn't currently affect us.mdm@chromium.org2009-09-241-1/+1
| | | | | | | | | | We don't pass a format string starting with '-' to setproctitle(), but I was looking at doing that and found this small bug. BUG=none TEST=none Review URL: http://codereview.chromium.org/218033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27114 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring some of the NativeViewHost and NativeControl focus management so ↵jcampan@chromium.org2009-09-2423-121/+268
| | | | | | | | | | | their consumers don't have to explicitly set the focused view. BUG=None TEST=Run all tests. Make sure focus is stored/restored properly in Chrome. Review URL: http://codereview.chromium.org/214029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27113 0039d316-1c4b-4281-b951-d872f2087c98
* Preliminary fixes to enable link dependent objects.maruel@chromium.org2009-09-246-9/+14
| | | | | | | | BUG=22926 TEST=still builds Review URL: http://codereview.chromium.org/231020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27112 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize the remaining members of HistoryContentsProvider.jhawkins@chromium.org2009-09-241-0/+6
| | | | | | | | | CID=1633 BUG=none TEST=none Review URL: http://codereview.chromium.org/223025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27111 0039d316-1c4b-4281-b951-d872f2087c98
* Update googleurl to 118.mattm@chromium.org2009-09-241-1/+1
| | | | | | | | BUG=5490 Review URL: http://codereview.chromium.org/219015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27110 0039d316-1c4b-4281-b951-d872f2087c98