| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
I had to make the KeyEvent constructor include the event flags.
Also cleaned-up some unit-tests
BUG=None
TEST=Run the unit-tests.
Review URL: http://codereview.chromium.org/266012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/267024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
when sad tab is showing.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/270018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove the alert icon from the download item dangerous download xib.
- Remove the download fav icon from the download shelf xib.
- Update the download shelf to fetch the image from the pak.
- Update the download item to fetch the alert image from the pak.
- Update the bookmark bar to fetch the folder icon from the xib and cache it.
- Remove the three images from the bundles.
BUG=20230
TEST=all three still show their images
Review URL: http://codereview.chromium.org/260012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
version of r20787.
BUG=http://crbug.com/18719
TEST=download a theme, make sure that it doesn't stay in the download shelf.
Review URL: http://codereview.chromium.org/268008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=amit
http://codereview.chromium.org/255087
Adding a unique runtime Id to Profile objects, that can be used as the key
of the ProfileSiteInstanceMap type. This is used to make sure that Profile
objects can correctly share site information when one profile is derived
from another.
BUG=0
TEST=See unit tests
Review URL: http://codereview.chromium.org/261012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/268015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Patch by Joel Stanley <joel@jms.id.au>
Review URL: http://codereview.chromium.org/261021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/271022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/261022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28385 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/255080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tooltips longer than 1024 chars get truncated. However, to determine if the
tooltip changed, the un-truncated new text was compared to the truncated old
text. Thus, for long tooltips, the tooltip text was considered to be constantly
changing, causing the tooltip to be destroyed and re-created constantly.
Patch by Simon Radford
R=beng,darin
BUG=4754
TEST=Go to (for example) http://people.mozilla.org/~rdoherty/tooltips.html and
check that the long tooltips do not flash on Windows (I used Vista).
Review URL: http://codereview.chromium.org/265003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
had pointed to bugs that were closed as duplicates.
BUG=none
R=TBD
TEST=none
Review URL: http://codereview.chromium.org/265035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28382 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=18984
Review URL: http://codereview.chromium.org/269017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28381 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
R=TBR
TEST=none
Review URL: http://codereview.chromium.org/271021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
be flaky.
BUG=none
TEST=none
TBR=jam
Review URL: http://codereview.chromium.org/261020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28379 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the bug numbers in test_expectations, so that all the bugs are in one place:
Bugs remapped as follows:
1058654 - 24187
793944 - 24185
849085 - 24186
753420 - 24189
700464 - 24191
849072 - 24192
879449 - 24193
941049 - 24194
972450 - 24195
973468 - 24197
992321 - 24198
1042838 - 24199
1089231 - 24203
1115062 - 24204
1124568 - 24205
1126050 - 24206
1166644 - 24207
1204878 - 24208
1344252 - 24209
BUG=none
R=dglazkov
TEST=none
Review URL: http://codereview.chromium.org/265030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28378 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/18854
TEST=Titles on mouse-over in Expose. No extra title in titlebar.
Review URL: http://codereview.chromium.org/259023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=hclam
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/261019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28374 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=hclam
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/265034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=aa
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to pick up the flag.
TBR=kbr
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
WebKit.
TBR=kbr
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
isolated world. Chromium side of change.
Review URL: http://codereview.chromium.org/262002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
CID=6427
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/267020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28368 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Have the system_metrics generated code depend on 'protobuf_lite'.
Review URL: http://codereview.chromium.org/242117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
observe changes.
- implemented power menu button showing remaining battery info.
- implemented clock menu button showing detailed clock info.
- also implemented monitoring of network status change.
- don't show highlighted state for these menu buttons
BUG=23923
TEST=none
Review URL: http://codereview.chromium.org/251099
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
original issue: http://codereview.chromium.org/207062
The issue had to do with a symbol collison with the nss libraries (which are currently out-of-date) on the build bots.
HTML Pack Extension Dialog. This removes the views implementation of the ExtensionPackDialog, and implements the dialog in html in the extensions_ui DOMUI.
Additionally, support is added for packaging extensions via ---pack-extension on linux and mac
BUG=20668, 20669
TBR=aa,wtc
Review URL: http://codereview.chromium.org/265032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=24217
TEST=screenshotted before and after.
Review URL: http://codereview.chromium.org/261018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28364 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
HttpResponseInfo.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/269012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28363 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=rebuild gyp files, open chrome.sln. Observer chrome_frame project.
Review URL: http://codereview.chromium.org/271014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
UpdatePopupAppearance() never removes child views (the popup quickly grows to its child limit and then stays there forever; we only show some of the children at a time though).
BUG=20511
TEST=none
TBR=huanr
Review URL: http://codereview.chromium.org/262018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
necessary. Remove unnecessary V8::IsDead() check (IdleNotification() already checks IsRunning(), which is mutually exclusive with IsDead()).
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/265019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
implemented in both the mac-specific file and the shared one, and several
virtual functiongs that were never derived for anything.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/267017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
we'll have all the slow tests marked and can bring the timeout
down to something like 5 seconds.
Review URL: http://codereview.chromium.org/267015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
in unit_tests.
Review URL: http://codereview.chromium.org/271017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert r28350 aka http://codereview.chromium.org/259023
Passed the trybots because of DCHECK which wasn't there for build
bots.
TBR=zork
Review URL: http://codereview.chromium.org/271015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The http_server python script had everything defined in the batch script, but the ui tests use the python file directly. This makes sure the google python package gets imported successfully.
TBR=thestig
BUG=6784
TEST=run http_server.py directly, not via sh.
Review URL: http://codereview.chromium.org/271016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/269015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=12341, 21411
TEST=none
Review URL: http://codereview.chromium.org/264006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=19895
TEST=AuthWatcherTest
Review URL: http://codereview.chromium.org/246098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refactored out UrlIsAlive to live outside the ApacheHttpd class and imported http_utils.py into http_server.py
Now they share common code.
BUG=6784
TEST=started and stopped http_server successfully.
Review URL: http://codereview.chromium.org/243022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/18854
TEST=Titles on mouse-over in Expose. No extra title in titlebar.
Review URL: http://codereview.chromium.org/259023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/218014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
matches its result count (views).
BUG=20511
TEST=none
Review URL: http://codereview.chromium.org/271013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
we reassign them. The particular scenario that can lead to this is
when migrating bookmarks out of the db we never reset the ids of the
newly created nodes, so that we wrote all to the file with ids of
0. I'm not patching that code so that I have coverage of the unit
test, and we'll handle fix up during reading anyway.
BUG=24060
TEST=covered by unit tests
Review URL: http://codereview.chromium.org/268001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=NONE
TBR=aa
Review URL: http://codereview.chromium.org/270017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
but still shows up on the bots.
BUG=20814
Review URL: http://codereview.chromium.org/268009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28343 0039d316-1c4b-4281-b951-d872f2087c98
|