| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
BUG:41319
Review URL: http://codereview.chromium.org/1508034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts r44299.
BUG=none
TEST=perf steps return to normal
TBR=nsylvain@chromium.org
Review URL: http://codereview.chromium.org/1625012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BookmarkBarFolderController. Now all bookmarks can be dragged to the desktop, the tab strip, or other windows to load, even ones in folders.
BUG=40834
TEST=see bug. Test bookmarks on the bookmark bar didn't regress.
Review URL: http://codereview.chromium.org/1549037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
based on host permissions
BUG=38398
TEST=none
TBR=jochen@chromium.org
Review URL: http://codereview.chromium.org/1642005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1607016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
based on host permissions.
BUG=38398
TEST=none
Review URL: http://codereview.chromium.org/1095002
TBR=jochen@chromium.org
Review URL: http://codereview.chromium.org/1575036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
permissions.
BUG=38398
TEST=none
Review URL: http://codereview.chromium.org/1095002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Updated it so it matches with what we have on the mocks.
BUG=none
TEST=Run with --login-manager --login-screen=oobe and check that Welcome to Chromium OS label is visible and has the right color.
Review URL: http://codereview.chromium.org/1611025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebKit::WebGeolocationServiceBridgeImpl::stopUpdating().
(depends on the fix provided by http://trac.webkit.org/changeset/57335).
BUG=40660,40478
TEST=GeolocationBrowserTest.InvalidUrlRequest
Review URL: http://codereview.chromium.org/1626011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
application locale codes.
The change is necessary to integrate UI language selection in the language
settings dialog. In short, input languages and UI languaes (application
locale codes are used for UI languages) need to be compatible.
TEST=unit_tests
BUG=2336
Review URL: http://codereview.chromium.org/1575034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Along the way, refactor the code to use tags in ButtonPressed(),
and remove members that are no longer necessary by the change.
TEST=manually
BUG=crosbug.com/2545
Review URL: http://codereview.chromium.org/1525028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44339 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
websocket server. Submitting this as a 2-sided patch to make it easier
to roll it back if something breaks.
BUG=none
TEST=none
TBR=antonm
Review URL: http://codereview.chromium.org/1521026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44336 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=dumi@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The code is conditional. I guess my gaming side
spidey senses can't stand the overhead but
I could be convinced to make it non-conditional.
TEST=various unit tests
BUG=none
Review URL: http://codereview.chromium.org/1629004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44334 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=41291
TEST=DevToolsSanityTest.TestProfilerTab
TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/1578028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=40995
TEST=none
TBR=ukai
Review URL: http://codereview.chromium.org/1542028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/1627018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=antonm
Review URL: http://codereview.chromium.org/1618017
TBR=dumi@chromium.org
Review URL: http://codereview.chromium.org/1513032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=41259,19113
TEST=build code that uses mmx intrinsics.
Review URL: http://codereview.chromium.org/1604030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44325 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=antonm
Review URL: http://codereview.chromium.org/1618017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44324 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
have run.
This is consistent with the comment for Thread::CleanUp(), which says it runs after the message loop has "stopped".
Certain consumers depend on this ordering to avoid accessing variables which are deleted by Thread::CleanUp().
BUG=39723
TEST=ThreadTest.CleanUp
Review URL: http://codereview.chromium.org/1540002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1653001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44319 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=19113
TEST=build official chrome on linux 32 bit.
Review URL: http://codereview.chromium.org/1508031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44318 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
avoids unnecessarily performing a second map lookup
in many cases.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1631012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44317 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/1575030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44313 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=40073
TEST=Focus the list or the tree. Press the context menu keyboard key. The menu should be positioned relative to the selected item.
Review URL: http://codereview.chromium.org/1542027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=19113
TEST=Left border in WebKit/LayoutTests/media/content/test.ogv is clearly visible.
Review URL: http://codereview.chromium.org/1650002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=antonm
Review URL: http://codereview.chromium.org/1605023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44310 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
anchor. The IsTopLevelUrl function exposed by the navigation manager
would compare the URL received in the BHO which has the anchor and the URL received from the anchor which does not have the anchor. As a result
we would not wrap the bind status callback which caused this issue.
The IsTopLevelUrl function now compares the URLs after stripping the anchor portion in the URL.
Should fix bug http://code.google.com/p/chromium/issues/detail?id=38265.
This only works if the moniker patch is enabled.
Bug=38265
Test=Covered by unit test.
Review URL: http://codereview.chromium.org/1559027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1611024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44308 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=19113
TEST=do large scale factors and look for lines every nth line. Should look smooth and be faster than previously.
Review URL: http://codereview.chromium.org/1521023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44307 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I have an SDCH experiment, and a DNS prefetch experiment running.
I reduced both percentages to 1 in 1000.
r=wtc
Review URL: http://codereview.chromium.org/1528031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
The swig action should depend on the headers it includes.
Review URL: http://codereview.chromium.org/1646002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44305 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=41196,38364
TEST=In the bugs
Review URL: http://codereview.chromium.org/1519033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44304 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=40669, 41007
Review URL: http://codereview.chromium.org/1647002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44303 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
are opened in the new window instead of the original window. This change hinges on having URL opening code return the browser into which the URL was opened so that subsequent openings may now into which browser to do so.
BUG=39901,41104
TEST=Bring up context menu on a folder with two or more bookmarks and select "Open All in Incognito Window". Insure that all of the URLs are opened in the newly created, top-most window. Verify that no new tabs were created in the original window. Perform this same test using "Open All in New Window".
Review URL: http://codereview.chromium.org/1633009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44302 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Swap expected verus actual value in unit test. A small cleanup item.
BUG=none
TEST=AutoFillProfileTest
Review URL: http://codereview.chromium.org/1651001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44300 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=perf steps are green
Review URL: http://codereview.chromium.org/1582025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44299 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44298 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
make sure HostContentSettingsMap correctly fires off notifications whenever
it modifies them, and re-loads them when they are modified.
Take 2...
BUG=40484,41003
TEST=HostContentSettingsMapTest.*
Review URL: http://codereview.chromium.org/1604020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44297 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
A better fix is to make FileDescriptorWatcher handle this internally, will track that as a follow-up issue.
BUG=39932
Review URL: http://codereview.chromium.org/1550003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44296 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=antonm
Review URL: http://codereview.chromium.org/1559028
TBR=dumi@chromium.org
Review URL: http://codereview.chromium.org/1609023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44292 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=35038
TEST=PasswordStoreMacTest
Review URL: http://codereview.chromium.org/1524011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44291 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=antonm
Review URL: http://codereview.chromium.org/1559028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44290 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
is needed by <http://codereview.chromium.org/1604020> because the host_content_settings now registers as an observer of the profile and needs to unregister itself on the UI thread.
BUG=none
TEST=CookiePromptWindowControllerTest.*
Review URL: http://codereview.chromium.org/1527028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44289 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
According to http://mail.google.com/support/bin/answer.py?hl=en&ctx=mail&answer=10313#, gmail ignores period characters and case differences in the username portion of an email address. Follow those rules.
BUG=chromiumos:2260
TEST=unit tests, also run on device and log in with user@google.com and user@GOOGLE.COM; verify that you get the same tab state, etc. in both sessions.
Review URL: http://codereview.chromium.org/1539030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=41184
TEST=None
Review URL: http://codereview.chromium.org/1610022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44285 0039d316-1c4b-4281-b951-d872f2087c98
|