summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Gtk confirm form resubmission dialog.mattm@chromium.org2009-08-3122-57/+198
| | | | | | | | | | | Refactor so that the dialog is shown by calling BrowserWindow::ShowRepostFormWarningDialog BUG=19761 TEST=see bug Review URL: http://codereview.chromium.org/174294 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24930 0039d316-1c4b-4281-b951-d872f2087c98
* Change title of Welcome to Chrome thumbnail in first run NTP to "Welcome to ↵mirandac@chromium.org2009-08-313-5/+8
| | | | | | | | | | | Chrome" from "Google Chrome." BUG= none TEST= Open NTP with clean profile. Note that title of first thumbnail is "Welcome to Chrome" or "Welcome to Chromium". Review URL: http://codereview.chromium.org/177036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24929 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r24920 without the other cruft that I had in my checkout, which broke ↵pkasting@chromium.org2009-08-312-33/+24
| | | | | | | | | | | the compile. TBR=mmoss BUG=none TEST=none Review URL: http://codereview.chromium.org/176043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24928 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r24920 due to compile failures.mmoss@chromium.org2009-08-312-28/+29
| | | | | | | | | TBR=pkasting Review URL: http://codereview.chromium.org/181023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24927 0039d316-1c4b-4281-b951-d872f2087c98
* up cullingzsort stress test pdiff thresholdgman@google.com2009-08-311-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24926 0039d316-1c4b-4281-b951-d872f2087c98
* TBR:pkastingmmoss@chromium.org2009-08-311-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24924 0039d316-1c4b-4281-b951-d872f2087c98
* Prep for ascii only converter optiongman@google.com2009-08-313-5/+17
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24921 0039d316-1c4b-4281-b951-d872f2087c98
* Minor autocomplete fixes while trying to track down a topcrash:pkasting@chromium.org2009-08-312-29/+32
| | | | | | | | | | | | | * Turn some DCHECKs into CHECKs (I don't think any of these will get hit) * Ensure that URLsForDefaultMatch() doesn't leave any results lying around on the controller, since the popup isn't open (and those two states should be locked in step) * Eliminate some old code in Move() that shouldn't have actually done anything anymore (since result() should already be in sync with the popup, and SetSelectedLine() is going to stop the controller) * Use a pre-existing helper function at two places in the Edit for readability BUG=none TEST=none Review URL: http://codereview.chromium.org/180045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24920 0039d316-1c4b-4281-b951-d872f2087c98
* Don't hardcode the timeout in the unload ui test.estade@chromium.org2009-08-311-1/+1
| | | | | | | | | The too-short timeout was making it leak in valgrind. BUG=20617 Review URL: http://codereview.chromium.org/180044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24919 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug where the tooltip would not be erased if it had been non-empty and ↵pkasting@chromium.org2009-08-311-4/+4
| | | | | | | | | | then was updated to be empty. BUG=none TEST=Start Chrome, type a letter in the omnibox, hover the Go button and wait for the tooltip. Then delete the character and move the mouse pointer a tiny bit. The tooltip should disappear. Review URL: http://codereview.chromium.org/175032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24918 0039d316-1c4b-4281-b951-d872f2087c98
* Change perf expect. object from array to hash.chase@chromium.org2009-08-311-1/+1
| | | | | | | | | | | | | Simplifies code in Buildbot, making sure the stopgap has the correct format. BUG=18597 TBR=nsylvain TEST=none Review URL: http://codereview.chromium.org/176039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24917 0039d316-1c4b-4281-b951-d872f2087c98
* linux: disable querying the page window for windowless pluginspiman@chromium.org2009-08-311-2/+6
| | | | | | | | | | | | | | The problem is that the XID of the page window can change at arbitrary times (e.g. when the tab is detached then reattached), so we need to be able to track these changes, and let the PluginInstance know. BUG=17110 TEST=go to www.nvidia.com, detach then reattach the tab, move the mouse, verify no crash Review URL: http://codereview.chromium.org/180019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24916 0039d316-1c4b-4281-b951-d872f2087c98
* Disable flakey browsertests on Linux.rafaelw@chromium.org2009-08-311-4/+7
| | | | | | | | | | | This disables ExtensionMessagingTab and ExtensionViews TBR=estade Review URL: http://codereview.chromium.org/173632 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24915 0039d316-1c4b-4281-b951-d872f2087c98
* Make AutocompleteController::done() match up with when results are actually ↵pkasting@chromium.org2009-08-312-8/+8
| | | | | | | | | | | | pushed to listeners. r24290 made it possible for the controller to be "done" (in that all providers had finished) but have not yet sent the final results to listeners. This makes done() only return true when the controller has actually pushed the final results. I'm not sure precisely what effects this discrepancy could have had but I suspect they were bad, given that callers assume done() means "results are stable". BUG=none TEST=none Review URL: http://codereview.chromium.org/173631 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24914 0039d316-1c4b-4281-b951-d872f2087c98
* Linux 64-bit: Fix failing unit_tests and ignore non-working plugin/media tests.mmoss@chromium.org2009-08-313-2/+6
| | | | | | | | | | | Related bugs: http://crbug.com/18337 http://crbug.com/20467 Review URL: http://codereview.chromium.org/175019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24913 0039d316-1c4b-4281-b951-d872f2087c98
* Double the number of runs we track in the flakiness dashboard.ojan@google.com2009-08-311-1/+1
| | | | | | | | | | | | 100 doesn't seem to be enough for some of the tests that only flake 1/100 runs to see if they also flake on other platforms or build types. BUG=none TEST=none Review URL: http://codereview.chromium.org/179042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24912 0039d316-1c4b-4281-b951-d872f2087c98
* Don't resize the renderer while opening the bookmark bar or an infobar.estade@chromium.org2009-08-319-19/+26
| | | | | | | | | | This is just a performance optimization. Previously this code was added for closing bookmark bars as a bit of visual polish.Doing the same thing for opening bookmark bars should reduce CPU usage but it won't look any different (for fast computers anyway). BUG=17133 Review URL: http://codereview.chromium.org/183011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24911 0039d316-1c4b-4281-b951-d872f2087c98
* linux: prefer non-nspluginwrapper/crossover pluginsevan@chromium.org2009-08-311-2/+24
| | | | | | | | BUG=18947, various nspluginwrapper-related bugs perhaps Review URL: http://codereview.chromium.org/173617 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24910 0039d316-1c4b-4281-b951-d872f2087c98
* Add rebaseline tool support to pull archive results from webkit.org canary botvictorw@chromium.org2009-08-311-4/+19
| | | | | | | | | | BUG=20695 TEST=none Review URL: http://codereview.chromium.org/175031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24909 0039d316-1c4b-4281-b951-d872f2087c98
* Change "View source" shortcut from cmd-u to cmd-opt-u on os x.thakis@chromium.org2009-08-311-7/+7
| | | | | | | | | | | Two reasons: 1. Compatibility with Safari. 2. Doesn't conflict with webapps that want to use cmd-u for e.g. underline. Review URL: http://codereview.chromium.org/177030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24908 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for Canvas::DrawBitmap that I broke when addinggman@google.com2009-08-311-1/+1
| | | | | | | | adding pitch to Texture2D::Lock Review URL: http://codereview.chromium.org/177029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24907 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for archive request. It turns out this thinggman@google.com2009-08-316-36/+54
| | | | | | | | | | | | | | can be called recursively. Because of that ArchiveRequest::raw_data_ would be invalid when the outer call came back. This way we mostly don't use that field. Also updated the docs so it can me marked as deprecated. Review URL: http://codereview.chromium.org/173620 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24906 0039d316-1c4b-4281-b951-d872f2087c98
* Makes 'Pin tab' option in context menu a checkbox.sky@chromium.org2009-08-311-1/+1
| | | | | | | | | | BUG=20575 TEST=On linux pin a tab. Right click on the tab and make sure you see a check next to 'Pin Tab'. Review URL: http://codereview.chromium.org/175028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24905 0039d316-1c4b-4281-b951-d872f2087c98
* Lands 176025 from Oshima:sky@chromium.org2009-08-315-15/+86
| | | | | | | | | | | | | Combobox implemenation for GTK Removed const from GetPreferredSize, as GTK implementation has cache to update. TEST=none BUG=none Review URL: http://codereview.chromium.org/183015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24904 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Use a GtkInvisible to track the tab dragging operation. Originally we ↵jhawkins@chromium.org2009-08-313-81/+114
| | | | | | | | | | were using the actual tab widget for this purpose, but this is unreliable becauase we hide and detach the tab widget, which disturbs the drag operation. BUG=19725,20513 TEST=Extensive tab dragging. Review URL: http://codereview.chromium.org/176034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24903 0039d316-1c4b-4281-b951-d872f2087c98
* More correctly run the second browser in ChromeMainTest.phajdan.jr@chromium.org2009-08-313-139/+165
| | | | | | | | | | | | | | - wait for the second browser process to finish - only initialize user dir once Will it kill flakiness? Who knows. TEST=none http://crbug.com/20546 Review URL: http://codereview.chromium.org/181016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24902 0039d316-1c4b-4281-b951-d872f2087c98
* Removes unnecessary using-declaration.phajdan.jr@chromium.org2009-08-311-3/+0
| | | | | | | | | | | Patch by Thiago Farina. Original review: http://codereview.chromium.org/177031 BUG=None TEST=None Review URL: http://codereview.chromium.org/173629 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24901 0039d316-1c4b-4281-b951-d872f2087c98
* Disk Cache: Function re-ordering. No code change.rvargas@google.com2009-08-313-94/+101
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/182023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24900 0039d316-1c4b-4281-b951-d872f2087c98
* Replace the RenderProcessHost.PID function that returns the OS-generatedbrettw@chromium.org2009-08-3173-639/+747
| | | | | | | | | | | | | | | | | | | | process ID with an internally-generated id() function. This allows us the guarantee that the IDs are unique over the entire run of the application. This also cleans up some code associated with managing the PID. The main potentially interesting change is now the PID is set uniquely for every creation of RenderProcessHost. It used to be set cleared if the process went away, and re-set if the process was re-created. The ID generation is in ChildProcesInfo so it is also unique between workers and plugins. I had to change some significant things in resource_dispatcher_host_unittest to take into account this new generation of IDs. BUG=17828 TEST=none Review URL: http://codereview.chromium.org/160203 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24899 0039d316-1c4b-4281-b951-d872f2087c98
* Remove suppression for memory leak in IPC::Channel::Channel()nirnimesh@chromium.org2009-08-311-14/+0
| | | | | | | | | BUG=17888 TEST=mac valgrind bot should stay green. Review URL: http://codereview.chromium.org/179038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24898 0039d316-1c4b-4281-b951-d872f2087c98
* Switch to a "+" address so I can distinguish watchlist mail from my ownpam@chromium.org2009-08-311-4/+4
| | | | | | | | | | | reviews. BUG=none TEST=make sure I still get watchlist mail Review URL: http://codereview.chromium.org/175020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24897 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the color of links in list form so that they're themed and not default blue.mirandac@chromium.org2009-08-311-0/+1
| | | | | | | | | BUG= http://crbug.com/20277 TEST= Open NTP, try out some themes, observe that links change color to keep up with theme, and are legible against background of page. Review URL: http://codereview.chromium.org/176033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24896 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Provisional commit to handle Web inspector call frame changes ↵pfeldman@chromium.org2009-08-311-1/+1
| | | | | | | | | upstream. TBR=yurys git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24893 0039d316-1c4b-4281-b951-d872f2087c98
* share extension API test frameworkerikkay@chromium.org2009-08-3124-333/+183
| | | | | | | | | BUG=18442 TEST=ExtensionApiTest.* Review URL: http://codereview.chromium.org/173622 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24892 0039d316-1c4b-4281-b951-d872f2087c98
* Roll webkit to r47896. Rebaseline one test as the new resultsojan@google.com2009-08-315-3/+3
| | | | | | | | | | | | are actually correct (the only results contained failing statements). This was fixed with the upstream change http://trac.webkit.org/changeset/47884. BUG=none TEST=none TBR=michaeln@chromium.org Review URL: http://codereview.chromium.org/182029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24891 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: make search engines dialog size based on locale settings.mdm@chromium.org2009-08-311-6/+11
| | | | | | | | | BUG=20453 TEST=none Review URL: http://codereview.chromium.org/180034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24890 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing newline at end of file.mdm@chromium.org2009-08-311-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/183010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24889 0039d316-1c4b-4281-b951-d872f2087c98
* Sanitizing the referrer header before starting the automation ↵tommi@chromium.org2009-08-314-10/+28
| | | | | | | | request.TEST=Run automation unit tests.BUG=none Review URL: http://codereview.chromium.org/183004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24888 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Disable input options in the clear browsing data window when workingrsesek@chromium.org2009-08-311-18/+182
| | | | | | | | | | | | | * Clear the spinner's |hidden| binding, and set it to not show when stopped. * Bind the spinner's |animate| to |owner.isClearning|. * Bind the checkboxes and dropdown's |enabled| to |!owner.isClearning|. BUG=19405 TEST=Clear browsing data on a decently sized profile. While clearing, the window's input controls should be disabled and the spinner should show and animate. Review URL: http://codereview.chromium.org/179035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24885 0039d316-1c4b-4281-b951-d872f2087c98
* Update bug number in test_expectationsvictorw@chromium.org2009-08-311-3/+4
| | | | | | | | | | TBR=dglazkov BUG=20566 TEST=none Review URL: http://codereview.chromium.org/178035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24884 0039d316-1c4b-4281-b951-d872f2087c98
* Adding command-line option to override bans on certain port numbers through ↵mirandac@chromium.org2009-08-316-1/+92
| | | | | | | | | | a comma-separated list of ports. BUG= http://crbug.com/18307 TEST= url_request_unittest, use commandline flag allowed_ports=1,600. Navigate to http://www.google.com:1 or http://www.google.com:600. You should not get an ERR_UNSAFE_PORT, it will attempt to load the page. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24883 0039d316-1c4b-4281-b951-d872f2087c98
* Fix two bugs in chrome://extensions/:aa@chromium.org2009-08-312-5/+16
| | | | | | | | | | | | | | | * CHECK when reloading installed extension. Caused because we were somtimes trying to register for the same notifications twice. * Not able to "Reload" extensions that were loaded with "Load Unpacked Extension". TBR=erikkay@chromium.org Review URL: http://codereview.chromium.org/178033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24882 0039d316-1c4b-4281-b951-d872f2087c98
* Updates to clean up default theme and add hover states.avi@chromium.org2009-08-3133-2846/+4688
| | | | | | | | | | | | Patch by Cole. BUG=http://crbug.com/18573;http://crbug.com/18574;http://crbug.com/18360;http://crbug.com/18438 TEST=none Review URL: http://codereview.chromium.org/165499 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24881 0039d316-1c4b-4281-b951-d872f2087c98
* Widen a couple suppressions, fix typo in last commit (need a precommit ↵dkegel@google.com2009-08-311-6/+3
| | | | | | | | | | filter for these!) BUG=17996,20320,20581,20659 Review URL: http://codereview.chromium.org/173626 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24879 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Migrate from CppBound class to devtools bound object.pfeldman@chromium.org2009-08-313-99/+74
| | | | | | Review URL: http://codereview.chromium.org/183014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24878 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a button to chrome://extensions/ that allows easy packingaa@chromium.org2009-08-318-7/+380
| | | | | | | | | | | of extensions into crx files. BUG=20578 TEST=Create a sample extension, pack it, then try to install it. Review URL: http://codereview.chromium.org/181020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24877 0039d316-1c4b-4281-b951-d872f2087c98
* Update temporary default extension icon to the Google Labsaa@chromium.org2009-08-312-1/+1
| | | | | | | | | 'beaker'. It isn't clear how LGPL applies to images, so to avoid hassle, replaced the old icon with something else. TBR=erikkay@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24876 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Get rid of the title-centering code in TabRendererGtk. DrawStringInt ↵jhawkins@chromium.org2009-08-312-16/+2
| | | | | | | | | | centers the text for us already. This change also removes a hack that modified the clipping rect unnecessarily. BUG=20401,20610 TEST=none Review URL: http://codereview.chromium.org/179037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24875 0039d316-1c4b-4281-b951-d872f2087c98
* Remove old, unfunctional crx packing script. These days, ↵thakis@chromium.org2009-08-311-172/+0
| | | | | | | | | | | http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/packaging.html is what should be used to pack extensions. BUG=none TEST=none Review URL: http://codereview.chromium.org/173624 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24873 0039d316-1c4b-4281-b951-d872f2087c98
* Widen two more suppressions, fix a broken suppressiondkegel@google.com2009-08-302-10/+56
| | | | | | | | | | | | checked in last time (and give it a different bug number), add one that got away BUG=11282,17966,20320,20653,20659 TEST=green valgrind bots Review URL: http://codereview.chromium.org/177034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24872 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-12 17:05:28 +0000