summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Mark or rebaseline layout tests that indeed pass due to file URL universal ↵jianli@chromium.org2009-09-1114-78/+58
| | | | | | | | | | | access change. BUG=21522 TEST=none Review URL: http://codereview.chromium.org/203039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26035 0039d316-1c4b-4281-b951-d872f2087c98
* Add a DEPS file for app/sql so checkdeps doesn't complain about the sqlitebrettw@chromium.org2009-09-111-0/+3
| | | | | | | | | | inclueds. TEST=run checkdeps (as on buildbot) BUG=none Review URL: http://codereview.chromium.org/201098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26033 0039d316-1c4b-4281-b951-d872f2087c98
* Changing the Chrome browser app name when CHROME_EXP_BUILD is defined. robertshield@chromium.org2009-09-111-1/+4
| | | | | | Review URL: http://codereview.chromium.org/201097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26032 0039d316-1c4b-4281-b951-d872f2087c98
* Reverts r26015. It caused a startup regression:(sky@chromium.org2009-09-119-173/+307
| | | | | | | | | | BUG=20823 TEST=none TBR=agl Review URL: http://codereview.chromium.org/203041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26030 0039d316-1c4b-4281-b951-d872f2087c98
* The shell dialog code explicitly disables the browser HWND before calling ↵jcampan@chromium.org2009-09-111-1/+42
| | | | | | | | | | | | | | the Windows API to select a file. When the dialog is closed, the browser HWND gets a WM_ACTIVATE but is still disabled, which messes up with the focus restoration. This patch ensures we restore the focus explicitly when the browser HWND is reenabled to work-around that issue. BUG=3380 TEST=Set the focus on a page with scroll-bars, right-click to do a 'save as'. Close the dialog. The arrow keys should let you scroll the page. Accelerators such as Ctrl-T should still work. Test 'open a file', 'print' and the font selection dialog (in the options). When closing the dialog the focus should return to the view that last had focus. Review URL: http://codereview.chromium.org/195065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26029 0039d316-1c4b-4281-b951-d872f2087c98
* Fix two issues with a downloaded file's extension:paul@chromium.org2009-09-112-5/+3
| | | | | | | | | | | | | | | | | | | 1. On Mac, we were prepending an extra '.' to the extension causing it to fail a comparison (resulting in second extension being added). 2. For downloads with the extension '.tgz' and mime type 'application/x-gzip', we were appending an extra '.gz' extension. The extension compare code is starting to get a little long, but I don't think it's too bad if there are only a few of these cases. BUG=21591,21595 TEST=1. Download a file on Mac with a well known extension type (mp3, gz) and notice that there are no double extensions. 2. Download a tgz file and notice that the file's extension is '.tgz', not '.tgz.gz'. Review URL: http://codereview.chromium.org/195064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26028 0039d316-1c4b-4281-b951-d872f2087c98
* Bump O3D DEPS revision to 147 to get Cg 2.2 (also gspencer's pdiff CL).tschmelcher@google.com2009-09-111-1/+1
| | | | | | Review URL: http://codereview.chromium.org/196093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26026 0039d316-1c4b-4281-b951-d872f2087c98
* Second part of the multi-toast experimentcpu@chromium.org2009-09-115-26/+40
| | | | | | | | | | | | | | | | There are 4 flavors of the toast, if the user qualfies use coin toss to show one of them. - Accordingly we have now four experiment sets: TAxx, TBxx, TCxx, TDxx. BUG=b/1484308 TEST= see bug for instructions Review URL: http://codereview.chromium.org/200092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26025 0039d316-1c4b-4281-b951-d872f2087c98
* Write layout test output to chunk dir to enable a purify dashboard to be ↵erikkay@chromium.org2009-09-112-7/+19
| | | | | | | | | | possible. (it can now see which tests were run each chunk) BUG=18475 Review URL: http://codereview.chromium.org/173595 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26024 0039d316-1c4b-4281-b951-d872f2087c98
* ExtensionApiTest.Tabs - disable failing asserts, add debug outputrafaelw@chromium.org2009-09-111-1/+7
| | | | | | | | BUG=20828 Review URL: http://codereview.chromium.org/196095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26023 0039d316-1c4b-4281-b951-d872f2087c98
* Add a new wrapper for sqlite. This is mostly a large cleanup of the existingbrettw@chromium.org2009-09-1114-135/+1740
| | | | | | | | | | | | | | | one, combined with the statement cache in a nice way. It is designed to entirely wrap sqlite so that we can catch corrupt errors in the future and "do something" when we get them without having to change all the calling code. There is also a new meta_table file which is almost exactly like the old one but which uses the new sql interface. This patch changes Chrome's history TextDatabase to use this new wrapper as a proof of concept, because this usage is relatively well-confined. Review URL: http://codereview.chromium.org/199047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26022 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compiler warnings in chrome\browser\sync.nick@chromium.org2009-09-1111-19/+22
| | | | | | | | | | | | | Warnings are treated as errors in the Chrome build. Most of these are just forcing the implicit conversion to maintain the previous behavior. TEST=sync unit tests BUG=none Review URL: http://codereview.chromium.org/193085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26020 0039d316-1c4b-4281-b951-d872f2087c98
* Undo change that crept into my last cl.estade@chromium.org2009-09-111-15/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26017 0039d316-1c4b-4281-b951-d872f2087c98
* Add "New Window" and "New Incognito Window" items to the Dock Menu.sgk@google.com2009-09-113-0/+54
| | | | | | | | | Add a unit test module for AppController with a simple DockMenu test. BUG=none TEST=none Review URL: http://codereview.chromium.org/199031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26016 0039d316-1c4b-4281-b951-d872f2087c98
* Nukes font_skia and converts font_gtk to use pango. This wassky@chromium.org2009-09-119-307/+173
| | | | | | | | | | | | | | | | | | | | | | necessitated by Pango and Skia differing on how the fonts are sized, resulting in lots of clipping in views. The only iffy part of this is I've made Font::nativeFont() win/mac only (it isn't used on Linux). I did this to avoid folks accidentally modifying the underlying font out from under Font. That said, I could certainly nuke GetPangoFontDescription in favor of nativeFont() and make it return the PangoFontDescription (not a copy). Let me know if you feel strongly about converting this. Assuming your ok with this, I'll watch the perf tests to make sure this doesn't impact startup. BUG=20823 TEST=none Review URL: http://codereview.chromium.org/195058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26015 0039d316-1c4b-4281-b951-d872f2087c98
* While importing favicon, make sure there is an entry in the history db.kuchhal@chromium.org2009-09-119-40/+130
| | | | | | | | | | This will match with what history db does for regular bookmarked URLs with favicons - when history db is cleaned, we keep an entry in the db with 0 visits as long as that url is bookmarked. BUG=13338 Review URL: http://codereview.chromium.org/193053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26014 0039d316-1c4b-4281-b951-d872f2087c98
* Linux focus ring color: Go through WebKit::WebColor api rather than through ↵estade@chromium.org2009-09-119-146/+112
| | | | | | | | | | | | the webview. Also use SkColor isntead of a triplet of colors in RenderPreferences. BUG=21521 Review URL: http://codereview.chromium.org/195059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26013 0039d316-1c4b-4281-b951-d872f2087c98
* Followup after http://codereview.chromium.org/201034 to correctly handle months.phajdan.jr@chromium.org2009-09-113-0/+16
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/199082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26012 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a crash in the plugin process specifically in the ↵ananta@chromium.org2009-09-118-4/+73
| | | | | | | | | | | | | | | | | | | | PluginStreamUrl::DidReceiveData function. This crash occurs if the PluginStreamUrl instance is deleted in the context of PluginStream::Write which occurs if the underlying NPP_Write call to the plugin returns a negative value, indicating that the plugin did not accept data. We close the stream in this case which releases existing references to the PluginStream which results in the object being deleted. Added a UI test for this case. Fixes bug http://code.google.com/p/chromium/issues/detail?id=19393 Bug=19393 Review URL: http://codereview.chromium.org/199093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26011 0039d316-1c4b-4281-b951-d872f2087c98
* Replace worker support in test shell with a dummy implementation.levin@chromium.org2009-09-1110-640/+37
| | | | | | | | | | | | | | | | | | The current implementation doesn't really work so no worker tests are run from test shell. The dummy implementation is only present to allow tests to pass that enumerate objects and their properties generically (without actually using the objects like fast/js/instanceof-operator.html). BUG=18676 TEST=layout tests fast/js/instanceof-operator.html Review URL: http://codereview.chromium.org/193082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26010 0039d316-1c4b-4281-b951-d872f2087c98
* Remove WebViewDelegate::SpellCheckerDocumentTag method and eliminatedarin@chromium.org2009-09-115-53/+43
| | | | | | | | | | | | synchronous IPCs to fetch a document tag on platforms other than Mac. R=pinkerton BUG=none TEST=none Review URL: http://codereview.chromium.org/201096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26009 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Don't show the GTK theme button on chromeos.erg@google.com2009-09-111-0/+2
| | | | | | Review URL: http://codereview.chromium.org/193088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26007 0039d316-1c4b-4281-b951-d872f2087c98
* Add button number to page action event reply object. Fix outdated page ↵mattm@chromium.org2009-09-117-10/+26
| | | | | | | | action docs. Review URL: http://codereview.chromium.org/194082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26006 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the target the bots used to use (but don't any more).thomasvl@chromium.org2009-09-111-12/+35
| | | | | | | | | | Add two targets for the chromium mac builders to build the subset their testers run for better cycle times. TEST=none BUG=none Review URL: http://codereview.chromium.org/195063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26005 0039d316-1c4b-4281-b951-d872f2087c98
* Increase number of tries in CheckInternetZoneIdentifier.phajdan.jr@chromium.org2009-09-111-1/+1
| | | | | | | | | | | | Hopefully this will be enough to kill flakiness. But I'm afraid it'll require some better solution in the end. TEST=ui_tests BUG=20809 Review URL: http://codereview.chromium.org/203033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26004 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Ship libCg on 32-bit Debian systems too, since nvidia-cg-toolkit ↵tschmelcher@google.com2009-09-113-2/+6
| | | | | | | | doesn't seem to like to use the latest version. Cg 2.2 fixes some Linux bugs, so it's worth ensuring that it's used on all systems. Review URL: http://codereview.chromium.org/194081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26003 0039d316-1c4b-4281-b951-d872f2087c98
* Update ExtensionApiTest.Tabs and re-enablerafaelw@chromium.org2009-09-114-125/+161
| | | | | | | | BUG=20828 Review URL: http://codereview.chromium.org/199091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26002 0039d316-1c4b-4281-b951-d872f2087c98
* Bug fix: produce unique temp file names when the VFS requests a handle to a ↵dumi@chromium.org2009-09-112-44/+62
| | | | | | | | | | | null file. BUG=none TEST=none Review URL: http://codereview.chromium.org/194021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26001 0039d316-1c4b-4281-b951-d872f2087c98
* Replace my e-mail with a new @chromium.org addresstimurrrr@chromium.org2009-09-111-1/+1
| | | | | | Review URL: http://codereview.chromium.org/202061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25999 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash in process infomhm@chromium.org2009-09-112-0/+5
| | | | | | | | | BUG=21561 TEST=Open task manager, it doesn't crash anymore. Review URL: http://codereview.chromium.org/196090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25998 0039d316-1c4b-4281-b951-d872f2087c98
* There was already release_extra_cflags for linux;dkegel@google.com2009-09-111-3/+15
| | | | | | | | | | | | | | this just generalizes it to debug_ and to mac. Required a litle rearranging. Tested by comparing xcode and make files before and after change. Ignores those settings when generating Visual C++ projects, but since the goal was to let valgrind bots tweak optimization settings, that's ok for now. Review URL: http://codereview.chromium.org/202054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25997 0039d316-1c4b-4281-b951-d872f2087c98
* Force page-action views to update after reloading an extension, by deletingpam@chromium.org2009-09-1113-13/+102
| | | | | | | | | | | | | | | them all. Otherwise, since the view count is unchanged, the views continue to use stale extension information and the page-action icon fails to be displayed. Fix excessive timeout logging in WaitForPageActionVisibilityChangeTo(). BUG=http://crbug.com/21324 TEST=write page-action extension, load as unpacked, reload, verify that icon is shown on a matching page. Also covered by browser_tests unit test. Review URL: http://codereview.chromium.org/202027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25996 0039d316-1c4b-4281-b951-d872f2087c98
* Add more suppressions for ThreadSanitizertimurrrr@chromium.org2009-09-111-1/+81
| | | | | | Review URL: http://codereview.chromium.org/199095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25995 0039d316-1c4b-4281-b951-d872f2087c98
* Add api tests for cross-origin XHR.aa@chromium.org2009-09-115-0/+75
| | | | | | Review URL: http://codereview.chromium.org/199092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25994 0039d316-1c4b-4281-b951-d872f2087c98
* Don't use --owner or --group in tar -c, these options are not present inmark@chromium.org2009-09-111-1/+1
| | | | | | | Mac OS X 10.6 ("Snow Leopard")'s tar. Review URL: http://codereview.chromium.org/194078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25993 0039d316-1c4b-4281-b951-d872f2087c98
* [Windows] Clear Browsing Data dialog should not have any button as defaultmark@chromium.org2009-09-112-0/+5
| | | | | | | | | | | | | | action. Also makes the behavior in Windows side act the same as in Linux/Mac. Patch by Thiago Farina <thiago.farina@gmail.com> BUG=21461 TEST=open "clear browsing data" and see if none of buttons are set as default. Code review URL: http://codereview.chromium.org/201080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25992 0039d316-1c4b-4281-b951-d872f2087c98
* Small fix from Glen for download progress image.mirandac@chromium.org2009-09-112-0/+0
| | | | | | | | | BUG= http://crbug.com/21170 TEST= Install a dark theme. Download something. Note that download progress bar is aesthetically pleasing. Review URL: http://codereview.chromium.org/201095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25991 0039d316-1c4b-4281-b951-d872f2087c98
* Removes deprecated version of PathIsWritable which is no longer called by ↵erikkay@chromium.org2009-09-112-5/+0
| | | | | | | | | | | | any function. BUG=None TEST=None Review URL: http://codereview.chromium.org/196038 Patch from thiago.farina@gmail.com. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25990 0039d316-1c4b-4281-b951-d872f2087c98
* Updated extension docs. Mainly to add i18n.html to navigation side bar,xji@chromium.org2009-09-1131-11/+82
| | | | | | | | | | | and updated i18n.html with overview and example. BUG=none TEST=none Review URL: http://codereview.chromium.org/199094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25989 0039d316-1c4b-4281-b951-d872f2087c98
* Since themes are designed with the custom frame in mind, we need to offsettony@chromium.org2009-09-111-1/+9
| | | | | | | | | | | | | | | | the background when the custom frame is off. This is needed after http://codereview.chromium.org/193030 was checked in (which fixed a related bug on Windows). We don't translate the x values because the tab renderer code already takes the x offset into consideration. TEST=Install the Color Chips theme from the theme gallery. The vertical white lines should line up on the inactive tabs. Review URL: http://codereview.chromium.org/194080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25988 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate some methods.darin@chromium.org2009-09-117-30/+18
| | | | | | | | | | | | | | | | Removes WebFrame::reportFindInPageSelection since it was only ever called by WebFrameImpl. Now it is a private method. Removes WebViewDelegate::DownloadUrl since it can be expressed using WebFrameClient::loadURLExternally. R=dglazkov BUG=none TEST=none Review URL: http://codereview.chromium.org/201092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25987 0039d316-1c4b-4281-b951-d872f2087c98
* Fix installer_util_string's expected output file to match whatsgk@chromium.org2009-09-111-1/+5
| | | | | | | | | create_string_rc.py actually creates. BUG=none TEST=none Review URL: http://codereview.chromium.org/203031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25986 0039d316-1c4b-4281-b951-d872f2087c98
* Support running tests under LayoutTests/http/tests/local as local file, in ↵jianli@chromium.org2009-09-1126-148/+69
| | | | | | | | | | | | | | | | order to mimic what run-webkit-tests does. Search "http/tests/local/" in http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/run-webkit-tests for what it does. This is needed by http/tests/local/resources/send-dragged-file.js. Turn on file URL universal access in the test_shell. Delete rebaseline results of those layout tests that pass due to this change. Also add a UI test to make sure it is not on for the browser. BUG=9275,12882 TEST=none Review URL: http://codereview.chromium.org/201048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25985 0039d316-1c4b-4281-b951-d872f2087c98
* sync-webkit-git: add more docs on a gclient tweakevan@chromium.org2009-09-111-1/+6
| | | | | | Review URL: http://codereview.chromium.org/203030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25983 0039d316-1c4b-4281-b951-d872f2087c98
* Removes a piece of comment that no longer applies.erikkay@chromium.org2009-09-111-4/+2
| | | | | | | Review URL: http://codereview.chromium.org/194036 Patch from thiago.farina@gmail.com. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25982 0039d316-1c4b-4281-b951-d872f2087c98
* Remove suppression for Mem leak with BrowserWindowCocoa::Show()nirnimesh@chromium.org2009-09-111-14/+0
| | | | | | | | | | | | The leak appears to been fixed. Cannot repro anymore. TEST=valgrind ui bot should not show this BUG=16628 Review URL: http://codereview.chromium.org/197058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25980 0039d316-1c4b-4281-b951-d872f2087c98
* Remove willchan from the watchlist for 'net'.wtc@chromium.org2009-09-111-1/+1
| | | | | | | | | TBR=willchan BUG=none TEST=none Review URL: http://codereview.chromium.org/199096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25979 0039d316-1c4b-4281-b951-d872f2087c98
* Expand tests to allow "." in keys.chase@chromium.org2009-09-111-1/+1
| | | | | | | | | | | | Expand the regex used to test keys so "." is an allowed character. Needed for perf ids like "mac-release-10.5". BUG=18597 TEST=a perf_expectations dict with keys containing "." passes presubmit tests Review URL: http://codereview.chromium.org/194084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25978 0039d316-1c4b-4281-b951-d872f2087c98
* svn:ignore both webkit\tools\test_shell\test_shell_pak.vcproj and ↵maruel@chromium.org2009-09-110-0/+0
| | | | | | | | | | | | chrome\interactive_ui_tests_dll.vcproj NO CODE CHANGE. BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25977 0039d316-1c4b-4281-b951-d872f2087c98
* add mole collapse/expand events. convert mappy to use this.erikkay@chromium.org2009-09-1110-3/+168
| | | | | | | | | BUG=15494 TEST=browser_tests.exe --gtest_filter=ExtensionApiTest.Toolstrip Review URL: http://codereview.chromium.org/203023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25976 0039d316-1c4b-4281-b951-d872f2087c98