summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* revert 35785. TBR=phajdan.jr@jochen@chromium.org2010-01-082-36/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35787 0039d316-1c4b-4281-b951-d872f2087c98
* Add DCHECK for error_string so future NULL pointers can be caughtjochen@chromium.org2010-01-081-0/+1
| | | | | | Review URL: http://codereview.chromium.org/523138 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35786 0039d316-1c4b-4281-b951-d872f2087c98
* Also match against the query string if present.jochen@chromium.org2010-01-082-3/+36
| | | | | | | BUG=none TEST=BlacklistTest.QueryStringMatch git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35785 0039d316-1c4b-4281-b951-d872f2087c98
* Marking ExtensionApiTest.Storage flaky only on Linux.tyoshino@google.com2010-01-081-0/+5
| | | | | | | | | | | | | | | | | | | | | | http://chrome-buildbot.corp.google.com:8010/builders/XP%20Tests%20(dbg)(4)/builds/2628/steps/browser_tests/logs/Storage http://chrome-buildbot.corp.google.com:8010/builders/XP%20Tests%20(dbg)(4)/builds/2604/steps/browser_tests/logs/Storage ExtensionApiTest.Storage: Got EXTENSION_LOADED notification. Got EXTENSION_HOST_DID_STOP_LOADING notification. C:\b\slave\chromium-dbg-builder\build\src\chrome\test\in_process_browser_test.cc(293): error: Test timed out. Each test runs for a max of 30000 ms (kInitialTimeoutInMS). C:\b\slave\chromium-dbg-builder\build\src\chrome\browser\extensions\extension_storage_apitest.cc(8): error: Value of: RunExtensionTest("storage") Actual: false Expected: true No response from message loop. BUG=22006 TBR=lzheng,japhet Review URL: http://codereview.chromium.org/525110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35784 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 293.0 to 294.0chrome-bot@google.com2010-01-081-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35783 0039d316-1c4b-4281-b951-d872f2087c98
* wine_valgrind: Fix typos, add a new suppression, remove suppression for a ↵thestig@chromium.org2010-01-081-13/+10
| | | | | | | | | | | fixed Wine bug. TBR=dank BUG=none TEST=none Review URL: http://codereview.chromium.org/524068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35781 0039d316-1c4b-4281-b951-d872f2087c98
* Marking LayoutTests/editing/inserting/12882.html falky. The image result ↵tyoshino@google.com2010-01-081-0/+3
| | | | | | | | | | | | | | | | mismatch is occurring sometimes. Flakiness dashboard http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/flakiness_dashboard.html#tests=LayoutTests/editing/inserting/12882.html BUG=31803 TBR=lzheng,japhet Review URL: http://codereview.chromium.org/517075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35779 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at landing this.ananta@chromium.org2010-01-0815-177/+365
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Deleting cookies by setting the expires attribute on them with an empty value would not work in ChromeFrame with the host network stack enabled. When we receive a response in the host browser (IE) we send over the response headers which include the Set-Cookie header and a list of cookies retreived via the InternetGetCookie API. We call this API to retrieve the persistent cookies and send them over to Chrome. However this API returns session cookies as well as persistent cookies. There is no documented way to return only persistent cookies from IE. As a result we would end up setting duplicate cookies in Chrome, which caused this issu.e. To workaround this issue when we receive the response in the url request automation job which handles ChromeFrame network requests, we strip out duplicate cookies sent via InternetGetCookie. When a script deletes a cookie we now handle it correctly in IE and set the data to an empty string. However this does not delete the cookie. When such cookies show up in Chrome, we strip them out as well. Fixes bug http://code.google.com/p/chromium/issues/detail?id=30786 The changes to chrome_frame_npapi.cc/.h are to move the NPAPI functions to the chrome_frame namespace as they conflict with similar functions in NACL. Added the DeleteCookie function to the CookieStore interface, which I think missed out by oversight. Bug=30786 Test=Covered by ChromeFrame unit tests. I also added a unit test to test the newly added URLRequestAutomationJob::IsCookiePresentInCookieHeader function TBR=amit Review URL: http://codereview.chromium.org/521072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35778 0039d316-1c4b-4281-b951-d872f2087c98
* Marking WorkerTest.LimitTotal disabled.tyoshino@google.com2010-01-081-1/+1
| | | | | | | | | | | | | Already fixing work is started for this issue, but since the test hangs the builder too frequently, I'd like to disable this test until it becomes stable. BUG=30307 TBR=lzheng,japhet Review URL: http://codereview.chromium.org/523160 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35777 0039d316-1c4b-4281-b951-d872f2087c98
* Move code duplicated in two tests up into the TestingProfile.rsesek@chromium.org2010-01-084-92/+94
| | | | | | | | | | | | | | | | Move TestURLRequestContextGetter and friends from CookieTreeModelTest and CookiesWindowControllerTest into TestingProfile. In the TestingProfile, return a valid CookieMonster and URLRequstContextGetter, if CreateRequestContext() is called. Original CL: http://codereview.chromium.org/525072/show BUG=None TEST=Covered by unit tests Review URL: http://codereview.chromium.org/525106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35776 0039d316-1c4b-4281-b951-d872f2087c98
* Marking LayoutTests/http/tests/appcache/offline-access.html CRASH.tyoshino@google.com2010-01-081-1/+1
| | | | | | | | | | | | | | Initially, this test was marked CRASH on WebKit rollout. And, in this revision, CRASH has been removed, but still crashing. http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/test_expectations.txt?view=diff&r1=35406&r2=35407 BUG=31302 TBR=lzheng,japhet Review URL: http://codereview.chromium.org/517074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35775 0039d316-1c4b-4281-b951-d872f2087c98
* Marking LayoutTests/storage/domstorage/localstorage/enumerate-storage.html ↵tyoshino@google.com2010-01-081-1/+4
| | | | | | | | | | | | | | flaky crashing. Flakiness dashboard http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/flakiness_dashboard.html#tests=LayoutTests/storage/domstorage/localstorage/enumerate-storage.html BUG=31794 TBR=lzheng,japhet Review URL: http://codereview.chromium.org/525108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35774 0039d316-1c4b-4281-b951-d872f2087c98
* Fix our version of eventSender to handle keyLocation arg correctly.kinuko@chromium.org2010-01-082-3/+17
| | | | | | | | | BUG=31360 TEST=LayoutTests/fast/events/keydown-numpad-keys.html Review URL: http://codereview.chromium.org/518036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35773 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a NetworkChangeNotifier dependency to ProxyService; when we observer a ↵eroman@chromium.org2010-01-086-54/+196
| | | | | | | | | | | | | | | network change through the notifier, the ProxyService re-configures itself. So for example, if you were to switch to VPN and are using a custom PAC URL, we will re-download that URL on the new network. Similarly if you are using auto-detect PAC settings, we will re-run the autodiscovery steps for the next resolve. Note that Chromium is still passing a NULL NetworkChangeNotifier dependency into its ProxyService -- until it passes a real implementation, this will not impact Chrome. BUG=12293 TEST=ProxyServiceTest.NetworkChangeTriggersPacRefetch Review URL: http://codereview.chromium.org/525104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35772 0039d316-1c4b-4281-b951-d872f2087c98
* Reason:tyoshino@chromium.org2010-01-0814-360/+177
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Linux Builder (ChromiumOS) failed. http://chrome-buildbot.corp.google.com:8010/builders/Linux%20Builder%20(ChromiumOS)/builds/2050/steps/compile/logs/stdio Please add changes to external_cookie_handler_unittest.cc no to break compilation and reland? ---- Revert 35769 - Deleting cookies by setting the expires attribute on them with an empty value would not work in ChromeFrame with the host network stack enabled. When we receive a response in the host browser (IE) we send over the response headers which include the SetCookie header and a list of cookies retreived via the InternetGetCookie API. We call this API to retrieve the persistent cookies and send them over to Chrome. However this API returns session cookies as well as persistent cookies. There is no documented way to return only persistent cookies from IE. As a result we would end up setting duplicate cookies in Chrome, which caused this issu.e. To workaround this issue when we receive the response in the url request automation job which handles ChromeFrame network requests, we strip out duplicate cookies sent via InternetGetCookie. When a script deletes a cookie we now handle it correctly in IE and set the data to an empty string. However this does not delete the cookie. When such cookies show up in Chrome, we strip them out as well. Fixes bug http://code.google.com/p/chromium/issues/detail?id=30786 The changes to chrome_frame_npapi.cc/.h are to move the NPAPI functions to the chrome_frame namespace as they conflict with similar functions in NACL. Added the DeleteCookie function to the CookieStore interface, which I think missed out by oversight. Bug=30786 Test=Covered by ChromeFrame unit tests. I also added a unit test to test the newly added URLRequestAutomationJob::IsCookiePresentInCookieHeader function Review URL: http://codereview.chromium.org/518054 TBR=ananta@chromium.org Review URL: http://codereview.chromium.org/517070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35771 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug of unnecessary "Confirm form resubmission" dialog.tkent@chromium.org2010-01-082-0/+58
| | | | | | | | | | | | | | | If a URL is requested by the POST method and then the page is redirected to another URL, NavigationEntry::has_post_data_ is not cleared correctly with the prior code. So "Confirm form resubmission" dialog is shown when a user asks reloading the redirected page. TEST=Add a unit test BUG=21245 Review URL: http://codereview.chromium.org/524057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35770 0039d316-1c4b-4281-b951-d872f2087c98
* Deleting cookies by setting the expires attribute on them with an empty ↵ananta@chromium.org2010-01-0814-177/+360
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | value would not work in ChromeFrame with the host network stack enabled. When we receive a response in the host browser (IE) we send over the response headers which include the Set-Cookie header and a list of cookies retreived via the InternetGetCookie API. We call this API to retrieve the persistent cookies and send them over to Chrome. However this API returns session cookies as well as persistent cookies. There is no documented way to return only persistent cookies from IE. As a result we would end up setting duplicate cookies in Chrome, which caused this issu.e. To workaround this issue when we receive the response in the url request automation job which handles ChromeFrame network requests, we strip out duplicate cookies sent via InternetGetCookie. When a script deletes a cookie we now handle it correctly in IE and set the data to an empty string. However this does not delete the cookie. When such cookies show up in Chrome, we strip them out as well. Fixes bug http://code.google.com/p/chromium/issues/detail?id=30786 The changes to chrome_frame_npapi.cc/.h are to move the NPAPI functions to the chrome_frame namespace as they conflict with similar functions in NACL. Added the DeleteCookie function to the CookieStore interface, which I think missed out by oversight. Bug=30786 Test=Covered by ChromeFrame unit tests. I also added a unit test to test the newly added URLRequestAutomationJob::IsCookiePresentInCookieHeader function Review URL: http://codereview.chromium.org/518054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35769 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Reverting workaround for focus issue in WidgetGtk."oshima@chromium.org2010-01-081-2/+6
| | | | | | | | | | | | | | Spoke too soon. It's still crashing. This reverts commit 005f42a518774136337cd4be88431f21c50aba68. BUG=chromium-os:1010 TEST=None TBR=sky@chromium.org Review URL: http://codereview.chromium.org/518077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35768 0039d316-1c4b-4281-b951-d872f2087c98
* Remove most uses of EmptyString(), EmptyWString(), EmptyString16(), and ↵pkasting@chromium.org2010-01-0840-158/+154
| | | | | | | | | | EmptyGURL(), since the code in question can just use the default constructor. BUG=none TEST=none Review URL: http://codereview.chromium.org/517054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35766 0039d316-1c4b-4281-b951-d872f2087c98
* Finish removing query_helpers.*zork@google.com2010-01-087-1009/+26
| | | | | | | | | BUG=none TEST=Run sync_unit_tests Review URL: http://codereview.chromium.org/526002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35765 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: implement setting cursor typetschmelcher@chromium.org2010-01-083-11/+83
| | | | | | Review URL: http://codereview.chromium.org/527024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35764 0039d316-1c4b-4281-b951-d872f2087c98
* We should not return the raw Google Update branch code if we fail to ↵finnur@chromium.org2010-01-085-51/+36
| | | | | | | | | | | | determine what branch we are on. We should just assume stable. We should also not add the branch code information to the version string, since it needs to be parsable by Version object. If we append the raw branch code, it might contain dots, which confuses the parsing done by the Version object. BUG=31772 TEST=Change your branch code to something like 3.0-dev or 2.0-dev-somerandomstring. Chrome should not crash when you open the About box. Review URL: http://codereview.chromium.org/523151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35763 0039d316-1c4b-4281-b951-d872f2087c98
* Http cache: Avoid resuming (and keeping) truncated entriesrvargas@google.com2010-01-086-17/+264
| | | | | | | | | | | | | | | | | | if the server doesn't provide a strong validator. We require: - A strong etag or a strong last modified date. - The total Content length. - Lack of an explicit rejection of ranges (Accept-ranges: none) This aligns better with the conditions used by Firefox. BUG=30220, b/2329250 TEST=unittests Review URL: http://codereview.chromium.org/517043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35761 0039d316-1c4b-4281-b951-d872f2087c98
* Shard WorkerFastLayoutTests to avoid Flakiness.ajwong@chromium.org2010-01-081-54/+76
| | | | | | | | This should make it run on reliability on Valgrind UI test bots where the previous grouping was running near the max timeout per test. Review URL: http://codereview.chromium.org/521049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35760 0039d316-1c4b-4281-b951-d872f2087c98
* linux: make the seccomp sandbox work againevan@chromium.org2010-01-081-12/+54
| | | | | | | | | | | | | | | | | We were hitting a stack overflow on renderer startup, because of the following: When we patch out syscalls, we need a scratch space near (within a 32-bit jump) of the original code. We pick the scratch space as the end of the nearest empty region available before the code we're patching. For the vdso region, the stack lies directly before it and so the region we'd grab was directly before the stack. This meant that as soon as the stack attempted to grow it'd fail because it ran into our patch region, and we'd hit a stack overflow. The fix is to specially note when we're near the stack region, and instead put our scratch space as far away from the stack as possible. Review URL: http://codereview.chromium.org/518071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35759 0039d316-1c4b-4281-b951-d872f2087c98
* Added an application framework for demos. This framework currently only ↵alokp@chromium.org2010-01-084-0/+275
| | | | | | | | | supports stand-alone apps. It will be extended to support trusted pepper and untrusted nacl apps. BUG=26099 Review URL: http://codereview.chromium.org/525083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35758 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid accepting suspiciously long URLs from the renderer. These can take downcevans@chromium.org2010-01-083-2/+8
| | | | | | | | | | | the browser with OOM. BUG=20233 TEST=NONE Review URL: http://codereview.chromium.org/523088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35757 0039d316-1c4b-4281-b951-d872f2087c98
* New baselines for WebKit Update 52943:52952.dglazkov@chromium.org2010-01-0718-39/+23
| | | | | | | | | | | | These are all due to http://trac.webkit.org/changeset/52947. TBR=japhet TEST=none BUG=none Review URL: http://codereview.chromium.org/525103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35756 0039d316-1c4b-4281-b951-d872f2087c98
* Add/update baselines from previous WebKit updates.dglazkov@chromium.org2010-01-0718-11/+45
| | | | | | | | | | TBR=japhet TEST=none BUG=none Review URL: http://codereview.chromium.org/523152 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35755 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit Update 52943:52952.dglazkov@chromium.org2010-01-072-5/+18
| | | | | | | | | | | | http://trac.webkit.org/changeset/52947 created some redness, but all are rebaselines. TBR=johnnyg BUG=none TEST=none Review URL: http://codereview.chromium.org/523150 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35754 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 35735 - Relanding the language detection code.jcampan@chromium.org2010-01-0724-473/+129
| | | | | | | | | | | | | | | | | | | | | | | | | Still causes redness on the reliability bot. The code would crash if multiple PageContents notifications were received rapidly. The CLDHelper now notifies the TabContents directly and the TabContents ensures only one language detection can be performed at a time. Added unittests to validate these cases in web_contents_unittest.cc. Note that patch set 1 is the original patch, patch set 2 contains the new changes. Original review: http://codereview.chromium.org/492024/show BUG=30662 TEST=Run the unittests. Review URL: http://codereview.chromium.org/504051 TBR=jcampan@chromium.org Review URL: http://codereview.chromium.org/523149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35753 0039d316-1c4b-4281-b951-d872f2087c98
* Raise the window when showing the widget.oshima@chromium.org2010-01-071-1/+4
| | | | | | | | | | | | FindBar is behind other gdk window (i believe the tab content) when re-showing and is not visible. This fixed the issue. BUG=31735 TEST=None Review URL: http://codereview.chromium.org/519082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35752 0039d316-1c4b-4281-b951-d872f2087c98
* Implement AutoFillProfile, a collection of form groups that stores profile ↵jhawkins@chromium.org2010-01-0713-13/+222
| | | | | | | | | | information. BUG=none TEST=none Review URL: http://codereview.chromium.org/517066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35751 0039d316-1c4b-4281-b951-d872f2087c98
* New baselines for WebKit Roll 52899:52930.dglazkov@chromium.org2010-01-0791-57/+218
| | | | | | | | | | | | All caused due to http://trac.webkit.org/changeset/52904. TBR=japhet TEST=none BUG=none Review URL: http://codereview.chromium.org/523144 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35750 0039d316-1c4b-4281-b951-d872f2087c98
* Log the results of proxy resolution to LoadLog when "full logging mode" is ↵eroman@chromium.org2010-01-076-17/+52
| | | | | | | | | | | | | | enabled. Examples of what the logged text looks like: "Resolved proxy list: PROXY foobar:6233" "Resolved proxy list: DIRECT" "Resolved proxy list: PROXY foobar:80;SOCKS5 baz:1080;DIRECT" Review URL: http://codereview.chromium.org/518042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35749 0039d316-1c4b-4281-b951-d872f2087c98
* wine_valgrind: Disable a couple tests that use leaky FF2 dlls without symbols.thestig@chromium.org2010-01-071-0/+2
| | | | | | | | | TBR=dank BUG=none TEST=none Review URL: http://codereview.chromium.org/521065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35748 0039d316-1c4b-4281-b951-d872f2087c98
* Cancel any outstanding host resolve when calling ↵eroman@chromium.org2010-01-075-11/+113
| | | | | | | | | | | SOCKSClientSocket::Disconnect(). BUG=25440 TEST=SOCKSClientSocketTest.DisconnectWhileHostResolveInProgress Review URL: http://codereview.chromium.org/525084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35747 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes possible crash in menus on views/gtk. The crash would happen ifsky@chromium.org2010-01-072-5/+21
| | | | | | | | | | | | | | | between the time we called into the model when the user selected an item and the time MessageLoop::Quit is processed the menu was destroyed, we would crash. As MessageLoop::Quit isn't immediate, and we really don't want to call out from a nested message loop, we wait until the quit is processed, then notify the model. CROS_BUG=1108 TEST=see bug Review URL: http://codereview.chromium.org/521063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35746 0039d316-1c4b-4281-b951-d872f2087c98
* Reverts change to native_view_host_gtk. This fixes the bug, but isn'tsky@chromium.org2010-01-071-2/+0
| | | | | | | | | | | | the right fix. Current code is correct. BUG=31132 TEST=none TBR=oshima Review URL: http://codereview.chromium.org/523141 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35745 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit Update 52930:52943.dglazkov@chromium.org2010-01-072-2/+5
| | | | | | | | | | TBR=japhet TEST=none BUG=none Review URL: http://codereview.chromium.org/525101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35744 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 35737 (Chrome OS failing) - Include more extension browser tests on ↵kkania@chromium.org2010-01-0711-225/+106
| | | | | | | | | | | | | mac and linux. Some minor changes and reorganization. BUG=none TEST=none Review URL: http://codereview.chromium.org/504064 TBR=kkania@chromium.org Review URL: http://codereview.chromium.org/518068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35743 0039d316-1c4b-4281-b951-d872f2087c98
* Fix up expectations yet again. Apparently rebaselining tool mis-fired. Or I ↵dglazkov@chromium.org2010-01-071-0/+2
| | | | | | | | | | | | mis-fired. One of those. TBR=japhet TEST=none BUG=none Review URL: http://codereview.chromium.org/525100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35742 0039d316-1c4b-4281-b951-d872f2087c98
* Submitting Arne's fix (http://codereview.chromium.org/521062).kathyw@google.com2010-01-072-2/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/521064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35741 0039d316-1c4b-4281-b951-d872f2087c98
* Certain PDF files would not load in Chrome if the HTTP multipart response ↵ananta@chromium.org2010-01-072-14/+46
| | | | | | | | | | | | | | | | | | | contains the Range header instead of the Content-Range header. This would cause the Acrobat PDF plugin to freeze or display an error message. Fix is to look for the Range header while parsing the multipart response if we fail to find the Content-Range header. This fixes bug http://code.google.com/p/chromium/issues/detail?id=31050 Bug=31050 Test=Covered by test_shell_tests. Review URL: http://codereview.chromium.org/521048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35740 0039d316-1c4b-4281-b951-d872f2087c98
* Histograms sent out to Chrome need to have the kIPCSerializationSourceFlag ↵ananta@chromium.org2010-01-071-0/+1
| | | | | | | | | | flag set. Not having this flag causes a DCHECK to fire. Review URL: http://codereview.chromium.org/519077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35739 0039d316-1c4b-4281-b951-d872f2087c98
* Add new baselines for WebKit Update 52852:52867.dglazkov@chromium.org2010-01-0758-152/+132
| | | | | | | | | | TBR=japhet TEST=none BUG=none Review URL: http://codereview.chromium.org/518066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35738 0039d316-1c4b-4281-b951-d872f2087c98
* Include more extension browser tests on mac and linux. Some minor changes ↵kkania@chromium.org2010-01-0711-106/+225
| | | | | | | | | | and reorganization. BUG=none TEST=none Review URL: http://codereview.chromium.org/504064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35737 0039d316-1c4b-4281-b951-d872f2087c98
* Flip expectation of failure from LINUX to MAC. My bad.dglazkov@chromium.org2010-01-071-1/+1
| | | | | | | | | | TBR=japhet BUG=none TEST=none Review URL: http://codereview.chromium.org/523136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35736 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding the language detection code.jcampan@chromium.org2010-01-0724-129/+473
| | | | | | | | | | | | | | | | | | | | The code would crash if multiple PageContents notifications were received rapidly. The CLDHelper now notifies the TabContents directly and the TabContents ensures only one language detection can be performed at a time. Added unit-tests to validate these cases in web_contents_unittest.cc. Note that patch set 1 is the original patch, patch set 2 contains the new changes. Original review: http://codereview.chromium.org/492024/show BUG=30662 TEST=Run the unit-tests. Review URL: http://codereview.chromium.org/504051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35735 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to fix crash in issue 31082xiyuan@chromium.org2010-01-071-0/+4
| | | | | | | | | | | | | Crash in issue 31082 is inside Windows ICM (Image Color Management) code. I suspect it is caused by invalid bV5Intent value in the BITMAPV5HEADER we passed in. BUG=31082 TEST=Crashes in issue 31082 should be gone. Review URL: http://codereview.chromium.org/519081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35734 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 11:43:05 +0000