| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
non-POD structs.
Cuts ~2MB off our .a files (Debug, Linux). Also added the "virtual" keyword on
a whole bunch of virtual dtors that were missing it.
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/3522004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=ran ui_tests
Review URL: http://codereview.chromium.org/3608002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61099 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=57375
Review URL: http://codereview.chromium.org/3518006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61097 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
the plugins on the UI/IO thread. Add a way for PluginList to indirectly ensure it doesn't load the plugins on the wrong thread.
BUG=57425
Review URL: http://codereview.chromium.org/3599004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This implements http://folder/glen/chrome/spec/101_ntp/8_wish&sidebar mocks 2, 5, 6
It's a bit lame to use a bit in the "sections" bitmask to serialize the "should show?" information, but the damage here was done when someone decided to that "THUBMS bit missing" should mean "show a list instead" (instead of adding another bit for that).
BUG=55148
TEST=Hover "Most Visited" bar. Close button should appear. Clicking it should hide "Most Visited" area and add a button at the window edge. That button should have a menu that makes it possible to make the "Most Visited" area visible again. Also do this while multiple NTPs are open; the changes made in the front NTP should be synced to the background NTPs.
Review URL: http://codereview.chromium.org/3455007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=morrita
BUG=None
TEST=Non
Review URL: http://codereview.chromium.org/3578005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Most changes are to avoid false positives. There's a
small regression somewhere in the intl page cyclers
which I filed a bug on.
- linux-release-hardy/dhtml/times/t
- mac-release-10.6/intl1/times/t
- mac-release-10.6/intl2/times/t
- vista-release-dual-core/intl1/times/t
- xp-release-dual-core/intl1/times/t
- xp-release-dual-core/intl2/times/t
- xp-release-dual-core/morejs/times/t
- xp-release-dual-core/startup/warm/t
BUG=57447
TEST=perf steps are green
TBR=nsylvain@chromium.org
Review URL: http://codereview.chromium.org/3572005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
platforms.
Remove broken template specializations that were never instantiated that
references extern code that doesn't exist in the project (!).
BUG=none
TEST=compiles, smaller binaries on linux, chromeos and mac
Review URL: http://codereview.chromium.org/3594003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61092 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
that allows this test to wait until both events have occurred, irrespective of their relative ordering.
BUG=None
TEST=chrome_frame_tests --gtest_filter=DeleteBrowsingHistoryTest.*
Review URL: http://codereview.chromium.org/3609001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61091 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Windows screenreaders.
BUG=none
TEST=manual testing with and without JAWS and NVDA screenreaders.
Review URL: http://codereview.chromium.org/3598003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61090 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The important part is that it comes after the EXTENSION_UNLOADED
notification is sent. This makes it easier on the listeners, as they
can assume that extension notifications other than EXTENSION_UNINSTALLED
are sent for currently-installed extensions.
BUG=54415
TEST=BackgroundModeManagerTest
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60834
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60848
Review URL: http://codereview.chromium.org/3461025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
controlled by the browser.
BUG=53616
TEST=none
Review URL: http://codereview.chromium.org/3534003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61086 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
eliminates two coverity issues.
CID=12683,12686
BUG=none
TEST=Test 'under the hood' panel displays correctly when extension controls proxy prefs.
Review URL: http://codereview.chromium.org/3535001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes a problem with password autocomplete where the popup was not being dismissed in cases where the value of the text field was non-empty but no longer matching a saved name/password combination. This change detects this case and dismisses the popup.
BUG=57213
TEST=Manual test as per bug.
Review URL: http://codereview.chromium.org/3551008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61081 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61080 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=54332
TBR=sky
TBR=erikkay@chromium.org
Review URL: http://codereview.chromium.org/3590008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61079 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:7160
TEST=Verify fix for chromium-os:7160
Review URL: http://codereview.chromium.org/3575004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=52430,52916
TEST=Enable Page Info Bubble in about:labs and click on the lock icon.
Review URL: http://codereview.chromium.org/3461016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
principally being added for debugging purposes; compositor support is
being added simultaneously to DumpRenderTree in
https://bugs.webkit.org/show_bug.cgi?id=46849 . The changes here are
dependent on the WebKit changes.
Tested in test_shell on Linux both with the default Mesa backend as
well as with --use-gl=desktop and verified that CSS 3D samples work.
BUG=51879
TEST=none
Review URL: http://codereview.chromium.org/3529003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Map it to .sh, also mark it as executable. Either one of these fixes alone would take care of this bug, but 2 fixes are better than 1!
BUG=56855
TEST=manual (see bug)
Review URL: http://codereview.chromium.org/3557003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=54332
TBR=sky
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
headers. This is where we used to call GetSSLInfo. In
r56646 (Chrome 7.0) we changed to call GetSSLInfo as soon
as SSL Connect completes. This will be problematic when
we do "pseudo connect" with SSL Snap Start.
Allow HttpStreamParser::GetSSLInfo and
HttpStreamParser::GetSSLCertRequestInfo to be called when
connection_->socket() is not connected.
R=agl,mbelshe
BUG=none
TEST=net_unittests --gtest_filter=HTTPSRequestTest.HTTPS*Test.
For manual testing, verify the info in the Page Security
Information dialog is correct.
Review URL: http://codereview.chromium.org/3603002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change doesn't make us *use* the local copy yet, that's the next
step. The checked in code is taken from the same SVN revision which we
currently pull with DEPS.
(This is a no-op change from the point of view of the build.)
BUG=56579
TEST=none
http://codereview.chromium.org/3549005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61072 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(This also removes support for DNSSEC lookups. This is a temporary measure
while I work on refactoring it.)
BUG=none
TEST=net_unittests
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We still append extensions to extensionless downloads, and do some extension rewriting around dangerous extensions, but don't try to be smart about renaming, e.g., .txt to .zip
BUG=57080
TEST=download_util_unittest
Review URL: http://codereview.chromium.org/3453027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tab.
Added two new filter types: "type" and "id". "Type"
specifies source type, and "id" specifies source ID.
Both only allow exact matches, and multiple values of both
can be specified ("id:5 id:6" will match source IDs 5 and
6).
Added links to the #dns/#sockets tabs to link to filters to
display all outstanding DNS requests/live sockets. The
idle and connecting socket counts also now link to source
id filters, using ids which are now passed to Javascript
along with the rest of the socket pool information.
As socket pools do not seem to maintain a list of active
sockets, the same is not yet done for active
sockets.
Also fixes a bug that resulted in handed out/connecting
socket counts being reversed in the primary socket pool
table.
BUG=56437
TEST=manual
Review URL: http://codereview.chromium.org/3436033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The goal of the test is to verify that the HighResNow() clock has faster
than 15ms precision. Modify the test to not depend on how long Sleep()
takes in order to verify this.
BUG=50291
TEST=TimeTicks.HighResNow
Review URL: http://codereview.chromium.org/3452018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes Guest mode for test images.
BUG=chromium-os:6626
TEST=On test image "Skip sign-in ang go incognito" opens proper Guest mode.
Review URL: http://codereview.chromium.org/3525007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=57378
TEST=none
TBR=skerner@chromium.org
Review URL: http://codereview.chromium.org/3541006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
privilege increase checks, unique ignoring the RCD, so example.com + example.co.uk is treated as a single host. If an extension adds more international versions to its permission list it's not treated as a privilege increase. When the extension is installed initially, a smaller list of hostnames can be showed even if it's matching a large list of international domain variants.
BUG=57042
TEST=ExtensionTest.IsPrivilegeIncrease,ExtensionTest.GetDistinctHosts
Review URL: http://codereview.chromium.org/3598001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Landing on behalf of fenix@google.com (Roberto Peon)
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3583004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SpdySessionPool.
BUG=57343
TEST=none
Review URL: http://codereview.chromium.org/3602001
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/3541005
TBR=willchan@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
events.
BUG=none
TEST=Added new unittest: WizardAccessibilityHandlerTest
Review URL: http://codereview.chromium.org/3223011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
http_util.cc (NameValuePairsIterator). In preparation for re-use of name-value pair parsing in ChromeFrame (for X-UA-Compatible header).
BUG=None
TEST=net_unittests (HttpAuth* and HttpUtilTest.NameValuePairs*)
Review URL: http://codereview.chromium.org/3525004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=greener tree
TBR=sky
Review URL: http://codereview.chromium.org/3608001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=danno
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=47731
TEST=Disabling outdated plugins should show up in about:labs
Review URL: http://codereview.chromium.org/3386033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61055 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crosbug.com/3062
TEST=Manual
Review URL: http://codereview.chromium.org/3492014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61054 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
iterations. Otherwise the test may time out due to slowdown.
TBR=akalin
Review URL: http://codereview.chromium.org/3578004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61053 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=56547
TEST=net_unittests
Review URL: http://codereview.chromium.org/3448029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This change just deletes all the resources used in the test explicitly. (As far as I have tested on try bots, it seems to fix the leaks.)
BUG=57387
TEST=make the "Linux Tests (valgrind)(1)" bot green.
Review URL: http://codereview.chromium.org/3560002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61051 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Assigns delegate member of the background to NULL when the owner is
changed.
BUG=chromium-os:6679
TEST=none
Review URL: http://codereview.chromium.org/3569006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61048 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Debug builds).
BUG=N/A
TEST=Manual. No crash should happen in Debug build.
Review URL: http://codereview.chromium.org/3546002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to avoid forever connecting to netowrk
BUG=http://code.google.com/p/chromium-os/issues/detail?id=7167
TEST=browser_tests --gtest_filter=NetworkScreenTest.*
Review URL: http://codereview.chromium.org/3571004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61045 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=49539
TEST=CollectedCookiesTest.*
Review URL: http://codereview.chromium.org/3584001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=hclam
Review URL: http://codereview.chromium.org/3591004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61043 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=54435
TEST=open the url javascript:window.open('http://www.google.com/', '', 'foobar'); (this should open a popup), click on the omnibox to set focus to it, and press Alt-F4. The popup should close.
Review URL: http://codereview.chromium.org/3345015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=levin
BUG=57405
TEST=none
Review URL: http://codereview.chromium.org/3581004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is needed to write a fix for the bug below.
BUG=56734
TEST=changing tests, and only tests (net_unittests)
Review URL: http://codereview.chromium.org/3412039
TBR=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/3537007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61040 0039d316-1c4b-4281-b951-d872f2087c98
|