| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
to the ignored list. Here's what I believe is happening:
// This test has hover effects that change the font size. This test also
// moves the mouse around, resulting in a layout that dances around.
// Depending upon when the snapshot is taken we get different results.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/19681
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
about issues I discovered in this process.
Review URL: http://codereview.chromium.org/19677
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19673
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
it fails because of font size differences.
Review URL: http://codereview.chromium.org/19478
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
chrome_dll (we use the methods in renderer_glue.cc instead).
Review URL: http://codereview.chromium.org/19678
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the UI, just had to manually edit the file.
Review URL: http://codereview.chromium.org/19480
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
also removed support for window frame sizes with unequal widths vs. heights; Windows' UI doesn't actually let you do this and it was making the code more complex than it needed to be.
Review URL: http://codereview.chromium.org/19477
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8916 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MessageLoop. I'm going to need this when running ui tests in
process. In this case I'll pass in the IO thread.
I'll change all callers to use the new method, but before doing that
wanted to make sure you're ok with it.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/19039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
pointer. Based on the crash dump, the crash occurs in the windows message filter hook, used for tracking whether the plugin enters a modal loop. The global plugin instance pointer gets reset to NULL in the windowed plugin wndproc and HandleEvent. If these events occur in nested order, then it is quite possible for the plugin instance pointer to get set to NULL incorrectly.
Added a check for whether this pointer is NULL in the message filter hook along with a NOTREACHED statement.
We maintain a local global stack to ensure that the plugin instance pointer gets set/reset correctly.
The bug is http://code.google.com/p/chromium/issues/detail?id=6703
The other issue being fixed is to set the modal_loop_pump_messages_event coming in from the plugin
in WebPluginDelegateProxy correctly. This caused the plugin to not receive events when it enters a modal loop like a context menu.
Bug=6703
Review URL: http://codereview.chromium.org/19444
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Turns out we need to broadcast the NOTIFY_USER_SCRIPTS_LOADED message even if
there are no scripts. I just removed the DCHECK that expects scripts.
Review URL: http://codereview.chromium.org/19475
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
get loaded correctly.
Review URL: http://codereview.chromium.org/19676
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19675
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
webkit into unit_tests.
There was also a problem with simple_clipboard_impl.cc which should only be
compiled into test_shell.
I can't remove mock_webkit_glue.cc until I verify that the mac build doesn't
need it anymore.
Review URL: http://codereview.chromium.org/19474
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8910 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
this file, but WebCore includes it, and so we can avoid some WebCore
forking by implementing npruntime_impl.h appropriately.
R=dglazkov
Review URL: http://codereview.chromium.org/19472
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19473
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19674
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=maruel
Review URL: http://codereview.chromium.org/19641
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19669
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
chrome/installer/util/version.*. This version has more flexible parsing rules and is more robust to detecting bogus versions, supporting arbitrary numbers of version components rather than just dotted quads. It's possible that we should switch chrome installer to use this version.
Review URL: http://codereview.chromium.org/19667
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
already).
Review URL: http://codereview.chromium.org/19653
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19471
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19672
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19671
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18175
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
code that runs it.
Review URL: http://codereview.chromium.org/19666
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8895 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
implementation more flexible, and prevents the use of templates by the client.
Now, the filters themselves simply expose a static FilterFactory() method that returns a new factory object. The constructor and destructor of the class
should be private and the FilterFactory object shuold be declarded as a friend. There is still a template factory, but the class uses this template class
directly (if they want to us it) to implement their factory.
Review URL: http://codereview.chromium.org/19435
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
rects whose origin wasn't (0,0). Fix this and reduce some redundancy.
Review URL: http://codereview.chromium.org/19457
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
for linux and mac. See BUG 6598.
Review URL: http://codereview.chromium.org/18801
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
more sense anyway) so I'll be able to use it in custom_frame_window.cc.
Also eliminate an unnecessarily-repeated set of resource IDs from the opaque nonclient view, and move a comment to match what I ended up doing (but haven't yet sent up for review) in other places. Seems I couldn't make up my mind on that one.
Review URL: http://codereview.chromium.org/19458
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
in layout test mode.
Review URL: http://codereview.chromium.org/19668
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19468
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
LayoutTests/fast/dom/Window/setting-properties-on-closed-window.html
as passing. This test has past the last 5 times (on debug and
release), so I'm marking fixed.
BUG=none
TEST=none
TBR=tc
Review URL: http://codereview.chromium.org/19470
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19454
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Disconnect the "browser controlled printing" and always delegate the control flow to the renderer.
Simplify the tests by not using a message loop anymore.
Followup changes will remove more parts that are not needed anymore.
Review URL: http://codereview.chromium.org/19460
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19469
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
avoid possible crash.
Review URL: http://codereview.chromium.org/19451
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
them, and this lets us unfork a file in webkit).
Review URL: http://codereview.chromium.org/19650
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=7191
Review URL: http://codereview.chromium.org/19665
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
UI by plumbing through a delegate notification. This will also fix metrics for
the "focus the URL bar" command.
This also includes some OCD URL-formatting changes to the DOM UI that I noticed.
Review URL: http://codereview.chromium.org/19455
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Dean pointed out that this is causing layout test failures.
Review URL: http://codereview.chromium.org/19664
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
but in doing this it cause a bunch of other linker issues to get hit, so this
will help force more things be ported right.
Review URL: http://codereview.chromium.org/19448
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
being tested here. They right behavior is to throw a syntax error in
the first line of the test.
Review URL: http://codereview.chromium.org/19662
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8874 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Ignore test that is testing a Safari incompatibility.
Review URL: http://codereview.chromium.org/19465
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=6661
Review URL: http://codereview.chromium.org/18775
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
studio projects for creating snapshots.
Apply change http://codereview.chromium.org/19635 to chrome and webkit solution files.
Review URL: http://codereview.chromium.org/19659
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This relands wtc's original CL for working around not caching the intermediate CA certificates. We believe the original commit failed on buildbot because of a bad incremental build, and will be resolved by doing a clobber
Review URL: http://codereview.chromium.org/19463
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19655
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8869 0039d316-1c4b-4281-b951-d872f2087c98
|