summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* I'm moving the test LayoutTests/fast/inline/dirtyLinesForInline.htmlsky@google.com2009-01-291-1/+4
| | | | | | | | | | | | | to the ignored list. Here's what I believe is happening: // This test has hover effects that change the font size. This test also // moves the mouse around, resulting in a layout that dances around. // Depending upon when the snapshot is taken we get different results. BUG=none TEST=none Review URL: http://codereview.chromium.org/19681 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8925 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up the Windows-ness in the sizing of new views. Write a bunch of commentsbrettw@chromium.org2009-01-295-34/+28
| | | | | | | about issues I discovered in this process. Review URL: http://codereview.chromium.org/19677 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8923 0039d316-1c4b-4281-b951-d872f2087c98
* More testsfinnur@google.com2009-01-2911-213/+214
| | | | | | Review URL: http://codereview.chromium.org/19673 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8922 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaselining LayoutTests/http/tests/navigation/metaredirect-basic.html since ↵jcampan@chromium.org2009-01-294-73/+73
| | | | | | | | it fails because of font size differences. Review URL: http://codereview.chromium.org/19478 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8920 0039d316-1c4b-4281-b951-d872f2087c98
* Move simple_clipboard_impl into test_shell. It's not needed intc@google.com2009-01-293-4/+8
| | | | | | | | chrome_dll (we use the methods in renderer_glue.cc instead). Review URL: http://codereview.chromium.org/19678 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8919 0039d316-1c4b-4281-b951-d872f2087c98
* fix a stale outlet in the File's Owner from renaming. No way to fix this in ↵pinkerton@google.com2009-01-291-8/+0
| | | | | | | | the UI, just had to manually edit the file. Review URL: http://codereview.chromium.org/19480 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8918 0039d316-1c4b-4281-b951-d872f2087c98
* whut u meAn I sp3lld iT rong?pinkerton@google.com2009-01-291-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8917 0039d316-1c4b-4281-b951-d872f2087c98
* Per Glen, remove the bottom border of maximized windows. I went ahead and ↵pkasting@chromium.org2009-01-299-107/+67
| | | | | | | | also removed support for window frame sizes with unequal widths vs. heights; Windows' UI doesn't actually let you do this and it was making the code more complex than it needed to be. Review URL: http://codereview.chromium.org/19477 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8916 0039d316-1c4b-4281-b951-d872f2087c98
* Provide the option for HTTPServer to be created with a specificsky@google.com2009-01-2922-102/+120
| | | | | | | | | | | | | | | MessageLoop. I'm going to need this when running ui tests in process. In this case I'll pass in the IO thread. I'll change all callers to use the new method, but before doing that wanted to make sure you're ok with it. BUG=none TEST=none Review URL: http://codereview.chromium.org/19039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8915 0039d316-1c4b-4281-b951-d872f2087c98
* Maintain a local/global stack for the global WebPluginDelegateImpl instance ↵ananta@chromium.org2009-01-292-7/+24
| | | | | | | | | | | | | | | | | | | pointer. Based on the crash dump, the crash occurs in the windows message filter hook, used for tracking whether the plugin enters a modal loop. The global plugin instance pointer gets reset to NULL in the windowed plugin wndproc and HandleEvent. If these events occur in nested order, then it is quite possible for the plugin instance pointer to get set to NULL incorrectly. Added a check for whether this pointer is NULL in the message filter hook along with a NOTREACHED statement. We maintain a local global stack to ensure that the plugin instance pointer gets set/reset correctly. The bug is http://code.google.com/p/chromium/issues/detail?id=6703 The other issue being fixed is to set the modal_loop_pump_messages_event coming in from the plugin in WebPluginDelegateProxy correctly. This caused the plugin to not receive events when it enters a modal loop like a context menu. Bug=6703 Review URL: http://codereview.chromium.org/19444 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8914 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable the NoScript unittest.mpcomplete@google.com2009-01-293-4/+1
| | | | | | | | Turns out we need to broadcast the NOTIFY_USER_SCRIPTS_LOADED message even if there are no scripts. I just removed the DCHECK that expects scripts. Review URL: http://codereview.chromium.org/19475 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8913 0039d316-1c4b-4281-b951-d872f2087c98
* Fix regression from my previous plugin change where internal plugins didn't ↵jam@chromium.org2009-01-292-11/+8
| | | | | | | | get loaded correctly. Review URL: http://codereview.chromium.org/19676 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8912 0039d316-1c4b-4281-b951-d872f2087c98
* Alphabetize some files that weren't in orderamanda@chromium.org2009-01-291-7/+7
| | | | | | Review URL: http://codereview.chromium.org/19675 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8911 0039d316-1c4b-4281-b951-d872f2087c98
* Fix our link madness on linux. We now properly linktc@google.com2009-01-297-21/+67
| | | | | | | | | | | | | | | webkit into unit_tests. There was also a problem with simple_clipboard_impl.cc which should only be compiled into test_shell. I can't remove mock_webkit_glue.cc until I verify that the mac build doesn't need it anymore. Review URL: http://codereview.chromium.org/19474 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8910 0039d316-1c4b-4281-b951-d872f2087c98
* rest of the rename, accidentally leftout. TBR.pinkerton@chromium.org2009-01-294-22/+30
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8909 0039d316-1c4b-4281-b951-d872f2087c98
* roll DEPS to pick up latest WebKitdarin@chromium.org2009-01-291-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8908 0039d316-1c4b-4281-b951-d872f2087c98
* Modify npruntime_impl.h to be useful. Previously, we were not usingdarin@chromium.org2009-01-291-51/+33
| | | | | | | | | | | this file, but WebCore includes it, and so we can avoid some WebCore forking by implementing npruntime_impl.h appropriately. R=dglazkov Review URL: http://codereview.chromium.org/19472 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8906 0039d316-1c4b-4281-b951-d872f2087c98
* rename from tab_bar to tab_strip to be more consistent with windowspinkerton@chromium.org2009-01-295-23/+24
| | | | | | Review URL: http://codereview.chromium.org/19473 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8905 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 8844.sidchat@google.com2009-01-2916-53/+28
| | | | | | Review URL: http://codereview.chromium.org/19674 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8904 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed up the EOL style on all /src/media source files.scherkus@chromium.org2009-01-292-12/+12
| | | | | | | TBR=maruel Review URL: http://codereview.chromium.org/19641 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8903 0039d316-1c4b-4281-b951-d872f2087c98
* hookup tabs to the model and handle new tab creationpinkerton@google.com2009-01-2911-194/+397
| | | | | | Review URL: http://codereview.chromium.org/19669 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8902 0039d316-1c4b-4281-b951-d872f2087c98
* Add a Version class and matching unit tests, roughly based on ↵erikkay@google.com2009-01-298-0/+214
| | | | | | | | chrome/installer/util/version.*. This version has more flexible parsing rules and is more robust to detecting bogus versions, supporting arbitrary numbers of version components rather than just dotted quads. It's possible that we should switch chrome installer to use this version. Review URL: http://codereview.chromium.org/19667 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8901 0039d316-1c4b-4281-b951-d872f2087c98
* Remove pointless function override (the base class does the exact same thing ↵pkasting@chromium.org2009-01-292-5/+0
| | | | | | | | already). Review URL: http://codereview.chromium.org/19653 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8900 0039d316-1c4b-4281-b951-d872f2087c98
* Updating some test statuses now that I have more plugin code hooked up.thomasvl@chromium.org2009-01-291-2/+5
| | | | | | Review URL: http://codereview.chromium.org/19471 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8899 0039d316-1c4b-4281-b951-d872f2087c98
* Add a stub shell dialogs to help us get linking faster.brettw@google.com2009-01-292-0/+23
| | | | | | Review URL: http://codereview.chromium.org/19672 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8898 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the test while investigating.maruel@chromium.org2009-01-291-1/+2
| | | | | | Review URL: http://codereview.chromium.org/19671 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8897 0039d316-1c4b-4281-b951-d872f2087c98
* Change chrome:// to chrome-ui://, fix up one chrome-resource:// reference.glen@chromium.org2009-01-2917-44/+47
| | | | | | Review URL: http://codereview.chromium.org/18175 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8896 0039d316-1c4b-4281-b951-d872f2087c98
* Make the shared shell dialog not use Windows types, as well as the web contentsbrettw@chromium.org2009-01-298-18/+24
| | | | | | | code that runs it. Review URL: http://codereview.chromium.org/19666 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8895 0039d316-1c4b-4281-b951-d872f2087c98
* A minor change to the pattern for filter factories that makes the ↵ralphl@chromium.org2009-01-294-308/+388
| | | | | | | | | | | implementation more flexible, and prevents the use of templates by the client. Now, the filters themselves simply expose a static FilterFactory() method that returns a new factory object. The constructor and destructor of the class should be private and the FilterFactory object shuold be declarded as a friend. There is still a template factory, but the class uses this template class directly (if they want to us it) to implement their factory. Review URL: http://codereview.chromium.org/19435 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8894 0039d316-1c4b-4281-b951-d872f2087c98
* The new version of Inset() Ben added a while ago didn't work quite right for ↵pkasting@chromium.org2009-01-292-10/+4
| | | | | | | | rects whose origin wasn't (0,0). Fix this and reduce some redundancy. Review URL: http://codereview.chromium.org/19457 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8893 0039d316-1c4b-4281-b951-d872f2087c98
* Add routine to close file descriptors on execjeremy@chromium.org2009-01-295-31/+66
| | | | | | | | for linux and mac. See BUG 6598. Review URL: http://codereview.chromium.org/18801 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8892 0039d316-1c4b-4281-b951-d872f2087c98
* Move kClientEdgeThickness from BrowserView to NonClientView (which makes ↵pkasting@chromium.org2009-01-296-27/+19
| | | | | | | | | more sense anyway) so I'll be able to use it in custom_frame_window.cc. Also eliminate an unnecessarily-repeated set of resource IDs from the opaque nonclient view, and move a comment to match what I ended up doing (but haven't yet sent up for review) in other places. Seems I couldn't make up my mind on that one. Review URL: http://codereview.chromium.org/19458 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8891 0039d316-1c4b-4281-b951-d872f2087c98
* We need to reset the theme stuff in a code path that actually used when notthomasvl@chromium.org2009-01-291-9/+8
| | | | | | | in layout test mode. Review URL: http://codereview.chromium.org/19668 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8890 0039d316-1c4b-4281-b951-d872f2087c98
* Roll DEPS to pick up unforking of ThreadGlobalData.hamanda@chromium.org2009-01-291-1/+1
| | | | | | Review URL: http://codereview.chromium.org/19468 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8889 0039d316-1c4b-4281-b951-d872f2087c98
* Marks the testsky@google.com2009-01-291-1/+0
| | | | | | | | | | | | | | LayoutTests/fast/dom/Window/setting-properties-on-closed-window.html as passing. This test has past the last 5 times (on debug and release), so I'm marking fixed. BUG=none TEST=none TBR=tc Review URL: http://codereview.chromium.org/19470 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8888 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue 7146, sending large messages over IPC on POSIX was broken.jeremy@chromium.org2009-01-292-7/+17
| | | | | | Review URL: http://codereview.chromium.org/19454 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8887 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land revision 8821 with the ui test fixed.maruel@chromium.org2009-01-298-187/+119
| | | | | | | | | | Disconnect the "browser controlled printing" and always delegate the control flow to the renderer. Simplify the tests by not using a message loop anymore. Followup changes will remove more parts that are not needed anymore. Review URL: http://codereview.chromium.org/19460 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8886 0039d316-1c4b-4281-b951-d872f2087c98
* Mark one svg test as only failing on win/linux since mac passes.thomasvl@chromium.org2009-01-291-1/+1
| | | | | | Review URL: http://codereview.chromium.org/19469 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8884 0039d316-1c4b-4281-b951-d872f2087c98
* Create and destroy members of the AutomationProxy in the correct order to ↵stoyan@chromium.org2009-01-291-1/+11
| | | | | | | | avoid possible crash. Review URL: http://codereview.chromium.org/19451 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8882 0039d316-1c4b-4281-b951-d872f2087c98
* Remove references to Mac text codecs (since we weren't correctly building ↵amanda@chromium.org2009-01-291-6/+0
| | | | | | | | them, and this lets us unfork a file in webkit). Review URL: http://codereview.chromium.org/19650 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8880 0039d316-1c4b-4281-b951-d872f2087c98
* Disable DownloadTest.UnknownSize because it is flaky.maruel@chromium.org2009-01-291-1/+2
| | | | | | | BUG=7191 Review URL: http://codereview.chromium.org/19665 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8879 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the Windows set focus call and bad-design browser call from the new tabbrettw@chromium.org2009-01-294-27/+29
| | | | | | | | | | UI by plumbing through a delegate notification. This will also fix metrics for the "focus the URL bar" command. This also includes some OCD URL-formatting changes to the DOM UI that I noticed. Review URL: http://codereview.chromium.org/19455 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8878 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Linux: use WebKit HEAD's gtk2drawing.c"agl@chromium.org2009-01-293-9/+2
| | | | | | | | | Dean pointed out that this is causing layout test failures. Review URL: http://codereview.chromium.org/19664 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8877 0039d316-1c4b-4281-b951-d872f2087c98
* Go ahead and wire in the plugin list to the shell, doesn't help anything pass,thomasvl@chromium.org2009-01-291-1/+1
| | | | | | | | but in doing this it cause a bunch of other linker issues to get hit, so this will help force more things be ported right. Review URL: http://codereview.chromium.org/19448 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8875 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore invalid test instead of rebaseing it. Nothing interesting isager@chromium.org2009-01-293-8/+4
| | | | | | | | being tested here. They right behavior is to throw a syntax error in the first line of the test. Review URL: http://codereview.chromium.org/19662 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8874 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline test that only differ in function printing.ager@google.com2009-01-296-14/+205
| | | | | | | Ignore test that is testing a Safari incompatibility. Review URL: http://codereview.chromium.org/19465 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8873 0039d316-1c4b-4281-b951-d872f2087c98
* Add more unit tests for net/base/host_resolver.phajdan.jr@chromium.org2009-01-299-116/+315
| | | | | | | | BUG=6661 Review URL: http://codereview.chromium.org/18775 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8872 0039d316-1c4b-4281-b951-d872f2087c98
* Update to latest V8 trunk version to fix dependency problem with our visual ↵ager@google.com2009-01-293-3/+35
| | | | | | | | | studio projects for creating snapshots. Apply change http://codereview.chromium.org/19635 to chrome and webkit solution files. Review URL: http://codereview.chromium.org/19659 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8871 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 8868.ericroman@google.com2009-01-299-256/+301
| | | | | | | This relands wtc's original CL for working around not caching the intermediate CA certificates. We believe the original commit failed on buildbot because of a bad incremental build, and will be resolved by doing a clobber Review URL: http://codereview.chromium.org/19463 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8870 0039d316-1c4b-4281-b951-d872f2087c98
* Rolling DEPS to pick up unforked filesdimich@google.com2009-01-291-1/+1
| | | | | | Review URL: http://codereview.chromium.org/19655 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8869 0039d316-1c4b-4281-b951-d872f2087c98