summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* POSIX: Rewrite IPC's interaction with FileDescriptoragl@chromium.org2009-03-059-49/+49
| | | | | | | | | | | | | | | | | | | The FileDescriptor API is clearly too hard to use. It's the only IPC data type which is non-POD and serialising an invalid file descriptor is fatal to Chrome on POSIX. The use of Maybe is possibly non-obvious to non-functional programmers. This patch merges Maybe and FileDescriptor so that serialising invalid file descriptors is permitted and results in -1 at the other end. (Serialising /closed/ a file descriptor is still fatal.) Also, it adds a pointer in base/file_descriptor.h to instructions for its use with IPC. Although it's generally bad practice to mention IPC in base, in this case I cannot find another suitable location. Review URL: http://codereview.chromium.org/39208 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11041 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor v8 extensions so that they aren't in the WebCore namespace, and can ↵asargent@chromium.org2009-03-0524-234/+193
| | | | | | | | | | | call functions in the rest of Chromium code without having to go through ChromiumBridge (which now lives upstream in the WebKit repository). R=darin,mbelshe Review URL: http://codereview.chromium.org/40132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11040 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue 8331: About dialog became too narrow when we changedfinnur@chromium.org2009-03-0551-110/+50
| | | | | | | | | | | | | ChromeFont::GetExpectedTextWidth to use dlu_base_x _or_ average character width (depending on which one is smaller). BUG=8331 TEST=Open About box in all languages and make sure it is roughly the same size as it was in 1.0. Review URL: http://codereview.chromium.org/39214 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11039 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a bug in the criteria checker that caused the 6-month flag to not be ↵gwilson@google.com2009-03-051-72/+32
| | | | | | | | | | | deleted. BUG=8217 R=kuchhal Review URL: http://codereview.chromium.org/27307 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11038 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline a layout test for Win. The rendering of the image was different ↵jhawkins@chromium.org2009-03-053-2/+2
| | | | | | | | and actually looked better than the baseline. Review URL: http://codereview.chromium.org/40181 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11037 0039d316-1c4b-4281-b951-d872f2087c98
* The new history and download tab caused a regression where opening the NTP ↵jcampan@chromium.org2009-03-058-13/+11
| | | | | | | | | | | | | | | would not focus the location bar. DOM UI now by default focus the page. The NTP one focus the location bar. Also removed some unused fields from the history and download DOM UI. BUG=8356 TEST=Open NTP, focus should be on location bar Review URL: http://codereview.chromium.org/39173 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11034 0039d316-1c4b-4281-b951-d872f2087c98
* Update the mac text test output, the only differences are due to v8.thomasvl@chromium.org2009-03-052-1/+19
| | | | | | Review URL: http://codereview.chromium.org/40171 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11033 0039d316-1c4b-4281-b951-d872f2087c98
* NO CODE CHANGE.maruel@google.com2009-03-0583-196/+329
| | | | | | | Split the lines >80 cols. (Part 1) Review URL: http://codereview.chromium.org/39206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11032 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline results for js-update-image to account for rendering differences ↵ben@chromium.org2009-03-054-2/+6
| | | | | | | | between Windows and Mac. Review URL: http://codereview.chromium.org/40180 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11031 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the chrome view contents tab contents type. Nobody uses it.brettw@chromium.org2009-03-051-1/+4
| | | | | | Review URL: http://codereview.chromium.org/39212 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11030 0039d316-1c4b-4281-b951-d872f2087c98
* Several little style cleanups in GTK download shelf code.estade@chromium.org2009-03-054-8/+23
| | | | | | Review URL: http://codereview.chromium.org/40174 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11029 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline an SVG layout test. The vertical lines are shaded slightly ↵sidchat@google.com2009-03-054-9/+9
| | | | | | | | different - the diagonal lines are anti-aliased in a slightly different shade, and the text is drawn differently. Review URL: http://codereview.chromium.org/39053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11028 0039d316-1c4b-4281-b951-d872f2087c98
* Set svn:eol-style to CRLF.tc@google.com2009-03-050-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11027 0039d316-1c4b-4281-b951-d872f2087c98
* Try #2 of "make JavaScript alerts reflect the URL of the frame they came from,brettw@chromium.org2009-03-0523-65/+103
| | | | | | | | | | | not the enclosing frame." The diffrence between this one and the previous version of this patch is the addition of test_webview_delegate. BUG=1686837 Review URL: http://codereview.chromium.org/39163 Review URL: http://codereview.chromium.org/40175 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11026 0039d316-1c4b-4281-b951-d872f2087c98
* Address some of the review comments on comment 2 ofbrettw@chromium.org2009-03-0516-321/+334
| | | | | | | | https://bugs.webkit.org/show_bug.cgi?id=24299 This is everything up to "not supposed to be using STL container classes." Review URL: http://codereview.chromium.org/40122 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11025 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the TAB_CONTENTS_NEW_TAB_UI tab contents type. This was not actually usedbrettw@chromium.org2009-03-058-14/+17
| | | | | | | now, so everytime this appears was dead code. Review URL: http://codereview.chromium.org/39200 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11024 0039d316-1c4b-4281-b951-d872f2087c98
* Load the webkcore strings into a data pack and use them in TestShell. Fixes ↵pinkerton@chromium.org2009-03-059-10/+52
| | | | | | | | several layout tests that required these strings. We need to rebaseline them because the strings Chromium uses differ from the strings WebKit.org uses. Review URL: http://codereview.chromium.org/40170 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11023 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the bug: Scrolling the Spell-checker drop-down box adds the languages ↵sidchat@google.com2009-03-052-2/+44
| | | | | | | | | scrolled. Basically, when a spell check language changes, it is added to the accept languages list so that it is remembered later. However, when the list gets scrolled, it keeps adding all the languages it scrolled. So, I decided to fix this by adding only the latest language selected as the spell check dictionary language in the drop down. Issue=8374 Review URL: http://codereview.chromium.org/40145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11022 0039d316-1c4b-4281-b951-d872f2087c98
* Have WebWorkerProxy send messages directly through RenderThread, instead of ↵jam@chromium.org2009-03-053-10/+6
| | | | | | | | RenderWidget, since that could lead to the terminateworker message being dropped. Review URL: http://codereview.chromium.org/39176 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11021 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the golden file. JSON files should end in CRLF ontc@google.com2009-03-053-21/+19
| | | | | | | | | | | all platforms. Also, we sort dictionary keys by value so the path moved. BUG=8339 Review URL: http://codereview.chromium.org/39174 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11020 0039d316-1c4b-4281-b951-d872f2087c98
* Delete some duplicate test outputs.evan@chromium.org2009-03-05232-3836/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11019 0039d316-1c4b-4281-b951-d872f2087c98
* Tool for finding duplicate test outputs.evan@chromium.org2009-03-051-0/+46
| | | | | | Review URL: http://codereview.chromium.org/40177 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11018 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline some ok tests on Linux.evan@chromium.org2009-03-0516-14/+62
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11017 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce the height of options on the Languages panel.mal@chromium.org2009-03-051-2/+2
| | | | | | | | | | | | | I changed two instances of kUnrelatedControlLargeVerticalSpacing to the shorter kUnrelatedControlVerticalSpacing. Tested on XP (Luna, no theme) and Vista Aero. BUG= 5511 R= ben Review URL: http://codereview.chromium.org/40148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11016 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unnecessary typedef keywords that make gcc 4.3 unhappy.avi@chromium.org2009-03-051-2/+2
| | | | | | | | | | Committed on behalf of Craig Schlenter. http://codereview.chromium.org/40158 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11015 0039d316-1c4b-4281-b951-d872f2087c98
* fix oopsdarin@chromium.org2009-03-051-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11014 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the problem that worker context object could be double deleted.jianli@chromium.org2009-03-051-0/+10
| | | | | | Review URL: http://codereview.chromium.org/28147 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11013 0039d316-1c4b-4281-b951-d872f2087c98
* Update tests_fixable.txt for the 41420:41447 merge.darin@chromium.org2009-03-051-0/+15
| | | | | | | | TBR=nsylvain Review URL: http://codereview.chromium.org/39210 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11012 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit merge 41420:41447darin@chromium.org2009-03-052-3/+3
| | | | | | | | R=eroman Review URL: http://codereview.chromium.org/39198 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11010 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 11002.brettw@chromium.org2009-03-0521-94/+57
| | | | | | Review URL: http://codereview.chromium.org/39203 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11008 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline a test that moved by one pixel.evan@chromium.org2009-03-051-4/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11005 0039d316-1c4b-4281-b951-d872f2087c98
* roll DEPS to pick up test for page cycler perfdarin@chromium.org2009-03-051-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11004 0039d316-1c4b-4281-b951-d872f2087c98
* Make JavaScript alerts reflect the URL of the frame they came from, not thebrettw@chromium.org2009-03-0521-57/+94
| | | | | | | | | enclosing frame. BUG=1686837 Review URL: http://codereview.chromium.org/39163 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11002 0039d316-1c4b-4281-b951-d872f2087c98
* Only tune SO_SNDBUF/SO_RCVBUF sizes for pre-Vista systems.mbelshe@google.com2009-03-051-15/+24
| | | | | | Review URL: http://codereview.chromium.org/40168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11001 0039d316-1c4b-4281-b951-d872f2087c98
* Bump for 169 dev cyclemal@chromium.org2009-03-051-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11000 0039d316-1c4b-4281-b951-d872f2087c98
* Remove -Werror from the WebCore settings, so warnings generated bysgk@google.com2009-03-051-0/+4
| | | | | | | ../third_party/WebKit/WebCore/dom/Document.cpp don't stop the build. Review URL: http://codereview.chromium.org/39155 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10999 0039d316-1c4b-4281-b951-d872f2087c98
* We were waiting for the scrollbar changes to finally land, but this is thethomasvl@chromium.org2009-03-054-573/+569
| | | | | | | | | | needed rebaseline in the mean time. the original baselines where taken with the wrong scrollbar, font, etc. settings. So both the image and the text expects were wrong. Review URL: http://codereview.chromium.org/39195 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10998 0039d316-1c4b-4281-b951-d872f2087c98
* We need the missing image image for layout tests. This got lost in gypping.avi@chromium.org2009-03-051-0/+1
| | | | | | Review URL: http://codereview.chromium.org/39196 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10997 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r10974 since it didn't change performance on the page cyclers.darin@chromium.org2009-03-055-49/+1
| | | | | | | | TBR=dglazkov Review URL: http://codereview.chromium.org/39197 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10996 0039d316-1c4b-4281-b951-d872f2087c98
* Implement --startup-dialog.avi@chromium.org2009-03-051-2/+10
| | | | | | Review URL: http://codereview.chromium.org/39193 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10994 0039d316-1c4b-4281-b951-d872f2087c98
* Changes bookmark sorting to sort folders first.sky@google.com2009-03-052-7/+49
| | | | | | | | | BUG=8338 TEST=covered by unit tests Review URL: http://codereview.chromium.org/39175 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10993 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily disable max_cols=80 rule since there's too many source files ↵maruel@chromium.org2009-03-051-2/+6
| | | | | | | | that trigger this rule at the moment. Review URL: http://codereview.chromium.org/39192 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10992 0039d316-1c4b-4281-b951-d872f2087c98
* Add 2 tests to the test_fixable.nsylvain@chromium.org2009-03-051-0/+3
| | | | | | | | | | | | The first one is one you removed yesterday, you might want to take a look at it. The second one started being flaky about at the same time, but I don't see the reason. Review URL: http://codereview.chromium.org/39194 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10991 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore layout test search-event-delay.html.ager@chromium.org2009-03-051-0/+6
| | | | | | | | | It simply does not work. It is testing the exact time between a key event and a search event. A GC or any other variation at an unlucky time will make this fail. Review URL: http://codereview.chromium.org/40165 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10990 0039d316-1c4b-4281-b951-d872f2087c98
* Mac test updatesthomasvl@chromium.org2009-03-051-37/+4
| | | | | | | | | - large set of keyboard tests now passing thanks to avi's cl the other day. - one test only fails in debug, mark as such. - one test timed out 16 of the last 20 runs, marking as timeout or pass. Review URL: http://codereview.chromium.org/39190 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10989 0039d316-1c4b-4281-b951-d872f2087c98
* Revert change 10975 and 10972 because it broke the purify nsylvain@chromium.org2009-03-0511-105/+7
| | | | | | | | | | | | | | | | | | | | | | | tests, and it might have caused a unit tests failure. purify error : UMR in URLRequest::response_data_file failing test: URLFetcherHeadersTest.Headers: c:\b\slave\chromium-rel-builder\build\src\chrome\browser\net\url_fetcher_unittest.cc(222): error: Value of: source->response_headers()->GetNormalizedHeader("cache-control", &header) Actual: false Expected: true c:\b\slave\chromium-rel-builder\build\src\chrome\browser\net\url_fetcher_unittest.cc(223): error: Value of: header Actual: "" Expected: "private" c:\b\slave\chromium-rel-builder\build\src\chrome\browser\net\url_fetcher_unittest.cc(181): error: Value of: response_code Actual: 404 Expected: 200 Release only. Review URL: http://codereview.chromium.org/39191 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10988 0039d316-1c4b-4281-b951-d872f2087c98
* Guard against exceptions when getting and setting the event propertyager@chromium.org2009-03-052-89/+64
| | | | | | | on the global object in event handling code. Review URL: http://codereview.chromium.org/39187 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10987 0039d316-1c4b-4281-b951-d872f2087c98
* Get history and download HTML UIs into Mac/Linux builds along with ↵pinkerton@chromium.org2009-03-058-29/+59
| | | | | | | | supporting icon scaffolding. Review URL: http://codereview.chromium.org/39132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10986 0039d316-1c4b-4281-b951-d872f2087c98
* Make UTF8ToWide take a StringPiece, to avoid copying to a std::string.deanm@chromium.org2009-03-052-2/+3
| | | | | | | | | The previous prototype took only a std::string, unless you used the less convenient output parameter version. This required copying char* input to a std::string. Using a StringPiece the input will be implicitly both std::string and char* without any copying. This helps especially on Linux, where all input we get will be in utf8 char*. Review URL: http://codereview.chromium.org/40106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10985 0039d316-1c4b-4281-b951-d872f2087c98
* - Add «no trailing whitespace» and <=80 cols rules.maruel@chromium.org2009-03-052-47/+103
| | | | | | | | | | - Remove the invalid import os statement (PRESUBMIT.py shouldn't import anything). - Add excluded paths. Mostly third parties. - Increase what is considered a source file. - Don't check for DO NOT SUBMIT on upload. Review URL: http://codereview.chromium.org/28219 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10983 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-23 02:45:30 +0000