summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Support pasting text from a clipboard that has no published targets.estade@chromium.org2009-07-213-8/+43
| | | | | | | | | BUG=16887 TEST=paste from intellij into chrome render view Review URL: http://codereview.chromium.org/159107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21142 0039d316-1c4b-4281-b951-d872f2087c98
* Info bubble focus tweaks.estade@chromium.org2009-07-213-18/+51
| | | | | | | | | | | | | | | | | | | | | | | | | | We can't close info bubbles when they lose focus because then we can't use the select dropdown in the bookmark bubble. Thus we have to watch the active window. Since we are doing this, we no longer need the application level grab or the button press handler. This also fixes the problem that a browser window showing an info bubble will paint inactive (assuming your WM supports active/inactive windows). This maintains the desirable properties: - info bubbles close when you click outside them but inside the parent window - info bubbles close when the parent window closes - info bubbles don't show up on alternate desktops (even if your WM doesn't support active/inactive windows) - info bubbles can survive losing focus to a popup window This breaks the desirable properties: - clicking on something in the browser while the info bubble is showing both dismisses the info bubble and does the appropriate action in the browser - the info bubble dismisses when the browser loses focus in a window manager that doesn't support active/inactive state - on xmonad, if you have the cursor over the browser window but the focus is on the info bubble (this is hard to do, since focus is supposed to follow the mouse, but not impossible), then it requires two clicks to dismiss the info bubble. But I think that this is a problem with xmonad and is present before this patch as well. So this is not the best of all possible worlds, but it is an improvement over our current state as well as an improvement over the state before r20977. BUG=17223 TEST=browser doesn't crash when you open the select dropdown in the bookmark bubble Review URL: http://codereview.chromium.org/155793 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21141 0039d316-1c4b-4281-b951-d872f2087c98
* linux: implement encodings menuevan@chromium.org2009-07-216-64/+105
| | | | | | | | BUG=11599 Review URL: http://codereview.chromium.org/155830 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21140 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some problems with my panel scroller.brettw@chromium.org2009-07-214-9/+10
| | | | | | | | These problems were caused by me addressing review comment and forgetting to compile before checkin. Review URL: http://codereview.chromium.org/159114 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21139 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid dereferencing null pointer when an audio initialization error occurs.fbarchard@chromium.org2009-07-212-8/+7
| | | | | | | | | BUG=17283 TRY=play multichannel audio (ie trek6.mp4) in media player and a crash occurs. This fix avoids the crash. Review URL: http://codereview.chromium.org/159099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21138 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring to share MockAudioOutputStream implementations across 3 platformshclam@chromium.org2009-07-2119-196/+190
| | | | | | Review URL: http://codereview.chromium.org/155471 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21137 0039d316-1c4b-4281-b951-d872f2087c98
* Fix GTK/Mac builds.ben@chromium.org2009-07-216-13/+7
| | | | | | Review URL: http://codereview.chromium.org/155826 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21136 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bustage - correct definitionben@chromium.org2009-07-211-2/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21135 0039d316-1c4b-4281-b951-d872f2087c98
* Resurrect toolkit_views build.ben@chromium.org2009-07-2113-28/+47
| | | | | | Review URL: http://codereview.chromium.org/155797 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21132 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Linux startup crash.brettw@chromium.org2009-07-211-10/+12
| | | | | | | | | | | | | When there is no existing browser, this code will crash. It only works because of the Linux splash screen. Original review=http://codereview.chromium.org/155795 R=agl TEST=none Review URL: http://codereview.chromium.org/155822 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21131 0039d316-1c4b-4281-b951-d872f2087c98
* Stubs for DB-related methods in ChromiumBridge.dumi@chromium.org2009-07-205-2/+48
| | | | | | Review URL: http://codereview.chromium.org/159044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21130 0039d316-1c4b-4281-b951-d872f2087c98
* Make standard input /dev/null when running xdg-settings to set the default ↵mdm@chromium.org2009-07-201-3/+21
| | | | | | | | | | | browser. BUG=17219 TEST=run chrome from a terminal in KDE and use the "set as default browser" feature when ~/.kde/share/config/profilerc is owned by root; chrome should not freeze Review URL: http://codereview.chromium.org/155796 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21129 0039d316-1c4b-4281-b951-d872f2087c98
* Infobar UI cleanup on Mac. Adds the yellow background gradient androhitrao@chromium.org2009-07-207-72/+334
| | | | | | | | | | | | | | | centers all of the buttons. Also adds the ok/cancel buttons to the xib file. Infobars that do not need the buttons can remove them from the view before displaying. BUG=http://crbug.com/14462 BUG=http://crbug.com/17195 TEST=Infobars should have yellow background, look less ugly. Review URL: http://codereview.chromium.org/155788 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21128 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Browser::IsApplication so it conforms to the TabContentsDelegate interface.erg@google.com2009-07-201-1/+1
| | | | | | | | | | This was showing up as a BAD_OVERRIDE in Coverity. http://crbug.com/18296 Review URL: http://codereview.chromium.org/155810 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21127 0039d316-1c4b-4281-b951-d872f2087c98
* Don't complain about leaks during fatal error loggingdkegel@google.com2009-07-201-1/+9
| | | | | | Review URL: http://codereview.chromium.org/155807 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21126 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Strip newlines from paste.shess@chromium.org2009-07-2010-16/+345
| | | | | | | | | | | | | | http://crbug.com/11817 TEST=Copy an URL somewhere and break it apart with newlines at random places. Copy/paste it into omnibox and the newlines should be gone. Try this one: http://dev.chro mium.org/develo pers/how-tos/ge t-the-code Review URL: http://codereview.chromium.org/159018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21125 0039d316-1c4b-4281-b951-d872f2087c98
* Pulling in new gyp version.bradnelson@chromium.org2009-07-202-2/+2
| | | | | | | | | | | | | | Switching two includes in common.gypi to msvs_system_include_dirs. This will force them to the back of the include order (which matches where the non-hermetic copies of these libraries would be). BUG=None TEST=None Review URL: http://codereview.chromium.org/155812 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21124 0039d316-1c4b-4281-b951-d872f2087c98
* Including config.h temporarily to make the Mac/Linux builds happy.dumi@chromium.org2009-07-201-0/+4
| | | | | | Review URL: http://codereview.chromium.org/159100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21123 0039d316-1c4b-4281-b951-d872f2087c98
* Widen ExtensionUnpacker_Test suppression yet againstuartmorgan@google.com2009-07-201-1/+1
| | | | | | | | | BUG=17129 TEST=Greener Mac valgind unit_test bot. Review URL: http://codereview.chromium.org/155808 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21122 0039d316-1c4b-4281-b951-d872f2087c98
* Don't make all bookmark buttons the same width.jrg@chromium.org2009-07-203-42/+212
| | | | | | | | | | | | | | | | | | | | | | | | | | | Make thinner if possible. Feelin luv 4 pink. BUG=http://crbug.com/16942 TEST=2 main parts: 1) Create bookmarks (click 'Star'). Make sure long titles get trimmed. Make sure small titles have smaller buttons and text does NOT get trimmed. Quit and launch with bookmark bar open. Make sure things are still fine (icons load after bar first assembled). 2) Quit Chromium. Rename a LONG button title by editing ~/Library/Application Support/Chromium/Default/Bookmarks. Relaunch Chromium. Make sure the button is now smaller but is not "trimmed" (e.g. all the text is there). Repeat for 5 buttons with different short (5-10 char) titles on each. Make sure the buttons are smaller and the text is NOT trimmed. Review URL: http://codereview.chromium.org/155712 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21121 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: Fix spacing so page and app menus take up full height in GTK ↵erg@google.com2009-07-201-5/+7
| | | | | | | | theme mode. Review URL: http://codereview.chromium.org/159103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21120 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing TemplateURL include.phajdan.jr@chromium.org2009-07-201-0/+1
| | | | | | | | TBR=brettw Review URL: http://codereview.chromium.org/159102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21119 0039d316-1c4b-4281-b951-d872f2087c98
* Hopefully fix Windows release compile.phajdan.jr@chromium.org2009-07-201-0/+3
| | | | | | | | TBR=brettw Review URL: http://codereview.chromium.org/155813 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21118 0039d316-1c4b-4281-b951-d872f2087c98
* Switch the first thread in a child process to be the main thread, and make ↵jam@chromium.org2009-07-2028-351/+202
| | | | | | | | the IO thread be the second thread. The change is needed for plugins on mac. Review URL: http://codereview.chromium.org/149558 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21117 0039d316-1c4b-4281-b951-d872f2087c98
* Header cleanup in browser/importerphajdan.jr@chromium.org2009-07-2016-86/+141
| | | | | | | | | | - forward declare more things - move bits from header to implementation files to cut includes - extract bookmark_model_observer.h out of bookmark_model.h to reduce includes Review URL: http://codereview.chromium.org/159097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21116 0039d316-1c4b-4281-b951-d872f2087c98
* Add a Mac suppression for a sporadic leak.stuartmorgan@google.com2009-07-201-0/+10
| | | | | | | | | BUG=17297 TEST=Greener Mac valgrind unit_test bot Review URL: http://codereview.chromium.org/155806 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21115 0039d316-1c4b-4281-b951-d872f2087c98
* Fix misleading name and comment of Browser::GetCurrentPageTitle.phajdan.jr@chromium.org2009-07-207-12/+12
| | | | | | | | | | | GetWindowTitleForCurrentTab more accurately describes what this function really does. TEST=none http://crbug.com/16231 Review URL: http://codereview.chromium.org/155534 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21114 0039d316-1c4b-4281-b951-d872f2087c98
* When we save the window bounds, make sure we are only storing thetc@google.com2009-07-202-10/+12
| | | | | | | | | | | | | | | | | non-maximized and non-fullscreen bounds. We still keep track of whether the window is maximized or not, but this allows restoring a maximized browser to go back to it's previous state. This also fixes a bug where we would confuse window managers by setting the initial window size to the full desktop would cause WMs to disable resize/move. BUG=16602 Review URL: http://codereview.chromium.org/155802 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21113 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash on older versions of windows that don't have DWM APIs.ben@chromium.org2009-07-201-8/+12
| | | | | | | | | http://crbug.com/17290 TEST=none Review URL: http://codereview.chromium.org/155798 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21112 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaselines and test_expectations for some Linux tests fixed by ↵senorblanco@chromium.org2009-07-209-7/+69
| | | | | | | | | | | http://bugs.webkit.org/show_bug.cgi?id=26618, rolled into Chromium as of r21049. BUG=http://crbug.com/10404,http://crbug.com/10309 TEST=See buildbots run. Run, buildbots, run. Review URL: http://codereview.chromium.org/159032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21111 0039d316-1c4b-4281-b951-d872f2087c98
* File dropped off a popup CL :-(jrg@chromium.org2009-07-201-24/+30
| | | | | | | | | | | | | | | | | | TEST=A few things. Bookmark bar test (16063): - open bookmark bar, then open popup. Popup should not have bmb. - close bookmark bar, then open popup. Popup should not have bmb. - In main window, toggle bmb a few times. Popup should not change. Tab at bottom bug (16329): - Open 'details' popup in gmail (next to 'last acct activity') - make sure no tab strip at the bottom of the window General (15727): - Open a popup. Make sure no toolbar (back/fwd buttons et al) Test: same as listed in Review URL: http://codereview.chromium.org/155785 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21110 0039d316-1c4b-4281-b951-d872f2087c98
* Move all the xib files out of the en.lproj in prep for starting to land real ↵thomasvl@chromium.org2009-07-2019-61/+89
| | | | | | | | | | | | l10n support. Cleanup some tabs/indents in chrome.gyp BUG=16764 TEST=All UI still works Review URL: http://codereview.chromium.org/155800 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21109 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable extensions auto-update.asargent@chromium.org2009-07-201-1/+1
| | | | | | | | | BUG=12117 TEST=none Review URL: http://codereview.chromium.org/159085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21107 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: remove suppression for 9757.agl@chromium.org2009-07-201-8/+0
| | | | | | | | | | It appears that this issue has been fixed amoungst the multiple rewrites that this code has received in the mean time. BUG=9757 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21106 0039d316-1c4b-4281-b951-d872f2087c98
* Update deb package version to 0.1.40.0-1 and add some code to produce an ↵tschmelcher@google.com2009-07-202-5/+41
| | | | | | | | error if it ever gets out of sync with the plugin version in the future. We can't really update the deb package version automatically because packages ship with a changelog that needs to be updated by a human to describe changes in each new release. Hence it will now be necessary to update the Debian changelog when bumping the plugin version. Review URL: http://codereview.chromium.org/155728 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21105 0039d316-1c4b-4281-b951-d872f2087c98
* Implement WebNode, and fix self assignment for WebKit api classes.ajwong@chromium.org2009-07-206-3/+116
| | | | | | Review URL: http://codereview.chromium.org/149728 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21104 0039d316-1c4b-4281-b951-d872f2087c98
* Change fullscreen mode to be determined by the window manager.tc@google.com2009-07-202-21/+30
| | | | | | | | | | | | | | | | | We used to have a bool that determined whether we were in full screen mode or not, but that's not always in sync with the WM so wait for the WM to tell us that we're in full screen mode. Also, change it so when we're in full screen mode, we don't save our window bounds because that causes us to restart in full screen mode which is all sorts of broken. BUG=16602 Review URL: http://codereview.chromium.org/159087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21103 0039d316-1c4b-4281-b951-d872f2087c98
* Changed the extension.connect() API not to broadcast to all tabs. Added ampcomplete@chromium.org2009-07-2032-241/+448
| | | | | | | | | | | | | more specific tabs.connect(tabId) API to connect to a specific tab. Also changed the ExtensionMessageService from a singleton to a Profile-owned object. BUG=12461 TEST=no Review URL: http://codereview.chromium.org/155707 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21102 0039d316-1c4b-4281-b951-d872f2087c98
* Pretend we're the default browser when xdg-settings fails.mdm@chromium.org2009-07-201-14/+15
| | | | | | | | | BUG=16981 TEST=use an unsupported desktop environment (like awesome) and start chrome; it should not ask about setting itself as the default Review URL: http://codereview.chromium.org/159086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21101 0039d316-1c4b-4281-b951-d872f2087c98
* Change GetAllLogins to GetAllBlacklistLogins.stuartmorgan@google.com2009-07-2013-88/+108
| | | | | | | | | BUG=none TEST=accessing the list of passwords and password blacklists should still work. Review URL: http://codereview.chromium.org/149778 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21100 0039d316-1c4b-4281-b951-d872f2087c98
* linux: remove unimplemented menu itemsevan@chromium.org2009-07-201-4/+12
| | | | | | Review URL: http://codereview.chromium.org/155786 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21099 0039d316-1c4b-4281-b951-d872f2087c98
* Update the nacl part of the gyp build so it works correctly for tests,gspencer@google.com2009-07-202-7/+6
| | | | | | | and so it doesn't have a hard-coded path to python... Review URL: http://codereview.chromium.org/159093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21098 0039d316-1c4b-4281-b951-d872f2087c98
* Linux sandbox: plumb timezone calls through the sandboxagl@chromium.org2009-07-203-1/+114
| | | | | | | | | | | | | | | | | | | | | The localtime (and localtime_r) functions try to access /etc/localtime in the filesystem. For sandboxed renderers, this fails, the the functions default to a UTC timezone. These functions are called from within WebCore and V8 and there's no clean way to patch the source code in place to do a hairpin turn and manage an IPC. Additionally, we cannot overwrite the calls with the usual symbol resolution procedures since the same chrome binary must serve as both the unsandboxed browser and sandboxed renderer. Thus we patch the GOT at runtime if we find, in the zygote process, that we are sandboxed. BUG=16800 TEST=Run javascript:alert(new Date().getTimezoneOffset()) in a sandboxed renderer. The resulting timezone offset (in minutes) should be correct for the local timezone. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21097 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Set the task manager scrolled window policy to GTK_POLICY_AUTOMATIC so ↵jhawkins@chromium.org2009-07-201-1/+1
| | | | | | | | | | that the task manager window is not resized when a page with a long title is viewed. BUG=17079 TEST=Open the task manager after navigating to a site with a long page title. The task manager window should not resize to fit the title. Review URL: http://codereview.chromium.org/159081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21096 0039d316-1c4b-4281-b951-d872f2087c98
* Adds timestamp to session restore for tabs and windows.arv@google.com2009-07-204-25/+176
| | | | | | | | | | BUG=13134 TEST=None Review URL: http://codereview.chromium.org/155609 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21095 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the popup notification is shown during animation.erg@chromium.org2009-07-201-1/+2
| | | | | | | | | | | (I don't see a call to hide between the first show and the animation, but this fixes it so it must be getting called...) http://crbug.com/14062 Review URL: http://codereview.chromium.org/155717 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21094 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: add use_system_ffmpeg GYP variable.agl@chromium.org2009-07-201-8/+19
| | | | | | | | | | | | | | | | | In r20548, we switched from using a shell script to copy the ffmpeg binaries to the output directory, to using the GYP 'copies' stanza. When built using Scons, any copies for which the source file was missing began to fail. Since Ubuntu policy (and size considerations) prohibit the shipping of the binaries in the source packages of chromium-browser, so add a GYP variable which can be set to inhibit this copying for cases where the source files aren't included. http://codereview.chromium.org/155791 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21093 0039d316-1c4b-4281-b951-d872f2087c98
* Add a simple "sidebar"-like panel container that will scroll.brettw@chromium.org2009-07-208-0/+514
| | | | | | | | This doesn't actually hold any panels at the moment, just dummy content. Review URL: http://codereview.chromium.org/155593 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21092 0039d316-1c4b-4281-b951-d872f2087c98
* Software volume adjustment by changing samples.fbarchard@chromium.org2009-07-206-27/+182
| | | | | | | | | BUG=16500 TEST=play youtube in different window. play another video with video tag and mute sound and make sure it does not affect youtube. Review URL: http://codereview.chromium.org/159092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21091 0039d316-1c4b-4281-b951-d872f2087c98
* Widen suppression to match error on bot.dkegel@google.com2009-07-201-1/+0
| | | | | | | | | BUG=16579 TEST=watch valgrind ui bots go green Review URL: http://codereview.chromium.org/159089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21090 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-20 02:55:27 +0000