| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/199095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/199092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25994 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Mac OS X 10.6 ("Snow Leopard")'s tar.
Review URL: http://codereview.chromium.org/194078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25993 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
action. Also makes the behavior in Windows side act the same as in Linux/Mac.
Patch by Thiago Farina <thiago.farina@gmail.com>
BUG=21461
TEST=open "clear browsing data" and see if none of buttons are set as default.
Code review URL: http://codereview.chromium.org/201080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25992 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= http://crbug.com/21170
TEST= Install a dark theme. Download something. Note that download progress bar is aesthetically pleasing.
Review URL: http://codereview.chromium.org/201095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25991 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
any function.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/196038
Patch from thiago.farina@gmail.com.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
and updated i18n.html with overview and example.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/199094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25989 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the background when the custom frame is off.
This is needed after http://codereview.chromium.org/193030 was checked in (which fixed a related bug on Windows).
We don't translate the x values because the tab renderer code
already takes the x offset into consideration.
TEST=Install the Color Chips theme from the theme gallery. The vertical white lines should line up on the inactive tabs.
Review URL: http://codereview.chromium.org/194080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25988 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removes WebFrame::reportFindInPageSelection since it was only
ever called by WebFrameImpl. Now it is a private method.
Removes WebViewDelegate::DownloadUrl since it can be expressed
using WebFrameClient::loadURLExternally.
R=dglazkov
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/201092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
create_string_rc.py actually creates.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/203031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
order to mimic what run-webkit-tests does.
Search "http/tests/local/" in http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/run-webkit-tests for what it does.
This is needed by http/tests/local/resources/send-dragged-file.js.
Turn on file URL universal access in the test_shell. Delete rebaseline results of those layout tests that pass due to this change. Also add a UI test to make sure it is not on for the browser.
BUG=9275,12882
TEST=none
Review URL: http://codereview.chromium.org/201048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/203030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/194036
Patch from thiago.farina@gmail.com.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The leak appears to been fixed. Cannot repro anymore.
TEST=valgrind ui bot should not show this
BUG=16628
Review URL: http://codereview.chromium.org/197058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25980 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=willchan
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/199096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Expand the regex used to test keys so "." is an allowed
character. Needed for perf ids like "mac-release-10.5".
BUG=18597
TEST=a perf_expectations dict with keys containing
"." passes presubmit tests
Review URL: http://codereview.chromium.org/194084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome\interactive_ui_tests_dll.vcproj
NO CODE CHANGE.
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=15494
TEST=browser_tests.exe --gtest_filter=ExtensionApiTest.Toolstrip
Review URL: http://codereview.chromium.org/203023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25976 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
[0911/072720:FATAL:/b/slave/chromium-dbg-linux-builder/build/src/base/at_exit.cc(40)] Check failed: false. Tried to RegisterCallback without
an AtExitManager
TBR=tony
BUG=none
TEST=crash
Review URL: http://codereview.chromium.org/194085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=9847
TEST=printing on linux should have right font in pdf
Patch contributed by Min-Yu Huang <minyu.huang@gmail.com>
Review URL: http://codereview.chromium.org/196071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
quite similar, this wasn't that much work.
BUG=none
TEST=make sure tabs behave correctly on windows, as well as testing
pinning/unpinning.
Review URL: http://codereview.chromium.org/193051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25973 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
permissions to that tab.
Cleaned up a few things along the way:
- added a GetExtension() method to
ExtensionFunctionDispatcher and ExtensionFunction since it
was used in more than one place.
- Removed first param from chrome.test.failCallback() since
it wasn't used anywhere.
- Added a convenience CanAccessHost() method to Extension,
since it seems likely to be commonly used.
- Refactored setup of mock host resolver in browsertest,
since the way it was, you could only customize it at the
testsuite level, not the test level.
Review URL: http://codereview.chromium.org/199074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25971 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Catch a crash for debug build users who followed the
Linux 64bit instructions.
BUG=21454
TEST=debug chrome crashes at NOTREACHED in error
condition using old NSS, skips past in new NSS and
under both conditions in release builds.
Review URL: http://codereview.chromium.org/201086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25969 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
temporary text.
This CL fixes issue 21362: The original text and selection can't be reverted correctly when pressing escape key in omnibox if currently selected line is not the default match.
BUG=21362: The original text and selection can't be reverted correctly when pressing escape key in omnibox if currently selected line is not the default match.
TEST=Input something in omnibox and make sure inline autocomplete is triggered, then press down to select another line, then press escape to revert to the default match and see of the original text and selection was reverted correctly.
Review URL: http://codereview.chromium.org/194056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
glue directly. Everything now goes through webkitclient.
This is the first step to be able to split webkit in its
own dll.
Review URL: http://codereview.chromium.org/196051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
probably shoudln't have been added in to begin with.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/203015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=21048
TEST=Open task manager and sort any column
Review URL: http://codereview.chromium.org/196040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=kathyw
Review URL: http://codereview.chromium.org/200091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=21531
TEST=use gtk theme, look at icons in task manager, bookmark bar, tab strip, change gtk theme with gnome-appearance-properties,note that the default favicons and folder icons have changed
Review URL: http://codereview.chromium.org/202055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
bottom of the screen, rather than the bottom of the text box.
BUG= http://crbug.com/21543
TEST= Install "Folders" theme. Open incognito window. Observe that NTP background looks the same as it doesn in normal mode.
Review URL: http://codereview.chromium.org/202056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=darin
Review URL: http://codereview.chromium.org/196088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the following case:
requested family: A
post_config_family: B
post_match_family: A
BUG=12530
TEST=none
Review URL: http://codereview.chromium.org/192062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implemented for Mac; behavior implicit on Windows.
If you do NOT get an "activate on launch" behavior on Windows, it is
because Selenium is not the current foreground app. See
http://msdn.microsoft.com/en-us/library/ms633539(VS.85).aspx
for details on foreground behavior. This isn't something we can fix
in Chrome on Windows.
BUG=http://crbug.com/20935
TEST=Launch Chrome from the command line.
E.g. "..../Chromium.app/Contents/MacOS/Chromium". See it NOT gain
foreground. Add --activate-on-launch. DO see it gain foreground.
Review URL: http://codereview.chromium.org/202053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
and how big it ends up being.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/193061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25957 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/194035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patches add a checkbox to the "Clear Browsing Data" dialog which
clears the STS state when checked. Since we don't timestamp our
entries (for now at least, should we?), the duration selected has no
effect: we always clear everything.
Mac doesn't appear to have a dialog for this yet, so no Mac specific
changes.
http://codereview.chromium.org/196070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=21506
TEST=Remove a thumbnail from the NTP and notice the color of the undo
link. The text should be dark blue with a lighter blue underline color.
Review URL: http://codereview.chromium.org/202052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25953 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The code in TestWebViewDelegate was unreachable.
R=dglazkov
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/193079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
experimentation.
Review URL: http://codereview.chromium.org/202049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=21170
TBR=thakis
Review URL: http://codereview.chromium.org/199089
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=21428
TEST=Open Options tab in locales de, cs, hr, ml and note there should be no truncation in any tab.
Review URL: http://codereview.chromium.org/200090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the latest jscompiler.
There were a few issues.
For some reason o3djs.math.matrix4 was not working
in ff3.0 when compiled. I spent about 8 hours trying
to reproduce the issue in a small case but had no luck.
I finally just tried changing original code and it work.
In the process of trying to figure that out I got the
latest jscompiler and found there were a bunch of other
problems with our js code which are now fixed.
Also found out I was incorrectly striping @o3dparameter
tags from our code in build_docs.py
Also, I learned that properties of objects are strings
when returned in an "in" statement as in
for (key in object)
key is a string regardless of what each key is in
object.
Review URL: http://codereview.chromium.org/200089
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
screen size. This works around a WM work around that causes
the popup to end up in full screen mode.
BUG=21456
TEST=Go to www.stonephotography.ca, click on enter site, verify that
the window is not in full screen mode (over taskbar).
Review URL: http://codereview.chromium.org/202050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25943 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=21492
Review URL: http://codereview.chromium.org/200088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
upstream WebKit patch.
BUG=20833
TEST=LayoutTests/editing/selection/click-in-margins-inside-editable-div.html, LayoutTests/editing/selection/click-in-padding-with-multiple-line-boxes.html
Review URL: http://codereview.chromium.org/199088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/200086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/202051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25938 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/199087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25936 0039d316-1c4b-4281-b951-d872f2087c98
|