summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Update valgrind suppressions.willchan@chromium.org2009-11-061-0/+26
| | | | | | | | BUG=26966 Review URL: http://codereview.chromium.org/371042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31319 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Defer close from renderer while tab is a drag source.shess@chromium.org2009-11-061-3/+12
| | | | | | | | | | | | When dragging a link out of web content, pin the tab so that it doesn't close out from under the drag. BUG=26134 TEST=See bug for test.html. View test.html. Dragging link out should cause page to not close, and app should no longer crash. Review URL: http://codereview.chromium.org/372023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31318 0039d316-1c4b-4281-b951-d872f2087c98
* Add View:Developer:JavaScript Console, bind to command-shift-Cmark@chromium.org2009-11-063-69/+743
| | | | | | | | | | | | | | This is the Mac equivalent of r31225, http://codereview.chromium.org/377005 BUG=none TEST=Command-shift-C and View:Developer:JavaScript Console should bring up the Developer Tools in console mode. Command-option-J and View:Developer:Developer Tools should show the Developer Tools window not in console mode. The menu items should be visible in View:Developer and in the Page menu under Developer. Review URL: http://codereview.chromium.org/377017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31317 0039d316-1c4b-4281-b951-d872f2087c98
* Adds hover and pressed states for the newtab button on the Mac.dmaclach@chromium.org2009-11-066-9/+3631
| | | | | | | | | | | | | | | | | | | | BrowserWindow.xib change was to add newtab_p as the image for the alternate state for the new tab button. BUG=26205 TEST=1) mouse over the new tab button and it should highlight. 2) Click and hold on the new tab button and its state should change 3) Release, and watch new tab get created. Verify that new button state changes appropriately 4) Create a full tab strip of tabs. Verify that button state stays correct as you click on the new tab button and new tabs are created but the button doesn't move. 5) Create 2 tabs, and move the mouse button into the newtab button. See that it highlights. hit cmd-w to close a tab. As the newtab button moves away from under the cursor make sure it loses its highlight. Review URL: http://codereview.chromium.org/372009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31316 0039d316-1c4b-4281-b951-d872f2087c98
* Open the extensions manager tab in single-tab-per-window mode.aa@chromium.org2009-11-062-9/+9
| | | | | | | Review URL: http://codereview.chromium.org/372016 Patch from Akira <akira@yayakoshi.net>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31315 0039d316-1c4b-4281-b951-d872f2087c98
* Document restrictions on integers in the version.kathyw@google.com2009-11-062-7/+21
| | | | | | | | | BUG=26957 TEST=none Review URL: http://codereview.chromium.org/371030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31314 0039d316-1c4b-4281-b951-d872f2087c98
* Commit from review 373017eseidel@google.com2009-11-064-52/+52
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31313 0039d316-1c4b-4281-b951-d872f2087c98
* Bulletproof the url going into a std::string and ensure it's not going topinkerton@chromium.org2009-11-061-5/+12
| | | | | | | | | be NULL, which throws and exception. BUG=26883 TEST=dragging things into the content area (urls, images, text, etc) Review URL: http://codereview.chromium.org/373016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31312 0039d316-1c4b-4281-b951-d872f2087c98
* Remove stale suppression.jorlow@chromium.org2009-11-061-7/+0
| | | | | | | | | TEST=none BUG=26326 Review URL: http://codereview.chromium.org/377012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31311 0039d316-1c4b-4281-b951-d872f2087c98
* Reenable tests that were disabled due to the epic flakyness of LocalStorage ↵jorlow@chromium.org2009-11-062-4/+2
| | | | | | | | | | | which has since been fixed. TEST=none BUG=25746 Review URL: http://codereview.chromium.org/377011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31310 0039d316-1c4b-4281-b951-d872f2087c98
* Added menu item for sync to wrench menu.akalin@chromium.org2009-11-064-4/+204
| | | | | | | | | | | | | | | Wrench menu item is right above "Preferences...". Chrome menu item will be added in a future CL right above "Clear Browsing Data...". Sync menu items are hidden if bookmark sync is disabled (the current default for OS X). UI decisions were made after consulting with Cole. Added code in browser_window_controller.mm to update sync menu item dynamically. Added unit tests. BUG=23073 TEST=manual testing, trybots, unittests Review URL: http://codereview.chromium.org/363017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31309 0039d316-1c4b-4281-b951-d872f2087c98
* Roll WebKit DEPS 50600:50603.levin@chromium.org2009-11-061-1/+1
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/372030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31308 0039d316-1c4b-4281-b951-d872f2087c98
* Set SDKROOT in the project-wide xcode_settings block instead of doing it inmark@chromium.org2009-11-061-1/+11
| | | | | | | | | | | | | target_defaults. This is equivalent to how Xcode sets SDKROOT from the Project Info window's General tab. Making this setting project-wide means that the selected SDK will show up properly in that UI. BUG=26976 TEST=Build still works. SDK (typically "Mac OS X 10.5") shows up in Project Info:General. Review URL: http://codereview.chromium.org/371035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31307 0039d316-1c4b-4281-b951-d872f2087c98
* Cancel unused timeout events. Without this change they candkegel@google.com2009-11-062-9/+14
| | | | | | | | | | | | | | accumulate for a while, wasting memory and causing unneeded wakeups. BUG=25641 TEST=green valgrind or heapchecker on net_unittests Previously reviewed as http://codereview.chromium.org/370005/ TBR=timurrrr Review URL: http://codereview.chromium.org/372033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31306 0039d316-1c4b-4281-b951-d872f2087c98
* Take3:mbelshe@google.com2009-11-068-362/+654
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rework the FlipProtocol to separate the Clike structs from the methods. Without this refactoring, we didn't have a clean way to allocate and deallocate FlipFrames. Now we can use the scoped_ptr cleanly. Summary of misc changes: * Merged in some small changes from the GFE side. * flip_protocol.h Changes substantially. We now have separate structs and classes. No longer can you cast from one frame type to another. All FlipFrame classes derive from FlipFrame. A FlipFrame owns a buffer which is used for the frame, and when you create the Frame, you can specify whether the FlipFrame will selfclean its buffer or not. This makes it cheap to instantiate a FlipFrame class on the stack and use it temporarily for accessing fields without having to do any copies or allocations. * You can't use sizeof(FlipFrame) anymore that is now a class. Added a static "size()" method to each FlipFrame type for declaring its real size. * Refactored a couple of routines in flip_framer. These were previously in a huge state machine (ProcessInput), just copied the code into subroutines. * Added flip_protocol_test to the mix from the gfe side. Much of this is a refactoring from flip_framer_test. * Eliminated reinterpret_casts as much as I could and got rid of all uses of scoped_array for FlipFrames. BUG=none TEST=all flip tests reworked Review URL: http://codereview.chromium.org/377014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31305 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a stupid mistake in updating test_expectations.txtjaphet@chromium.org2009-11-061-3/+1
| | | | | | | | | BUG=none TEST=none TBR=dglazkov git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31304 0039d316-1c4b-4281-b951-d872f2087c98
* Wires through didChangeScrollOffset so that it triggers saving contentsky@chromium.org2009-11-065-0/+15
| | | | | | | | | | | state. BUG=17220 TEST=none Review URL: http://codereview.chromium.org/373014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31303 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: provide a way for clients to detach and attach client hosts to ↵pfeldman@chromium.org2009-11-062-11/+57
| | | | | | | | | | render views. BUG=25287 Review URL: http://codereview.chromium.org/375011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31302 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Fix context menu positioning.estade@chromium.org2009-11-066-19/+52
| | | | | | | | | | There are still some issues with context menus. The context menu doesn't respect links, for example. That is, if you tab to a link and hit the menu button, it will act as if you right clicked on the upper left pixel of the web page (both in content and position of the menu). This seems to be a webkit bug/missing feature as safari 4 on windows does the same. However, some cases do work as expected, for example if you select text and hit the menu button. Anyway, I'll do the webkit side of this fix as some later patch. BUG=26811 Review URL: http://codereview.chromium.org/371033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31301 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build.thakis@chromium.org2009-11-061-0/+2
| | | | | | | | TBR=jcampan Review URL: http://codereview.chromium.org/372032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31300 0039d316-1c4b-4281-b951-d872f2087c98
* Support running memory watch under vista, plus other tweaksjar@chromium.org2009-11-067-107/+248
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This version of memory_watcher can run under Vista, even though the recursive calls that it handles are appearing often enough that there is a performance penalty. With this landed, it may be possible for other folks to run the tool, and I can work on improving its performance. This CL also resolves the problem with hanging processes. Although memory reporting can only be done once, and it leaves a pile of memory "hanging around," the browser can be cleanly exited. Tweaks include outputing the aggregate stacks such that the largest stacks appear at the start of the output file. This version avoids ongoing aggregation of stats in favor of only doing the aggregation at dump-time. This probably enhances performance at run-time, although it is hidden (on Vista) by the recursive calling. This also simplifies the tracking code a fair amount. There is some evidence that a small number of duplicate calls are being made to "track" the same memory region, without an intervening free (i.e., call to "untrack"). The code to better diagnose this is currently in place, but ifdef'ed, as it is only useful under a debugger. Exercise of this code (turning a stack-frame list into a human readable stack trace string) currently causes some corruption shortly after it triggers, so I can't leave it on full time. r=mbelshe Review URL: http://codereview.chromium.org/366031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31299 0039d316-1c4b-4281-b951-d872f2087c98
* Part 2 of string cleanup in Sync:munjal@chromium.org2009-11-0613-492/+386
| | | | | | | | | | | | | | | | | | - Get rid of sync_char16 from syncapi - Use wstring for title in syncapi since that gets converted to wstring later on anyway. - Use GURL for urls in syncapi - Return const string references from syncapi instead of pointers to C-style strings. - Make appropriate changes to calling code. BUG=26342 TEST=Already exist. Review URL: http://codereview.chromium.org/362019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31298 0039d316-1c4b-4281-b951-d872f2087c98
* Fix dummy plugin window update (Mac)stuartmorgan@chromium.org2009-11-061-6/+8
| | | | | | | | | | | Our dummy window needs to have its bounds updated if the size changes, even if the origin doesn't. BUG=25820 TEST=Mouse tracking should work in test cases from bug. Review URL: http://codereview.chromium.org/373015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31297 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Change find bar to use a floating container rather than some hacked up ↵estade@chromium.org2009-11-066-92/+87
| | | | | | | | | | | | | | | gtkfixed business. The straw that broke this camel's back was when I realized that showing the findbar in fullscreen mode would inescapably mean an extra 1 pixel border at the top. Also fix z-ordering problems for findbar that have been around since I introduced the floating bookmark bar (the fact that no one filed a bug on this suggests that it's not that noticeable). BUG=none TEST=find bar still works. find bar works in fullscreen. the toolbar bottom border still exists at all times. there are no z-ordering problems. the find bar still gets out of way of find results. Review URL: http://codereview.chromium.org/373007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31296 0039d316-1c4b-4281-b951-d872f2087c98
* Add another drag flavor for bookmark menu controller menu items.estade@chromium.org2009-11-061-2/+4
| | | | | | | | BUG=26835 Review URL: http://codereview.chromium.org/372003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31295 0039d316-1c4b-4281-b951-d872f2087c98
* Rename gtk_tree::ModelAdapter to TableAdapter in preparation for adding ↵mattm@chromium.org2009-11-0610-28/+28
| | | | | | | | | | | TreeAdapter. BUG=none TEST=none Review URL: http://codereview.chromium.org/374007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31293 0039d316-1c4b-4281-b951-d872f2087c98
* De-flakay mac test_expectations.japhet@chromium.org2009-11-061-58/+9
| | | | | | | | | | | | | | | BUG=23486 BUG=23472 BUG=23460 BUG=10448 BUG=18740 BUG=20898 BUG=24232 TEST=none Review URL: http://codereview.chromium.org/378017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31292 0039d316-1c4b-4281-b951-d872f2087c98
* Pipe cmd-z back to browser.thakis@chromium.org2009-11-061-5/+0
| | | | | | | | | | | Followup to http://codereview.chromium.org/355016 BUG=26735 TEST=Focus web, hit cmd-z. Should blink menu bar. Same for cmd-shift-z. Review URL: http://codereview.chromium.org/371031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31291 0039d316-1c4b-4281-b951-d872f2087c98
* Add in missing expectationsdpranke@google.com2009-11-061-1/+1
| | | | | | | | | | | | | | run_webkit_tests is now correctly reporting missing png's, but I forgot to account for them in test_expectations. There are probably a few other to follow. R=TBR BUG=26969 TEST=none Review URL: http://codereview.chromium.org/374018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31290 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 31284 - Added menu item for sync to wrench menu.willchan@chromium.org2009-11-064-202/+4
| | | | | | | | | | | | | | | | | | Wrench menu item is right above "Preferences...". Chrome menu item will be added in a future CL right above "Clear Browsing Data...". Sync menu items are hidden if bookmark sync is disabled (the current default for OS X). UI decisions were made after consulting with Cole. Added code in browser_window_controller.mm to update sync menu item dynamically. Added unit tests. BUG=23073 TEST=manual testing, trybots, unittests Review URL: http://codereview.chromium.org/363017 TBR=akalin@chromium.org Review URL: http://codereview.chromium.org/374017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31289 0039d316-1c4b-4281-b951-d872f2087c98
* Add in missing expectationsdpranke@google.com2009-11-061-0/+3
| | | | | | | | | | | | | run_webkit_tests is now correctly reporting missing png's, but I forgot to account for them in test_expectations. There are probably a few other to follow. R=TBR BUG=26969 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31288 0039d316-1c4b-4281-b951-d872f2087c98
* Send keypress() events for ctrl-key and cmd-key in addition to keydown().thakis@chromium.org2009-11-062-1/+27
| | | | | | | | | | | | | The ctrl-key behavior matches what Safari does: We first send a keydown for ctrl-key, and only if the key is not an emacs shortcut, we send a keypress. The cmd-key behavior is slightly different from Safari: Safari triggers menu items after the keypress command has not been swallowed by javascript. We trigger menu items after keydown. That means that if the user hits cmd-key, we send a keydown and only send a keypress if the shortcut doesn't trigger a menu item. Safari always sends both keydown and keypress. BUG=25249 TEST=Go to http://unixpapa.com/js/testkey.html . Hit ctrl-a, only a keydown should be generated. Hit ctrl-s, both keydown and keypress should be generated. Hit cmd-a, only a keydown should be generated. Hit cmd-shift-a, both keypress and keydown should be generated. Also, ctrl-1 now makes something a heading in google docs. Cmd-s and Cmd-f should still work in docs. Review URL: http://codereview.chromium.org/293019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31287 0039d316-1c4b-4281-b951-d872f2087c98
* Update linux valgrind suppressions.willchan@chromium.org2009-11-061-0/+26
| | | | | | | | BUG=26966 Review URL: http://codereview.chromium.org/371028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31286 0039d316-1c4b-4281-b951-d872f2087c98
* Extensions UI page should not allow Reload forextensions that are not 'in ↵finnur@chromium.org2009-11-066-10/+15
| | | | | | | | development' andshould not DCHECK when uninstalling a disabledextension.I also reordered the links on the page, now thatwe show the Reload link conditionally, sinceit is weird to enable extensions after this change.The order starts out as...Disable - Reload - Uninstall... then when you press Disable it becomes: Enable - Uninstallpress Enable, it becomes:Disable - Reload - UninstallNotice how the Reload link pops up where Enable linkwas and where you'd expect Disable to be?TEST=Open chrome://extensions and make sure extensionsloaded with --load-extension have the Reload optionand when you disable an extension it does not DCHECKin debug version of Chrome.BUG=http://crbug.com/26901, http://crbug.com/26910 Review URL: http://codereview.chromium.org/374014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31285 0039d316-1c4b-4281-b951-d872f2087c98
* Added menu item for sync to wrench menu.akalin@chromium.org2009-11-064-4/+202
| | | | | | | | | | | | | | | Wrench menu item is right above "Preferences...". Chrome menu item will be added in a future CL right above "Clear Browsing Data...". Sync menu items are hidden if bookmark sync is disabled (the current default for OS X). UI decisions were made after consulting with Cole. Added code in browser_window_controller.mm to update sync menu item dynamically. Added unit tests. BUG=23073 TEST=manual testing, trybots, unittests Review URL: http://codereview.chromium.org/363017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31284 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: show correct default favicon in tab strip.viettrungluu@chromium.org2009-11-062-3/+8
| | | | | | | | | | | We should show the "blank page" favicon for pages which don't have their own (this favicon is used everywhere else for this purpose), not the "globe" (nav.pdf) favicon. BUG=26953 TEST=Go to, e.g., "about:blank" and check the favicon in the tab in the tab strip. Review URL: http://codereview.chromium.org/373012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31283 0039d316-1c4b-4281-b951-d872f2087c98
* Modify rebaselining tool to also rebaseline IMAGE, IMAGE+TEXT, and TEXTdpranke@google.com2009-11-061-1/+4
| | | | | | | | | | | | failures. BUG=none R=victorw@chromium.org TEST=none Review URL: http://codereview.chromium.org/375008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31282 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 31277 - Take 2:willchan@chromium.org2009-11-068-654/+362
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rework the FlipProtocol to separate the Clike structs from the methods. Without this refactoring, we didn't have a clean way to allocate and deallocate FlipFrames. Now we can use the scoped_ptr cleanly. Summary of misc changes: * Merged in some small changes from the GFE side. * flip_protocol.h Changes substantially. We now have separate structs and classes. No longer can you cast from one frame type to another. All FlipFrame classes derive from FlipFrame. A FlipFrame owns a buffer which is used for the frame, and when you create the Frame, you can specify whether the FlipFrame will selfclean its buffer or not. This makes it cheap to instantiate a FlipFrame class on the stack and use it temporarily for accessing fields without having to do any copies or allocations. * You can't use sizeof(FlipFrame) anymore that is now a class. Added a static "size()" method to each FlipFrame type for declaring its real size. * Refactored a couple of routines in flip_framer. These were previously in a huge state machine (ProcessInput), just copied the code into subroutines. * Added flip_protocol_test to the mix from the gfe side. Much of this is a refactoring from flip_framer_test. * Eliminated reinterpret_casts as much as I could and got rid of all uses of scoped_array for FlipFrames. BUG=none TEST=all flip tests reworked Review URL: http://codereview.chromium.org/376012 TBR=mbelshe@google.com Review URL: http://codereview.chromium.org/371027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31281 0039d316-1c4b-4281-b951-d872f2087c98
* Add a mac valgrind suppression.willchan@chromium.org2009-11-061-0/+26
| | | | | | | | BUG=26964 Review URL: http://codereview.chromium.org/378018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31279 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 31266. threw asserts in test_shell on the bots.amanda@chromium.org2009-11-063-18/+141
| | | | | | Review URL: http://codereview.chromium.org/377013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31278 0039d316-1c4b-4281-b951-d872f2087c98
* Take 2:mbelshe@google.com2009-11-068-362/+654
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rework the FlipProtocol to separate the C-like structs from the methods. Without this refactoring, we didn't have a clean way to allocate and deallocate FlipFrames. Now we can use the scoped_ptr cleanly. Summary of misc changes: * Merged in some small changes from the GFE side. * flip_protocol.h Changes substantially. We now have separate structs and classes. No longer can you cast from one frame type to another. All FlipFrame classes derive from FlipFrame. A FlipFrame owns a buffer which is used for the frame, and when you create the Frame, you can specify whether the FlipFrame will self-clean its buffer or not. This makes it cheap to instantiate a FlipFrame class on the stack and use it temporarily for accessing fields without having to do any copies or allocations. * You can't use sizeof(FlipFrame) anymore - that is now a class. Added a static "size()" method to each FlipFrame type for declaring its real size. * Refactored a couple of routines in flip_framer. These were previously in a huge state machine (ProcessInput), just copied the code into subroutines. * Added flip_protocol_test to the mix from the gfe side. Much of this is a refactoring from flip_framer_test. * Eliminated reinterpret_casts as much as I could and got rid of all uses of scoped_array for FlipFrames. BUG=none TEST=all flip tests reworked Review URL: http://codereview.chromium.org/376012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31277 0039d316-1c4b-4281-b951-d872f2087c98
* Add flaky purify failures for unit_tests.exe.willchan@chromium.org2009-11-061-0/+72
| | | | | | Review URL: http://codereview.chromium.org/376013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31275 0039d316-1c4b-4281-b951-d872f2087c98
* Improve the display of LoadLogs when truncation occurs.eroman@chromium.org2009-11-0621-108/+180
| | | | | | | | | | | | | | Rather than drop all subsequent entries, we now preserve the final entry that was appended to the log. This way, even if entries have been dropped, we can still infer what the total time was, and what the exit condition was. Also makes LoadLog take the bound as a required parameter. BUG=none TEST=LoadLogUtilTest.DisplayOfTruncated Review URL: http://codereview.chromium.org/363025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31274 0039d316-1c4b-4281-b951-d872f2087c98
* Handle missing files more cleanly.dpranke@google.com2009-11-062-0/+2
| | | | | | | | | | | | | We weren't handling a missing .png's properly - they weren't getting reported as MISSING failures and the failure was basically getting swallowed. BUG=none TEST=none R=ojan@chromium.org Review URL: http://codereview.chromium.org/378016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31273 0039d316-1c4b-4281-b951-d872f2087c98
* Got rid of DieFileDie in user_settings_unittest.cc.idana@chromium.org2009-11-062-32/+49
| | | | | | | | | | | | It turns out that the v10 -> v11 database migration code had a bug where the destination file (SyncData.sqlite3) wasn't copied into the correct directory. I fixed that problem too. BUG=21834 Review URL: http://codereview.chromium.org/366011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31272 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash when GetOleInterface returns NULL. The replaced class, ↵jhawkins@chromium.org2009-11-061-2/+4
| | | | | | | | | | CComQIPtr, handles attaching to a NULL pointer, but ScopedComPtr does not, so check for a non-NULL ole_interface before calling QueryFrom. BUG=22829 TEST=none Review URL: http://codereview.chromium.org/374012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31271 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for a renderer crasher related to password autofill.jcampan@chromium.org2009-11-061-0/+8
| | | | | | | | | | | | | In some cases it seems we have no frame for the text node getting the autofill user selection. Not sure how it can happen. See bug comments for more info. BUG=26168 TEST=Make sure password and form autofill still work as expected. Review URL: http://codereview.chromium.org/378014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31270 0039d316-1c4b-4281-b951-d872f2087c98
* Use GetSwitchValueASCII.tony@chromium.org2009-11-0619-88/+86
| | | | | | | | | | | | BUG=24672 TEST=None Original patch by Thiago Farina <thiago.farina@gmail.com> at http://codereview.chromium.org/296004 Review URL: http://codereview.chromium.org/373013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31269 0039d316-1c4b-4281-b951-d872f2087c98
* Another regression from r31031: Fix RWHV sizing in extension popups.tony@chromium.org2009-11-061-0/+1
| | | | | | | | | | | Without this call, the RWH didn't actually change size and was always 0x0. BUG=26927 Review URL: http://codereview.chromium.org/376011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31268 0039d316-1c4b-4281-b951-d872f2087c98
* Add some instrumentation to SystemHostResolverProc() to capture the hostname ↵eroman@chromium.org2009-11-061-1/+20
| | | | | | | | | | | | when getaddrinfo() crashes. This may help understand why we are seeing crashes in getaddrinfo() in the field. BUG=22083 Review URL: http://codereview.chromium.org/378011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31267 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-22 16:06:12 +0000