| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It returned a wstring, when really we wanted the native encoded
strings. Fixing the majority of callers actually simplified them
in many cases because the callers wanted native strings too.
Since I'm touching every caller, I gave it a more useful name.
I'm not sure where "loose" came from but it never made sense to me.
BUG=24672
Review URL: http://codereview.chromium.org/3028010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53193 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:4727
TEST=None
Review URL: http://codereview.chromium.org/2858061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53192 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=48987
Review URL: http://codereview.chromium.org/3010018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53191 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
destructors from classes with instance members of type
scoped_ptr_malloc<>
Also remove #include of iostream from remaining header file.
Review URL: http://codereview.chromium.org/2861065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53190 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
WM will resize the window to fullscreen.
BUG=4399
TEST=none
Review URL: http://codereview.chromium.org/3019013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53189 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
started through ShellExecute (with a switch argument terminator).
BUG=46182
TEST=Launch Chrome on Windows by double clicking on a .htm file. Wait for Chrome to be upgraded in the background, select Update Chrome from Wrench menu and make sure your session is properly restored (even if Restore Last Session is not set).
Review URL: http://codereview.chromium.org/2868063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53188 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
changed IsFocusable to check IsVisibleInRootView. This meant that any
views (like label) whose preferred size takes into account focusable
and cached the preferred size before they were visible in the root
view would end up with the wrong size because they didn't recalculate
when IsVisibleInRootView changed.
I've separated out the two states so that IsFocusable no longer checks
IsVisibleInRootView and is protected. All consumers now call
IsFocusableInRootView which checks IsFocusable and
IsVisibleInRootView.
BUG=49635
TEST=see bug.
Review URL: http://codereview.chromium.org/3046008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=danno@chromium.org
Review URL: http://codereview.chromium.org/3020018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
menu.
This avoids doing work from within the menu's nested run loop, which can lead to
wonky behavior.
BUG=49716
TEST=Enter full screen from Wrench menu a few times. The overlay always appears.
Review URL: http://codereview.chromium.org/3014021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53185 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Originally, it was a vector of pair<domain_string, CanonicalCookie>.
TEST=Refactor; all relevant unit tests should still pass.
BUG=8850
Review URL: http://codereview.chromium.org/2799057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53184 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Navigate to https://encrypted.google.com. Click the green padlock in the URL bar. Click "Certificate Information". Verify that a SHA-256 hash appears.
http://codereview.chromium.org/3005016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/49370
TEST=as in bug
Review URL: http://codereview.chromium.org/3047005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
(aka: agl's an idiot. Thanks Julien.)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Switch to the new preference value source checkers in Preference. While at it,
add a unit test and better test infrastructure for controlling preference
values in tests. Convert existing unit tests where appropriate.
BUG=48952
TEST=ProfileSyncServicePreferenceTest.ManagedPreferences
Review URL: http://codereview.chromium.org/3051001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is needed for code at http://code.google.com/p/page-speed/source/browse/bin/trunk/src/pagespeed/pagespeed_input_populator.cc#148
Contributed by: bmcquade@google.com
BUG=48192
TEST=Added new unit tests, ran net_unittests.
Review URL: http://codereview.chromium.org/2849041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53178 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I've guarded all chromium-os specific stuff at register_page_ui.cc with ifdef.
Original CL description:
Add getUserInfo, getRegistrationUrl message callback for register screen.
Restrict chrome://register to OOBE wizard only.
Actually delete about:register.
BUG= http://crosbug.com/4813
TEST=none
Review URL: http://codereview.chromium.org/2825057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53177 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
unit tests.
Review URL: http://codereview.chromium.org/3057001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Don't start up the connection if we're only requesting active engines.
BUG=chromium-os:4244
TEST=Enable ibus-chewing. Change the number of candidates to 8. Kill ibus-daemon. Go to a text window and enable ibus-chewing. type "hol" and press space. Check that 8 candidates show up.
Review URL: http://codereview.chromium.org/2877016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I've come across some feeds that append (a sometimes invalid) HTML/script below a valid RSS feed, which trips up the XMLHTTPRequest object (responseXML becomes NULL). I've changed it so that if the XML document returned by responseXML is null we try to DOMparse responseText instead and we don't abort if there is an error (unless the doc is still empty). This will at least show partial feed data instead of 'invalid feed' error (and show full feed data if the syntax error is below the feed).
BUG=None
TEST=Covered by automated test.
Review URL: http://codereview.chromium.org/3031014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=49307
TEST=none
TBR=tyoshino
Review URL: http://codereview.chromium.org/3037013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53167 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=49756
TBR=thestig
TEST=TSan/Win bot should become green
Review URL: http://codereview.chromium.org/3031017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=48980
TEST=none
TBR=stuartmorgan
Review URL: http://codereview.chromium.org/3018012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53165 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
link again.
BUG=28072
TEST=none
TBR=stuartmorgan
Review URL: http://codereview.chromium.org/2806065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=49590
TEST=none
TBR=hbono
Review URL: http://codereview.chromium.org/3033016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This includes user-visible info about the following types of infobars:
- ConfirmInfoBarDelegate (includes ThemeInstalledInfoBarDelegate & CrashedExtensionInfoBarDelegate)
- AlertInfoBarDelegate
- LinkInfoBarDelegate
- TranslateInfoBarDelegate
Adds a test to verify crash infobar when a (flash) plugin dies.
Review URL: http://codereview.chromium.org/2305001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=49750
TEST=none
TBR=jochen
Review URL: http://codereview.chromium.org/2808057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53160 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=49648
TEST=TwoClientLiveAutofillSyncTest.ProfileSteady
Review URL: http://codereview.chromium.org/3029017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53159 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=20653
TEST=none
TBR=stuartmorgan
Review URL: http://codereview.chromium.org/3013022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=46886
TEST=none
TBR=stuartmorgan
Review URL: http://codereview.chromium.org/3040012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53156 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Even though the file is tiny, we should read it on the FILE thread and not the UI thread.
BUG=None
TEST=unit tests, put onto a device and verify that online, offline and localaccount logins all work.
Review URL: http://codereview.chromium.org/2873051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=This has actually been running "in production" for a while, just never got submitted.
The gclient failures of this past week on chromecoverity-Windows prove this works right.
Review URL: http://codereview.chromium.org/3042011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53154 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
various purposes. This CL implements some helper functions that we'll use to generate this key and store the halves in the places we need them.
BUG=chromium-os:4485
TEST=unit tests
Review URL: http://codereview.chromium.org/2891001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=27687, 28928
TEST=DownloadManagerTest.DownloadRenameTest
Review URL: http://codereview.chromium.org/2877008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Dismiss all non sticky when the panel is closed.
BUG=chromium-os:4771, chromium-os:3847
TEST=added new TestCloseDissmissAllNonSticky test
Review URL: http://codereview.chromium.org/3029006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Relanding issue 2819046
BUG=48883
TEST=Exercise Personal Stuff page via --enable-tabbed-options
Review URL: http://codereview.chromium.org/3042005
TBR=csilv@chromium.org
Review URL: http://codereview.chromium.org/3044014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53147 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3035010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TBR=sargrass
TEST=bots go green
Review URL: http://codereview.chromium.org/3012014
TBR=csilv@chromium.org
Review URL: http://codereview.chromium.org/3015013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53145 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
browser.custom_chrome_frame for now).
BUG=none
TBR=sargrass
TEST=bots go green
Review URL: http://codereview.chromium.org/3017015
TBR=csilv@chromium.org
Review URL: http://codereview.chromium.org/3025007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=trybots
Signed-off-by: Thiago Farina <tfarina@chromium.org>
Review URL: http://codereview.chromium.org/2847058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=44090
TEST=none
TBR=stuartmorgan
Review URL: http://codereview.chromium.org/3029016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=49268
TEST=none
TBR=stuartmorgan
Review URL: http://codereview.chromium.org/2884031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix for ethernet not getting detected in login screen
Old version would always chose the last available
ethernet service in the list. This change makes it
so it chooses a connected service over a unconnected
service.
BUG=None
TEST=Ran browser with this change
Review URL: http://codereview.chromium.org/3027015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/42028
TEST=Scroll. See scroll. See scroll faster.
Review URL: http://codereview.chromium.org/3030008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/49638
TEST=green tree
Review URL: http://codereview.chromium.org/2878041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is a first step to make test server easier to use
and more reliable.
TEST=none
BUG=49680
Review URL: http://codereview.chromium.org/3040011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TBR=sargrass
TEST=bots go green
Review URL: http://codereview.chromium.org/3017015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=46666
TEST=none
TBR=maruel
Review URL: http://codereview.chromium.org/2861070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=stuartmorgan
Review URL: http://codereview.chromium.org/2856052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53131 0039d316-1c4b-4281-b951-d872f2087c98
|