| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Start / stop profiling commands are now sent using debugger protocol,
effectively breaking into script execution. Getting profiler log and
active modules is executed on IO thread.
BUG=28689
TEST=none
Review URL: http://codereview.chromium.org/460018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/466068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34039 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
types observed at NPP_HandleEvent.
Review URL: http://codereview.chromium.org/465110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
allows the caller to specify the behaviour of the window focus when the pop-up is displayed.
I added a test for the new parameter in the ExtensionApiTest.FLAKY_Popup test. I also corrected a truncated string in the unit-test.
Because the pop-up actually uses two windows, I had to change the WidgetWin::Show() routine to also reposition the window at the top. If a window is shown and activated, it is automatically brought to the front. Because we don't activate the pop-up when we want to keep the focus in the current extension view, I had to bring it to the front so that it wouldn't be hidden behind the 'chrome-bubble' window.
BUG=none
TEST=ExtensionApiTest.FLAKY_Popup
Review URL: http://codereview.chromium.org/454019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
* Don't use LOG/CHECK. Replace with RAW_LOG/DCHECK (newly added to logging.h)
* Don't directly post a task to the UI loop. Write to a magic pipe. Read this from a separate thread which will post to a task to the UI loop.
BUG=http://crbug.com/29240
Review URL: http://codereview.chromium.org/460094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The key point is to provide correct unmodifiedText field for fabricated Char events, because in webkit, unmodifiedText is used for matching accesskey.
BUG=23221
TEST=See bug report.
Review URL: http://codereview.chromium.org/460105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/460132
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
render surface.
Review URL: http://codereview.chromium.org/469011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Roll deps for FFmpeg to pull in changes to build on ARM.
Review URL: http://codereview.chromium.org/470004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34031 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Use DISALLOW_COPY_AND_ASSIGN instead.
Patch contributed by Thiago Farina
Review URL: http://codereview.chromium.org/460087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/464064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34029 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
have access to google.httpd_utils. Turns out we didn't really need
to use it anyways. Just using urllib directly.
Review URL: http://codereview.chromium.org/466061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Part 1."
Original CL: http://codereview.chromium.org/400018/show
Looks like we're no longer hoping to get this approach into mstone4 release, so I'm unwinding this.
BUG=27431
TBR=aa
Review URL: http://codereview.chromium.org/467042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23570,21640
TEST=Chromium-->Preferences-->Manage. (1) See "Default" group. (2) Add an engine and it appears under an "Other" group header. (3) Make that new engine default and it moves under the "Default" group and the "Other" header disappears.
Review URL: http://codereview.chromium.org/466022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Fixed some failing tests resulting from size of command field.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/465099
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=28038,29193
TEST=on any XP box this should pass: chrome_frame_test.exe --gtest_filter=*CFInstall*
Review URL: http://codereview.chromium.org/469012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
(since tests are run one at a time) we need to delete it before we
begin on Windows.
Review URL: http://codereview.chromium.org/460129
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Change the URL for real player to
http://forms.real.com/real/realone/download.html?type=rpsp_us
2. Add divX as the handler for previously undefined mime-types:
video/divx
video/x-matroska
R= ananta
BUG= http://b/2200313
TEST= uninstall divx and/or realPlayer. Visit pages that use their plugins.
Make sure Chrome offers to install.
Review URL: http://codereview.chromium.org/466062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34018 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=michaeln
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/469015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- wire the flavor (as promised)
- two experiment groups (one gets a welcome back url the other does not)
BUG=none
TEST=see twiki/bin/view/Main/ChromeAttritionExperiments for instructions
Review URL: http://codereview.chromium.org/470002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34015 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
new unit test.
TBR=cpu
TEST=unit test included
BUG=19374
Review URL: http://codereview.chromium.org/450037
Review URL: http://codereview.chromium.org/460128
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34014 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
call FindPreference directly.
BUG=None
TEST=compiles and passes existing tests
Original patch by Thiago Farina <thiago.farina@gmail.com> at
http://codereview.chromium.org/460117/show
Review URL: http://codereview.chromium.org/463044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is required for supporting NaCl on 64-bit Windows
TEST=none
BUG=28176
Review URL: http://codereview.chromium.org/460083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34009 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=kuchhal
TEST=unit test included
BUG=19374
Review URL: http://codereview.chromium.org/450037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34008 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Originally committed in r33997, still causing red on
vista interactive perf.
BUG=28968
TEST=tab switching test is disabled
TBR=ben
Review URL: http://codereview.chromium.org/467041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34007 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=29470
TEST=layout test try servers
Review URL: http://codereview.chromium.org/469007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and use it on Linux.
TODO: persist the order of buttons
TODO: use the model on windows, mac
TODO: let the view change the order of buttons
My plan for persisting the order is just to write/read a simple text file to/from disk, one extension id per line. Similar to the bookmark model, except that is structured data (because they try to hold more information).
BUG=26990
Review URL: http://codereview.chromium.org/462026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/470003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34004 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=gregoryd
Review URL: http://codereview.chromium.org/460027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We reset the idle timer after any activity, which includes an extension event
or message, or a new extension view being created. The timer runs after 10
seconds of idleness.
BUG=29329
Review URL: http://codereview.chromium.org/460062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
These test results are not that unexpected, the test
just needs to be reset and variance increased.
BUG=none
TEST=vista intl1 and morejs are green
Review URL: http://codereview.chromium.org/467040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/460113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=25859
TEST=unittests
Review URL: http://codereview.chromium.org/465087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33999 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/464062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Disabled in r33278 but works locally for me. Need to
re-enable to test if it is still failing on the slaves.
BUG=28968
TEST=tab switching test runs on slaves
Review URL: http://codereview.chromium.org/466060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Patch from Thiago Farina <thiago.farina@gmail.com>
Original review: http://codereview.chromium.org/465004
BUG=5027
TEST=None
Review URL: http://codereview.chromium.org/460121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33996 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
contains, which can be anything. Assert the type of subjectAltName
we're trying to find.
R=avi
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/464026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Updated test expectations.
TBR=michaeln@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/464063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33994 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This should make diagnosing OOM crashes a lot easier.
TEST=manually force OOM, check the stack
BUG=29351
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33878 (reverted at 33879)
Review URL: http://codereview.chromium.org/462030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33993 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This reverts r33990 due to compile failure on linux ChromeOS.
Review URL: http://codereview.chromium.org/466059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33992 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
which should improve test reliability.
Make running the Chrome Frame integration tests slightly less onerous by not killing non-ChromeFrame instances of Chrome.
BUG=All chrome.exe instances would die when running these tests, which made them annoying to run.
TEST=Only Chrome Frame instances of Chrome will be killed when running the integration tests.
Review URL: http://codereview.chromium.org/467036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33991 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is required for supporting NaCl on 64-bit Windows
TEST=none
BUG=28176
Review URL: http://codereview.chromium.org/460083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
device types. Implement a stub of the 3D device API. Fix style in some of the
plugin related code.
TEST=run the pepper_test_plugin
BUG=none
Review URL: http://codereview.chromium.org/468012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33989 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
ipc and ipc_win64 targets are now defined in ipc.gypi and share most of the settings.
TEST=none
BUG=28176
Review URL: http://codereview.chromium.org/466028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33988 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
base::GetProcId() was previously not threadsafe since it relied upon threads observing reads between two different static variables in the same order that they were written without any explicit synchronization. This probably is responsible for a small number of our startup crashes (http://crash/search?query=product:%22Chrome%22+base::GetProcIdViaGetProcessId). This fixes the race by dropping w2k support and directly calling the function.
TEST=start up without crashing
BUG=none
Review URL: http://codereview.chromium.org/460063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
line of a continuation has 0 length.
BUG=29322
TEST=ftp://sourceware.org works.
Review URL: http://codereview.chromium.org/467032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
during login. This happens because on Chrome OS we start the WM and
Chrome at the same time, which means it's possiblef for us not to be
able to get the name of the window manager. I've changed the code to
assume that if we can't get the name of the window manager we're on
Chrome OS. This isn't perfect. Hopefully once the WM tells us we're
maximized before we're shown we can do away with this code.
BUG=ChromeOS bug 929
TEST=none
Review URL: http://codereview.chromium.org/463042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A DamageRects change sped up some dhtml performance
tests. Other tests require a wider variance to avoid
false alerts.
BUG=none
TEST=tests are green
Review URL: http://codereview.chromium.org/460115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of SIGTERM to avoid getting nonzero exit codes when shutting down
lighttpd.
Also, remove some unnecessary sleep calls and share the code that waits
until the server is up between Apache and lighttpd scripts.
Review URL: http://codereview.chromium.org/463039
TBR=ojan@chromium.org
Review URL: http://codereview.chromium.org/467039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33983 0039d316-1c4b-4281-b951-d872f2087c98
|