| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
Crash was due the final Release() called from inside message handler.
Additionally prevent invoking member functions of invalid/old chrome_frame_delegate_.
Still have a race acessing url_fetcher_ though.
BUG=35556
Review URL: http://codereview.chromium.org/825005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41290 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
associated tests.
This is in preparation for squelching false positive crash reports during DLL load.
BUG=31980
TEST=Unittests in this change.
Review URL: http://codereview.chromium.org/882001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41289 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(it is crashing and causing tree failures even though it is marked
as crashing).
BUG=37869
TEST=Modifying test expectations.
TBR=dpranke
Review URL: http://codereview.chromium.org/839004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=37962
TEST=Disabling tests
TBR=dglazkov
Review URL: http://codereview.chromium.org/869003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
See https://bugs.webkit.org/show_bug.cgi?id=35920 for the webkit side.
TEST=http/tests/security/no-referrer.html
BUG=none
Review URL: http://codereview.chromium.org/884001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This has had a few tests crash on the bots, so its starting out flaky/bad.
BUG=None
TEST=New unit tests, tree should stay green after this checkin.
Review URL: http://codereview.chromium.org/669276
TBR=jeremy@chromium.org
Review URL: http://codereview.chromium.org/885001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41284 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
we don't strictly need it.
BUG=http://code.google.com/p/chromium/issues/detail?id=37199
TEST=none
Review URL: http://codereview.chromium.org/838003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41283 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=29424
TEST=Disabling JavascriptAlertActivatesTab.
TBR=pamg
Review URL: http://codereview.chromium.org/866004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41282 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
callers can issue fine-grained Cancel() for individual tasks
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/802004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41279 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is the first of hopefully only two changes to improve our error handling situation. This change changes the way we use OnUnrecoverableError -- previously this was called whenever there was some kind of error in the MA or CP, but now it is only used for asynchronous errors. It has been removed from synchronous methods in favor of boolean return values to report errors. This simplifies some of the error handling.
The next step is to make sure asynchronous usage of OnUnrecoverableError actually works as it should.
Review URL: http://codereview.chromium.org/778002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41278 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41277 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- I put the dev library in the runtime section,
- I missed the runtime library (libdbus-glib-1-2) altogether
- These issues were masked as apt-get couldn't resolve lib32readline-dev
replacing it with lib32readline6-dev appears to solve this.
BUG=http://crbug.com/37199
TEST=none
Review URL: http://codereview.chromium.org/811007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41276 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously we would allocate memory in the child process. However, the
allocation might have happened while the malloc lock was held,
resulting in a deadlock.
This patch removes allocation from the child but probably makes Mac's
startup time slower until a Mac person can implement
dir_reader_posix.h.
TEST=Unittest for new code
BUG=36678
http://codereview.chromium.org/672003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41275 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=New unit tests, tree should stay green after this checkin.
Review URL: http://codereview.chromium.org/669276
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
crashiness.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/841002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41273 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/37853
TEST=none
Review URL: http://codereview.chromium.org/853003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41266 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41264 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change pulls the new Russian dictionary, landed as r41000 <http://codereview.chromium.org/545078>.
TBR=jshin
BUG=8397
TEST=<http://codereview.chromium.org/661460>
Review URL: http://codereview.chromium.org/863001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41262 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also clean up the code a bit.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/782004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41261 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
As of now if using buffers of sizes < 2K one can get 0 number of read bytes
if string cannot fit the buffer (string are splitted if they are longer than 2K).
Review URL: http://codereview.chromium.org/832001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Build broke by commit for http://codereview.chromium.org/790001. Revision 41252.
BUG=None
Test=None
Review URL: http://codereview.chromium.org/869001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the missing draggingSourceOperationMask method to the FakeBookmarkDraggingInfo class.
Broke by commit for http://codereview.chromium.org/790001.
Revision 41252.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/860002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41253 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=35969
TEST=Hold down the <option> key while dragging a bookmark to a new location. Repeat with the following: 1) From bookmark bar to bookmark bar, 2) from bookmark bar into a folder, 3) from within a folder to a different place within the same folder, 4) from within a folder to the bookmark bar, 5) from within a folder to a different folder. Check to insure that the original bookmark (and its contents if it was a folder) are in both the original location and the new location.
Review URL: http://codereview.chromium.org/790001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
For now, it does nothing, but we'll add code for the table in the
subsequent changes.
TEST=manually
BUG=none
Review URL: http://codereview.chromium.org/807002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/850001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
folder closes. This matches the effect when finishing dragging a button.
BUG=None
TEST=Go fullscreen. Omnibox should not have focus. Open a folder on the bookmarkbar and hover over one of its subentries. Overlay should not scroll back up. Dismiss the overlay. Overlay should animate out, not disappear instantly.
Review URL: http://codereview.chromium.org/803002
TBR=rohitrao@chromium.org
Review URL: http://codereview.chromium.org/854002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
after a crash.
BUG=20909
TEST=Start chrome, load some pages/tabs, move the window somewhere else. Click away and back to the window (to trigger saving window position). Kill chrome (you may have to use kill -9 to actually kill it uncleanly). Restart, click to restore pages. Window should jump to where it was before the crash.
Review URL: http://codereview.chromium.org/660395
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41248 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Committing on behalf of jschuh@google.com
BUG=37383
TEST=None
R=dpranke@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This matches the effect when finishing dragging a button.
BUG=None
TEST=Go fullscreen. Omnibox should not have focus. Open a folder on the bookmarkbar and hover over one of its subentries. Overlay should not scroll back up. Dismiss the overlay. Overlay should animate out, not disappear instantly.
Review URL: http://codereview.chromium.org/803002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This can pollute the log since it gets hit often (each time poll for checks).
BUG=none
Review URL: http://codereview.chromium.org/781001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41243 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
new-run-webkit-tests infrastructure.
The code now runs but it fails several unit tests since we now tack a newline
onto the end of the expectations string. I'll let Ojan deal with that.
BUG=none
TEST=update_expectations_from_dashboard_unittest
R=ojan@chromium.org
Review URL: http://codereview.chromium.org/812006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=37896
TEST=fast/text/firstline/001.html
TBR=japhet@chromium.org
Review URL: http://codereview.chromium.org/852002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=55822
R=japhet@chromium.org
TEST=none
Review URL: http://codereview.chromium.org/854001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41240 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/790007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This gets rid of third_party references in webkit_resources.grd which will allow us to build this file upstream.
Review URL: http://codereview.chromium.org/792005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=japhet@chromium.org
Review URL: http://codereview.chromium.org/851001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41237 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
it can be loaded into a tab. Originally it was only copied to the build directories resources folder.
The broken key issue still exists but if you manually add a good key this works fine.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=41098
Review URL: http://codereview.chromium.org/775001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
wrapper over the real tool in src/third_party/WebKit/WebKitTools/Scripts/
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/781003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=jianli
Review URL: http://codereview.chromium.org/795005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
model by rendering offscreen, reading back the frame buffer, and
drawing the rendering results into the CGContextRef.
This code path is currently Chrome-specific, but could be used for any
browser with similar characteristics. This will require refactoring of
the drawing and event model selection code, which may be done in a
subsequent bug.
Changed the RenderSurface APIs to allow the Bitmap for readback to be
passed in. Added Client::SetOffscreenRenderingSurfaces so that the
entry point Client::RenderClient() can be used unchanged.
Fixed problem with plugin_enable_fullscreen_msg gyp variable which
needs to be in top-level gypi so #define is consistent throughout
project. Fixed minor issue in Cocoa key event handling. Fixed log
message causing crashes when render target attachment fails.
Chrome currently blacklists the O3D plugin's MIME type, so to enable
support for O3D this blacklist entry needs to be removed from Chrome.
Ran nearly all O3D samples in Chrome on Mac OS X. There are a couple
of failures which will be fixed in subsequent bugs. Also ran samples
in Safari and Firefox on Mac and verified no performance regressions.
BUG=http://code.google.com/p/o3d/issues/detail?id=215
TEST=ran O3D samples in Chrome, Safari and Firefox
Review URL: http://codereview.chromium.org/669220
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=37896
TBR=dglazkov@chromium.org
TEST=none
Review URL: http://codereview.chromium.org/843001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TBR=victorw@chromium.org
TEST=bots stay green
Review URL: http://codereview.chromium.org/837001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
resized. This is used to close the AutoFill popup in the renderer.
BUG=31865
TEST=none
Review URL: http://codereview.chromium.org/805006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the fadeout animation to prevent the window object from leaking.
BUG=37717
TEST=none
Review URL: http://codereview.chromium.org/822007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/799007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
People not using my new code will be unaffected, but this change makes it so the new stuff works again.
Review URL: http://codereview.chromium.org/826003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
allow ID = 0 to make it through to the glBindXXX
functions.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/783002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=37895
TBR=dglazkov
TEST=none
Review URL: http://codereview.chromium.org/784003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
buffers.
I mostly just copied the macros from O3D and make sure it compiled using our own GLES2 emu backend. It should theoretically compile on real native GLES2 but the setup in service/gles2_cmd_decoder.cc needs work.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/799002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41224 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
handle offline login.
TEST=Unittests, and also run on chromium OS device with --in-chrome-auth
Review URL: http://codereview.chromium.org/822006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41223 0039d316-1c4b-4281-b951-d872f2087c98
|