summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Attempt to fix the Linux Views and ChromiumOS builds following r38658.mark@chromium.org2010-02-106-11/+11
| | | | | | | | | | | | | chrome/browser/views/tab_contents/render_view_context_menu_win.cc appears to be a views file, not a Windows file, so why is it named with _win.cc? This is a speculative change. BUG=none TEST=Linux Builder (Views dbg) and Linux Builder (ChromiumOS) compile steps turn green Review URL: http://codereview.chromium.org/596040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38669 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to fix the Linux Views and ChromiumOS builds following r38658.mark@chromium.org2010-02-101-2/+2
| | | | | | | | | | | | | | | chrome/browser/views/tab_contents/render_view_context_menu_win.cc appears to be a views file, not a Windows file, so why is it named with _win.cc? This is a speculative change. It may not work, in which case the file will need to be renamed. BUG=none TEST=Linux Builder (Views dbg) and Linux Builder (ChromiumOS) compile steps turn green Review URL: http://codereview.chromium.org/598042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38667 0039d316-1c4b-4281-b951-d872f2087c98
* Better alignment for Star button and location bar.avayvod@chromium.org2010-02-101-3/+7
| | | | | | | | | BUG=none TEST=Toggle compact location bar. Star button should be now aligned with Reload button, not be above it. Review URL: http://codereview.chromium.org/601012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38666 0039d316-1c4b-4281-b951-d872f2087c98
* base::SharedMemory does not set the size in other than the creatingsehr@google.com2010-02-103-3/+16
| | | | | | | | process. Create an API to get the size of the audio shared memory region. Review URL: http://codereview.chromium.org/596038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38665 0039d316-1c4b-4281-b951-d872f2087c98
* Include test_shell.gypi in webkit.gyp instead of maintaining a distinctmark@chromium.org2010-02-107-77/+90
| | | | | | | | | | | | | | | | | | test_shell.gyp. This allows the removal of webkit.gyp:pull_in_test_shell, eliminating the circular relationship between webkit.gyp and test_shell.gyp. The expected semantics of building all of test_shell during a webkit.gyp:All build is performed are retained. This change depends on GYP r781 (in Chromium at r38526) for GYP suffix operator path section treatment. It also depends on Chromium r38519 and r38658 for common.gypi treatment of chromium_code. BUG=33186 TEST=Xcode no longer holds stale project files in memory Review URL: http://codereview.chromium.org/602006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38664 0039d316-1c4b-4281-b951-d872f2087c98
* Update test expectations according to reality.dglazkov@chromium.org2010-02-101-17/+2
| | | | | | | | | | TBR=zork TEST=none BUG=many Review URL: http://codereview.chromium.org/593044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38663 0039d316-1c4b-4281-b951-d872f2087c98
* Per brakowski, the cookie prompt default should be "remember" and not "ask".pkasting@chromium.org2010-02-101-1/+1
| | | | | | | | BUG=none TEST=Turn on cookie prompting. The prompt default should be "remember". Review URL: http://codereview.chromium.org/593043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38661 0039d316-1c4b-4281-b951-d872f2087c98
* Check-in a script to visualize the host resolver traces.eroman@chromium.org2010-02-104-0/+527
| | | | | | Review URL: http://codereview.chromium.org/578026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38659 0039d316-1c4b-4281-b951-d872f2087c98
* Let the chromium_code variable be applied in target scope in addition to .gypmark@chromium.org2010-02-101-5/+18
| | | | | | | | | | | | | | | | | file scope. This extends r38519, which was incomplete. To resolve bug 33186, I am trying to turn test_shell.gyp into test_shell.gypi, and have webkit.gyp include it. webkit.gyp is not chromium_code, but the targets in test_shell.gypi are. BUG=33186 TEST=builds still work, -Werror and friends are still applied (or not) correctly Review URL: http://codereview.chromium.org/600047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38658 0039d316-1c4b-4281-b951-d872f2087c98
* Adds code to restore application extensions. I'm also enabling tabsky@chromium.org2010-02-1019-29/+326
| | | | | | | | | | | | pinning on views again as everything in place, except a couple of bugs. BUG=32845 TEST=none Review URL: http://codereview.chromium.org/598027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38657 0039d316-1c4b-4281-b951-d872f2087c98
* Change the name fields back to their previous name to unbreak the buildzork@chromium.org2010-02-102-2/+2
| | | | | | | BUG=none TEST=build chrome git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38656 0039d316-1c4b-4281-b951-d872f2087c98
* First stab at a DataTypeController.skrul@chromium.org2010-02-1027-206/+1143
| | | | | | | | This is my first stab at a DataTypeController, plus a BookmarkDataTypeController implementation. It is not fully wired into the PSS yet :) Review URL: http://codereview.chromium.org/545074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38655 0039d316-1c4b-4281-b951-d872f2087c98
* Update the .proto files to change the fields to optional.zork@chromium.org2010-02-102-4/+4
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/598035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38654 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash when parsing address fields. It's possible we've run out of ↵jhawkins@chromium.org2010-02-101-0/+4
| | | | | | | | | | fields while parsing the zip code. The other fields check this in ParseText, but ParseZipCode opens up the field to get at the name. BUG=35176 TEST=none Review URL: http://codereview.chromium.org/604002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38653 0039d316-1c4b-4281-b951-d872f2087c98
* xpdual/intl1 got faster, update expectations.chase@chromium.org2010-02-101-1/+1
| | | | | | | | | | | | Perf improved on this test by 40ms. Not sure why yet, none of the CLs are obviously a cause. BUG=none TEST=xpdual/intl1 stays green Review URL: http://codereview.chromium.org/597024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38652 0039d316-1c4b-4281-b951-d872f2087c98
* Update NSS to NSS 3.12.6 Beta 1 and NSPR to NSPR 4.8.4wtc@chromium.org2010-02-101-1/+1
| | | | | | | | | | | Beta 1. R=agl BUG=none TEST=none Review URL: http://codereview.chromium.org/598031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38651 0039d316-1c4b-4281-b951-d872f2087c98
* Fill in the preference sync TODOs using the preference specifics proto andalbertb@google.com2010-02-107-53/+115
| | | | | | | | | | | client tags. BUG=32409 TEST=none Review URL: http://codereview.chromium.org/593029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38650 0039d316-1c4b-4281-b951-d872f2087c98
* Re-add suppression for the un-fixed leak from r38619.rsesek@chromium.org2010-02-101-0/+7
| | | | | | | | | | TBR=dglazkov BUG=31586 TEST=Mac Valgrind unit_tests Review URL: http://codereview.chromium.org/604003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38649 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure that ResourceQueue is shut down before destruction.phajdan.jr@chromium.org2010-02-106-375/+315
| | | | | | | | | | | | | Rewrite UserScriptListener unit test to not use ResourceDispatcherHost. Share more code with ExtensionsServiceTest. TEST=Covered by unit_tests. BUG=none Review URL: http://codereview.chromium.org/601005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38648 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enabled test - worker-messageport-gc.html.atwilson@chromium.org2010-02-101-2/+1
| | | | | | | | | BUG=22947 TEST=re-enabled test. Review URL: http://codereview.chromium.org/602010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38647 0039d316-1c4b-4281-b951-d872f2087c98
* Cleaning up invocations of grit and grit_info.bradnelson@google.com2010-02-102-28/+21
| | | | | | | | | | | Making webkit grd dependencies more correct. BUG=19866 TEST=None Review URL: http://codereview.chromium.org/600029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38646 0039d316-1c4b-4281-b951-d872f2087c98
* API changes and protocol changes for supporting the latest SPDY spec.mbelshe@chromium.org2010-02-108-88/+142
| | | | | | | | | | | | | | | | | | Changes include: rename FIN_STREAM to RST_STREAM update enums Add associated-to field to SYN_STREAM Update SYN_STREAM APIs Fix up unit tests. I think these are all the on-wire compatibility changes in the spec. More semantic changes are necessary, of course. BUG=none TEST=none Review URL: http://codereview.chromium.org/599018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38645 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Build fixerg@chromium.org2010-02-101-1/+1
| | | | | | TBR=sheriff git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38644 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Implements the content settings window and the minor changes to the ↵erg@chromium.org2010-02-1019-150/+823
| | | | | | | | | | | | | | options dialog. The "Exceptions" dialogs are still not implemented; they're the next step but this changelist is already getting pretty huge. BUG=35178 TEST=none Review URL: http://codereview.chromium.org/602005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38642 0039d316-1c4b-4281-b951-d872f2087c98
* Make path absolute so URL Fixer Upper unittest does not fail if invoked ↵jochen@chromium.org2010-02-101-1/+3
| | | | | | | | | | | | using something like ../../out/Debug/unit_tests BUG=none TEST=Run the unit_tests executable with a path containing a "/../". It should pass. Review URL: http://codereview.chromium.org/595005 Patch from Bernhard Bauer. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38641 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a bug where if there are only localstorage nodes, but nocookies nodes, ↵ian@chromium.org2010-02-109-38/+93
| | | | | | | | | the Remove and Remove All buttons are disabled.BUG=34886 TEST=clear all cookies, go to www.ianfette.com/localstorage.html and open cookies dialog, check that remove button is enabled. Review URL: http://codereview.chromium.org/596002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38640 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the temporary scaffolding stubs.phajdan.jr@chromium.org2010-02-1026-278/+303
| | | | | | | | | | | | | They have served they purpose well, but now it's time to retire. It's one of the things that draggen in the bad dependency of chrome/common on chrome/browser, and is sufficiently small now to stub things out individually. TEST=none BUG=none Review URL: http://codereview.chromium.org/593037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38639 0039d316-1c4b-4281-b951-d872f2087c98
* This CL addresses 2 issues:jcampan@chromium.org2010-02-107-6/+77
| | | | | | | | | | | | | | | | - we were not computing the max request text size correctly in some cases (by forgetting the size of the &q= string) causing assertions. - the translate server might send inconsistent response in some cases, this CL makes sure we deal with them. A common case is when sending separators only strings, which we are not doing now anymore. Other more complicated case are less clear. BUG=35055 TEST=Visit www.spiegel.de and translate the page. The page should be translated correctly. Review URL: http://codereview.chromium.org/594023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38637 0039d316-1c4b-4281-b951-d872f2087c98
* This reverts r38541, which reverts previous reverts.erg@chromium.org2010-02-104-14/+72
| | | | | | | | | | | | | This will re-introduce a mac performance regression but will make the code correct. R=mirandac (over shoulder) BUG=34775,34078 TEST=none Review URL: http://codereview.chromium.org/600045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38636 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for HTML5 databases to the cookie tree model.jochen@chromium.org2010-02-1028-263/+1441
| | | | | | | | | BUG=34633 TEST=create local databases, open cookie tree view from prefs. Review URL: http://codereview.chromium.org/596009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38635 0039d316-1c4b-4281-b951-d872f2087c98
* Initial implementation of Network selection/welcome screen for OOBE.nkostylev@google.com2010-02-1010-13/+342
| | | | | | | | | BUG=35016 TEST=With --login-manager=network screen should be shown. Currently this screen is not used in wizard process. Network selection is not fully supported. Review URL: http://codereview.chromium.org/570041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38634 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a UI test for WebKit fix to beforeunload bug.creis@chromium.org2010-02-101-0/+20
| | | | | | | | | | | The issue with Gmail warnings on cross-site navigations has been fixed upstream, and a recent WebKit DEPS roll pulled it in. This just adds an automated test for it in Chrome. BUG=32615 TEST=UnloadTest.BrowserCloseWithInnerFocusedFrame Review URL: http://codereview.chromium.org/594014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38633 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Use the ExtensionToolbarModel for ordering of the Browser Actions. ↵andybons@chromium.org2010-02-109-84/+93
| | | | | | | | | | | | Prep for drag and drop for re-ordering. Also fixes crashers where if you tried to disable an extension via its context menu while an incognito window was key, boom. BUG=26990 TEST=none Review URL: http://codereview.chromium.org/595017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38632 0039d316-1c4b-4281-b951-d872f2087c98
* Initial Feedback from UX on the filebrowserdhg@chromium.org2010-02-104-45/+71
| | | | | | Review URL: http://codereview.chromium.org/596025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38631 0039d316-1c4b-4281-b951-d872f2087c98
* Mark download tests as flaky on all platform, just the sad truth.phajdan.jr@chromium.org2010-02-101-21/+17
| | | | | | | | | | TBR=dglazkov, kuchhal TEST=still flaky BUG=35275, 20809 Review URL: http://codereview.chromium.org/601030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38630 0039d316-1c4b-4281-b951-d872f2087c98
* Remove redundant casts in g_signal_connect() throughout all gtk code we have.erg@chromium.org2010-02-1049-195/+189
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/600033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38629 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug in DownloadFile::Rename where we need to seek to the end of the file.jianli@chromium.org2010-02-102-1/+6
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/601018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38628 0039d316-1c4b-4281-b951-d872f2087c98
* Move build/external_code.gypi into build/common.gypi.mark@chromium.org2010-02-102-44/+29
| | | | | | | | BUG=35184 TEST=none Review URL: http://codereview.chromium.org/593025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38626 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for bug 26397: Bookmark manager in Incognito mode doesn't show Sync ↵dantasse@chromium.org2010-02-101-1/+1
| | | | | | | | | | | | | | | Bookmarks button The bug exists because the BookmarkManagerView checks the profile to see if it has a ProfileSyncService set up to see whether it should show the "Sync Bookmarks" button. Incognito profiles do not have a ProfileSyncService, even if the corresponding "original profile" has a PSS. So the fix is to check the original profile (here called "profile_"), not the profile. This is already fixed in Linux (bookmark_manager_gtk.cc). Also, all native versions are scheduled to be replaced by a common bookmark manager soon. BUG=26397 TEST=manual Review URL: http://codereview.chromium.org/574022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38625 0039d316-1c4b-4281-b951-d872f2087c98
* Only show one FileBrowse pop up for the same folderxiyuan@chromium.org2010-02-102-15/+42
| | | | | | | | | | | | Check existing FileBrowse pop ups before opening new one so that we only show one per folder; BUG=none TEST=On ChromeOS, download multiple files to default downloads dir and there should be only one FileBrowse pop up showing up. Review URL: http://codereview.chromium.org/601013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38624 0039d316-1c4b-4281-b951-d872f2087c98
* Couple of tweaks to the cookie prompt dialog:sky@chromium.org2010-02-108-82/+66
| | | | | | | | | | | | | | | . Fixes bug that lead to randomly expanding and not (expanded_view_ wasn't in the member initializer list). . Fixed bug where expanding/collapsing would result in dialog changing to wrong size. . Persist expanded state to prefs. BUG=35092, 35165 TEST=see bugs Review URL: http://codereview.chromium.org/595014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38622 0039d316-1c4b-4281-b951-d872f2087c98
* Add automation proxy methods for sending InstallExtension message.kkania@chromium.org2010-02-102-0/+12
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/595013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38621 0039d316-1c4b-4281-b951-d872f2087c98
* Fix event generation for layout tests. Key codes are 'A'..'Z' so we must ↵avi@chromium.org2010-02-101-4/+7
| | | | | | | | | | | ensure that the values used are they. BUG=none TEST=none Review URL: http://codereview.chromium.org/582023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38620 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a leak in CookiesWindowControllerTest and remove the appropriate suppressionrsesek@chromium.org2010-02-102-7/+5
| | | | | | | | | BUG=31586 TEST=Mac Valgrind unit tests Review URL: http://codereview.chromium.org/597015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38619 0039d316-1c4b-4281-b951-d872f2087c98
* linux: fix the shared build by excluding cookie_modal_dialog.craig.schlenter@chromium.org2010-02-101-0/+1
| | | | | | | | | | | | | | | | | This will have to be reverted of course once the linux-gtk implementation of CookiePromptModalDialog lands. Error was: out/Debug/lib.target/chrome/libbrowser.so: undefined reference to `vtable for CookiePromptModalDialog' BUG=None TEST=compiles Patch from Thiago Farina <thiago.farina@gmail.com> Review URL: http://codereview.chromium.org/595002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38618 0039d316-1c4b-4281-b951-d872f2087c98
* Roll WebKit to 54596jorlow@chromium.org2010-02-101-1/+1
| | | | | | | | | | TBR=yurys TEST=none BUG=none Review URL: http://codereview.chromium.org/603003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38617 0039d316-1c4b-4281-b951-d872f2087c98
* Remove poll'n'loop code from extension_browsertest.cc.phajdan.jr@chromium.org2010-02-107-115/+123
| | | | | | | | | | | | Also use a common wait function from extension_browsertest in the page action popup test. BUG=34339 TEST=browser_tests Review URL: http://codereview.chromium.org/582013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38615 0039d316-1c4b-4281-b951-d872f2087c98
* Added sanity checks for base_unittests to Memcheck and ThreadSanitizer test ↵glider@chromium.org2010-02-104-16/+44
| | | | | | | | | runners. Note that the sanity checks may fail if the tests are ran with the sanity tests excluded (e.g. local test runs). I suppose this shouldn't be a problem, because the exit code matters only on buildbots. Review URL: http://codereview.chromium.org/598013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38612 0039d316-1c4b-4281-b951-d872f2087c98
* Revert the part of http://codereview.chromium.org/593018 touching ↵phajdan.jr@chromium.org2010-02-101-4/+17
| | | | | | | | | | | | | | | | unload_uitest.cc The test started to hang mysteriously on Linux Tests(dbg)(1) and I remember some past problems about this test. Would need more investigation. The test is fine on all other platforms and bots, including Linux Tests(dbg)(2). TBR=brettw TEST=stop hanging BUG=none Review URL: http://codereview.chromium.org/597020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38611 0039d316-1c4b-4281-b951-d872f2087c98
* Really enable JAVASCRIPT_DEBUGGER WebKit feature for Chromium.mnaganov@chromium.org2010-02-101-0/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/596035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38610 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-04 11:16:14 +0000