summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Move context menu module out of experimental.aa@chromium.org2010-07-1766-50/+200
| | | | | | | | BUG=48725,39508 Review URL: http://codereview.chromium.org/2840038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52784 0039d316-1c4b-4281-b951-d872f2087c98
* Add a simple cookies sample.aa@chromium.org2010-07-176-0/+372
| | | | | | Review URL: http://codereview.chromium.org/2824058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52783 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: fix navigation button click logic.estade@chromium.org2010-07-171-1/+1
| | | | | | | | | BUG=none TEST=right click on new tab button should do nothing rather than crash in debug. Review URL: http://codereview.chromium.org/3005014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52782 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash in SSLClientSocketPool:GetLoadStatevandebo@chromium.org2010-07-172-1/+7
| | | | | | | | | | | ClientSocketHandle::GetLoadState is only valid when the handle doesn't have a socket. And we repeat the DoTunnelConnectComplete state when when need to restart the http proxy with authentication - after the transport_socket_handle_ has been assigned the http proxy socket. BUG=41408 TEST=amended SSLClientSocketPoolTest.DoProxyAuth Review URL: http://codereview.chromium.org/2856043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52781 0039d316-1c4b-4281-b951-d872f2087c98
* In ChromeFrame if window.open is received for a pending external tab, i.e. ↵ananta@chromium.org2010-07-171-1/+6
| | | | | | | | | | | | | | | | | | | | | | | which has not received a connect from the host browser, currently we end up crashing chrome due to dereferencing a NULL automation channel. Ideally we should queue all IPC messages destined for a pending tab and send them out once we receive a connect. However that solution is tricky as the messages carry the tab handle as one of the arguments which is only available when we receive a connnect for the tab. The AutomationHandleTracker gives out these handles and is per automation provider. We may have different automation provider instances in the case of IE8 and hence we cannot pre compute the tab handle. Current solution is to add a NULL check around the offending code path which would basically drop the new contents notification. Fixes bug http://code.google.com/p/chromium/issues/detail?id=49188 Bug=49188 Review URL: http://codereview.chromium.org/3021002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52780 0039d316-1c4b-4281-b951-d872f2087c98
* Http Cache: Enable some checks to track a low volume crash.rvargas@google.com2010-07-171-10/+19
| | | | | | | | | | | BUG=47895 TEST=none Review URL: http://codereview.chromium.org/2996006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52779 0039d316-1c4b-4281-b951-d872f2087c98
* Implement IsSearchProviderInstalled and a test for it.levin@chromium.org2010-07-1714-37/+498
| | | | | | | | | | | | | It is currently off by default and one must pass in a flag (--enable-search-provider-api-v2) to use it. Api details are in the bug. BUG=38475 TEST=ui_tests --gtest_filter=SearchProviderTest.TestIsSearchProviderInstalled Review URL: http://codereview.chromium.org/2823042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52778 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmarks: Remove the link from the bookmark list items.arv@chromium.org2010-07-172-26/+9
| | | | | | | | | BUG=43312 TEST=Open bookmarks manager. There bookmark list items should not longer be underlined on hover and clicking them should only select them. Review URL: http://codereview.chromium.org/2813059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52777 0039d316-1c4b-4281-b951-d872f2087c98
* Http Cache: Don't delete the callback that is waiting forrvargas@google.com2010-07-172-2/+46
| | | | | | | | | | | | the backend creation when the cache goes away. BUG=49193 TEST=net_unittests Review URL: http://codereview.chromium.org/3016006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52776 0039d316-1c4b-4281-b951-d872f2087c98
* Added two new crashes to the reliability tests known crashes. These occur ↵ananta@chromium.org2010-07-171-0/+7
| | | | | | | | | | | | | consistently in ChromeFrame reliability test runs. Bugs=49271,49384 TBR=amit Review URL: http://codereview.chromium.org/3026005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52775 0039d316-1c4b-4281-b951-d872f2087c98
* Marked dmaclach@chromium.org2010-07-171-2/+2
| | | | | | | | | | | | | | | | TEST_F(CollectedCookiesTest, FAILS_TestDoubleDisplay) and TEST_F(CollectedCookiesTest, FAILS_NavigateAway) because they were causing issues in the build waterfall. http://code.google.com/p/chromium/issues/detail?id=49386 TEST=none BUG=none Review URL: http://codereview.chromium.org/3008007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52774 0039d316-1c4b-4281-b951-d872f2087c98
* Fix memory leak in unit testcpu@chromium.org2010-07-171-4/+4
| | | | | | | | | | | | | Test is TemplateURLPrepopulateDataTest_ProvidersFromPrefs TBR=oshima BUG=49086 TEST=none Review URL: http://codereview.chromium.org/2843056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52773 0039d316-1c4b-4281-b951-d872f2087c98
* grit: Set first_id XML attribute as a string.estade@chromium.org2010-07-171-1/+1
| | | | | | | | | BUG=none TEST=compile works again (not sure why it was only failing for me and a few others) Review URL: http://codereview.chromium.org/3018006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52772 0039d316-1c4b-4281-b951-d872f2087c98
* Mark WorkerTest.WorkerWebSocketLayoutTests as flaky.jhawkins@chromium.org2010-07-161-1/+2
| | | | | | | | | | TBR=mmoss BUG=49381 TEST=WorkerTest.WorkerWebSocketLayoutTests Review URL: http://codereview.chromium.org/3028011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52771 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeOS PDF handling: if the built-in PDF viewer plug-in is active, don't ↵scottbyer@chromium.org2010-07-161-1/+20
| | | | | | | | | | | intercept PDF opening and forward to gView, but use the plug-in instead. BUG=chromium-os:4790 TEST=none Review URL: http://codereview.chromium.org/2906010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52770 0039d316-1c4b-4281-b951-d872f2087c98
* Move CollectedCookiesTest.* from ui_tests to interactive_ui_tests.jochen@chromium.org2010-07-162-1/+1
| | | | | | | | | BUG=none TEST=less redness Review URL: http://codereview.chromium.org/2843057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52769 0039d316-1c4b-4281-b951-d872f2087c98
* checkperms: update to handle autoconf more generallyevan@chromium.org2010-07-161-22/+21
| | | | | | | | Fixes recent libxml change. Simplifies code a bit. Review URL: http://codereview.chromium.org/3028008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52768 0039d316-1c4b-4281-b951-d872f2087c98
* Add failing test from webkit mergeojan@google.com2010-07-161-0/+3
| | | | | | Review URL: http://codereview.chromium.org/2868057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52767 0039d316-1c4b-4281-b951-d872f2087c98
* Add third_party/ prefix to ppapi include for checkdeps.ajwong@chromium.org2010-07-161-1/+1
| | | | | | | | | | The only users of this ppb should be inside chrome so this should work fine. TBR=jam@chromium.org Review URL: http://codereview.chromium.org/3019006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52766 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a compile error in nacl_security_tests on some versionstony@chromium.org2010-07-161-2/+5
| | | | | | | | | | | | | of gcc. Some versions of gcc give the following compilation error: /usr/include/bits/fcntl2.h:51: error: call to ‘__open_missing_mode’ declared with attribute error: open with O_CREAT in second argument needs 3 arguments make: *** [out/Release/obj.target/nacl_security_tests/chrome/test/nacl_security_tests/commands_posix.o] Error 1 So provide a third argument (the permissions of the file if created). Review URL: http://codereview.chromium.org/3046001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52765 0039d316-1c4b-4281-b951-d872f2087c98
* This webkit change causes whitespace to be inserted between </head> and <body>.tony@chromium.org2010-07-162-2/+4
| | | | | | | | TBR=ojan,abarth Review URL: http://codereview.chromium.org/3008006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52763 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the build on ChromeOS.phajdan.jr@chromium.org2010-07-161-0/+1
| | | | | | | | | TBR=oshima TEST=compile, please BUG=48913 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52759 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 52744 - Enable all sync DB layout tests.dumi@chromium.org2010-07-161-43/+28
| | | | | | | | | | | | BUG=49118 TEST=none Review URL: http://codereview.chromium.org/2813055 TBR=dumi@chromium.org Review URL: http://codereview.chromium.org/2847057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52758 0039d316-1c4b-4281-b951-d872f2087c98
* Mark tests as failing that started failing with the webkit roll.ojan@google.com2010-07-161-8/+10
| | | | | | | | Will fix shortly, but don't want to rollback. Review URL: http://codereview.chromium.org/3023003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52756 0039d316-1c4b-4281-b951-d872f2087c98
* file_util: deprecate remaining wstring functionsevan@chromium.org2010-07-1610-60/+86
| | | | | | | | | | | This removes the last wstring-accepting functions from file_util on non-Windows platforms. BUG=24672 Review URL: http://codereview.chromium.org/3005005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52755 0039d316-1c4b-4281-b951-d872f2087c98
* Add private Pepper v2 API to get localized strings.jam@chromium.org2010-07-167-4/+93
| | | | | | Review URL: http://codereview.chromium.org/3035005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52754 0039d316-1c4b-4281-b951-d872f2087c98
* Sync server should return correct version number on item deletion.rsimha@chromium.org2010-07-161-4/+7
| | | | | | | | | | | | | When a sync item is deleted, the python sync server returns a version number of 0 on commit, when in fact, an incremented version number must be returned. This was causing some errors in integration tests. BUG=49365 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/2868055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52753 0039d316-1c4b-4281-b951-d872f2087c98
* TBR:brettw@chromium.orgtfarina@chromium.org2010-07-1611-36/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52752 0039d316-1c4b-4281-b951-d872f2087c98
* Move implementations in menu model stuff from header to implementation.erg@chromium.org2010-07-164-33/+60
| | | | | | | | | | | This breaks a dependency on SkBitmap.h for everything that just uses menus. BUG=none TEST=none Review URL: http://codereview.chromium.org/2854046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52751 0039d316-1c4b-4281-b951-d872f2087c98
* Remove now unused states (cleanup).vandebo@chromium.org2010-07-162-10/+0
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/3040003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52750 0039d316-1c4b-4281-b951-d872f2087c98
* Download code cleanup: split big files into smaller one.phajdan.jr@chromium.org2010-07-1641-1257/+1327
| | | | | | | | | | | | | It's hard to find things in the download directory. DownloadFile and DownloadFileManager were bundled together. Similarly for DownloadItem and DownloadManager, which was much less intuitive. Some 3-5 line structs were also in one bag with something else. I extracted them to their own small file. TEST=unit_tests, browser_tests, ui_tests BUG=48913 Review URL: http://codereview.chromium.org/2806054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52749 0039d316-1c4b-4281-b951-d872f2087c98
* [GTK] Fix pref initialization order so options page doesn't instantly crash.estade@chromium.org2010-07-161-9/+8
| | | | | | | | | BUG=none TEST=open options dialog Review URL: http://codereview.chromium.org/3007004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52748 0039d316-1c4b-4281-b951-d872f2087c98
* When using SelectFileDialog::SelectFile with type SELECT_FOLDER, set button ↵csilv@chromium.org2010-07-162-0/+11
| | | | | | | | | | | | title to 'Select' and show the 'New Folder' button. BUG=none TEST=From preferences select a new download folder, verify button title and new folder button. Review URL: http://codereview.chromium.org/3028002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52747 0039d316-1c4b-4281-b951-d872f2087c98
* Change dashboard link to say "Google Dashboard"tim@chromium.org2010-07-161-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3039006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52746 0039d316-1c4b-4281-b951-d872f2087c98
* New PyAuto hook to get saved passwords. BUG=36179alyssad@chromium.org2010-07-167-6/+228
| | | | | | Review URL: http://codereview.chromium.org/2842047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52745 0039d316-1c4b-4281-b951-d872f2087c98
* Enable all sync DB layout tests.dumi@chromium.org2010-07-161-28/+43
| | | | | | | | | BUG=49118 TEST=none Review URL: http://codereview.chromium.org/2813055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52744 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Build interactive_ui_teststhakis@chromium.org2010-07-161-5/+4
| | | | | | | | | | | This doesn't add them to the builders yet (which is good. because some of the tests fail due to NOTIMPLEMENTED()s). BUG=21276 TEST=project dropdown in xcode has "interactive_ui_tests" when opening chrome.xcodeproj Review URL: http://codereview.chromium.org/2805087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52743 0039d316-1c4b-4281-b951-d872f2087c98
* Update DEPS to bring in latest PPAPI.jam@chromium.org2010-07-161-1/+1
| | | | | | | TBR=brettw Review URL: http://codereview.chromium.org/3014007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52742 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac]Handle edit commands from input methods correctly.suzhe@chromium.org2010-07-162-104/+107
| | | | | | | | | | | | | | | | This CL does the following changes: 1.) It removes the EditCommandMatcher class and folds its behavior into RenderWidgetHostViewCocoa's -doCommandBySelector:. When -doCommandBySelector: is executed during execution of -keyDown: (the normal case), the commands are scheduled to be sent by -keyDown: later on, else they are sent immediately. 2.) If edit commands have been scheduled while IME composition is happening, delay delivery of the real key event (and eventual edit commands) until the fake key event(keycode 229) and IME composition have been sent to webkit. Safari sends the IME composition events first and deliver the key events after that, but according to HTML DOM Level3 Events Spec (http://www.w3.org/TR/DOM-Level-3-Events/#keyset-comp-input), the key events shall be sent before the IME composition events. BUG=48161 I should press 'enter' twice to search korean keyword in the omnibox and web fields BUG=48247 Pagedown/pageup inserts characters in textbox TEST=See bug reports. Review URL: http://codereview.chromium.org/2805075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52741 0039d316-1c4b-4281-b951-d872f2087c98
* Always show the 'Control sync from Google Dashboard' link on the sync ↵tim@chromium.org2010-07-165-31/+16
| | | | | | | | | | | options dialog. BUG=48844 TEST=open Personal Stuff on any platform, see dashboard link. Review URL: http://codereview.chromium.org/2827055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52740 0039d316-1c4b-4281-b951-d872f2087c98
* Fix race conditions in event_sys_unittest.albertb@chromium.org2010-07-161-13/+14
| | | | | | | | | BUG=37839 TEST=tsan doesn't report any races Review URL: http://codereview.chromium.org/2856036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52739 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Toolbar UI tweaks.andybons@chromium.org2010-07-162-16/+214
| | | | | | | | | | | | | o 4px between wrench menu and location bar/edge of window. o 4px between reload button and location bar. o Adjust size of wrench menu to be the same size as every other button. o Fix bug where location bar would be too close to the wrench menu when disabling the last visible browser action. BUG=46738,48678 TEST=visual Review URL: http://codereview.chromium.org/3027005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52738 0039d316-1c4b-4281-b951-d872f2087c98
* Added switch to use ChromeAsyncSocket for sync.akalin@chromium.org2010-07-1618-39/+129
| | | | | | | | | BUG=45612 TEST=manual Review URL: http://codereview.chromium.org/2819049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52737 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash bug in new SSLClientSocketPool.davidben@chromium.org2010-07-162-2/+30
| | | | | | | | | | | | | We also need to push additional error state out of the SSLClientSocketPool on a ERR_SSL_CLIENT_AUTH_CERT_NEEDED error. BUG=49197 TEST=no crash when visiting https://foafssl.org/srv/idp?authreqissuer=http://foaf.me/index.php Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52693 Review URL: http://codereview.chromium.org/2827053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52735 0039d316-1c4b-4281-b951-d872f2087c98
* Add the always/never translate buttonsfeldstein@chromium.org2010-07-165-9/+123
| | | | | | | | | | | | | Port over the windows work onto the mac to add the button when a user presses translate or cancel more than 3 times in a row. BUG=48136 TEST=Cancel or accept translation more than 3 times in a row to see the button pop up and work. Review URL: http://codereview.chromium.org/2891015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52734 0039d316-1c4b-4281-b951-d872f2087c98
* This little guy got left behind.aa@chromium.org2010-07-161-0/+3289
| | | | | | | TBR=kathyw@chromium.org BUG=41663 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52733 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit merge 63514:63575ojan@google.com2010-07-161-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52732 0039d316-1c4b-4281-b951-d872f2087c98
* This adds four files ported from their C++ counterparts: animation.js, ↵pathorn@chromium.org2010-07-167-0/+2571
| | | | | | | | | | counter.js, curve.js and param_object.js. BUG= TEST=o3d-webgl-samples/animations.html works Review URL: http://codereview.chromium.org/2856032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52731 0039d316-1c4b-4281-b951-d872f2087c98
* Remove lock.h from resource_bundle.h and histogram.h.erg@chromium.org2010-07-1610-13/+24
| | | | | | | | | | | Use a scoped_ptr<Lock> instead of Lock in resource bundle. BUG=none TEST=none Review URL: http://codereview.chromium.org/3038005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52730 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: access GNOME Keyring on the GLib main thread, rather than the DB thread.mdm@chromium.org2010-07-162-208/+490
| | | | | | | | | I was unable to reproduce the crash, but it's happening to a lot of people and the web suggests that moving access to GNOME Keyring to the GLib main thread should fix the problem. BUG=48343, 25404 TEST=hopefully it won't crash for some people any more Review URL: http://codereview.chromium.org/2953006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52729 0039d316-1c4b-4281-b951-d872f2087c98