| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=48725,39508
Review URL: http://codereview.chromium.org/2840038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52784 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2824058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52783 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=right click on new tab button should do nothing rather than crash in debug.
Review URL: http://codereview.chromium.org/3005014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52782 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ClientSocketHandle::GetLoadState is only valid when the handle doesn't have a socket. And we repeat the DoTunnelConnectComplete state when when need to restart the http proxy with authentication - after the transport_socket_handle_ has been assigned the http proxy socket.
BUG=41408
TEST=amended SSLClientSocketPoolTest.DoProxyAuth
Review URL: http://codereview.chromium.org/2856043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52781 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
which has not received a connect
from the host browser, currently we end up crashing chrome due to dereferencing a NULL automation channel.
Ideally we should queue all IPC messages destined for a pending tab and send them out once we receive a connect.
However that solution is tricky as the messages carry the tab handle as one of the arguments which is only available
when we receive a connnect for the tab. The AutomationHandleTracker gives out these handles and is per automation provider.
We may have different automation provider instances in the case of IE8 and hence we cannot pre compute the tab handle.
Current solution is to add a NULL check around the offending code path which would basically drop the new contents
notification.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=49188
Bug=49188
Review URL: http://codereview.chromium.org/3021002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=47895
TEST=none
Review URL: http://codereview.chromium.org/2996006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It is currently off by default and one must pass in a flag
(--enable-search-provider-api-v2) to use it. Api details are
in the bug.
BUG=38475
TEST=ui_tests --gtest_filter=SearchProviderTest.TestIsSearchProviderInstalled
Review URL: http://codereview.chromium.org/2823042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=43312
TEST=Open bookmarks manager. There bookmark list items should not longer be underlined on hover and clicking them should only select them.
Review URL: http://codereview.chromium.org/2813059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
the backend creation when the cache goes away.
BUG=49193
TEST=net_unittests
Review URL: http://codereview.chromium.org/3016006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
consistently in ChromeFrame reliability
test runs.
Bugs=49271,49384
TBR=amit
Review URL: http://codereview.chromium.org/3026005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52775 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TEST_F(CollectedCookiesTest, FAILS_TestDoubleDisplay)
and
TEST_F(CollectedCookiesTest, FAILS_NavigateAway)
because they were causing issues in the build waterfall.
http://code.google.com/p/chromium/issues/detail?id=49386
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3008007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52774 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Test is TemplateURLPrepopulateDataTest_ProvidersFromPrefs
TBR=oshima
BUG=49086
TEST=none
Review URL: http://codereview.chromium.org/2843056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52773 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compile works again (not sure why it was only failing for me and a few others)
Review URL: http://codereview.chromium.org/3018006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52772 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=mmoss
BUG=49381
TEST=WorkerTest.WorkerWebSocketLayoutTests
Review URL: http://codereview.chromium.org/3028011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52771 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
intercept PDF opening and forward to gView, but use the plug-in instead.
BUG=chromium-os:4790
TEST=none
Review URL: http://codereview.chromium.org/2906010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=less redness
Review URL: http://codereview.chromium.org/2843057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52769 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Fixes recent libxml change. Simplifies code a bit.
Review URL: http://codereview.chromium.org/3028008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2868057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The only users of this ppb should be inside chrome so this should work fine.
TBR=jam@chromium.org
Review URL: http://codereview.chromium.org/3019006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of gcc.
Some versions of gcc give the following compilation error: /usr/include/bits/fcntl2.h:51: error: call to ‘__open_missing_mode’ declared with attribute error: open with O_CREAT in second argument needs 3 arguments
make: *** [out/Release/obj.target/nacl_security_tests/chrome/test/nacl_security_tests/commands_posix.o] Error 1
So provide a third argument (the permissions of the file if created).
Review URL: http://codereview.chromium.org/3046001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=ojan,abarth
Review URL: http://codereview.chromium.org/3008006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52763 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=oshima
TEST=compile, please
BUG=48913
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=49118
TEST=none
Review URL: http://codereview.chromium.org/2813055
TBR=dumi@chromium.org
Review URL: http://codereview.chromium.org/2847057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Will fix shortly, but don't want to rollback.
Review URL: http://codereview.chromium.org/3023003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This removes the last wstring-accepting functions from file_util
on non-Windows platforms.
BUG=24672
Review URL: http://codereview.chromium.org/3005005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3035005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When a sync item is deleted, the python sync server returns a version
number of 0 on commit, when in fact, an incremented version number must
be returned. This was causing some errors in integration tests.
BUG=49365
TEST=sync_integration_tests
Review URL: http://codereview.chromium.org/2868055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This breaks a dependency on SkBitmap.h for everything that just uses menus.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2854046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3040003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's hard to find things in the download directory. DownloadFile and DownloadFileManager
were bundled together. Similarly for DownloadItem and DownloadManager, which was much less
intuitive. Some 3-5 line structs were also in one bag with something else. I extracted them
to their own small file.
TEST=unit_tests, browser_tests, ui_tests
BUG=48913
Review URL: http://codereview.chromium.org/2806054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=open options dialog
Review URL: http://codereview.chromium.org/3007004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
title to 'Select'
and show the 'New Folder' button.
BUG=none
TEST=From preferences select a new download folder, verify button title and new folder button.
Review URL: http://codereview.chromium.org/3028002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3039006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2842047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52745 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=49118
TEST=none
Review URL: http://codereview.chromium.org/2813055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52744 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This doesn't add them to the builders yet (which is good. because some of the tests fail due to NOTIMPLEMENTED()s).
BUG=21276
TEST=project dropdown in xcode has "interactive_ui_tests" when opening chrome.xcodeproj
Review URL: http://codereview.chromium.org/2805087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=brettw
Review URL: http://codereview.chromium.org/3014007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52742 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL does the following changes:
1.) It removes the EditCommandMatcher class and folds its behavior into RenderWidgetHostViewCocoa's -doCommandBySelector:. When -doCommandBySelector: is executed during execution of -keyDown: (the normal case), the commands are scheduled to be sent by -keyDown: later on, else they are sent immediately.
2.) If edit commands have been scheduled while IME composition is happening, delay delivery of the real key event (and eventual edit commands) until the fake key event(keycode 229) and IME composition have been sent to webkit. Safari sends the IME composition events first and deliver the key events after that, but according to HTML DOM Level3 Events Spec (http://www.w3.org/TR/DOM-Level-3-Events/#keyset-comp-input), the key events shall be sent before the IME composition events.
BUG=48161 I should press 'enter' twice to search korean keyword in the omnibox and web fields
BUG=48247 Pagedown/pageup inserts characters in textbox
TEST=See bug reports.
Review URL: http://codereview.chromium.org/2805075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
options dialog.
BUG=48844
TEST=open Personal Stuff on any platform, see dashboard link.
Review URL: http://codereview.chromium.org/2827055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=37839
TEST=tsan doesn't report any races
Review URL: http://codereview.chromium.org/2856036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
o 4px between wrench menu and location bar/edge of window.
o 4px between reload button and location bar.
o Adjust size of wrench menu to be the same size as every other button.
o Fix bug where location bar would be too close to the wrench menu when disabling the last visible browser action.
BUG=46738,48678
TEST=visual
Review URL: http://codereview.chromium.org/3027005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=45612
TEST=manual
Review URL: http://codereview.chromium.org/2819049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We also need to push additional error state out of the SSLClientSocketPool on a ERR_SSL_CLIENT_AUTH_CERT_NEEDED error.
BUG=49197
TEST=no crash when visiting https://foafssl.org/srv/idp?authreqissuer=http://foaf.me/index.php
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52693
Review URL: http://codereview.chromium.org/2827053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52735 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Port over the windows work onto the mac to add the button when a user presses
translate or cancel more than 3 times in a row.
BUG=48136
TEST=Cancel or accept translation more than 3 times in a row to see the button
pop up and work.
Review URL: http://codereview.chromium.org/2891015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=kathyw@chromium.org
BUG=41663
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
counter.js, curve.js and param_object.js.
BUG=
TEST=o3d-webgl-samples/animations.html works
Review URL: http://codereview.chromium.org/2856032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Use a scoped_ptr<Lock> instead of Lock in resource bundle.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3038005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
I was unable to reproduce the crash, but it's happening to a lot of people and the web suggests that moving access to GNOME Keyring to the GLib main thread should fix the problem.
BUG=48343, 25404
TEST=hopefully it won't crash for some people any more
Review URL: http://codereview.chromium.org/2953006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52729 0039d316-1c4b-4281-b951-d872f2087c98
|